Jollyroger: an inside bar auto-trader by SteveHopwood | Page 3 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

3 Bar Fractal with mid-bar and bar on each side 11 replies

Inside bar or outside bar identifier 7 replies

SteveHopwood EAs 4 replies

Pin bar, pin bar, pin bar 0 replies

What's Wrong with this Inside Bar Indicator 1 reply

Attachments: Jollyroger: an inside bar auto-trader by SteveHopwood
Exit Attachments

Jollyroger: an inside bar auto-trader by SteveHopwood

  • #41
  • May 27, 2011 4:52am May 27, 2011 4:52am
I have no further interest in this.

JR sent me a spec that I coded.

Now it seems that others want a different spec coded. Why the blue blazes should I try to keep up with all this?

And what is this with the day's opening price? A day is a day is a day. The open is either the open of the day or it isn't.

Sort this out amongst yourselves guys. I am busy elsewhere.
  • #42
  • May 27, 2011 5:11am May 27, 2011 5:11am
Mmm you'll be back
Thanks anyway for your work, having great fun with it!
  • #43
  • May 27, 2011 5:17am May 27, 2011 5:17am
right now there is a serious bug regarding how to calculate DayOpenPrice. as per DIBS, its always 6 AM GMT, as per EA its prev day close price. if broker doesnt close day by 6 AM GMT then EA places wrong orders
  • #44
  • May 27, 2011 6:32am May 27, 2011 6:32am
Quoting roundrock
right now there is a serious bug regarding how to calculate DayOpenPrice. as per DIBS, its always 6 AM GMT, as per EA its prev day close price. if broker doesnt close day by 6 AM GMT then EA places wrong orders
Hi!, I've not reviewed all the code, but thinks that this simple piece of code will do the trick ...

Inserted Code
void ReadIndicatorValues()
{

   //Draw hi-lo of inside bar if the previous candle was an inside bar
   DrawRangeLines();
   
   //Previous day close price
   //Don't want yesterday's prices based on the Sunday candle
   int shift = 1;
   [b]int shiftHour = 0;[/b]
   [b]int hour = 0;[/b]
   if (CriminalHasSundayCandle && shift == 1)
   {
      int day = (TimeDayOfWeek(TimeLocal()) );
      if (day == 1) shift = 2;
   }//if (CriminalHasSundayCandle && PivotShift == 1)

   //Long pending trades
   [b]//DayOpenPrice = iOpen(NULL, PERIOD_D1, 0);
   hour = TimeHour(TimeCurrent());
   if(hour>6)
      shiftHour=hour-6;
   DayOpenPrice = iOpen(NULL,PERIOD_H1,shiftHour);[/b]
   ObjectDelete(todayopenprice);
   ObjectCreate(todayopenprice, OBJ_TREND,0,iTime(NULL, PERIOD_D1, shift) ,DayOpenPrice, TimeCurrent(), DayOpenPrice);
   ObjectSet(todayopenprice,OBJPROP_COLOR,Turquoise);
   ObjectSet(todayopenprice,OBJPROP_STYLE,STYLE_DASH);
   ObjectSet(todayopenprice,OBJPROP_WIDTH,1);
   ObjectSet(todayopenprice,OBJPROP_RAY,true);
   

}//void ReadIndicatorValues()
  • #45
  • May 27, 2011 8:20am May 27, 2011 8:20am
Quoting roundrock
right now there is a serious bug regarding how to calculate DayOpenPrice. as per DIBS, its always 6 AM GMT, as per EA its prev day close price. if broker doesnt close day by 6 AM GMT then EA places wrong orders
i noticed the same...this bot does not calculate 6 am gmt as daily open price which PC used.
i found the attached dibbs ea in the 'no free lunch continues..' thread. you can set different ratios of primary and secondary trades and also you have the option to set two different daily open( one extra for the US session which i dont think PC used). downside of this ea is that it does not draw any bars or lines for visual aid and it does not work with ecn brokers. there are lots of pretty good indicators on the thread anyway. also there is no secondory trade trailing stop feature to let the trade run. of course MPTM is always there if we want to lt it run alongside.
play with it with diffrent settings guys, i think it is pretty close to mimicing basic dibbs rules.
Attached File(s)
File Type: mq4 DIBS_EA_ver7.mq4   27 KB | 434 downloads
  • #46
  • May 27, 2011 10:42am May 27, 2011 10:42am
I have traded this method manually for something like 3 months and it is easy. Rules simple and VERY profitable.

If we could just get the EA to work I'm sure this can be a winner, Steve's EA just needs some adjustments to its latest form (the SL issue and the open/close line).

Any coders? Please help!
  • #47
  • May 27, 2011 11:38am May 27, 2011 11:38am
Quoting acostafulano
I have traded this method manually for something like 3 months and it is easy. Rules simple and VERY profitable.

If we could just get the EA to work I'm sure this can be a winner, Steve's EA just needs some adjustments to its latest form (the SL issue and the open/close line).

Any coders? Please help!
Did you try to use the code I posted ?, that's solve the problem of getting the opening price at 6 A.M, if someone could test it, I could do the needed changes.
  • #48
  • May 27, 2011 11:45am May 27, 2011 11:45am
Quoting rbetancor
Did you try to use the code I posted ?, that's solve the problem of getting the opening price at 6 A.M, if someone could test it, I could do the needed changes.
Hello! Unfortunately I'm pretty much useless when it comes to MQL

Could someone please post Steve's EA with this fix so we can try and test if it works?
  • #49
  • May 27, 2011 12:15pm May 27, 2011 12:15pm
Fixed the problem i guess, please try out this one. This makes sure dayopen = price at 6 GMT. Just had to add the parameter gmt_offset, which is the offset of the broker (so the mt4 platform), so NOT of the local computer. Sorry, didn't know how else to code it.

Have a nice weekend!
Attached File(s)
File Type: mq4 Jollyroger.mq4   48 KB | 503 downloads
  • #50
  • May 27, 2011 12:28pm May 27, 2011 12:28pm
Quoting rbetancor
Hi!, I've not reviewed all the code, but thinks that this simple piece of code will do the trick ...

[code]
void ReadIndicatorValues()
{...

It appears that your change of the bots base price to the 0600 GMT line is effective. I apologize to Steve and the followers of this thread for not being more specific in stating that Peter Crown's TRADING DAY began at 0600 GMT. Steve coded exactly what I asked which was stated "the previous days close" and not the open at 0600 GMT.

We still have a major error in the bot that needs to be corrected in that the latest trades taken by the bot set the TP on the one order using a TP at DOUBLE the opening price rather than DOUBLE the DIFFERENCE between the Stop Loss and the opening price.

There is an additional occasional error that does not set a stop loss on one of the bots opening orders.

Both these errors are correctable manually but that is difficult if you are asleep.

If Steve's interest is revived or if any other coder cares to bring forth a solution to the above problems we will have a heck of a robot here.

I currently have 7 free trades making pips and being managed by the jumping stop built into the bot.

We've got something good here. Lets keep it going.
Roger
  • #51
  • May 27, 2011 1:00pm May 27, 2011 1:00pm
Quoting Jollyroger
It appears that your change of the bots base price to the 0600 GMT line is effective. I apologize to Steve and the followers of this thread for not being more specific in stating that Peter Crown's TRADING DAY began at 0600 GMT. Steve coded exactly what I asked which was stated "the previous days close" and not the open at 0600 GMT.

We still have a major error in the bot that needs to be corrected in that the latest trades taken by the bot set the TP on the one order using a TP at DOUBLE the opening price rather than DOUBLE the DIFFERENCE between...
This method is proven to work (see the original thread) and the main part of the EA is already coded and working (thanks steve) it only needs slight modifications to work as intended and start making us pips! S.O.S coders
  • #52
  • May 27, 2011 1:05pm May 27, 2011 1:05pm
Quoting Jollyroger
It appears that your change of the bots base price to the 0600 GMT line is effective. I apologize to Steve and the followers of this thread for not being more specific in stating that Peter Crown's TRADING DAY began at 0600 GMT. Steve coded exactly what I asked which was stated "the previous days close" and not the open at 0600 GMT.

We still have a major error in the bot that needs to be corrected in that the latest trades taken by the bot set the TP on the one order using a TP at DOUBLE the opening price rather than DOUBLE the DIFFERENCE between...
Ok, I'll check the errors you mention ... could you tell me a date/hour/pair in witch you show the errors ? ... a screen capture maybe ok too.
  • #53
  • May 27, 2011 1:08pm May 27, 2011 1:08pm
Quoting esquire
Fixed the problem i guess, please try out this one. This makes sure dayopen = price at 6 GMT. Just had to add the parameter gmt_offset, which is the offset of the broker (so the mt4 platform), so NOT of the local computer. Sorry, didn't know how else to code it.

Have a nice weekend!
Umm ... I didn't know the iBarShift function, and that will help my with other EA's I'm working with ...

I have a function that could auto-detect gmtOffset of the server, will add it to you version of the EA and post it.
  • #54
  • May 27, 2011 3:39pm May 27, 2011 3:39pm
Just subscribed to this thread. Looks like you have the makings of a great EA here but how do I attach the MQ4 file to my MT4 charts?
  • #55
  • May 27, 2011 4:17pm May 27, 2011 4:17pm
Quoting pipseeker32
Just subscribed to this thread. Looks like you have the makings of a great EA here but how do I attach the MQ4 file to my MT4 charts?
Pipsqueaker. Not to offend, but this is a thread for advanced users. You are asking a "How do I crawl" kind of question, amongst a bunch of marathoners.

As for me, I'm at the 3K walk/run stage.

Please come back when you can answer your own question.
  • #56
  • May 27, 2011 5:26pm May 27, 2011 5:26pm
Thank you soooo much for your help and time!
  • #57
  • May 27, 2011 7:01pm May 27, 2011 7:01pm
Quoting rbetancor
Ok, I'll check the errors you mention ... could you tell me a date/hour/pair in witch you show the errors ? ... a screen capture maybe ok too.
5/27 19:45 EUR/USD
5/27 21:19 GBP/USD
Those are two I remember. I can't give you a screen shot since I have already corrected the errors. Also 1 of the trades was taken in the wrong direction. Next week I am sure the errors will occur again and I will post screen shots etc. Not being a coder puts me at a disadvantage in trying to comment on EA problems. Sorry I was not more help.
Roger
  • #58
  • May 27, 2011 7:03pm May 27, 2011 7:03pm
Quoting pipseeker32
Just subscribed to this thread. Looks like you have the makings of a great EA here but how do I attach the MQ4 file to my MT4 charts?
Suggest you go to Babypips .com and take there forex tutorials and it will give you a good basic beginning understanding of forex and MT4.
  • #59
  • May 28, 2011 4:59am May 28, 2011 4:59am
Quoting Jollyroger
It appears that your change of the bots base price to the 0600 GMT line is effective. I apologize to Steve and the followers of this thread for not being more specific in stating that Peter Crown's TRADING DAY began at 0600 GMT. Steve coded exactly what I asked which was stated "the previous days close" and not the open at 0600 GMT.

We still have a major error in the bot that needs to be corrected in that the latest trades taken by the bot set the TP on the one order using a TP at DOUBLE the opening price rather than DOUBLE the DIFFERENCE between...
Jollyroger, can you tell me the precise method how to trade? If i know what to do i can mod the code (which only needs little adjustments, thanks to steve )

As far as i know, this is the procedure:

- Search inside bar
- Place order when price exeeds high + 1 pip + spread of inside bar (or the low - 1 - spread) & price is higher then 6 GMT Open (or lower)
- SL is the other end of the inside bar (wihthout 1 pip & spread).
- Close half of the position where the profit of that closed half will cover the risk of the other half open. Which would mean it is the difference between the sl & the open price. Don't understand what you mean with "Double the openingsprice"
- The other half is taken care of by steven's trailing stop (which works fine i guess?)

If the above is correct i'll just have to adjust the following:
- add the 1 pip + spread thing
- Make sure sl & tp are correctly coded (didn't check yet) and adjust if necessaire.

I think the bot is almost ready according to the thread, please specify if the procedure i stated is correct and i can have the changes done before monday

Cheers,
Simon
  • #60
  • Edited 9:46am May 28, 2011 9:44am | Edited 9:46am
[quote=esquire;4651032]J

As far as i know, this is the procedure:

- Search inside bar
- Place order when price exeeds high + 1 pip + spread of inside bar (or the low - 1 - spread) & price is higher then 6 GMT Open (or lower)
- SL is the other end of the inside bar (wihthout 1 pip & spread).
- Close half of the position where the profit of that closed half will cover the risk of the other half open. Which would mean it is the difference between the sl & the open price. Don't understand what you mean with "Double the openingsprice"
- The other half is taken care of by steven's trailing stop (which works fine i guess?)

If the above is correct i'll just have to adjust the following:
- add the 1 pip + spread thing
- Make sure sl & tp are correctly coded (didn't check yet) and adjust if necessaire.

Simon:
Your description is right on the money. (Personally I don't add the 1 pip and spread when trading manually but it couldn't hurt to code it)

My reference to "double the opening price" referred to a take profit ERROR that I am currently experiencing with the bot. I have had a number of instances where the bot has doubled the opening price using that for a TP rather than doubling the LENGTH OF THE IB to set the TP. When you check the SL & TP in the code you will probably find out why this is happening.

IT IS WORTH MENTIONING HERE THAT USING THE ORIGINAL CODE THAT STEVE WROTE I HAVE ACCUMULATED 7 "FREE" TRADES. THEY ARE BEING MANAGED BY THE JUMP STOP ON THE ORIGINAL BOT AND NOW AGGREGATE OVER 1700 PIPS PROFIT. NOT TOO BAD FOR A WEEKS TRADING ON 4 PAIRS. I have not yet checked the losses in the establishment of the free trades or the "Free" trades that have already closed for a profit.
Roger
0 traders viewing now