Menu

Options

Bookmark Thread

First Page First Unread Last Page Last Post

Print Thread

Similar Threads

Improved multi-timeframe/offset/chart period converter, P4L PeriodCon.mq4 330 replies

MT4 horizontal line price marker display help in mq4 6 replies

I need some MQ4 help from a real MQ4 programmer 2 replies

moutaki Mq4+fibo grid Mq4=profit+ease 39 replies

I need mq4 for this buy & sell script 2 replies

Attachments: Improved OrderHistory mq4 script to display trade history on charts
Exit Attachments

Improved OrderHistory mq4 script to display trade history on charts

Hi P4L,
Great script...I'm working on an Access database to collect my trade data...and want to grab trades from a couple of MT4 instances and combine...this will work quite nicely. Great work!!!!
Cheers
CanuckCT
Hello,
Thanks for the Script! I have added this to an offline Renko chart, and it seems the only way to get the script off the chart is to close the chart then reopen the chart. Once the script is plotted on the chart, when I right click on the chart there is no option to remove the script. Is there any other way to close the script on the offline chart without closing the chart and reopening it?

Thanks,
SatchFan
Quoting SatchFan
Hello,
Thanks for the Script! I have added this to an offline Renko chart, and it seems the only way to get the script off the chart is to close the chart then reopen the chart. Once the script is plotted on the chart, when I right click on the chart there is no option to remove the script. Is there any other way to close the script on the offline chart without closing the chart and reopening it?

Thanks,
SatchFan
You're description of the problem doesn't quite match how this script works, but there is an easy solution for you.

To clarify, when you add an indicator or an EA to a chart, it stays connected to the chart and you can remove it if desired. It so happens that most indicators have a "deinit()" function the programmer wrote to remove any objects/lines it creates when it is removed, or whenever you restart MT4 or change timeframes.

This however, is a script. Most scripts run just once and exit, and this is that kind of script. There are a few scripts that when added they start running in an infinite repeating loop, usually with a built-in delay between iterations (because if they don't delay using the sleep function, they'll eat up all your CPU like crazy). For these looping scripts, then yes, a right-click will give you a menu choice where you can elect to "stop" the script. Changing timeframes or restarting MT4 will also "stop" the script.

After my script runs, it exits and is no longer attached in any way to the chart. However, what you want to do is remove the objects from the chart, right? I built this feature into the script, and to use it:

1. First, use the script normally to display your trades. When you're done and want to remove the objects then...
2. AGAIN add the script to the chart, but change the variable "DeleteCreatedObjects" from false to "true", and that will remove all the objects that had been created by step #1.

I'm glad the script is apparently working for your renko offline charts. I never tested that. It does work with offline charts with non-standard timeframes like "H2", as generated by my "P4L PeriodCon.mq4" indicator, but ONLY if it's simply a period multiplier and not with a timeshift (because a timeshift changes the symbol name, so, if the symbol name doesn't match your trade records it can't display the trades). (That's probably something that could be enhanced in the "P4L OrderHistory" script to work, but I have no plans to do so. Nobody's ever asked so must not be an issue).


Where is a link to the renko chart indicator that you use?

Glad you (and others) like my script. Cheers.
Kent (pip4life)
Quoting pips4life
You're description of the problem doesn't quite match how this script works, but there is an easy solution for you.

To clarify, when you add an indicator or an EA to a chart, it stays connected to the chart and you can remove it if desired....
Thanks for the reply and taking the time to describe how a script works. I have a much better understanding of how a script works now. As for which renko indicator or EA I'm using, well I'm trying out several of them. I typically use indicator based renkos, instead of EA's because of how I set up my platform with profiles. I have a profile for every market I trade. So when I want to see a different market, I have to change profiles. I use remote desktop on my PDA when I'm away from the computer because the mobile metatrader doesn't do renko's. So when I have an EA on my chart creating the renko's, it takes wayyyyy to long for the renkos to be updated when I change profiles. It's much faster with indicators. Plus the fact that I'm using remote desktop which can slow me down some too. The combination of both of those can be quite frustrating at times.

Here is one renko indicator.

There are a bunch more here. I just downloaded Jake's versions of renko's in that list today, and haven't had a chance to try them out yet. You will also notice different versions of RenkoLiveChart (v2.1 v3.2) etc. in there too. Feel free to try out different versions, that's what I'm doing. Sometimes I notice that a version might not re-plot renko bars the same way after I have changed profiles and come back to the profile. For instance, it might show 4 down renko's 2 up, then 3 down. After changing the profile and coming back, however, it might show 4 down, 1 up, 3 down. Weird.. Anyway, I really do appreciate you taking the time to explain a script in detail and sharing your script on FF! I have learned something today!

Thanks again,
SatchFan

P.S. If you have any questions about renko or anything else, I'd be more than willing to try to help!
2011-05-18: New V6 of "P4L OrderHistory.mq4" released. (See Post #1)

* Fixes a problem with split orders. Either MT4 changed, or perhaps only certain brokers have this new problem. When an order is split by closing only a portion of the original order, the buy/sell arrows and trendlines for each part of the split should still originate from the same open-time & price of the original order. This version fixes a problem where the time of the split was used instead of the original OpenOrderTime.



Below is a picture showing the way it should be -- and is with V6. The buy/sell arrows and the trendlines all originate from the same spot where the 1st order was opened.


The bottom picture shows the problem. The buy/sell arrows and the trendlines for the SPLIT portion of the trade originate out in space. The price is correct, but the time(s) are for when the order was split (by closing a portion of the original trade).



P.S. Some people may ask "How do you split up an existing order?" When you place the first order with a given size (e.g. 5 lots), when you manage that order, you of course have a button to "Close" the order. However, notice that you can edit the #-of-lots that you want to close. If you change the #lots to "3" and "Close" it, you have closed only a portion of the original 5-lots. The remaining 2-lots are still open (and it will have a new OrderNumber too). You can then close the remaining 2-lots as desired (or you could split it again).

Attached Image (click to enlarge)
Click to Enlarge Name: V6 P4L OrderHistory.jpg Size: 357 KB
  • Post #46
  • Quote
  • Edited 1:04pm Jun 30, 2011 12:48pm | Edited 1:04pm
Hi Pips4life,

Newbie in forex and my first post in FF. Just registered to say Thank You for such a wonderful script! I just tried on it and it works great!

I used to copy & paste screen the chart to"paint" software in Window and painstakingly draw out every trade that I have done. With this handy tool, so much time can be saved!

Thanks again. Later when I grow more experienced in this field, I would like to contribute to this forum.
Hi Pips4life,

Excellent work! Thank you very much for this great contribution.

I have a question. When I export the history to a CSV file, I get the pips in the AA column right for 4 digit currencypairs (I use a 4 digit broker). However, for 2 digit pairs (i.e. USD/JPY) the pip count is a factor 100 too big. It says 1300 pips profit instead of 13 pips.

Am I overseeing something?

Maurice
Quoting MauriceW
Hi Pips4life,

Excellent work! Thank you very much for this great contribution.

I have a question. When I export the history to a CSV file, I get the pips in the AA column right for 4 digit currencypairs (I use a 4 digit broker). However, for 2 digit pairs (i.e. USD/JPY) the pip count is a factor 100 too big. It says 1300 pips profit instead of 13 pips.

Am I overseeing something?

Maurice
Good catch to find that bug. I have a fixed version I will release shortly. Any other bugs or enhancement requests?
2011-11-04: New "P4L OrderHistory.mq4" (V7) released. (See Post #1)

* Fixed a bug (reported by MauriceW) with Output columns that incorrectly reported "pips" for some of the currency pairs (It was related to 2-digit vs. 4-digit pairs). The wrong values were off by x100.

* The StartDate and EndDate variables were renamed to "Start_Date_OR_Number_of_weeks" and "End_Date_OR_Number_of_weeks". The default is to display (and/or output) the most recent 8 weeks of trades. Change the Start_Date... to "0" to get ALL trade history, or enter specific date(s) of interest.

* New variable "Make_Dollars_and_LotSize_SECRET" (false) can be set to True if the user wants to keep the Dollar amounts and LotSize secret. Profitable trades simply show a profit of "1.00", and unprofitable trades show "-1.00". "Break-even" trades show a profit of either 0.01 or -0.01. The LotSize is set to "1.0" for every trade. This affects all the created objects, AND it affects the values in the Output file. The benefit of this option is to allow a user to share the Output file (or possibly a Template file with the objects) with another person that shows the trades taken but gives no private details with respect to the profit/loss or the size of the trades. FYI, Swap and Commissions are also set to zero, since these indirectly indicate the LotSize. (NOTE: The User must VERIFY the Output file content to insure that private details are not inadvertantly left in the file! Especially check the Comments column. Open a blank Excel worksheet and import the Output file to inspect the details.)

* New variable "OUTPUT_SuppressBlankSymbolLines" (false) can be set to True if the user wants to suppress from the OUTPUT file all transactions which have a blank symbol name. These include account deposits, withdrawals, transfers, adjustments, commissions charged after-the-trade, etc. (FYI, this variable is auto-forced to True if Make_Dollars_and_LotSize_SECRET=True).
Good job!
What about an "always on" version of this script as an Indicator or an EA?
Would be very useful on Charts where automated trading EAs are running...
Quoting Hanky
Good job!
What about an "always on" version of this script as an Indicator or an EA?
Would be very useful on Charts where automated trading EAs are running...
Hi Hanky,

I can see how in conjunction with EA's it would be nice to see live updates that chart your trades graphically, real-time. I'll put it on my long-term list of ideas to think about and possibly implement. (Won't likely be soon due to other projects, and due to the fact that I don't (presently) trade with EA's. Even with manual trades, the live-updates could be nice but it's not as important, to me at least).

Thanks for replying,
Kent (pips4life)
Hello pips4life,

Do you know maybe if there is a possibility to retrieve orders history in real time for a backtest ?? Is kind of virtual account defined during backtest that you can retrieve such info ??

I know this orders are included in the logfiles but unfortunatelly MT4 does not flush them in real time. See this

http://forum.mql4.com/28877#536877

Do you know if is possible to force flushing the orders to the logfile in real time ??

Krzysztof
Quoting fajst_k
Hello pips4life,

Do you know maybe if there is a possibility to retrieve orders history in real time for a backtest ?? Is kind of virtual account defined during backtest that you can retrieve such info ??

I know this orders are included in the logfiles but unfortunatelly MT4 does not flush them in real time. See this

http://forum.mql4.com/28877#536877

Do you know if is possible to force flushing the orders to the logfile in real time ??

Krzysztof
Hi Krzysztof,

Sorry, I have no idea about forcing the Strategy Tester to do any such thing. I suppose you could try writing a function within the EA that writes out the trade details into an external tab-delimited (or comma or whatever) file. However, I still don't know whether that operation to write to a file would happen "real-time" or whether that too would get buffered into RAM until such time as it decides to flush the RAM out onto the disk file/logs/etc.

Good luck.
Kent
Hi pips4life
Wnated to say BIG THANKS for an indicator
it is exelent.
Just Tried it and it tells all the history that i did all day .
Very helpful to me in order to document my trades in the journal
Thank you for the script
Michael
Do not be victim to conflict of the General and Commander in you - by FTI
Quoting -Michael-
Hi pips4life
Wanted to say BIG THANKS for an indicator
it is exelent.
Just Tried it and it tells all the history that i did all day .
Very helpful to me in order to document my trades in the journal
Thank you for the script
Michael
Hi Michael,

You're welcome! I agree, actually, that this really is a very useful script, for journaling purposes and for many others. It is really good to be able to plot your trades on a chart and visually analyze the good and the bad about your trading decisions.

I wonder if people are making use of the ability to share their trade history with others ? The most recent version has a new variable (Make_Dollars_and_LotSize_SECRET) that if set to true, will hide the lot-size and private dollar details, but still can show the graphical trade information where the trade(s) were opened and closed, and whether these were profitable or not.

Occasionally I see people posting the MT4 Trade History Report. Sometimes it's posted as a screenshot, but if it is posted as an actual HTML file, I wonder if people know that my script can read that HTML file and plot the trades on their own charts? (It might require some time-shifting due to different broker GMT offsets, but that feature is built in to the script too). Even better, if people are willing to share, they can use the script to write an Output file (csv), and upload that for others to download and use as an Input file (again, time-shift as needed).

Given that it's now January, another nice feature is that one can gather all the trade information into an Excel file for analysis, and possibly use it as an additional record for tax purposes.

Love the way you posted the chart in your journal with the day's trades displayed. Very good.

Good trades to you,
Kent (pips4life)
Quoting pips4life
Hi Michael,

You're welcome! I agree, actually, that this really is a very useful script, for journaling purposes and for many others. It is really good to be able to plot your trades on a chart and visually analyze the good and the bad about your trading decisions.

I wonder if people are making use of the ability to share their trade history with others ? The most recent version has a new variable (Make_Dollars_and_LotSize_SECRET) that if set to true, will hide the lot-size and private dollar details, but still can show the graphical trade information...
Hi Kent (Pips4Life)
You right this is the easyest way to plot on chart i still trying different features of your script .
About this feature not to expose the Size and dolar Details.
I saw that in the script you wrote that you not totaly setisfied about the text placement. When i ploted the text it is on the background and between the candles. When i changed Candeles to Line chart it is more understandable from the Text side maybe it can be a solution for now to plot text of orders on Line chart
Thanks
Michael
Do not be victim to conflict of the General and Commander in you - by FTI
[quote=pips4life;5104255]2011-11-04: New "P4L OrderHistory.mq4" (V7) released. (See Post #1)


Hi Kent,

Very good script with so many features. Thank you.

I attached a chart with an example of a trade with two exits. The order history details are cluttered at the begining of the trendline drawn for each entry and exits. I think this is because the order data is in the object description of the trendline. See chart.
Can you make code change such that the order history data is printed at the Exit point for every Exit and not at the Enrty.
I think a second object variable for the Exit data may do the trick. But I am not good at coding. Still have my Learning plate on my back.
Thanks.
Attached Image (click to enlarge)
Click to Enlarge Name: P4LOrderHistory example.gif Size: 31 KB
Honesty is a very expensive gift. You wont find it in cheap people.WBuffett
Quoting emmanuel7788
Hi Kent,

Very good script with so many features. Thank you.

I attached a chart with an example of a trade with two exits. The order history details are cluttered at the begining of the trendline drawn for each entry and exits. I think this is because the order data is in the object description of the trendline. See chart.
Can you make code change such that the order history data is printed at the Exit point for every Exit and not at the Enrty.
I think a second object variable for the Exit data may do the trick. But I am not good at coding....

Hi Emmanuel7788,

I agree with you that the Description texts tend to overlap for split trades, but what I do is hit F8, select the "Common" tab, and turn OFF the "Show Object Descriptions".

While it's true that you won't see all the Descriptions of the trade info, you can point at any object and the popup will briefly display the trade details for the specific one you point at. That is more the intended usage model.

MT4 doesn't offer much control over the placement and orientation of the Description text. If I reverse the line direction, it does place the text at the "Exit" point, however it's upside down, so that's even worse for readability.

One could possibly put a new object on the chart that displays the text near the exit, but again, MT4 has so little control over text orientation that it would probably be even more confusing as to which text went with which trade. You have noticed, however, that there is already a graphic at every trade close, and again if you highlight that object (or the trendline), the popup will display the trade details briefly.

There is an option called "DisplayTexts" which you can change to "True". That will add some texts near the trade beginning, but they are staggered somewhat so as not to grossly overlap. It's not perfect, and to be honest, I never use the "DisplayTexts" feature myself, but maybe it could work for you.

Sorry I can't do much to the code for you, but glad you like it anyway.

Kent (pips4life)
Hi Kent

I'd like to thanks you for this great script, not being an MT4 savvy programmer this is great and just what I was looking for.

I wanted to ask though, how do I go about changing the STYLES I.e. arrow types, line styles, thickness', S/L & P/L symbols and so on. I've had a look and managed to change colour and other basic settings but cant seem to figure out how to do the styles. Could you explain this please.

I've looked through the forum but couldn't see any similar question (unless I missed it of course) if you could help with this it would be great.

Many Thanks
NinjaPip
Hi Kent

Me again, sorry I forgot to ask as well if you could describe how to adjust whats viewed in the description. As it is and as mentioned before in the forum it can get messy with multiple trades on a chart but I'm after a way to have just the MT4 ticket number attached to the line or maybe the entry arrow.

Could you show how to do this please...

Many Thanks and again great work with this I've been reviewing my losing trades with this and wow its so much quicker and easier to visually see whats gone wrong in the past. Up until now I've been using screen shots and manually putting in arrows with horizontal lines to depict exit price... This is time consuming though.

Regards Mark
0 traders viewing now