Ichimoku Kinko Hyo EA v1.1 | Page 2 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Ichimoku Kinko Hyo 200 replies

Ichimoku Kinko Hyo analysis and the "one glance on a single chart" 35 replies

Ichimoku Kinko Hyo: Does it repaint? 2 replies

Ichimoku Kinko Hyo 302 replies

Ichimoku Kinko Hyo Test 2 replies

Attachments: Ichimoku Kinko Hyo EA v1.1
Exit Attachments

Ichimoku Kinko Hyo EA v1.1

  • #21
  • Jun 19, 2011 3:56pm Jun 19, 2011 3:56pm
Very nice tool with good Features.
Läuft ab Mo. Demo und real.
Danke für die Arbeit.
  • #22
  • Jun 19, 2011 4:07pm Jun 19, 2011 4:07pm
thanks for clarification
  • #23
  • Jun 19, 2011 5:02pm Jun 19, 2011 5:02pm
thanks guys, I wanna let this EA running 24 hours this week, what do you guys think ?
acc: 500 usd
lot: 0.01
leverage: 1:400
i put the 5M settings, TP e SL based on ATR....


at chart appears 'TRADING NOT ALLOWED', but my tradeAllowed is TRUE...is it ok? will this take trades or i forgot something?
Attached Image (click to enlarge)
Click to Enlarge Name: Sem título.png Size: 103 KB
  • #24
  • Jun 19, 2011 5:28pm Jun 19, 2011 5:28pm
Quoting rlpaludo
thanks guys, I wanna let this EA running 24 at chart appears 'TRADING NOT ALLOWED', but my tradeAllowed is TRUE...is it ok? will this take trades or i forgot something?
tradeAllowed = true
GMTShift = 6 (CHANGE!, because thats for cambodia. see explanation above that setting)
stopTradingOnFriday = true ????

EA does not trade before sunday opening also. To get this work - you have to adjust the GMTShift-setting.

Quoting carlos.x
Very nice tool with good Features.
Läuft ab Mo. Demo und real.
Danke für die Arbeit.
in german: das REAL würde ich sein lassen. Und zwar so lange bis klar ist ob das Teil überhaupt profitabel ist (hängt auch von den SL/TP-settings, ichimoku-settings, timeframe, etc. ab).

in english: DO NOT TRADE WITH REAL MONEY UNTIL WE KNOW IF THAT EA IS PROFITABLE!!!!!!!!!! And, of course, that depends on the ichimoku-specific settings, the timeframe, the SL/TP-settings, and so on, and so on!

If you are just trading wit 0.01 or 0.001 lots, ok, why not? If you can absorb that loss of money, why not (ok, go drinking and fu**ing some girls with friends, it would be lots of more expensive, believe me, i know that!)
PM me with coding requests and I'll probably put you on my ignore list
  • #25
  • Jun 20, 2011 1:16am Jun 20, 2011 1:16am
Quoting rlpaludo
at chart appears 'TRADING NOT ALLOWED', but my tradeAllowed is TRUE...is it ok? will this take trades or i forgot something?
Ups, sorry, no wonder, because I did one mistake -

Attached you will find the newest Version and one template. Please re-download. Thanks.

It is updated for using a second timeframe also - if set to true, trades only will be opened if the signal on both the timeframes is the same.

the .mq4 and .ex4 files: copy to MT4-directory/experts/
the .tpl file: copy to MT4-directory/templates/
Attached File(s)
File Type: ex4 2011-06_Ichimoku EA v1.2.ex4   33 KB | 2,964 downloads
File Type: mq4 2011-06_Ichimoku EA v1.2.mq4   42 KB | 4,075 downloads
File Type: tpl Ichimoku EA v1.2.tpl   3 KB | 3,846 downloads
PM me with coding requests and I'll probably put you on my ignore list
  • #26
  • Jun 20, 2011 2:59am Jun 20, 2011 2:59am
hi fxd ... here in FF.com usually the newest version of bots, indis, templates etc. are published in post #1 ... so could you plz post the actual ea version in post #1 ?
  • #27
  • Jun 20, 2011 6:58pm Jun 20, 2011 6:58pm
Quoting fxdaytrader_
Ups, sorry, no wonder, because I did one mistake -

Attached you will find the newest Version and one template. Please re-download. Thanks.

It is updated for using a second timeframe also - if set to true, trades only will be opened if the signal on both the timeframes is the same.

the .mq4 and .ex4 files: copy to MT4-directory/experts/
the .tpl file: copy to MT4-directory/templates/
Any chance you can add one more time frame to the mix??
Thanks!
  • #28
  • Jun 21, 2011 5:53am Jun 21, 2011 5:53am
I could do that, yes.

But maybe it would make more sense to add one other filter like RSI oder ADX.

I hope I will have some time later to play around with that.
PM me with coding requests and I'll probably put you on my ignore list
  • #29
  • Jun 21, 2011 6:17am Jun 21, 2011 6:17am
Quoting DerBerliner
hi fxd ... here in FF.com usually the newest version of bots, indis, templates etc. are published in post #1 ... so could you plz post the actual ea version in post #1 ?
Thanks, I edited post #1 and added the link to the post with the newest version
PM me with coding requests and I'll probably put you on my ignore list
  • #30
  • Edited 8:35am Jun 21, 2011 8:16am | Edited 8:35am
Thanks for the EA. I'm testing it.
I noticed that when price reaches TP it closes the order and instantly opens another order on the same pair.
Wouldn't it be better if SL and TP are adjusted?

The EA also sells when price is above the Kijun line. I believe that's against Ichimoku rules?
(never mind, guess I shoud've set to strong signals only)
  • #31
  • Jun 21, 2011 9:05am Jun 21, 2011 9:05am
Quoting fxdaytrader_
I could do that, yes.

But maybe it would make more sense to add one other filter like RSI oder ADX.

I hope I will have some time later to play around with that.
Hello fxdaytrader and others. Thanks for starting this thread. I have spend several years now trying to put together a profitable EA without success. I hope you do what I have not been able to do, and I hope you share the results. Have spent a lot of time with ADX as a filter, and I would like to share my views. The down side of using ADX Level (say 24 for example) as a filter is that it gets one in the trade late much of the time, and thus causes losses because you enter about the time a reversal is due. So if you use ADX, it is my view that it is best used as a momentum indicator without concern for Level. If DI+ is above DI- and the ADX is getting higher, the signal is long. The opposite for short.

The ADX indicator that I like is Advanced_ADX, and you will find it attached. The code for the momentum filter that I suggest above using Advanced_ADX is as follows:

if (ADX_Filter_Enable)
{
double ADXup0 = iCustom(Symbol(), Timeframe, "Advanced_ADX", 13, 0, i);
double ADXdn0 = iCustom(Symbol(), Timeframe, "Advanced_ADX", 13, 1, i);
double ADXup1 = iCustom(Symbol(), Timeframe, "Advanced_ADX", 13, 0, i+1);
double ADXdn1 = iCustom(Symbol(), Timeframe, "Advanced_ADX", 13, 1, i+1);
if (ADXup0 > 0.0 && ADXup1 > 0.0 && ADXup0 > ADXup1)
{
signal long;
}
else if (ADXdn0 > 0.0 && ADXdn1 > 0.0 && ADXdn0 > ADXdn1)
{
signal short;
}
else
{
no signal;
}
}

Think you need to find a way to backtest (perhaps one pair at a time) in order to find the best combination of the many parameters you have to set.

Anyway, I wish you success.
Attached File(s)
File Type: mq4 Advanced_ADX.mq4   2 KB | 1,686 downloads
  • #32
  • Jun 21, 2011 12:28pm Jun 21, 2011 12:28pm
EasyRyder, thanks for your suggestion. I agree with you because I thought about the same.

Here is what I intend to implement (user will be able to switch on/off that function):

Inserted Code
 
//+------------------------------------------------------------------+
//| expert adxTrend function                                         |
//+------------------------------------------------------------------+ 
// function call: adxTrend(Symbol(),15,7,25) == "LONG"/"SHORT"/"FLAT"
string adxTrend(string symbol, int tf, int adxPeriod, int adxTrigger)
  {
    string adxTrend = "FLAT";
    
    double adxMain = iADX(symbol,tf,adxPeriod,PRICE_CLOSE,MODE_MAIN,0);
    double adxPlusDi = iADX(symbol,tf,adxPeriod,PRICE_CLOSE,MODE_PLUSDI,0);
    double adxMinusDi = iADX(symbol,tf,adxPeriod,PRICE_CLOSE,MODE_MINUSDI,0);
    
    if (adxMain > adxTrigger
        && adxPlusDi > adxMinusDi) adxTrend = "LONG";
    if (adxMain > adxTrigger
        && adxPlusDi < adxMinusDi) adxTrend = "SHORT";   
    
    return(adxTrend);
  }

You could call that function (here with timeframe = 15, adxPeriod = 7, adxTrigger = 25, if you donnot want to use the adxTrigger, set it to 0):
string adxTrend(Symbol(),15,7,25);

Then adxTrend would be "FLAT", "SHORT" or "LONG".

A little bit more sophisticated it would be if you checked if adxPlus is rising and adxMinusDi falling and so on, that could be done with that simple function:

Inserted Code
 
//+------------------------------------------------------------------+
//| expert adxRising function                                        |
//+------------------------------------------------------------------+ 
// call: adxRising(Symbol(),15,7,25) == "LONG"/"SHORT"/"FLAT"
string adxRising(string symbol, int tf, int adxPeriod, int adxTrigger)
  {
    string adxTrend = "FLAT";
    
    double adxMain = iADX(symbol,tf,adxPeriod,PRICE_CLOSE,MODE_MAIN,0);
    double adxMainB4 = iADX(symbol,tf,adxPeriod,PRICE_CLOSE,MODE_MAIN,1);
    
    double adxPlusDi = iADX(symbol,tf,adxPeriod,PRICE_CLOSE,MODE_PLUSDI,0);
    double adxPlusDiB4 = iADX(symbol,tf,adxPeriod,PRICE_CLOSE,MODE_PLUSDI,1);
    double adxMinusDi = iADX(symbol,tf,adxPeriod,PRICE_CLOSE,MODE_MINUSDI,0);
    double adxMinusDiB4 = iADX(symbol,tf,adxPeriod,PRICE_CLOSE,MODE_MINUSDI,1);
    
    if (adxMain > adxTrigger
        && adxPlusDi > adxMinusDi
        && adxPlusDi > adxPlusDiB4
        && adxMinusDi <= adxMinusDiB4) adxTrend = "LONG";
    if (adxMain > adxTrigger
        && adxMinusDi > adxPlusDi
        && adxMinusDi > adxMinusDiB4
        && adxPlusDi <= adxPlusDiB4) adxTrend = "SHORT";
        
    return(adxTrend);
  }

Or we could use a combination between RSI and EMA for the current and higher timeFrame.
PM me with coding requests and I'll probably put you on my ignore list
  • #33
  • Jun 21, 2011 5:32pm Jun 21, 2011 5:32pm
The announcement of the Greek confidence vote just caused a news spike that drove the EA crazy. EU spiked up 30 pips and then down 45 pips all over a 15 minute period. The spike occurred on numerous pairs. The net result for my demo account was 4 loosers and one winner. The EA was having a pretty good day up until this event.
  • #34
  • Jun 22, 2011 11:48am Jun 22, 2011 11:48am
Hello fxdaytrader -- hope you are doing well. I question if the move-to-breakeven function in the EA is working properly for 5-digit brokers. The function in the EA that manages BreakEven is "checkForBreakEven". You will see in the function that both "point" and "BreakEven" are scaled up by a "multiplier" factor of 10 for 5-digit brokers.

point*=multiplier;
BreakEven*=multiplier;

point*BreakEven would then seem to be scaled by 100 (10 x 10).
I have had a situation on Demo this morning where USDJPY repeatedly closed positions for a 1 pip BreakEven profit, even when the BreakEvenPIPS value of 5 was not reached. The above problem does not explain this, however.
Would appreciate your taking a look at this function when you get a chance.
  • #35
  • Jun 23, 2011 9:37am Jun 23, 2011 9:37am
I agree breakeven seems to be odd. I get a lot of $0.10 profits.
Additionally, see how the trade opens up again and again after it closes the SL at a profit. We may want to do a couple things.

 

  1. wait for the signal to change direction
  2. have a trailing stop loss
  3. smaller Tp - can't get my tp to work


All in all I like the ea. Today was a good day and I have been manually placing trailing stops to see if it helps the profit. Because all of those little $.10 wins could have been more. Plus we lose the spread on every new trade in the same direction.

Attached Image (click to enlarge)
Click to Enlarge Name: screenshot.700.jpg Size: 278 KB



Results - ignore the first drop I had the lots messed up on .1 instead of .01. Doing okay.

Attached Image (click to enlarge)
Click to Enlarge Name: screenshot.701.jpg Size: 126 KB
  • #36
  • Jun 23, 2011 10:14am Jun 23, 2011 10:14am
The EA would perform better if trades were opened only on a closed candle. That would prevent the repeated opening of trades after a close on BE.

I am having problems with take profit also. I ran the current version, v1.2, last night set for max 10 pairs. SL at 3 X ATR and TP at 3 x ATR. The EA opened 10 positions and set no stops or no TPs. It is currently up 880 pips and only closed one trade at BE (+1 pip). It immediately reopened the position that closed at BE and it is currenlt well in profit, but with no way to close. Did not have this problem yesterday while trading on Oanda demo -- TP and SL were set correctly. Last night I put it on a SmartTradeFX demo, and no SL or TP were set. Both Oanda and SmartTradeFX are 5=digit ECN (STP) brokers.

I have been looking through the code, but it will take me a while to figure things out. Hope fxdaytrader can find the time to help us out, since he seems to know the code.

Quoting Minnelli
I agree breakeven seems to be odd. I get a lot of $0.10 profits.
Additionally, see how the trade opens up again and again after it closes the SL at a profit. We may want to do a couple things.

 

  1. wait for the signal to change direction
  2. have a trailing stop loss
  3. smaller Tp - can't get my tp to work

All in all I like the ea. Today was a good day and I have been manually placing trailing stops to see if it helps the profit. Because all of those little $.10 wins could have been more. Plus we lose the spread on every new trade...

  • #37
  • Jun 23, 2011 10:28pm Jun 23, 2011 10:28pm
Thank you all for your help.

I did some changes to the EA and actually it is running on a 4digitBroker-demoaccount to see if it is fine.

One version was running for a few hours on a 5digitBroker-liveaccount to see if SL/TP were set correctly. This was the case.

With some other EA's I did the same problem you reported occured (sometimes no SL/TP set), I think that is because of the minimum pips-Step, some brokers allow e.g. a SL only 8 or more pips away from current price.

Time is running, now it is friday again (). I hope I will have more time in the upcoming week.

--------
I donnot want to dilute that thread here, but, BTW, here is one more ichimoku EA. I did not done that one, but maybe some of you want to give it a try also: http://www.ts-24.net/mql4_Ichimoku_K...Metatrader.php (attached you will find that EA). It seems that this EA does not have a look to the senkou/chikou-span, but maybe it works fine, I do not know because I did not test it already.
Attached File(s)
File Type: ex4 MQL4_ORG_Ichimoku_EA.ex4   57 KB | 2,465 downloads
PM me with coding requests and I'll probably put you on my ignore list
  • #38
  • Jun 24, 2011 12:15am Jun 24, 2011 12:15am
Thanks - I messed with this today a little and did find that the no sl and tp occurred if the range was too tight. that is setting the atr to say 2 for a stop may be within 100 points on some pairs and gets rejected.

Maybe we need to add code that if that happens it takes the closest stop. In the case about 100 points (10 pips). Just a suggestion to get around the no stops.

Also, I just set my max loss to $2.50 per apir and profit the same way to see how that works since I'm playing with a tighter atr.
  • #39
  • Jun 24, 2011 1:07am Jun 24, 2011 1:07am
Thank yo for this EA. Will try it with practice account first.
  • #40
  • Jun 24, 2011 1:54am Jun 24, 2011 1:54am
[quote=Minnelli;4722319]Thanks - I messed with this today a little and did find that the no sl and tp occurred if the range was too tight.quote]

I am sure that there are some bugs in the code. Because normally it should adjust the SL/TP to the minimum the fxbroker allows.

I just implemented a change quickly:
- Only open/close trades at beginning of new bar (the function checks the volume of the current bar, but I think it is a little bit buggy also: If the EA goes on the loop for every pair, maybe it could miss one bar open...).

- If there is NO SL AND TP set, try to set it.
that is done by the function modifyNoMagicTrades(atrCalcTF, atrCalcPeriod,atrTPmultiplier,atrSLmultiplier,magic)
It seems to work (because some minutes ago I saw that the EA did not set an SL/TP, after put the newest version of the EA running, it updated the trade)

Attached you will find version 1.3
Attached File(s)
File Type: ex4 2011-06_Ichimoku EA v1.3.ex4   37 KB | 5,059 downloads
File Type: mq4 2011-06_Ichimoku EA v1.3.mq4   48 KB | 7,667 downloads
PM me with coding requests and I'll probably put you on my ignore list
0 traders viewing now