Indicators for the 'Trading Made Simple' system | Page 2 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Monitor for 'Trading Made Simple' system 565 replies

System Made Simple 4 replies

MTF Indicators for the 'Trading Made Simple' system 241 replies

trading made simple system test 12 replies

Trading Made Simple system follower - Thanks to eelfranz 9 replies

Attachments: Indicators for the 'Trading Made Simple' system
Exit Attachments

Indicators for the 'Trading Made Simple' system

  • #21
  • May 16, 2011 9:04am May 16, 2011 9:04am
Yes, i know that's the concern. That's the whole problem now isn't it

Maybe to make it a bit more clear:
Upper indi is the tdi which runned for a couple of hours, so that is how you saw it live during trading
Middel indi is your TMS, freshly loaded
Bottom indi is freshly loaded TDI

As you said, the bottom indi doesn't paint like the upper one (which is the original problem here), but your indi doesn't seem to do anything different.
Attached Image
  • #22
  • May 16, 2011 9:42am May 16, 2011 9:42am
It is very clear that Xaphod knows what he is talking about. His indicator (TMS-Osc) displays the correct values for past bars and the current bar.

The original indicator (TDI Red Green) has a bug in it. The number of bars to recalculate is incorrect - the indicator does not recalculate the moving averages for the current bar. Now, I have no idea what the original indicator creator's intentions were when the indicator was created. Maybe it is working exactly how he planned it. However, as has been pointed out, it is not working correctly for this strategy.

There are two lines in the start() function of the original indicator that can be changed to fix the problem. The easiest fix for non-coders would be to change this line:

Inserted Code
for (i=limit-1;i>=0;i--)

to this:

Inserted Code
for (i=limit;i>=0;i--)

Programmers can clearly see that the bug originates in this line:

Inserted Code
int limit = Bars-counted_bars-1;

Now, I do not have the time (or desire) to get into a long description of why this line is the true cause of the problem, but it has to do with the IndicatorCounted() function and some simple arithmatic.

Good luck!

Attached is screenshot of the fixed original indicator, Xaphod's indicator, RSI and MAs, and my own version on a M1 chart. As you can see all indicator windows are in agreement.
Attached Image (click to enlarge)
Click to Enlarge Name: tdi-fix.gif Size: 21 KB
  • #23
  • May 16, 2011 9:43am May 16, 2011 9:43am
Attached Image

Case Closed!
  • #24
  • May 16, 2011 10:15am May 16, 2011 10:15am
Sorry, didn't saw you were right, now i am.

+10 for Xaphod, been looking for this for a week, thanks a lot!
  • #25
  • May 16, 2011 12:36pm May 16, 2011 12:36pm
Xaphod,

Like the arrow signals on the HA candles and how the optional #0 line gives a heads up on the green line of the TMS oscillator.
Just wondering if you happen to have a version of the TMS oscillator that includes the dark blue bands of the TDI? Is that something that I can add manually?
  • #26
  • May 16, 2011 2:05pm May 16, 2011 2:05pm
thanks . for your corrected indicators. i would like to use one of them for alerts. trouble is, they give multiple alerts all the time. my old indicator only gave one alert at a time. is there something i can do to change it to one alert? i will attach my old indicator.............thanks...........vince
Attached File(s)
File Type: mq4 TDI-Histo v1.00.mq4   13 KB | 1,840 downloads
  • #27
  • May 16, 2011 3:29pm May 16, 2011 3:29pm
Quoting zznbrm
The original indicator (TDI Red Green) has a bug in it. The number of bars to recalculate is incorrect...
Thanks for helping to expain this, zznbrm!
  • #28
  • May 16, 2011 3:51pm May 16, 2011 3:51pm
Quoting Vince-AC
trouble is, they give multiple alerts all the time. my old indicator only gave one alert at a time.
No, they do not give multiple alerts. They alert once when a bar closes. However, they did alert after initialization which is pointless and annoying. An oversight on my part. I have updated the indicators in the first post to versions which do not alert after initialization. Please reinstall them.
  • #29
  • May 16, 2011 4:20pm May 16, 2011 4:20pm
Quoting dazzdude
Do you have a MFT version on the TDI tape?
Quoting ataviano
if you can make the TMS-Osc.mq4 more flexible by adding a user define timeframe input. it would be great if we can plot it on maybe H1 tf and it would display the H4 data...
Here:
http://www.forexfactory.com/showthre...64#post4621964
  • #30
  • May 16, 2011 4:23pm May 16, 2011 4:23pm
Quoting tig07
Xaphod,

Like the arrow signals on the HA candles and how the optional #0 line gives a heads up on the green line of the TMS oscillator.
Just wondering if you happen to have a version of the TMS oscillator that includes the dark blue bands of the TDI? Is that something that I can add manually?
No I do not have that. You can modify the original TDI indicators according to zznbrm's instructions to fix the bugs if you need the blue lines.
  • #31
  • May 17, 2011 3:56am May 17, 2011 3:56am
Quoting Xaphod
No, they do not give multiple alerts. They alert once when a bar closes. However, they did alert after initialization which is pointless and annoying. An oversight on my part. I have updated the indicators in the first post to versions which do not alert after initialization. Please reinstall them.
Hi Xaphod, many thanks for your work

I have just loaded the TMS-OSC-Cross on one chart and am getting multiple alerts every minute.

This is 11 hours after your response above so I assume I'm using the new version

Using W7 & build 226
Screenshot shows the pop up
http://screencast.com/t/mVzBXV6FsJv

Cheers
You don't have to be right, just don't be too wrong
  • #32
  • May 17, 2011 5:29am May 17, 2011 5:29am
Quoting El Dee
I have just loaded the TMS-OSC-Cross on one chart and am getting multiple alerts every minute.

This is 11 hours after your response above so I assume I'm using the new version
Thanks. You are right. It was alerting when MT4 reloads bars. Fixed it. Download the new version (v1.02) in the first post. The version number is shown on the first line in the input parameters.
  • #33
  • Edited 5:44am May 17, 2011 5:31am | Edited 5:44am
Quoting Vince-AC
thanks . for your corrected indicators. i would like to use one of them for alerts. trouble is, they give multiple alerts all the time. my old indicator only gave one alert at a time. is there something i can do to change it to one alert? i will attach my old indicator.............thanks...........vince

Sorry. You were right. It was alerting when MT4 reloads bars. It was not happening when I tested it. Ie. there was no reloading of bars during my testing.

Fixed it. Download the new version (v1.02) in the first post. The version number is shown on the first line in the input parameters.
  • #34
  • May 17, 2011 8:47am May 17, 2011 8:47am
Xaphod - am still getting an alert when not necessary - but not muliple ones as before. Get an alert when there is an actual cross (lets say green crosses red). An hour later on an H1 chart if that condition still exists another alert is generated. Don't know what your intent is but this creates excess alerts via popup and email. Comment applies to TMS-Osc Cross. May or may not apply to TMS-Osc Histo as I have alerts set on the Osc Cross only.
  • #35
  • May 17, 2011 8:57am May 17, 2011 8:57am
Xaphod,

Thanks for great sharing.

Unfortunately i've problem loading MTF
TMS-Osc .mq4 & TMS-Osc Hist.mq4

I saw only all yellow color bar when loaded TMS-Osc Hist MTF, no matter what tf i set.

and no line show on TMS-Osc MTF.Can you tell me what have i done wrongly?
  • #36
  • May 17, 2011 9:09am May 17, 2011 9:09am
Quoting Android38
Unfortunately i've problem loading MTF
TMS-Osc .mq4 & TMS-Osc Hist.mq4

I saw only all yellow color bar when loaded TMS-Osc Hist MTF, no matter what tf i set.

and no line show on TMS-Osc MTF.Can you tell me what have i done wrongly?
You need to have 'TMS-Osc.ex4' installed.

Quote
Here are MTF versions of the 'Trading Made Simple' indicators.
They require that the indicator 'TMS-Osc.ex4' is installed in order to work.
  • #37
  • May 17, 2011 9:19am May 17, 2011 9:19am
Quoting johnsund
Xaphod - am still getting an alert when not necessary - but not muliple ones as before. Get an alert when there is an actual cross (lets say green crosses red). An hour later on an H1 chart if that condition still exists another alert is generated. Don't know what your intent is but this creates excess alerts via popup and email. Comment applies to TMS-Osc Cross. May or may not apply to TMS-Osc Histo as I have alerts set on the Osc Cross only.
It does not do that when I test it. Please post a screenshot with the alerts dialog and the most recent chart history.
  • #38
  • May 17, 2011 9:54am May 17, 2011 9:54am
Quoting Xaphod
Thanks. You are right. It was alerting when MT4 reloads bars. Fixed it. Download the new version (v1.02) in the first post. The version number is shown on the first line in the input parameters.
Many thanks
You don't have to be right, just don't be too wrong
  • #39
  • May 17, 2011 9:57am May 17, 2011 9:57am
Quoting Xaphod
It does not do that when I test it. Please post a screenshot with the alerts dialog and the most recent chart history.
Attached are snaps of the email alert and chart that prompts the question. On the chart note that the vertical green line is on the 8:00am candle (chart time is 10am EDT), yet there was no cross at that time - the cross occurred one candle earlier. The second snap is of the email alert that was generated at 8:00am local time.

Have confirmed that even though the histogram is on the chart, alerts are set to false. Is this what you need? This is not a huge deal - just a bit annoying.
Attached Image (click to enlarge)
Click to Enlarge Name: eurcad 05 17 11.gif Size: 18 KB
Attached Image
  • #40
  • May 17, 2011 4:11pm May 17, 2011 4:11pm
Quoting johnsund
Attached are snaps of the email alert and chart that prompts the question. On the chart note that the vertical green line is on the 8:00am candle (chart time is 10am EDT), yet there was no cross at that time - the cross occurred one candle earlier. The second snap is of the email alert that was generated at 8:00am local time.

Have confirmed that even though the histogram is on the chart, alerts are set to false. Is this what you need? This is not a huge deal - just a bit annoying.
I do not see anything wrong here. Apart from the time in the email. Will fix that.

Timeline:

 

  1. 06:00-06:59
    Candle closes with RSI below TS
  2. 07:00-07:59
    Candle closes with RSI Above TS
    A cross is confirmed. Alert sent out at 08:00 when the next candle opens.
  3. 08:00-08:59
    Candle closes with RSI Above TS. No alert sent a 09:00?

Technically the current candle is closed and the new candle opened on the same tick. In this case at 08:00.

0 traders viewing now