Basket 14 EA System | Page 42 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

BASKET TRADE Management: Using multiple trade management EA's on basket trades 11 replies

Basket Knights - A Basket Trading Round Table 1,313 replies

Relative Strength Basket Trading System 3,479 replies

Simple Basket Trading system 61 replies

TMS basket: Dashboard for a basket of MA-Filtered RSI Signals 135 replies

Attachments: Basket 14 EA System
Exit Attachments

Basket 14 EA System

  • #821
  • Edited 8:14pm Sep 30, 2010 7:13pm | Edited 8:14pm
Quoting MetaCoder
I can't possibly respond to every request to explain differences between versions.

Please arm yourself with a diff utility and compare the text of the EAs to see the differences.

Also, the thread should contain descriptions of the differences.
Fredgold, I have trouble remembering what the difference is in these also, so I will try to explain it to you and refresh my own knowledge at the same time.

Phantom_Add_01 was the original. It uses phantom trades on the 14 pair basket and those are expressed in pips. Every hour it opens a real trade of any phantom that is +20 pips or more. No real basket trades are ever opened.

Phantom_Add_02 is the same as 01 except that it will not open a trade on a pair that has previous trades that are negative. The intent is to not keep making trades on a pair that has reversed, but is still above the +20 pips.

Phantom_Add_01a is the same as 01, but the phantoms are expressed in dollars and real trades are opened on any pair that exceeds 1/10 of Dollar Profit Target.

Phantom _Add_01a_the-game is a combination of 01a and 02. The phantoms are expressed in dollars, every hour a real trade is opened on any pair that exceeds 1/10 of Dollar Profit Target, but only if all previous trades on that pair are winners.

Also, in all the Phantom EAs where there are no trim and reverses, the floating PL does show the actual drawdown of the account - equity will always be the balance + PL. That should make some of you happy.

I hope this helps - it helped me anyway.
Frazer
  • #822
  • Sep 30, 2010 8:14pm Sep 30, 2010 8:14pm
Quoting MetaCoder
In your added code, do you understand that these two conditions won't be true at the same time very often? You're saying "check that a particular phantom trade is losing, but all actual open trades on the same pair are in profit".

[code]...
Hi MC,

I can confirm that his coding is correct.

All he is doing for that section of code is to see if a phantom pair is < -20pips and see if any existing real open orders for that pair are in profit.

It can happen.

It's basically the mirror image of the original Phantom strategy.
  • #823
  • Sep 30, 2010 8:47pm Sep 30, 2010 8:47pm
Thanks, so i'm not going crazy afterall
In the meantime, another basket closed for another 1%.
I had to pause it for one cycle (if anyone is watching it that closely) as I wanted to get gomarkets to make my demo permanent so I could leave this sucker running for the long term.
Otherwise, untouched and I just let it do what it does.

thegame, if you are interested, I wouldnt mind some help ensuring that more than one trade per pair per check doesnt happen. Not massively important as the results are still good, but will just be one of those annoying things to me.
  • #824
  • Sep 30, 2010 8:50pm Sep 30, 2010 8:50pm
No worries, so are you saying on each hour or half hour a pair is getting added more than once?
  • #825
  • Sep 30, 2010 9:18pm Sep 30, 2010 9:18pm
yeah, what i "think" is happening is

the top of the hour hits, it scans thru and finds the >20 pips and <-20 pips, opens trades accordingly. But still has 60 seconds left, and continuously scans during that 60 seconds. Have feeling if a pair pops from 20 to 19 to 20 during that 60 seconds, it sees that and opens it again.
Could probably solve the problem if in the code we said to look at only minute 0 second 0, but I am not sure if thats possible. Probably better to let it scan for 60 seconds to catch them all, but once it opens one mark it as opened so it can't open it again in that 60 seconds. That would be the ideal fix anyhow imo.
  • #826
  • Sep 30, 2010 9:21pm Sep 30, 2010 9:21pm
A great thanks for your explanation of the phantoms.it is clear my mind to see what is going on with phantoms EA.
Do you have any idea why after 2 days does not open even one trade for GOD sake?
best regards
Fred
Quoting frazerd
Fredgold, I have trouble remembering what the difference is in these also, so I will try to explain it to you and refresh my own knowledge at the same time.

Phantom_Add_01 was the original. It uses phantom trades on the 14 pair basket and those are expressed in pips. Every hour it opens a real trade of any phantom that is +20 pips or more. No real basket trades are ever opened.

Phantom_Add_02 is the same as 01 except that it will not open a trade on a pair that has previous trades that are negative. The intent is to not keep making trades on...
  • #827
  • Sep 30, 2010 9:26pm Sep 30, 2010 9:26pm
Quoting tazmaan
yeah, what i "think" is happening is

the top of the hour hits, it scans thru and finds the >20 pips and <-20 pips, opens trades accordingly....
I don't think it is doing that as MC's original code:

1. Marks the symbol as being added for the 00 or 30 minute

Inserted Code
MarkSymbolAdded(SymbolArray[i]);

2. Checks if it hasn't been added for that 00 or 30 minute, if it has then it won't add another order

Inserted Code
!SymbolMarked(SymbolArray[i])

So in fact you are going crazy ;-)
  • #828
  • Sep 30, 2010 9:28pm Sep 30, 2010 9:28pm
Quoting fredgold3434
A great thanks for your explanation of the phantoms.it is clear my mind to see what is going on with phantoms EA.
Do you have any idea why after 2 days does not open even one trade for GOD sake?
best regards
Fred
Nope... you have to give us a bit more detail Starting capital, leverage, MaxMarginToUse, ProfitPct... etc...

It's like playing Guess Who with some of you guys

"Is yours a red-head?"
  • #829
  • Sep 30, 2010 9:37pm Sep 30, 2010 9:37pm
starting capital =$101824.97,leverage=200:1 Maxmargintouse=0.2 profitpct=1.0
i use all defualt settings.
thanks
fred
Quoting the-game
Nope... you have to give us a bit more detail Starting capital, leverage, MaxMarginToUse, ProfitPct... etc...

It's like playing Guess Who with some of you guys

"Is yours a red-head?"
  • #830
  • Sep 30, 2010 9:40pm Sep 30, 2010 9:40pm
Taz,

Please correct me if I am wrong and I apologize if I am. You have in your code:

if (TimeMinute(TimeCurrent()) != 0 || TimeMinute(TimeCurrent()) != 30) ClearSymbolMarks();

Shouldn't this be

if (TimeMinute(TimeCurrent()) != 0 && TimeMinute(TimeCurrent()) != 30) ClearSymbolMarks();

If you have an OR condition, it will always be true regardless of the Minute.

If the minute = 0 - the 2nd part will be true (Minute != 30).

If the minute = 30, the 1st part will be true (Minute != 0).

If the minute is something other than 0 or 30, say 15. both parts will be true.

The statement will be True all of the time, for every minute.

If you change the OR to and AND condition, it won't be true on Minutes 0 and 30.
  • #831
  • Sep 30, 2010 9:51pm Sep 30, 2010 9:51pm
Quoting fredgold3434
starting capital =$101824.97,leverage=200:1 Maxmargintouse=0.2 profitpct=1.0
i use all defualt settings.
thanks
fred
press Expert advisors button to disable EAs

remove the EA

press F3 and delete everything you see

press Expert advisors button again to enable EAs

attach the EA with the settings you want

If you still have problems after that then sorry I cannot help you.
  • #832
  • Sep 30, 2010 9:53pm Sep 30, 2010 9:53pm
Quoting dim13
Taz,

Please correct me if I am wrong and I apologize if I am. You have in your code:

[b]if (TimeMinute(TimeCurrent()) !=...
Good call... I saw that and fixed it for myself but thought nothing of it.

That actually answers taz's issue, because ClearSymbolMarks keeps getting called, so therefore the pairs keep getting added to.
  • #833
  • Sep 30, 2010 9:54pm Sep 30, 2010 9:54pm
Quoting the-game
I don't think it is doing that as MC's original code:

1. Marks the symbol as being added for the 00 or 30 minute

Inserted Code
MarkSymbolAdded(SymbolArray[i]);
2. Checks if it hasn't been added for that 00 or 30 minute, if it has then it won't add another order

Inserted Code
!SymbolMarked(SymbolArray[i])
So in fact you are going crazy ;-)
Can you take a look at my mod and see if what I added would cause them to open more than once? I know it's happening, I see it happen all the time, so must be something wrong in there somewhere (won't be suprised, as I said, was a total hack)
  • #834
  • Sep 30, 2010 9:56pm Sep 30, 2010 9:56pm
Quoting the-game
Good call... I saw that and fixed it for myself but thought nothing of it.

That actually answers taz's issue, because ClearSymbolMarks keeps getting called, so therefore the pairs keep getting added to.
Ok, yeah MC had it as !=0 in the original, so I just did what I could figure out to make it check on 30 min mark also lol.
So it is indeed working that it checks for new trades every hour and half hour, and opens them, but it's the marking them as opened that this wrong code is causing a problem?

That's one of those areas that threw me off, as I thought that had to do with when it checks to open new trades, not just when it clears the marked trades. Before I make the change I just wanted to make sure that it would not affect that the ea checks and opens trades every 30 minutes
  • #835
  • Sep 30, 2010 10:08pm Sep 30, 2010 10:08pm
Quoting tazmaan
Ok, yeah MC had it as !=0 in the original, so I just did what I could figure out to make it check on 30 min mark also lol.
So it is indeed working that it checks for new trades every hour and half hour, and opens them, but it's the marking them as opened that this wrong code is causing a problem?

That's one of those areas that threw me off, as I thought that had to do with when it checks to open new trades, not just when it clears the marked trades....
Works for me... dim is right. Change the || to && only in that line where it says ClearSymbolMarks()
  • #836
  • Sep 30, 2010 10:15pm Sep 30, 2010 10:15pm
If you do this though, you might find the EA won't be as successful.

My reasoning is the more you add while the momentum is strong in a certain direction for a pair, the faster you will reach the ProfitPct target (DollarProfitTarget).

With this fix it will just add once, you will see the order go into profit straight away most of the time, but then reverse just before the ProfitPct target.

If you do see this happening after the fix, just reduce the ProfitPct from 1.0 to 0.5 to get faster equity pops.
  • #837
  • Sep 30, 2010 10:15pm Sep 30, 2010 10:15pm
Yeah, I did it and am just waiting for some trades to open on another demo to be sure it fixes the problem. Thanks guys for helping me out with this
  • #838
  • Sep 30, 2010 10:17pm Sep 30, 2010 10:17pm
Quoting the-game
If you do this though, you might find the EA won't be as successful.

My reasoning is the more you add while the momentum is strong in a certain direction for a pair, the faster you will reach the ProfitPct target (DollarProfitTarget).

With this fix it will just add once, you will see the order go into profit straight away most of the time, but then reverse just before the ProfitPct target.

If you do see this happening after the fix, just reduce the ProfitPct from 1.0 to 0.5 to get faster equity pops.
Yeah, I had mentioned earlier that the results obviously don't mind multiple opens, and I am not sure I want to change anything. But the tradeoff if it isn't fixed is that the times when we are ranging and going nowhere, just all that many more trades being opened and using up margin. Only time will tell which action is better I guess
  • #839
  • Sep 30, 2010 10:21pm Sep 30, 2010 10:21pm
For everyone else, see attached for the fix
Attached File(s)
File Type: mq4 Phantom14_Add_02.taz.mq4   47 KB | 287 downloads
  • #840
  • Sep 30, 2010 10:31pm Sep 30, 2010 10:31pm
Quoting fredgold3434
A great thanks for your explanation of the phantoms.it is clear my mind to see what is going on with phantoms EA.
Do you have any idea why after 2 days does not open even one trade for GOD sake?
best regards
Fred
Which Phantom EA are you using? Did you download it after MC made the correction at http://www.forexfactory.com/showthre...42#post4047142 Before that change it would not open trades at all.

Can you provide a screenshot of the screen comments?
Frazer
0 traders viewing now