Basket 14 EA System | Page 41 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

BASKET TRADE Management: Using multiple trade management EA's on basket trades 11 replies

Basket Knights - A Basket Trading Round Table 1,313 replies

Relative Strength Basket Trading System 3,479 replies

Simple Basket Trading system 61 replies

TMS basket: Dashboard for a basket of MA-Filtered RSI Signals 135 replies

Attachments: Basket 14 EA System
Exit Attachments

Basket 14 EA System

  • #801
  • Sep 30, 2010 1:25pm Sep 30, 2010 1:25pm
My modification of phantom_add_02 is going extremely well.
Here's the link to the stats.

http://www.myfxbook.com/members/tazm...QdOl33qbInCOoT
  • #802
  • Edited 2:12pm Sep 30, 2010 1:56pm | Edited 2:12pm
Quoting tazmaan
My modification of phantom_add_02 is going extremely well.
Here's the link to the stats.

http://www.myfxbook.com/members/tazm...QdOl33qbInCOoT
zero open order? how could that be...
keep that running, would like to see result after 6-8 weeks.
tazmaan, do u mind posting your modified phantom... thanks
  • #803
  • Sep 30, 2010 2:11pm Sep 30, 2010 2:11pm
It's hard to argue with success. This one closed again a couple hours ago and is up 15.17% in 20 days (14 trading days). It was originally running as Add_01 and I changed it to 01a yesterday.
Attached File(s)
File Type: xls Bskt14_Add_01a_500-1.xls   207 KB | 185 downloads
Frazer
  • #804
  • Sep 30, 2010 2:17pm Sep 30, 2010 2:17pm
Hi Tazmaan,

What modifications are you talking about in your post #81?
  • #805
  • Sep 30, 2010 2:19pm Sep 30, 2010 2:19pm
Sorry, it is post 801
  • #806
  • Sep 30, 2010 2:33pm Sep 30, 2010 2:33pm
My modifications are as follows:
add trades happen when a pair is >20 pips - original strategy
add trades happen when a pair is >-20 pips, and the opposite trade is taken - mod
the ea also checks every half hour, instead of every hour.

There were no open trades at the time because it had just closed out for it's 1% profit target and was waiting for the next conditions to be inline at the top of the hour or the bottom of the hour.

There is one issue with it, and i might contact MC about it. Sometimes it opens multiple trades on the hour of the same pair. I believe this to be caused by the pip count jumping up and down, and in that 60 seconds where it is checking conditions, it sees it a few different times and acts accordingly. I've left it as is, because it seems to be working regardless, but I do think it should only open 1 trade per pair per check.
  • #807
  • Sep 30, 2010 3:39pm Sep 30, 2010 3:39pm
Quoting tazmaan
add trades happen when a pair is >-20 pips, and the opposite trade is taken - mod
Shouldn't it be:

when a pair is < -20 pips, and the opposite trade is taken (instead of >) ?
  • #808
  • Sep 30, 2010 3:50pm Sep 30, 2010 3:50pm
yes, depends on how you want to think about it.
'more than 20 pips negative' is how I am running it
so if a phantom is -10 pips, will not open a reverse trade.
if phantom is -25 pips, will open a reverse trade.
  • #809
  • Sep 30, 2010 4:12pm Sep 30, 2010 4:12pm
Quoting tazmaan
My modifications are as follows:
add trades happen when a pair is >20 pips - original strategy
add trades happen when a pair is >-20 pips, and the opposite trade is taken - mod
the ea also checks every half hour, instead of every hour.

There were no open trades at the time because it had just closed out for it's 1% profit target and was waiting for the next conditions to be inline at the top of the hour or the bottom of the hour.

There is one issue with it, and i might contact MC about it....
Hey Taz, since most of us are not programmers and probably could not figure out how to modify the code, could you upload the modified EA to the forum?

Did you modify the latest versions? MC had the same bug when he first posted those EAs - he fixed it and re-posted them a day later.
Frazer
  • #810
  • Sep 30, 2010 4:12pm Sep 30, 2010 4:12pm
hi mc
i have asked you earlier about phantoms EA.what is the difference between 01 and 02 and the game version?
i have tried the phantoms14 add 01a.it has not trade so far anything at all after 2 days.i even cleaned up global variable few times,still no trade at all.
regards
fred
Quoting MetaCoder
I'm going to stop pursuing so many permutations of these strategies. I believe we have explored trim'n'reverse type tactical frameworks enough. I'm not that fond of them.

I have identified a straightforward version of Phantom14 that I will share if it proves itself to me. It's criteria for adding trades is simple and makes sense to me.

I always test on IBFX 50:1 mini demos, so EAs I post usually contain settings with that setup in mind. Some of you already know how to change the settings to work well with different setups (500:1, etc).
  • #811
  • Sep 30, 2010 4:29pm Sep 30, 2010 4:29pm
Quoting frazerd
Hey Taz, since most of us are not programmers and probably could not figure out how to modify the code, could you upload the modified EA to the forum?
This is what I'm guessing the modification is to the AddIdNeeded() procedure:

//if ( TimeMinute( TimeCurrent() ) != 0 )
if ( TimeMinute( TimeCurrent() ) != 0 && TimeMinute( TimeCurrent() ) != 30 )

//if ( BidsHaveChanged && TimeMinute( TimeCurrent() ) == 0 && !CloseAll ) {
if ( BidsHaveChanged && ( TimeMinute(TimeCurrent()) == 0 || TimeMinute(TimeCurrent()) == 30 ) ) && !CloseAll ) {

// ADDED THIS IN THE FOR LOOP...
if ( OppositeTrade == 1 && PL_Array[i] <= -1 * PipTarget4Add && AllSymbolTradesInProfit( SymbolArray[i] ) && !SymbolMarked( SymbolArray[i] ) ) {

if ( i < 7 ) {
Comment( "Adding a " + SymbolArray[i] + " sell trade..." );
Print( "Adding a " + SymbolArray[i] + " short." );
OrderSend( SymbolArray[i], OP_SELL, UseLots, MarketInfo( SymbolArray[i], MODE_BID ), Slippage, 0, 0, "Adding to a short winner", MagicNumber, Red );
MarkSymbolAdded( SymbolArray[i] );
Sleep(1000);
} else {
Comment( "Adding a " + SymbolArray[i] + " buy trade..." );
Print( "Adding a " + SymbolArray[i] + " long." );
OrderSend( SymbolArray[i], OP_BUY, UseLots, MarketInfo( SymbolArray[i], MODE_ASK ), Slippage, 0, 0, "Adding to a long winner", MagicNumber, Blue );
MarkSymbolAdded( SymbolArray[i] );
Sleep(1000);
}

Taz, Is this close to your modifications ? Thanks

- EDIT: Sorry, it took the spaces out when I pasted the code here - hard to read
  • #812
  • Sep 30, 2010 4:32pm Sep 30, 2010 4:32pm
Here is my modified version.

I am not a coder and i am sure it could have been done much nicer, but it seems to work (other than the small issue of multiple trades opening once in awhile, but I am not sure it'd due to my modifications or if it exists in the original version as well).
Was impressed with myself to even be able to figure out how to modify it to do what I wanted
Attached File(s)
File Type: mq4 Phantom14_Add_02.taz.mq4   47 KB | 243 downloads
  • #813
  • Sep 30, 2010 4:38pm Sep 30, 2010 4:38pm
tazmaan, your mod does same pair hedging, correct?
Open to new approaches.
  • #814
  • Sep 30, 2010 4:40pm Sep 30, 2010 4:40pm
Quoting fredgold3434
hi mc
i have asked you earlier about phantoms EA.what is the difference between 01 and 02 and the game version?
i have tried the phantoms14 add 01a.it has not trade so far anything at all after 2 days.i even cleaned up global variable few times,still no trade at all.
regards
fred
I can't possibly respond to every request to explain differences between versions.

Please arm yourself with a diff utility and compare the text of the EAs to see the differences.

Also, the thread should contain descriptions of the differences.
Open to new approaches.
  • #815
  • Sep 30, 2010 4:44pm Sep 30, 2010 4:44pm
Quoting MetaCoder
tazmaan, your mod does same pair hedging, correct?

No, I have been watching it to see if that ever occurs and it has not as of yet.
I've never seen both long and short on the same pair. I thought that might be an issue i'd need to address and decide upon, but it hasnt happened yet lol :/
  • #816
  • Sep 30, 2010 4:55pm Sep 30, 2010 4:55pm
In your added code, do you understand that these two conditions won't be true at the same time very often? You're saying "check that a particular phantom trade is losing, but all actual open trades on the same pair are in profit".

Inserted Code
 
          PL_Array[i] <= PipTarget4Reverse            &&
          AllSymbolTradesInProfit(SymbolArray[i]

So the same pair hedging wouldn't be likely to occur, which explains why you haven't seen it. Since a phantom pair has to be positive for an actual trade to be opened on the same pair, we may NEVER see it.

The big difference between your version and the orginal is that you add trades twice as often.
Open to new approaches.
  • #817
  • Sep 30, 2010 4:57pm Sep 30, 2010 4:57pm
No, I can't say that I do understand.
And from our previous discussions, I am not sure how you can say that that is the only difference between the original and mine, as the original did not take reverse trades of -20 pip count.
  • #818
  • Edited 5:19pm Sep 30, 2010 5:06pm | Edited 5:19pm
Quoting tazmaan
No, I can't say that I do understand.
And from our previous discussions, I am not sure how you can say that that is the only difference between the original and mine, as the original did not take reverse trades of -20 pip count.
I'm trying to explain that your code is not taking reverse trades of -20 pip count. The code calls for shorts in the buy group and longs in the sell group.

Since you're not seeing that, and since it's logically unlikely to happen, it confirms that the code you put in place to do it is falling through the 'if' checks.

Remove the AllSymbolTradesInProfit(SymbolArray[i]... check where you are trying to reverse the trades if you want to see happening what you think should be happening.
Open to new approaches.
  • #819
  • Sep 30, 2010 5:12pm Sep 30, 2010 5:12pm
If you do get it working as intended, let us know what happens.

Also, I originally took your 'reverse' to mean you'd be CUTTING and reversing.
Open to new approaches.
  • #820
  • Sep 30, 2010 5:29pm Sep 30, 2010 5:29pm
No, at the moment I am not cutting and reversing, as I am trying to avoid that (and it has successfully avoided it so far, time will tell whether it continues to be successful).

Here is how it is working based on my observations (i watch it as much as possible):

phantom trades get opened.
pairs that are +20 pip or greater in profit, get a real trade added on at the top of the hour, or the bottom of the hour.
pairs that are -20 pip or greater in loss, get a real trade opened that is the reverse direction of the phantom trade.
I have watched this happen for a week now, and believe it to be working correctly. I am not a coder at all, and just managed to hack yours to take these opposite trades. So be gentle with me if I don't understand what's incorrect, because 99.9% of coding I don't understand
The only bug that I am noticing is the one I mentioned earlier, which is sometimes at the top of the hour or bottom of the hour, multiple trades will open because (i assume) the ea isn't marking them as already opened in that 60 second window while it's checking for conditions to open new trades.
Otherwise, for now this is working as I have intended (i believe)
1 trader viewing now