Add an alert and get my indicator for nothing | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

add alert and email to this indicator 1 reply

Add Email and Alert to Indicator 4 replies

Please add email alert to this price alert indicator 0 replies

Shakesfx GBP/ JPY Parabolic SAR. Nothing more, nothing less 115 replies

How do I add an Alert on TSR Execute Line Indicator 26 replies

Attachments: Add an alert and get my indicator for nothing
Exit Attachments

Add an alert and get my indicator for nothing

  • #1
  • First Post: Nov 29, 2007 9:18am Nov 29, 2007 9:18am
Hello all,

I have developped an indicator that is working very well (check my last posting http://www.forexfactory.com/showpost...postcount=1487) and the previous on the same thread.

But it has one issue. The alert system is working but it sends an alert 4 time in a row. Once on the candle where the signal occurs and then once on each 3 following candle. I have tried me and someone else to modify it with different techniques but none gave the correct result. Whatever i test, i get 4 alerts (i did not test the mail function during the modification period but at first it was sending 4 mail basically spamming my mail box ^^ )

I basically know why it sends 4 alerts but i can't find a workaround

The first coder who achieve to modify the coding so that it sends only one alert for each signal will get the full indicator in ex4 format with the "one alert coding" implemented and explanation about the ay it works. (not with sleep function, i tried it and it was not satisfactory)

I attach a light version of the indicator that shows a lot of signal but dont worry this is mainly ot protect my coding as i provide it as mq4.

I dont know if it is a simple job but i believe the reward is worth it.
Attached File(s)
File Type: mq4 stochV2.mq4   8 KB | 633 downloads
  • #2
  • Nov 30, 2007 2:39am Nov 30, 2007 2:39am
not so easy it seems
  • #3
  • Nov 30, 2007 12:20pm Nov 30, 2007 12:20pm
Give us some time.

I will take a look.
  • #4
  • Nov 30, 2007 12:34pm Nov 30, 2007 12:34pm
Sorry, hard for me to understand what is going on with limited code and my metatrader demo account isnt working so I cant test fully. So, if it incorrectly displays the next four bars, what about setting the time of the "last indicator" 4 bars into the future. Just a crazy thought, and I have not tried anything like that before so I am not sure if it would work.
  • #5
  • Nov 30, 2007 1:23pm Nov 30, 2007 1:23pm
Quoting logiktrader
Sorry, hard for me to understand what is going on with limited code and my metatrader demo account isnt working so I cant test fully. So, if it incorrectly displays the next four bars, what about setting the time of the "last indicator" 4 bars into the future. Just a crazy thought, and I have not tried anything like that before so I am not sure if it would work.
What i have posted is the primary function of the indicator. The full indicator has just a lot of filtering and variation around it so basically it work the same as the final indicator just it gives a lot of signals

As for your hint on the solution i'm not sure i understand it
  • #6
  • Nov 30, 2007 2:19pm Nov 30, 2007 2:19pm
I didn't look too deeply, but what I am guessing is that the conditions are often still true for 4 more candles after the first alert.

Why not just simply make it refuse to send more an alert not before X number of candles have formed ?

just add a static integer, increment it one each candle, and reset it to zero after 4 candles.

And you set your alert that it can only be triggers if that static integer is equal to zero.

Something like this (attached) : I've added
" //added"
to the lines I added. I did not really look how your indicator works, but that is the general idea.

HansBrocks
Attached File(s)
File Type: mq4 stochV2.mq4   9 KB | 515 downloads
  • #7
  • Nov 30, 2007 2:22pm Nov 30, 2007 2:22pm
I agree, it is because the situation still is "true" for those candles afterwards. Since this is an indicator and not an EA, the EA would have told you only once, if the trade was open and you limited yourself to one trade. But since this is an indicator, it is going to tell you everytime that it satisfies the criteria.

Make the alert, go to sleep for a few candles afterwards as needed, or somehow make it managed to only activate the first round through, maybe have the indicator look in the past and if the previous bar was an alert, to not alert again. Sorry I dont have more of a code example, just thoughts
  • #8
  • Nov 30, 2007 2:53pm Nov 30, 2007 2:53pm
Melpheos,

is it always exactly 4 times that the alert is repeated? and what are the timestamps in the repeated alerts?

I had a quick look at it last night but didn't appear to repeat itself, I will look at it again today.
  • #9
  • Nov 30, 2007 3:47pm Nov 30, 2007 3:47pm
Quoting Hansbrocks
I didn't look too deeply, but what I am guessing is that the conditions are often still true for 4 more candles after the first alert.

Why not just simply make it refuse to send more an alert not before X number of candles have formed ?

just add a static integer, increment it one each candle, and reset it to zero after 4 candles.

And you set your alert that it can only be triggers if that static integer is equal to zero.

Something like this (attached) : I've added
" //added"
to the lines I added. I did not really look how your indicator works, but that is the general idea.

HansBrocks
I totally agree on the definition of the reason why the alert appears 4 times (the situation is valid for 4 candles)

I will implement your solution this week end and test it on monday. I allready tried this solution but within the alert module but without success

Maybe within the test module it will work. If anyone has any other idea, please do not hesitate

http://www.forexfactory.com/showpost...postcount=1488

Quoting challenger78
Melpheos,

is it always exactly 4 times that the alert is repeated? and what are the timestamps in the repeated alerts?

I had a quick look at it last night but didn't appear to repeat itself, I will look at it again today.
Depending on the TF it was attached to, it was repeating 4 times every 5 minutes for example if attached to a 5M chart or every 15M if attached to a 15M chart.

The timestamp was a few seconds after the end of the candle (number of seconds depending of course of the start of the new candle that is based on a new tick )
  • #10
  • Nov 30, 2007 4:47pm Nov 30, 2007 4:47pm
I had a better look, but I can't do any testing now since markets are closed.

First, you have a small logic error in your code, where you calculate the average, you take 11 periods and then you divide by 10:

for (counter=i ;counter<=i+10;counter++)
AvgRange=AvgRange+MathAbs(High[counter]-Low[counter]);

Range=AvgRange/10;

You need to either do counter < i + 10 or divide by 11 for Range.

Now to the alert error: I noticed that you have your 2 alerts inside a for loop, I don't know exactly what you want to achieve by this, but I believe this is causing the 4 alerts. The loop variable limit is = 3, and since you have

for(i = 0; i <= limit; i++)

the loop executes exactly 4 times.

If your idea is no more than one alert possible in each execution of the script, I suggest moving the alert calls outside the for loop. You can have a bool flag to tell you if there is an alert, like SendAlert = true; whenever your conditions are met, and a string with the message you want for example, AlertMessage = "Stochastic Uptrend Case 1" or the other one.

Then outside the loop, check for SendAlert = true and if it is, call the alert function.

I will modify your script with what I have just said and post here in few minutes. Sadly we can't real test right now cause market is closed.
  • #11
  • Nov 30, 2007 4:55pm Nov 30, 2007 4:55pm
Here is the modified file as promised. I didn't change your average calculation by the way.

Edit: Note that if you get 2 alerts at the same time, the second will over write the first one, but I guess with your strategy this will never happen, just thought to point it out for completeness.
Attached File(s)
File Type: mq4 stochV2.mq4   9 KB | 587 downloads
  • #12
  • Dec 1, 2007 3:57am Dec 1, 2007 3:57am
Thanks Challenger, i will test this on monday and give you a report.

If the problem is solved, i'll send you the indicator

As for the average thing, it's not a big deal as as you can you see it is just to place the alert indicator above/below the price so a small calculation error does not really matter.

edit : same goes the Hansbroks if the solution works
  • #13
  • Dec 1, 2007 9:47am Dec 1, 2007 9:47am
I've glanced at this all of 45 seconds, so I may be FOS, but I think your problem is in your Case1_Shown and Case2_Shown logic. I've used them differently than your intent, but believe this will work as intended. If an up condition occurs, you won't get another arrow until after a down condition has occurred, and vice-versa.

See attached. Can't test today, as you know.
Attached File(s)
File Type: mq4 melphos stochV2.mq4   8 KB | 641 downloads
  • #14
  • Dec 1, 2007 10:06am Dec 1, 2007 10:06am
Quoting blueruby
I've glanced at this all of 45 seconds, so I may be FOS, but I think your problem is in your Case1_Shown and Case2_Shown logic. I've used them differently than your intent, but believe this will work as intended. If an up condition occurs, you won't get another arrow until after a down condition has occurred, and vice-versa.

See attached. Can't test today, as you know.
Thanks Blue, but i dont think this is the issue. Also, the case1shown case2shown etc is not relative to the up trend and downtrend but relative to the other case of downtrend and uptrend

So in fact in the full code i have 1st conditon for uptrend => case1shown, 2nd condition for uptrend, if case1shown=true, do not show signal, 3rd condition for uptrend, if case1shown= true or case2shown=true, do not show signal

Also due to the logic of the test, it is impossible to have a up signal and a down signal on the same candle because the first validation is a V shape or a /\ of the fast stochastic

There is 4 types of uptrend and downtrend but the reason why i have put the case1 shown is just to prevent to have several signal showing on the same candle.
  • #15
  • Edited 2:48pm Dec 2, 2007 12:27pm | Edited 2:48pm
OK finally i have decided to share my indicator with the code attached... I have implemented the different correction provided by the coders here but if it fixes the issue, there is adversary results like not showing all the signal...

I will make another topic for that so it wont get messy.
  • #16
  • Dec 3, 2007 4:48am Dec 3, 2007 4:48am
Quoting melpheos
Thanks Blue, but i dont think this is the issue. Also, the case1shown case2shown etc is not relative to the up trend and downtrend but relative to the other case of downtrend and uptrend

So in fact in the full code i have 1st conditon for uptrend => case1shown, 2nd condition for uptrend, if case1shown=true, do not show signal, 3rd condition for uptrend, if case1shown= true or case2shown=true, do not show signal

Also due to the logic of the test, it is impossible to have a up signal and a down signal on the same candle because the first validation is a V shape or a /\ of the fast stochastic

There is 4 types of uptrend and downtrend but the reason why i have put the case1 shown is just to prevent to have several signal showing on the same candle.
I thought the problem was too many alerts for a single signal?

So if the alert is disabled until a fresh signal occurs, wouldn't that solve the problem? I prefer only one alert per signal, so it must be disabled or you'll get alerts until the conditions are no longer true.
  • #17
  • Dec 3, 2007 5:47am Dec 3, 2007 5:47am
Quoting blueruby
I thought the problem was too many alerts for a single signal?

So if the alert is disabled until a fresh signal occurs, wouldn't that solve the problem? I prefer only one alert per signal, so it must be disabled or you'll get alerts until the conditions are no longer true.
I want one alert per visual signal. So even if i have one signal type 1 on lets say candle 1 and one signal type 1 on candle 5, i want two alerts and not 8 like it is doing right now.

Check http://www.forexfactory.com/showthread.php?t=58776

i have posted the full indicator will all the coding
  • #18
  • Dec 3, 2007 12:58pm Dec 3, 2007 12:58pm
Hi Melpheos,

can you check this picture and the alets? I doesn't seem to repeat every 4 bars, but it does not draw a signal for each alert. This is based on the cut down version of the indicator. Is this correct behaviour or a bug? I would think you need to draw 1 signal for each alert.
Attached Image(s) (click to enlarge)
Click to Enlarge Name: chart.gif Size: 15 KB
Click to Enlarge Name: alerts.JPG Size: 51 KB
  • #19
  • Last Post: Dec 3, 2007 2:04pm Dec 3, 2007 2:04pm
Quoting challenger78
Hi Melpheos,

can you check this picture and the alets? I doesn't seem to repeat every 4 bars, but it does not draw a signal for each alert. This is based on the cut down version of the indicator. Is this correct behaviour or a bug? I would think you need to draw 1 signal for each alert.
Yes, normally there should be a signal for each alert. I would turn the phrase more to there should be an alert for each signal but in your case, it seems it is sending the alert correctly but not showing the alert this time ^^
0 traders viewing now