Trading Made Simple | Page 3951 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Monitor for 'Trading Made Simple' system 565 replies

Trading Made Simple the right way, and other trading lessons 334 replies

Indicators for the 'Trading Made Simple' system 343 replies

MTF Indicators for the 'Trading Made Simple' system 241 replies

Trading Made Simple system follower - Thanks to eelfranz 9 replies

Attachments: Trading Made Simple
Exit Attachments

Trading Made Simple

  • #79,001
  • Edited 11:05am Apr 16, 2017 10:38am | Edited 11:05am
Quoting Kopan
As the Synergy APB indicator is utilized so heavily with the TMS trading philosophy as the replacement for HA candles I have question for those that program. I have found an anomaly with the indicator that has caused me to not trust the results 100%. I am using the indicator with iCustom() to retrieve a buffer value. Somewhat randomly I was getting results that seemed off, so I dug into the Synergy APB code. What I found was when you add < #property strict > the indicator will compile just fine, BUT you will get a run time error "array out of range"....

Hi Kopan,

I noticed this as well when I tried to re-code or tried to change the framework of execution as an indicator. However, if you want to read the indicator buffer from another indicator using iCustom, you need change the framework of execution... just like what you did in order to make it work ---this was only based on what I've understand on your post, if I am not mistaken.

Kindest regards,
v2v
Since Frank Sinatra sings in his own way, my chart sing... I did it, my way
  • #79,002
  • Apr 16, 2017 11:13am Apr 16, 2017 11:13am
hi all it have been some time since i last come to this forum... my tips is simple.. just focus on a few chart.. it will give u consistent.. rather then trade all the chart is the world.. i still running demo tho.. follow big e step..
  • #79,003
  • Apr 16, 2017 11:44am Apr 16, 2017 11:44am
Quoting v2vboni
{quote} Hi Kopan, I noticed this as well when I tried to re-code or tried to change the framework of execution as an indicator. However, if you want to read the indicator buffer from another indicator using iCustom, you need change the framework of execution... just like what you did in order to make it work ---this was only based on what I've understand on your post, if I am not mistaken. Kindest regards, v2v

Agreed. And that is how I resolved the issue for my program.

However an additional point of contention is that the indicator by itself has a flaw. Under certain circumstances, it is trying to access Candle Bar [-1]. Hence the "array out of range" error. That is not good hidden feature, and was not probably originally intended by the author. My concern was that as a result it might be giving incorrect Red or Blue candle signals on random occasion. That was the anomaly that caught my attention in the first place. I was counting number of bars in a trend, and it was not matching the visually colored Red/Blue candles displaying on the screen.

Thanks for the confirmation that I was not seeing things.
  • #79,004
  • Apr 16, 2017 12:14pm Apr 16, 2017 12:14pm
Quoting Kopan
{quote} Agreed. And that is how I resolved the issue for my program. However an additional point of contention is that the indicator by itself has a flaw. Under certain circumstances, it is trying to access Candle Bar [-1]. Hence the "array out of range" error. That is not good hidden feature, and was not probably originally intended by the author. My concern was that as a result it might be giving incorrect Red or Blue candle signals on random occasion. That was the anomaly that caught my attention in the first place. I was counting number of bars...
I think with regards to your other concern, I believe you may need to ask the master coders like mladen, mrtools, hanover, cja, lukeb, abokwaik... etc. Most of these guys are boosting or modifying/update/fix indicators for free.

...me, I am just an amateur coder ; )-
Since Frank Sinatra sings in his own way, my chart sing... I did it, my way
  • #79,005
  • Apr 16, 2017 12:29pm Apr 16, 2017 12:29pm
As mentioned, I have already fixed the issue, I was really more curious if anyone else had come across the issue. For an indicator that has been around for so long and is so widely used for TMS, I was surprised to find the error.
  • #79,006
  • Apr 17, 2017 5:56am Apr 17, 2017 5:56am
Quoting jmn5611
{quote} Amen. Big E was a PA trader who used the TDI to CONFIRM his entries. Newbies, in FX there is no black box system. Learn these things, and they will help you, but most of all you must learn about what kind of trader you want to be, and then position yourself accordingly.



You just hit the Big Round Number....

Attached Image (click to enlarge)
Click to Enlarge Name: TMS BRN 79000.png Size: 59 KB
Honesty is a very expensive gift. You wont find it in cheap people.WBuffett
  • #79,007
  • Apr 17, 2017 9:09am Apr 17, 2017 9:09am
Does anyone else completely avoid trading Sundays and Monday's... I feel like I find very valid setups just to find all my orders be stopped out within 2 candles. Don't think my stops are too tight, usually around 40 pips plus or minus?
  • #79,008
  • Apr 17, 2017 9:23am Apr 17, 2017 9:23am
Quoting Pipb0y
Does anyone else completely avoid trading Sundays and Monday's... I feel like I find very valid setups just to find all my orders be stopped out within 2 candles. Don't think my stops are too tight, usually around 40 pips plus or minus?
Post a chart with those trades
  • #79,009
  • Apr 17, 2017 9:57am Apr 17, 2017 9:57am
This chart shows how much in atr100/3 units can be achieved, when trading about 20 different currencies in the daily time frame in the whole year 2016.

Entry (SESE) like described by Emm (TMS moderate + ha close outside of pac), close like described by Emm (HA change colour).
Stop loss and trailing: 2*atr100. Tested with M1 bars.
Attached Image
  • #79,010
  • Apr 17, 2017 10:01am Apr 17, 2017 10:01am
Signals for today (morning):

2017-04-16 BuySignal AUD_USD
2017-04-16 BuySignal NZD_USD
2017-04-16 SellSignal EUR_AUD
  • #79,011
  • Apr 17, 2017 10:51am Apr 17, 2017 10:51am
Per request - I have attached the modified indicator.

To make the fix I used the default HeikenAshi indicator code that comes with the MT4 platform.

I added 1 line of code to convert the HA algorithm to the APB algorithm.

They are very similar, but I found I slightly prefer the APB end result versus the HA result and was reluctant to give it up.

It now compiles and runs without any errors (with #property strict) and more importantly when called from iCustom() the array output matches the color bar output. :-)

Cheers
Kopan
Attached File(s)
File Type: mq4 HeikenAshi_APB_v2.mq4   8 KB | 521 downloads
  • #79,012
  • Apr 17, 2017 11:18am Apr 17, 2017 11:18am
Quoting Kopan
Per request - I have attached the modified indicator. To make the fix I used the default HeikenAshi indicator code that comes with the MT4 platform. I added 1 line of code to convert the HA algorithm to the APB algorithm. They are very similar, but I found I slightly prefer the APB end result versus the HA result and was reluctant to give it up. It now compiles and runs without any errors (with #property strict) and more importantly when called from iCustom() the array output matches the color bar output. :-) Cheers Kopan {file}
Thank you Kopan. I will use this. I have been doing some automated back testing today of the various entry and exits on here so this will be very useful to compare against what I already have.
  • #79,013
  • Edited 1:12pm Apr 17, 2017 11:25am | Edited 1:12pm
Quoting Kopan
Per request - I have attached the modified indicator. To make the fix I used the default HeikenAshi indicator code that comes with the MT4 platform. I added 1 line of code to convert the HA algorithm to the APB algorithm. They are very similar, but I found I slightly prefer the APB end result versus the HA result and was reluctant to give it up. It now compiles and runs without any errors (with #property strict) and more importantly when called from iCustom() the array output matches the color bar output. :-) Cheers Kopan {file}
Just a comparison with Synergy Heiken Ashi APB Bars and the original Heiken Ashi Bars.

Kopan's modified version of Synergy Heiken Ashi APB removed this part of APB price action rules set by Synergy (see screenshot below). His version doesn't have a Synergy APB PA, but as he said, it uses the APB algorithm. Thus, same body size, but the wick color will follow the color of the body. The only difference between Synergy HA and original HA in terms of drawing HA bars... ---with Synergy, it simply added HA wick&body color representation (for their own HA PA rules) in accordance with their own extra (re)calculation of HA close which is the Average Price Bars ( haClose = (haClose + close) / 2.0 ) which changes the HA body & wick size --this is the added 1 line of code mentioned by Kopan.

I believe Big E was using the same drawn HA bars before, as I noticed on his charts it doesn't have APB PA colors. Maybe it can be confirmed by comparing his charts back in 2011 historical data, or simply use the Synergy APB that he shared here on this thread back in 2011. Another thing is that, there may be two of Synergy APB, the other one is without APB PA colors (earlier version).

Anyway IMO, Kopan's version is perfect for TMS users who don't use the Synergy APB PA... which exactly fits Big E's TMS rules in terms of HA body color change.
Attached Image
Since Frank Sinatra sings in his own way, my chart sing... I did it, my way
  • #79,014
  • Apr 17, 2017 3:49pm Apr 17, 2017 3:49pm
Quoting zMinga
This chart shows how much in atr100/3 units can be achieved, when trading about 20 different currencies in the daily time frame in the whole year 2016. Entry (SESE) like described by Emm (TMS moderate + ha close outside of pac), close like described by Emm (HA change colour). Stop loss and trailing: 2*atr100. Tested with M1 bars. {image}

And the same for 2015. Spread is not recognized. Buy, sell and close is 09:00 at the next day after the Signal.
Attached Image
  • #79,015
  • Apr 17, 2017 5:12pm Apr 17, 2017 5:12pm
Quoting emmanuel7788
{quote} You just hit the Big Round Number.... {image}
Hi buddy, I wanted to ask you how much you win to pip per day?
On average of course
  • #79,016
  • Apr 17, 2017 6:12pm Apr 17, 2017 6:12pm
GBPJPY +50pips.




Happy trading,
Yomi
Attached Image (click to enlarge)
Click to Enlarge Name: GBPJPYH4.png Size: 43 KB
Time always comes before price
  • #79,017
  • Apr 17, 2017 6:30pm Apr 17, 2017 6:30pm
Quoting fxrabbi
GBPJPY +50pips. Happy trading, Yomi {image}

Good trade.
Honesty is a very expensive gift. You wont find it in cheap people.WBuffett
  • #79,018
  • Apr 17, 2017 6:36pm Apr 17, 2017 6:36pm
Quoting emmanuel7788
{quote} Good trade.

Thanks.
Time always comes before price
  • #79,019
  • Apr 17, 2017 6:37pm Apr 17, 2017 6:37pm
Quoting Pixlab
{quote} Hi buddy, I wanted to ask you how much you win to pip per day? On average of course

there are more important trade statistics other than looking at pips count. I prefer to look at the Expectancy not the pips.

better to look at trade statistics over a slightly long term like 3 to 5 years, any period below 2 years is useless to measure the quality of a trading system.
Honesty is a very expensive gift. You wont find it in cheap people.WBuffett
  • #79,020
  • Apr 17, 2017 6:42pm Apr 17, 2017 6:42pm
Quoting zMinga
{quote} And the same for 2015. Spread is not recognized. Buy, sell and close is 09:00 at the next day after the Signal. {image}

For offline backtesting testing purposes, we can use an assumed spread.
I use 0.5% of the ADR 100 days as the spread.
Honesty is a very expensive gift. You wont find it in cheap people.WBuffett
199 traders viewing now