Need Help With P/L EA | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Need help with 10M chart - got it already but need some help! 1 reply

I need help about afl to mql4!!! please help to me 0 replies

need help with a simple MA crossover EA. anyone can help? 7 replies

help, help, help (templates) 5 replies

Help me out? I need the help of you. 20 replies

Attachments: Need Help With P/L EA
Exit Attachments

Need Help With P/L EA

  • #1
  • First Post: Oct 21, 2015 3:21am Oct 21, 2015 3:21am
Hi Folks.

I need help coding a (not-so) simple EA. What I want the EA to do is this: Supposing I got 2 open positions, when price reaches P/L of -500 dollars or US$ +500 dollars, I want the EA to close all positions (without the need to keep watching the screen all the time, this EA would save me time).

Please, would anyone please help me?

Thanks in advance,
MrJinks.
  • #2
  • Edited 4:22pm Oct 21, 2015 2:47pm | Edited 4:22pm
Quoting mrjinks
Hi Folks. I need help coding a (not-so) simple EA. What I want the EA to do is this: Supposing I got 2 open positions, when price reaches P/L of -500 dollars or US$ +500 dollars, I want the EA to close all positions (without the need to keep watching the screen all the time, this EA would save me time). Please, would anyone please help me? Thanks in advance, MrJinks.
mrjinks-
I 'm almost certain this type of EA already exists:
http://www.forexfactory.com/showthread.php?t=309868
http://www.forexfactory.com/search.p...rchid=17413232
  • #3
  • Oct 22, 2015 12:28pm Oct 22, 2015 12:28pm
Hi!

I would like to ask a little help. I have an EA and I tried to put something into the the sourcecode. (I drew a line) but I cannot delete it. The line should be gone when the price hit it. I am not good at the coding so i can't see where is the error. What I see in the tester, that as if would delete the line and then draw it again on and on and on. (flashing). There is another line in the program what is gone when the price hit it. I tried to use the same coding with "my line" but I cannot understand why not delete it.
Attached Image (click to enlarge)
Click to Enlarge Name: why.png Size: 120 KB
  • #4
  • Oct 22, 2015 9:37pm Oct 22, 2015 9:37pm
Your code is being executed every time your subroutine Set_Sl_Move() is run and so the line will be redrawn each time as you don't have a condition check on the drawing process.

Suggest you add this in front of your draw command:

if(!al) Draw_Con_Hor_Line(...........

in this way the line will only be drawn if al == false.
" check out The Traders Outpost "
  • #5
  • Oct 23, 2015 7:48am Oct 23, 2015 7:48am
Quoting RedLineFred
Your code is being executed every time your subroutine Set_Sl_Move() is run and so the line will be redrawn each time as you don't have a condition check on the drawing process. Suggest you add this in front of your draw command: if(!al) Draw_Con_Hor_Line(........... in this way the line will only be drawn if al == false.
Thank You! It's worked. But there is another thing. If my position(s) are closed (by any other reason) the line still there. It should be gone.
  • #6
  • Oct 23, 2015 8:08am Oct 23, 2015 8:08am
Suggest you delete the line every time you call Set_Sl_Move() - just add the ObjectDelete(...) line as the first line in the subroutine. In this way the line is deleted and only redrawn if the conditions are still correct.
" check out The Traders Outpost "
  • #7
  • Oct 23, 2015 8:18am Oct 23, 2015 8:18am
Quoting RedLineFred
Suggest you delete the line every time you call Set_Sl_Move() - just add the ObjectDelete(...) line as the first line in the subroutine. In this way the line is deleted and only redrawn if the conditions are still correct.
Thank You for the help! Works perfectly!
  • #8
  • Dec 9, 2015 7:56pm Dec 9, 2015 7:56pm
if(AccountProfit()>500 || AccountProfit()<-500)
{
bool res=false;
for(int i=OrdersTotal()-1; i>=0; i--)
{
if(OrderSelect(i,SELECT_BY_POS)==true)
{
if(OrderType()==OP_BUY)
{
res=OrderClose(OrderTicket(),OrderLots(),MarketInfo(OrderSymbol(), MODE_BID),10);
}
else
{
if(OrderType()==OP_SELL)
{
res=OrderClose(OrderTicket(),OrderLots(),MarketInfo(OrderSymbol(), MODE_ASK), 10);
}
}
}
if(!res)
Print("Error in OrderClose. Error code=",GetLastError());
else
Print("Order closed successfully.");
}
}
  • #9
  • Last Post: Dec 9, 2015 7:57pm Dec 9, 2015 7:57pm
Inserted Code
if(AccountProfit()>500 || AccountProfit()<-500)
     {
      bool res=false;
      for(int i=OrdersTotal()-1; i>=0; i--)
        {
         if(OrderSelect(i,SELECT_BY_POS)==true)
           {
            if(OrderType()==OP_BUY)
              {
               res=OrderClose(OrderTicket(),OrderLots(),MarketInfo(OrderSymbol(), MODE_BID),10);
              }
            else
              {
               if(OrderType()==OP_SELL)
                 {
                  res=OrderClose(OrderTicket(),OrderLots(),MarketInfo(OrderSymbol(), MODE_ASK), 10);
                 }
              }
           }
         if(!res)
            Print("Error in OrderClose. Error code=",GetLastError());
         else
            Print("Order closed successfully.");
        }
     }
0 traders viewing now