Enclosed new CloseTrades EA to address the issue in the post above. Zip file in Post #443 also amended.
Attached File(s)
- #465
- Edited 11:20pm Feb 9, 2015 4:45pm | Edited 11:20pm
- | Commercial User | Joined Jun 2009 | 1,676 Posts
- #467
- Edited 6:52pm Feb 9, 2015 5:18pm | Edited 6:52pm
- | Commercial User | Joined Jun 2009 | 1,676 Posts
Could somebody do me a favour and look at the code of the CloseTrades EA and propose a fix. This has been a ongoing problem since Friday.
You can see even after the last fix, 2 trades were opened .66 of a second later. TradersGift picks up the dummy buy limit and stops any more trades being placed but I am still stumped as to why the NZD trades were placed.
The fix I am inclined to make is to reintroduce a delay of 5 secs so the line
if(OrderType() == OP_BUYLIMIT) StopTrading = 1;
becomes
if(OrderType() == OP_BUYLIMIT)
{
StopTrading = 1;
Sleep(5000);
}
Having previously added a Sleep command, I'm not so sure that is the fix!
//+----------------------------------------------------------+
//| CloseTrades.mq4 |
//| Copyright
2015, David Currey |
//+----------------------------------------------------------+
extern int StartingEquity = 0;
extern int ProfitTarget = 0;
extern int LossTarget = 0;
extern int StopTrading = 0;
int res;
//+--------------------------------------- ------------------+
//| start function |
//+----------------------------------------------------------+
void start()
{
if (OrdersTotal() == 0) StopTrading = 0;
if (StartingEquity > 0 && StopTrading == 0 &&
(((AccountEquity() - StartingEquity) >= ProfitTarget) ||
(StartingEquity - AccountEquity())>= LossTarget))
{
res=OrderSend(Symbol(),OP_BUYLIMIT,1,0.1,1,0,0,"",99999,0,Green);
for(int i = OrdersTotal()-1; i >= 0; i--)
{
if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
if(OrderType() == OP_BUYLIMIT) StopTrading = 1;
}
}
if (StopTrading == 0) return;
for (i = OrdersTotal()-1; i >= 0; i--)
{
if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
if(OrderType() == OP_BUYSTOP || OrderType() == OP_SELLSTOP) res = OrderDelete(OrderTicket());
if ( OrderType() == OP_BUY) res = OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_BID), 5, Red );
if ( OrderType() == OP_SELL) res = OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_ASK), 5, Red );
}
}
//+----------------------------------------------------------+
You can see even after the last fix, 2 trades were opened .66 of a second later. TradersGift picks up the dummy buy limit and stops any more trades being placed but I am still stumped as to why the NZD trades were placed.
The fix I am inclined to make is to reintroduce a delay of 5 secs so the line
if(OrderType() == OP_BUYLIMIT) StopTrading = 1;
becomes
if(OrderType() == OP_BUYLIMIT)
{
StopTrading = 1;
Sleep(5000);
}
Having previously added a Sleep command, I'm not so sure that is the fix!
//+----------------------------------------------------------+
//| CloseTrades.mq4 |
//| Copyright
2015, David Currey |//+----------------------------------------------------------+
extern int StartingEquity = 0;
extern int ProfitTarget = 0;
extern int LossTarget = 0;
extern int StopTrading = 0;
int res;
//+--------------------------------------- ------------------+
//| start function |
//+----------------------------------------------------------+
void start()
{
if (OrdersTotal() == 0) StopTrading = 0;
if (StartingEquity > 0 && StopTrading == 0 &&
(((AccountEquity() - StartingEquity) >= ProfitTarget) ||
(StartingEquity - AccountEquity())>= LossTarget))
{
res=OrderSend(Symbol(),OP_BUYLIMIT,1,0.1,1,0,0,"",99999,0,Green);
for(int i = OrdersTotal()-1; i >= 0; i--)
{
if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
if(OrderType() == OP_BUYLIMIT) StopTrading = 1;
}
}
if (StopTrading == 0) return;
for (i = OrdersTotal()-1; i >= 0; i--)
{
if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
if(OrderType() == OP_BUYSTOP || OrderType() == OP_SELLSTOP) res = OrderDelete(OrderTicket());
if ( OrderType() == OP_BUY) res = OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_BID), 5, Red );
if ( OrderType() == OP_SELL) res = OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_ASK), 5, Red );
}
}
//+----------------------------------------------------------+
Oh it's a dummy order...Inserted Code
if (StartingEquity > 0 && StopTrading == 0 && (((AccountEquity() - StartingEquity) >= ProfitTarget) || (StartingEquity - AccountEquity())>= LossTarget)) {
res=OrderSend(Symbol(),OP_BUYLIMIT,1,0.1,1,0,0,"",99999,0,Green);
for (int i = OrdersTotal()-1; i >= 0; i--) {
if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
if(OrderType() == OP_BUYLIMIT || OrderType() == OP_SELLLIMIT || OrderType() == OP_BUYSTOP || OrderType() == OP_SELLSTOP) StopTrading = 1;
}
} Inserted Code
(StartingEquity - AccountEquity())>= LossTarget)
OrderSend(Symbol(),OP_BUY,10,Ask,30,SL,TP,"
",0,0,clrGreen);
",0,0,clrGreen);- #469
- Edited 9:58pm Feb 9, 2015 9:43pm | Edited 9:58pm
- | Commercial User | Joined Jun 2009 | 1,676 Posts
Huh? You are sending a pending order with 1 lot on 0.1 price?
The problem is still ongoing even after having inserted the Sleep function, in that some pending trades are still not being deleted.
The relevant code in TradersGift is in the CalculateCurrentOrders subroutine (The EA never opens limit orders itself)
int CalculateCurrOrders(string symbol)
{
Buys=0;
Sells=0;
BuyStops=0;
SellStops=0;
DisableTrading = 0;
//----
for(i=0;i<OrdersTotal();i++)
{
if(OrderType()==OP_BUYLIMIT) DisableTrading=1;
- #471
- Edited Feb 10, 2015 12:35am Feb 9, 2015 11:04pm | Edited Feb 10, 2015 12:35am
- | Commercial User | Joined Jun 2009 | 1,676 Posts
- #473
- Edited 1:25am Feb 10, 2015 12:21am | Edited 1:25am
- | Commercial User | Joined Jun 2009 | 1,676 Posts
- #478
- Feb 11, 2015 12:47am Feb 11, 2015 12:47am
{quote} your feb_05_2015 your set files i am start now login: 1632444 password: kavi123 server :FXOpen-Demo STP 7 pairs x 3 setup account balance: 4378.82 so performance wait and see for all
NO USE TESTING
- #479
- Feb 11, 2015 2:45am Feb 11, 2015 2:45am
{quote} I AM STOP ACCOUNT NO USE TESTING
- #480
- Feb 11, 2015 2:53am Feb 11, 2015 2:53am
{quote} People if you don't know how to use a srewdriver don't blame it. After several days of testing you have done so major conclusion. I really don't believe the stupidity level of some people's . Do a favor to you STOP trading at all.
ANY GOOD SETTING THEN REPLY TO ME
I AM STRAT NEW ACCOUNT AND EA RUN TO MY VPS
GIVE ME BEST
