Basket Trading EA | Page 99 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

BASKET TRADE Management: Using multiple trade management EA's on basket trades 11 replies

Basket Knights - A Basket Trading Round Table 1,313 replies

Trading 8 Forex Pairs - Fully Automatic - Basket Trading 7 replies

TMS basket: Dashboard for a basket of MA-Filtered RSI Signals 135 replies

Currency Basket and Carry Trading 51 replies

Attachments: Basket Trading EA
Exit Attachments

Basket Trading EA

  • #1,961
  • Jan 31, 2014 1:31am Jan 31, 2014 1:31am
Actually - now that I am looking at those screenshots - it appears the bot has placed the HTP on the incorrect side for a sell hence why it would immediately close. It has placed the HTP some 868 pips the wrong side of the open which I guess would be roughly double the 80 pips per pair (total of 400) it is set to so perhaps an incorrect calculation by the bot?

Just checked my C14 open trade and the HTP is drawn on the correct side for a short trade and the reason why that one behaved as expected.
  • #1,962
  • Jan 31, 2014 4:01am Jan 31, 2014 4:01am
If I click Ctrl 7 and then No and again Ctrl 7 and Yes SL line coming up on Screen, BUT it supposed be Blue and moveable 30 seconds, but it pop up already red and it not moveable so what can be problem?
  • #1,963
  • Jan 31, 2014 9:56am Jan 31, 2014 9:56am
Quoting x58
If I click Ctrl 7 and then No and again Ctrl 7 and Yes SL line coming up on Screen, BUT it supposed be Blue and moveable 30 seconds, but it pop up already red and it not moveable so what can be problem?
Do you have "UseBreakEven" set to true ???
  • #1,964
  • Jan 31, 2014 10:08am Jan 31, 2014 10:08am
Quoting Pip Poppy
Actually - now that I am looking at those screenshots - it appears the bot has placed the HTP on the incorrect side for a sell hence why it would immediately close. It has placed the HTP some 868 pips the wrong side of the open which I guess would be roughly double the 80 pips per pair (total of 400) it is set to so perhaps an incorrect calculation by the bot? Just checked my C14 open trade and the HTP is drawn on the correct side for a short trade and the reason why that one behaved as expected.
I am looking into it, but at this time I have no idea why it did that, and 868 pips makes no sense either, even if on the wrong side it should have been 400 pips, where that number came from is a mystery. The calculation doesn't use anything but the 80 pips times the number of pairs.
Also seeing that Entry 0 is red tells me the Robot knew it was a short trade.
Also the calculation isn't even correct for a long trade.
Also when a trade is closed everything starts over from scratch, so it is strange it keeps coming up with the same wrong answer.
Like Einstein said: " "

Short trade calculation:
FixedTP = Close[0]-((Entry0TPpipsEachPair*PairCount)/pipsmulti);

I am going to add some code to watch for the TP being on the wrong side of the trade and correct for it if it happens.

But looking through the code I see no reason for this to happen with all the safe guards already in place.
  • #1,965
  • Jan 31, 2014 1:15pm Jan 31, 2014 1:15pm
Quoting Pip Poppy
@Seller9, Just had a scary thing happen on a live account - robot opened a short trade as expected with an entry 0. The robot then immediately closed the trade using HTP (which is set @ 80 pips per pair so a long way off that). As the conditions were still correct for a trade to trigger it re-opened another short and again closed it immediately using HTP. This occurred 11 times in quick succession before I was able to close the loop only by deleting the offline chart. This was on a 240 min chart using C5 basket. I have onetradepercandle set to false....
You don't need to set "onetradepercandle" to false as this only effects the open of a trade and the close of a trade does not count, so no need to be false unless you want to open multiple trades on the same candle, this would have prevented what happened.
  • #1,966
  • Jan 31, 2014 2:48pm Jan 31, 2014 2:48pm
260 pip trade closed. Would of got around 300-350 if I'd stayed on the computer to set my tp I''ve probably got 1000 pips this week. Good result. Currently -90 pips but I see more downward momentum for jpy;,have to wait next week.
Have a good weekend guys
Lak
  • #1,967
  • Jan 31, 2014 3:07pm Jan 31, 2014 3:07pm
Quoting seller9
{quote} You don't need to set "onetradepercandle" to false as this only effects the open of a trade and the close of a trade does not count, so no need to be false unless you want to open multiple trades on the same candle, this would have prevented what happened.
Ok, I have changed it from false to true and will keep an eye on it.
Thanks for looking into it.
  • #1,968
  • Jan 31, 2014 6:42pm Jan 31, 2014 6:42pm
@Seller9,

I have been going through my previous basket trades and it would appear that the HTP causing the problems was a leftover from a previous long basket where my entry was at 304.748 and I had a 60 pip per pair HTP for a total of 300 pips - a target of 307.748.

That particular basket was opened on 28/01/14 at 08:00 broker time (GMT+2) and closed on 29/1/14.

I did not have another entry until I went short on 29/1/14 16:00 - a trade taken whilst I was in bed and it closed immediately when I hit the OK button for a HTP - I now suspect that this same 'leftover' HTP was responsible for closing that trade also - refer post #1929.

It would appear that the rogue HTP has remained in memory and is not updating when a new trade is taken, presumably because of the alert window issue?

Hope that helps you track it down.
  • #1,969
  • Jan 31, 2014 7:08pm Jan 31, 2014 7:08pm
Hi Seller,

Would you mind clarifying the definition of HAS cross? I reckon several times that when I chose XO2 direction and HAS cross, I suppose it will open long trade when XO2 is green and bar cross up the HAS and closed above it, then it buy next bar. But it didn't and vice versa for short.
  • #1,970
  • Jan 31, 2014 7:27pm Jan 31, 2014 7:27pm
Quoting jasonckb
Hi Seller, Would you mind clarifying the definition of HAS cross? I reckon several times that when I chose XO2 direction and HAS cross, I suppose it will open long trade when XO2 is green and bar cross up the HAS and closed above it, then it buy next bar. But it didn't and vice versa for short.
The HAS X refers to the crossing of the HAS colour itself from green to red or whatever colours you use. It does not refer to the price crossing the HAS indicator if that is what you mean.
  • #1,971
  • Jan 31, 2014 7:55pm Jan 31, 2014 7:55pm
Quoting Pip Poppy
@Seller9, I have been going through my previous basket trades and it would appear that the HTP causing the problems was a leftover from a previous long basket where my entry was at 304.748 and I had a 60 pip per pair HTP for a total of 300 pips - a target of 307.748. That particular basket was opened on 28/01/14 at 08:00 broker time (GMT+2) and closed on 29/1/14. I did not have another entry until I went short on 29/1/14 16:00 - a trade taken whilst I was in bed and it closed immediately when I hit the OK button for a HTP - I now suspect that this...
My thoughts also as I was doing some more thinking about it.

I have added some code to make sure the present chart price value gets updated in the EA before any new calculations are made, the old price could be what the calculations were based on because it was not being updated prior to the new TP calculations were done, this is something that is needed with offline charts.

I normally put the code in to do this but I missed it in that part, so it could have caused the calculation to be done on old prices.

I have also added more safety precautions to also watch out for this.

Thanks for the info.

I am waiting to see what happens with the release of the next version of MT4 before I release version 14, if it goes past Monday I will release it anyway.

It will probably be OK, but the basket create indy probably won't work until it gets updated with the new MT4.

Good Luck
  • #1,972
  • Jan 31, 2014 8:05pm Jan 31, 2014 8:05pm
Quoting seller9
{quote} My thoughts also as I was doing some more thinking about it. I have added some code to make sure the present chart price value gets updated in the EA before any new calculations are made, the old price could be what the calculations were based on because it was not being updated prior to the new TP calculations were done, this is something that is needed with offline charts. I normally put the code in to do this but I missed it in that part, so it could have caused the calculation to be done on old prices. I have also added more safety precautions...
Excellent - thank you Seller9.
I use a number of different brokers - one of them is Global Prime who have disabled auto update and will NOT release the new MT4 to their customer base until such time as they themselves can see that the move will be successful. Have not been notified by my other brokers as to what their intentions are. As you said - I think the major drama for us as basket traders will be the offline chart issue and how that is created.
  • #1,973
  • Jan 31, 2014 8:06pm Jan 31, 2014 8:06pm
Attached Image (click to enlarge)
Click to Enlarge Name: HAS_Cross.jpg Size: 215 KB
  • #1,974
  • Jan 31, 2014 8:44pm Jan 31, 2014 8:44pm
Hey guys,

Just testing this out over the weekend and the BT_CS_v8 isn't creating a correlation basket text file for the correlated buys or sells.

Can this be because the market is closed atm?

just wanted to check if I'm missing something. I watched the video and i get the idea that the EA should create the txt files by itself

Sorry for the (hopefully not) silly question!
Enter Signature
  • #1,975
  • Feb 1, 2014 3:23am Feb 1, 2014 3:23am
Quoting seller9
{quote} Do you have "UseBreakEven" set to true ???

Yes it is by Default, HELP!
  • #1,976
  • Feb 1, 2014 3:47am Feb 1, 2014 3:47am
Quoting seller9
{image}
Thanks clarification from Seller and Pip Poppy.
  • #1,977
  • Feb 1, 2014 10:15am Feb 1, 2014 10:15am
From what I am reading about the upgrade for MT4 due out Monday it doesn't look too good.

Backup your entire MT4 folder to a safe place.
  • #1,978
  • Feb 2, 2014 6:59pm Feb 2, 2014 6:59pm
I install Forex.com Demo account, but have a problems. Anybody?? Version 509.
Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot from 2014-02-03 02:43:41.png Size: 24 KB
  • #1,979
  • Feb 2, 2014 9:48pm Feb 2, 2014 9:48pm
Quoting seller9
From what I am reading about the upgrade for MT4 due out Monday it doesn't look too good. Backup your entire MT4 folder to a safe place.
I zipped all my MT4s... is that enough? if not please let us know what you mean.

also how bad is it going to be?
  • #1,980
  • Feb 3, 2014 2:46am Feb 3, 2014 2:46am
Seems like V13 got some real problems. I tried to open a short basket on a gbp5 basket, and although TP and SL are set correctly, it is closed instantly with
"Trade closed by HSL" and "Trade close by HTP". Seems like those settings don't work properly. TP and SL were set for MasterTakeProfit and MasterStopLoss and for every entry as well. TP and SL are also placed in opposite direction, that seems to be the problem. I opened a second sell trade for that basket, and before hitting ok on the popup i changed tp and sl, and the trade stayed open.
19 traders viewing now