T101 Basket Trader with ONE of Nanningbob's Balls

Quoting magft

Disliked

For reference there is a #define CLOSE_ORDER 9 at the top so this is not the cause of the problem. I have had a scan through the code and nothing is obviously standing out as wrong. I haven't had time to run yet, i'll try and have a look later on.

Not sure but i noticed in the indicator they use "current timeframe" and you have used "0" in your icustom calls but this doesn't look like it should cause issues. Also i have seen strange things happen if you don't pass all parameters to an indicator from icustom. So may be worth using a custom...

Ignored

Quoting jmw1970

Disliked

Hi All

well my internet is sort of working now, (apparently can take up to 10 days for the line speed to get stable)

I see there is a few TLE's being created, although most appear to have some sort of problem

Let me know if there is anything I can do to help

Regards, John

Ignored

Quoting Traderduke

Disliked

ep
this one gets in but doesn't close when it should.

Ignored

int Check_For_Close()
  {
//--
   Print("Check_For_Close");
   if (BasketType != 1 && BasketType != 2) return(0);
   Print("!TLE-Basket Type-start=====  ",BasketType);
   
   // Decide if the routine is to be run every tick
   // if so, comment out the next if statement
   if (Time[0] == LastBar) return(0);  // Once per bar 
   
   LastBar = Time[0];

   //if (Time[0] == LastAlert) return(0);  //?

   // Reset the communication buffers
   CB_Action[0] = DFT_RETURN; //-1


// the rest of the code in this routine is the user defined code for the TLE

   // Get trend hama
   double trend  = iCustom(NULL,TimeFrame,Indy1,"0",MaMetod,MaPeriod,Step,6,0);
   double trend1 = iCustom(NULL,TimeFrame,Indy1,"0",MaMetod,MaPeriod,Step,6,1);
    Print("trend========  ",trend,"--trend1=======  ",trend1);      
     // If the basket is a buy and we previous closed above the upper
   
   if (OrderType()==OP_BUY && trend < 0 && trend1 < 0 )
      Print("Basket Type-buy---=================================================-",BasketType);
      {
      Alert("Possible close of long at ",DoubleToStr(Close[0], Digits),TimeToStr(Time[0],TIME_DATE|TIME_MINUTES));
      LastAlert = Time[0];
      CB_Action[0] = 9;
      Print("CB_action-Buy-CLOSEORDER---------  ",CB_Action);
      }
      
   // If the basket is a sell and we previous closed below the lower
   
   if (OrderType()==OP_SELL && trend > 0 && trend1 > 0 )
      //Print("Basket Type-sell-------------------------------------------------",BasketType);
      {
      Alert("Possible close of short at ",DoubleToStr(Close[0], Digits),TimeToStr(Time[0],TIME_DATE|TIME_MINUTES));
      LastAlert = Time[0];
      CB_Action[0] = 9;
      Print("CB_action-Sell-CLOSEORDER---------  ",CB_Action);
      }
      
   // We don't want to send any actions UNLESS the market read is range
   if (MarketRead != MR_RANGE)
      CB_Action[0] = DFT_RETURN;
      
//----
   return(0);
  }
//+------------------------------------------------------------------+

int Check_For_Close()
  {
//--
   Print(Check_For_Close());
   //if (BasketType != OPEN_BUY && BasketType != OPEN_SELL) return(0);

   // Decide if the routine is to be run every tick
   // if so, comment out the next if statement
   if (Time[0] == LastBar) return(0);  // Once per bar 
   
   LastBar = Time[0];

//   if (Time[0] == LastAlert) return(0);  

   // Reset the communication buffers
   CB_Action[0] = DFT_RETURN;


// the rest of the code in this routine is the user defined code for the TLE

   // Get trend hama
   double trend  = iCustom(NULL,TimeFrame,Indy1,"0",MaMetod,MaPeriod,Step,6,0);
   double trend1 = iCustom(NULL,TimeFrame,Indy1,"0",MaMetod,MaPeriod,Step,6,1);
          
   // Get the bands
 //  double ld_Upper = iBands(NULL,0,BBand,Dev,0,PRICE_CLOSE,MODE_UPPER,Shift);
 // double ld_Lower = iBands(NULL,0,BBand,Dev,0,PRICE_CLOSE,MODE_LOWER,Shift);

   // If the basket is a buy and we previous closed above the upper
   if ([color="Red"][b]BasketType == OP_BUY[/b][/color] && trend < 0 && trend1 < 0 )
      {
      Alert("Possible close of long at ",TimeToStr(Time[0],TIME_DATE|TIME_MINUTES));
      LastAlert = Time[0];
      CB_Action[0] = CLOSE_ORDER;
      }
      
   // If the basket is a sell and we previous closed below the lower
   if ([color="red"][b]BasketType == OP_SELL[/b][/color] && trend > 0 && trend1 > 0 )
      {
      Alert("Possible close of short at ",TimeToStr(Time[0],TIME_DATE|TIME_MINUTES));
      LastAlert = Time[0];
      CB_Action[0] = CLOSE_ORDER;
      }
      
   // We don't want to send any actions UNLESS the market read is range
   [color="red"][b][b][b]//[/b][/b][/b][/color]if (MarketRead != MR_RANGE)
      [color="Red"][b]//[/b][/color]CB_Action[0] = DFT_RETURN;
      
//----
   return(0);
  }
//+------------------------------------------------------------------+

Quoting magft

Disliked

I think i might have found the problem with the closure.

[code]int Check_For_Close()
{
//--
Print("Check_For_Close");
if (BasketType != 1 && BasketType != 2) return(0);
Print("!TLE-Basket Type-start===== ",BasketType);

// Decide if the routine is to be run every tick
// if so, comment out the next if statement
if (Time[0] == LastBar) return(0); // Once per bar

LastBar = Time[0];

//if (Time[0] == LastAlert) return(0); //?

// Reset the communication buffers
CB_Action[0] = DFT_RETURN; //-1


// the...

Ignored

Quoting Chroniclez

Disliked

John,

Is it possible to incorporate a stop loss feature similar to the pending orders, into the EA?

It would be nice if I can adjust the stop loss line based on visual chart.

I think it would be way better than having a dollar value SL.

Thanks.

Ignored

Quoting Chroniclez

Disliked

John,

Is it possible to incorporate a stop loss feature similar to the pending orders, into the EA?

It would be nice if I can adjust the stop loss line based on visual chart.

I think it would be way better than having a dollar value SL.

Thanks.

Ignored

Quoting Traderduke

Disliked

magft
I think I had these Baskets and ordertype in together then out separatly but here goes. I'll retest and let you know. The problem with the no Clouser is the -1 from the Dft_RETURN, just not sure that line causes it.

Thanks for the input. We'll get sooner or later.


PS: well that didn't take long. See attach , I'm back to ground 0, the EA keeps buying and selling 6 or 7 times during the 1m chart

Ignored

Quoting Traderduke

Disliked

magft
I think I had these Baskets and ordertype in together then out separatly but here goes. I'll retest and let you know. The problem with the no Clouser is the -1 from the Dft_RETURN, just not sure that line causes it.

Thanks for the input. We'll get sooner or later.


PS: well that didn't take long. See attach , I'm back to ground 0, the EA keeps buying and selling 6 or 7 times during the 1m chart

Ignored

Quoting jmw1970

Disliked

Hi Chroniclez

please read the documentation

it is clearly stated that there is a visual Stop Loss / Take Profit & Hedge line, you just need to set the appropriate parameter to allow it to display

Regards, John

Ignored

int Check_For_Close()
  {
//--
   //Print("Check_For_Close");
   if (BasketType != OPEN_BUY && BasketType != OPEN_SELL) return(0);
   //Print("!TLE-Basket Type-start=====  ",BasketType);
   
   // Decide if the routine is to be run every tick
   // if so, comment out the next if statement
   if (Time[0] == LastBar) return(0);  // Once per bar 
   
   LastBar = Time[0];
   if (Time[0] == LastAlert) return(0);
   // Reset the communication buffers
   CB_Action[0] = DFT_RETURN; //-1

// the rest of the code in this routine is the user defined code for the TLE
   // Get trend hama
   ReadIndicators();
    
   // If the basket is a buy and we previous closed above the upper
   
   if (BasketType==OPEN_BUY && trend < 0 && trend1 < 0 && trend2 > 0 && HA_Body > MinHABodySize)
      if (ShowComments) Print("Basket Type-buy---=================================================-",BasketType);
      {
      if (ShowAlerts) Alert("Possible close of long at ",DoubleToStr(Close[0], Digits),TimeToStr(Time[0],TIME_DATE|TIME_MINUTES));
      LastAlert = Time[0];
      CB_Action[0] = CLOSE_ORDER;
      if (ShowComments) Print("CB_action-Buy-CLOSEORDER---------  ",CB_Action);
      }
      
   // If the basket is a sell and we previous closed below the lower
   
   if (BasketType==OPEN_SELL && trend > 0 && trend1 > 0 && trend2 < 0 && HA_Body > MinHABodySize)
      if (ShowComments) Print("Basket Type-sell-------------------------------------------------",BasketType);
      {
      if (ShowAlerts) Alert("Possible close of short at ",DoubleToStr(Close[0], Digits),TimeToStr(Time[0],TIME_DATE|TIME_MINUTES));
      LastAlert = Time[0];
      CB_Action[0] = CLOSE_ORDER;
      if (ShowComments) Print("CB_action-Sell-CLOSEORDER---------  ",CB_Action);
      }
      
   // We don't want to send any actions UNLESS the market read is range
   //if (MarketRead != MR_RANGE)
      //CB_Action[0] = DFT_RETURN;
      
//----
   return(0);
  }

Quoting magft

Disliked

Try this one, i have added a check for minimum HA body size to avoid small signals and also can turn alerts and comments off/on. These are defined at the top of the indicator.

Just watched it close a basket and then open another straight away.

Mike

Ignored

if((OrderType())== OP_BUY)  BasketType = OPEN_BUY ; //1
 
 
   Print("!TLE-Basket Type-start=====  ",OrderType());
 
   if((OrderType())== OP_SELL) BasketType = OPEN_SELL ; //2
   Print("!TLE-Basket Type-start=====  ",OrderType());
 
   if (BasketType != OPEN_BUY && BasketType != OPEN_SELL) return(0);
   Print("!TLE-Basket Type-start=====  ",BasketType,"    ",OrderType());

Quoting Traderduke

Disliked

John


Question, has anybody got a !TLE & Basket Trader that works together automaticly, ....

Ignored

Quoting EaglePip

Disliked

It is beginning to look like a problem between TLEs and the EA. I thought that TLE by Magft had worked, but went back over recent posts and it appears it has opened baskets but they seem to have been closed manually. That has also been my experience.
Now trying to prove the logic, using your method of putting the indicators in the EA.

Ignored

Quoting Traderduke

Disliked

EaglePip
I have 2 EAs with the indicator built in, HAMA & PrCh. They both seem to work flawslessly. .... The Current min profit seems to be helping a lot on the big turns.

Ignored

Quoting Traderduke

Disliked

EaglePip
I have 2 EAs with the indicator built in, HAMA & PrCh. They both seem to work flawslessly. I'm running four test on the HAMA for two days, buying and selling automaticly. Trying to find the best setting on the best TF chart. The range mkt eats you alive. Right now the HAMA 2, 14, 1 on a 1m chart seems to be doing well. I'll attach both EAs lets all test them and get back with the best settings. The Current min profit seems to be helping a lot on the big turns.

Ignored

Quoting dragosd1

Disliked

Question, those two EA's are working with T101 indi or with the Basket indi?

Ignored

Quoting EaglePip

Disliked

Look at top LH corner of Traderduke charts. It is the Basket indicator.
EP

Ignored