Expert Advisor based on E/U H1

Can someone help me with a simple EA?

I traded manually this method, maybe someone done it but so far so good.

An EA will be less time consuming, because this method is traded on H1. Only on EUR/USD.

Here are the basics:

1. TF is H1
2. If there are 3 consecutive bars going down, then issue a buy signal.
3. An option that will allow to set how much a bar is going down, because might be 3 consecutive bars going down only 15 pips each. So we should set this to atleast 40-50 pips (difference between High-Low of each bar) .
4. TP = 100, SL = 50 (these have to be tuned). We need to catch big moves.
5. The EA should work on ECN.

Also, I will appreciate any help given.

I will try to tune the settings by backtesting it and demo trading atleast 1 month. I will post each settings for each pair.

Here is what I have done so far. Why the Alerts don't trigger? Moved to lower TF to check when a new bar is formed.

Any further help?

I assume that you are getting nothing showing??

Try adding...


#property indicator_chart_window

after the #property link line

Added that line, but no luck. Everything is showing, even when a new bar is formed. But when there all 3 bars are up or down, the alert is not triggered.

The bool bNewBar () function is wrong!

Not sure what but is definitely the problem

(Too late in day for me to look further ... static int and all that)

Okay. Thanks for your help. Will try to modify it.

following is good code for a new bar

bool New_Bar()
{
bool pb_New.Bar;

static datetime ldt_Last.Bar;

if (Time[0] != ldt_Last.Bar) pb_New.Bar = true;

ldt_Last.Bar = Time[0];

return(pb_New.Bar);
}

the problem in your new bar routine was you was initialising the compare value each time

Thanks jmw.

Here you go... code amended so should work now

HTH

Okay. Thanks.

It returns 1 in "nNew Bar: "+New_Bar() but the if condition is not triggered. I don't know why....

Could not get the newbar function to work properly (don't know why).

Have updated the code with a workaround for now (but alert may go off 3or 4 times at start of bar)

Should get you going for now at least.

Fixed newbar check.

Looks good; simple answers are always the best. Thanks

Will look into it. Thanks for all your help

I did not bother to check if the newbar function actually worked. There was a simpler solution.

However, the proposed newbar function will only work once per new bar, as it updates the static variable that is used for saving the time reference.

It was called once in the comment() function, and then again in the alert loop. The call in the alert loop returned a false value as the time reference var had been updated to the current time in the previous call to the function.

Excellent spot Xaphod ... something that my limited abilities would not have spotted in a great hurry.

That now explains why I could not fathom it out .... hope that I remember that for the next time :-))

Thanks

Instead of reinventing the wheel over and over again, y'all should consider using 7bit's collection of useful functions here (common_functions.mqh).

Among the many useful functions you'll find the function isOldBar() which does what you want.

I don't code any of these little nuisances by hand any more; I just common_functions.mqh now.

Yet another great tip from this forum. Thankyou.

I take it that you are an experienced programmer .... makes total sense and is the only sensible thing to do.

Would you believe that I have that file somewhere! but always forget to use it ... guess that I will get there one day, wherever there is.

Programming is my day job (in contrast with certain piano teachers who frequent this site ).

If you find yourself hand-coding the same code patterns over and over, write a function to do it. Use the new function from then on. You can write new EAs (or other programs) faster and they're more reliable if you do it this way. And if someone writes useful functions that are well-documented and tested, you use those too.

You are right!