Umm . . . . are you sure you want to ask that question?
I have worked this out myself...
Thanks
Brijon Concept of Threes auto trading robot by Steve Hopwood
- #882
- Mar 22, 2011 3:11pm Mar 22, 2011 3:11pm
- Joined Oct 2008 | Status: Sailing for pips | 2,099 Posts
- #885
- Mar 22, 2011 3:32pm Mar 22, 2011 3:32pm
- Joined Oct 2008 | Status: Sailing for pips | 2,099 Posts
- #887
- Mar 22, 2011 4:38pm Mar 22, 2011 4:38pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
The bot defaults to two CHFJPY on the buy side. One should be USDJPY for the original mix I believe.
- #888
- Mar 22, 2011 4:39pm Mar 22, 2011 4:39pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
damn steve I don't even know if it works yet
thanks
- #890
- Mar 22, 2011 10:48pm Mar 22, 2011 10:48pm
- Joined Oct 2008 | Status: Sailing for pips | 2,099 Posts
- #891
- Mar 23, 2011 12:28am Mar 23, 2011 12:28am
It only took a few minutes, and you can play to your heart's content now.
Thanks very much for the latest EA.
I have noticed that CloseAllTrades doesn't check the MagicNumber and it would close all orders on the account. Would it be good idea to add one of the following?
OPTION A
if (!OrderSelect(cc, SELECT_BY_POS)) continue;
if (OrderMagicNumber() != MagicNumber) continue;
while(IsTradeContextBusy()) Sleep(100);
bool result = OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 5000, CLR_NONE);
if (!result) success = false;
Sleep(100);
OPTION B
if (!OrderSelect(cc, SELECT_BY_POS)) continue;
if (OrderMagicNumber()==MagicNumber)
{
while(IsTradeContextBusy()) Sleep(100);
bool result = OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 5000, CLR_NONE);
if (!result) success = false;
Sleep(100);
}
Regards,
Zeljko
- #893
- Edited 5:47am Mar 23, 2011 5:35am | Edited 5:47am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
The attached adopts Zeljko's suggestion. Thanks Zeljko.
A couple of logic flaws meant the original version would have gone on strike after closing a successful basket.
A couple of logic flaws meant the original version would have gone on strike after closing a successful basket.
- #894
- Mar 23, 2011 7:10am Mar 23, 2011 7:10am
- Joined Oct 2008 | Status: Sailing for pips | 2,099 Posts
The attached adopts Zeljko's suggestion. Thanks Zeljko.
A couple of logic flaws meant the original version would have gone on strike after closing a successful basket.
can finally give it a go Been out on Holiday and now back to the grind of work and FX
I have been manually running the 3 buy 3 sell pairs with pretty good success on demo still looking to see the max DD but have been in the 60.00 range with .1 lot but still early to tell.
Keep all posted
thanks again
- #895
- Mar 23, 2011 7:14am Mar 23, 2011 7:14am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Thanks Steve
can finally give it a go Been out on Holiday and now back to the grind of work and FX
I have been manually running the 3 buy 3 sell pairs with pretty good success on demo still looking to see the max DD but have been in the 60.00 range with .1 lot but still early to tell.
Keep all posted
thanks again
Once the hedged pairs have reached some extremes, it doesn't take much of a favourable movement by the losing one to get the upl climbing rapidly.
As you say though, early days. We shall see.
- #896
- Mar 23, 2011 10:54am Mar 23, 2011 10:54am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Ok guys. I had a long bath this morning.
The significance of this otherwise unremarkable, if odd, statement will not be lost on those of you who were with me back in the KG days.
During long baths, I mull over thingys. The thingy I was mulling this morning was this: it is not long before the hedged basket polarises with the winning trade in the hedge going profitable and its 'partner' lagging at the bottom of the profit table.
So, I wondered what would happen if we took a second of the profitable trades at x pips profit, so I coded this.
The new input is PipsToSecondTrade. To leave things as they are, i.e. no second trade, just leave this set to zero. The default is 20.
On my coding machine, I have the bot taking all 14 trades. By the time I finished the code, a basket had a couple of trades at just over +20; the new trades rushed the basket to my profit target within minutes.
This might have been coincidence; all we can do is try it and see.
Have fun.
Incidentally coders, I have tidied the code into arrays so it is easier to loop around the trade pairs.
The significance of this otherwise unremarkable, if odd, statement will not be lost on those of you who were with me back in the KG days.
During long baths, I mull over thingys. The thingy I was mulling this morning was this: it is not long before the hedged basket polarises with the winning trade in the hedge going profitable and its 'partner' lagging at the bottom of the profit table.
So, I wondered what would happen if we took a second of the profitable trades at x pips profit, so I coded this.
The new input is PipsToSecondTrade. To leave things as they are, i.e. no second trade, just leave this set to zero. The default is 20.
On my coding machine, I have the bot taking all 14 trades. By the time I finished the code, a basket had a couple of trades at just over +20; the new trades rushed the basket to my profit target within minutes.
This might have been coincidence; all we can do is try it and see.
Have fun.
Incidentally coders, I have tidied the code into arrays so it is easier to loop around the trade pairs.
- #899
- Mar 23, 2011 2:58pm Mar 23, 2011 2:58pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
I just realised there is a problem with the PipsToSecondTrade thingy.
With a multi-pair trader, this needs adjusting to x digit crims for every pair, so you will see some strange results.
I will sort this out later.
With a multi-pair trader, this needs adjusting to x digit crims for every pair, so you will see some strange results.
I will sort this out later.
- #900
- Mar 23, 2011 4:37pm Mar 23, 2011 4:37pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
I think the attached solves the problem of the need to adapt x digit crims to x digit pairs.