Nanningbob V5: Steve Hopwood's auto-trading robot

many many thanks
romano

Thanks for that Max. Corrected version attached. It seems that no matter how many times the code is read, something gets missed.
Steve, can you upload this to post 1.

MetaTrader adds more space at the top of the chart than the bottom. These are the values that I measured.

Thank you for your latest version. Much appreciated.

Cheers, Beastie.

'tis done. Cheers.

Very clever Beastie, interesting find.. Thank much

As I have posted before, I have detected several major bugs in ver 71c, and as I suspected they are still there in ver 78.
1.In RecoveryModule4H there is a “Copy and paste” error that result in unpredictable recovery:
Here is the existing code with comments about the correction:

CountOpenTrades4H(); //The count value returned in OpenTrades4H
if (OpenTrades4H == 0) RecoveryInProgress4H = false; // This is a correct check on OpenTrades4H

//If 1 trade open, then recovery is at the it's 1rst stage
if (OpenTrades == 1) // Wrong check! Should be OpenTrades4H
{ if (RecoveryRentry1Mult==0) Recovery4HStopTrading = true;
else { SendLots = Lot * RecoveryRentry1Mult; }
}
if (OpenTrades == 2) /) // Wrong check! Should be OpenTrades4H
{ if (RecoveryRentry2Mult==0) Recovery4HStopTrading = true;
else { SendLots = Lot * RecoveryRentry2Mult; }
}
if (OpenTrades == 3) ) // Wrong check! Should be OpenTrades4H
{ if (RecoveryRentry3Mult==0) Recovery4HStopTrading = true;
else { SendLots = Lot * RecoveryRentry3Mult; }
}
if (OpenTrades == 4) ) // Wrong check! Should be OpenTrades4H
{ Recovery4HStopTrading = true;}


2.In Trendline4HStartFunction module you can see the following sequence:
//---- Recovery
if (OpenTrades4H > 1) RecoveryInProgress4H = true;
if (RecoveryInProgress4H && !TpMoved4H)
{ CheckRecoveryTakeProfit(magic4H);
if (buy_price4H > 0) ModifyTakeProfit4H(buy_price4H);
if (sell_price4H > 0) ModifyTakeProfit4H(sell_price4H);
}//if (RecoveryInProgress4H)

The call to CheckRecoveryTakeProfit returns new takeprofit price in buy_price or sell_price But the check is on buy_price4H and sell_price4H – result is totally unpredictable.

3.Also in the above sequence just before the call to CheckRecoveryTakeProfit missing statements to zero both buy_price and sell_price otherwise – unpredictable results!
Another way is to place the zero statements in CheckRecoveryTakeProfit instead.

There are more to come… It takes some time to compare my corrections for 71c and the new version posted today.

Wonderfull Arbinka !!!
The 3 bugs corrected
Cheers
Max

Because I have a beautifull increase of equity this afternoon, (look green line) I choose to close all manually
Start 50 k 2 weeks ago. Play 0.5 lot

I love Max's work. This is way I'm so keen about cleaning it up!
I will post some more corrections when I get the time to go through some more code in the new version.
Here are the status for my forward testing of the corrected 71c. I started yesterday at the beginning of the market:

Wow thanks max

arbinka,
have you posted your 71c fixed version?
I have 76 installed on all pairs but the popup errors are constant.

I did not, but I am posting some bug fix to the latest version. I prefer doing it this way and let Max manage the real Max's EA. as you can see Max has already released new version that includes my corrections.

But there are more to come, unfortunately i haven't get much time today but i will do my best.

ok thanks, just wanted to make sure i wasn't missing it somewhere
Appreciate your help with the the bug fixing!
Just traded up to the latest version, will see if that is a little easier on the errors

Max, I think there is a problem with trades opening with incorrect lots. I had one NB Sell trade open at 1 lot, and then a KG_OS Buy trade opened at 2 lots.

I am running a 2.4.2 recovery system. Is the SendLots variable getting overwritten unnecessarily? Is there a need for a SendLots4H variable?

Cheers, Beastie.

Hi Max - does your version also have MPTM built in?

You are right! I think that this mode should either run mutually-exclusive with NB trades or have its own set of functions just like KG trades and only then it can trade in parallel with NB and KG.

Max has created a monster! I ran through the code initially thinking that the wrong magic number may be being used somewhere, but I think it is just a case of the 2 modes clashing. I think you may be right about the trades being mutually exclusive. I'm not over keen on having both Long and Short trades open together.

Cheers, Beastie.

MAX and arbinka - many thanks for your work and for posting results - WHAT TIME FRAME are those results from and are u finding to be most optimal? Still 1H?

Odysseus

I'm trading 1H as it seems to be most profitable on my backtest.

the great news is since i've updated it to the last posted v81, not a single error as of yet. What a relief nice job max/arbinka

Im not sure this has been mentioned, though I saw the same thing in Steve's bot awhile back

with ver 81, AUDXXX pairs all have the same message, I will sell @ xxxx, just looking now, so do the USDXXX pairs, it would appear that once one pair decides on an entry point, all the same currency charts take the same message.

Thanks for all your collective work.