Simone Guy's 'Simple and Consistent Fibonacci Method' | Page 14 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

SIMPLE EA for a simple method needed!! 2 replies

Simple, Non-subjective, Consistent, Effective 645 replies

What is the Differences between Fibonacci Fan and Fibonacci Arcs 15 replies

bo7a method... method for GBP/JPY 205 replies

Simple & Consistent Fibbing Method 1,913 replies

Attachments: Simone Guy's 'Simple and Consistent Fibonacci Method'
Exit Attachments

Simone Guy's 'Simple and Consistent Fibonacci Method'

  • #261
  • Jun 18, 2010 10:43am Jun 18, 2010 10:43am
Thanks Steve and coders/all. This is sure to be a winner.
I love the new graphics.
Please consider a MM% module at some point. Glenn
  • #262
  • Jun 18, 2010 11:35am Jun 18, 2010 11:35am
If you are still having problems, can you please
- re-download everything from msg#1
- extract it into the correct directories
- go into the experts\include folder, right-click on simone stuff.mqh and view Properties
- take a screenshot of it attach it to your msg. Please make sure the screenshot shows the file listing in the background too, as shown in my attached screenshot.

Please note that in my screenshot I am showing both the experts and the include folders.
I am showing the detailed content of the folders, incl file size and date/time
I am also showing the properties of each of the simone files in the popup dialog.

If none of this works out, please use the binary (ex4) file, also in msg1.

Do not pay any attention to the dates and filesizes of my files!


Cheers,
Nick


Quoting argon
still receive error messages, even with new Nick's modified EA Simone, always putt in include folder nicks 20% etc....

'simone stuff.mqh' - cannot open the program file...
Attached Image (click to enlarge)
Click to Enlarge Name: Image 1.png Size: 215 KB
  • #263
  • Jun 18, 2010 1:51pm Jun 18, 2010 1:51pm
Hello,

I investigated further in my ordersend and modify errors with Simone.

I was right with the order modify error 130.
The SL is only 2 pips from the TP. At least with my broker this won't work.

Any ideas.

I modified the code to show me all order details.

See the fiel attached.

Thanks,
Thilo
Attached Image (click to enlarge)
Click to Enlarge Name: ordermodify_error.JPG Size: 236 KB
  • #264
  • Jun 18, 2010 2:04pm Jun 18, 2010 2:04pm
Hello,

I found the problem for getting an error code 4107.

In my case Simone tries to send a 5 digit oderprice which is not fixed.

Forcing a NormalizeDouble makes it work fine

See the code below:
{
OrderSelect(TicketNo, SELECT_BY_TICKET);
PD = OrderOpenPrice() - Bid;
if (PD < (MinPipsBetweenTrades * Point) ) TradeAllowed = false;
}//if (TicketNo > 0)

if (TradeShort && !AlertNotTrade && TradeAllowed) TradeSuccess = SendSingleTrade(OP_SELL, TradeComment, Lot, NormalizeDouble(Bid,4), StopLoss, TakeProfit);
if (AlertNotTrade)
{
Alert(Symbol(), " Short trade setup");
ObjectCreate("DownArrow", OBJ_ARROW, Time[0], Ask, Time[0], Ask);
ObjectSet("DownArrow", OBJPROP_COLOR, Red);



The same is true on the OP_BUY side.

Even I see that the code checks the digits but I assume the check kicks in a few lines to late.

Thanks,
Thilo
  • #265
  • Jun 18, 2010 5:19pm Jun 18, 2010 5:19pm
Quoting thilool
Hello,

I found the problem for getting an error code 4107.

In my case Simone tries to send a 5 digit oderprice which is not fixed.

Forcing a NormalizeDouble makes it work fine

See the code below:...
The invalid price error is most likely to be generated by a requote. Bid is Bid, so I am not so sure that normalizing it will make any difference.

I have no objection to doing so, and so will Normalize(Bid/Ask, Digits) in the next release - does no harm. I just don't see it making any difference and reckon your subsequent success was down to coincidence.

  • #266
  • Edited 11:10pm Jun 20, 2010 10:39am | Edited 11:10pm
[updated 14:03, 21jun2010 AUS time, GMT+10]

this is an update of my msg #189

Before using this version, make sure you backup your current version of

expertsincludesimone stuff.mqh


You can tell you are using this version by looking at the parameters list.
The attached image shows you where it shows a version number.

(All references to 'enter this' or 'enter that' below, refer to entering trading hours)

The calculation sequence in this version is now as follows

  1. MT4 prompts for params.
  2. If you enter a number other than -1, everything stops here. Your value is what will be used.
    .
    .
  3. If you entered -1, the new autocalc function will determine the correct local trading hours. If it can't figure out the hours, it will leave it as -1 (for the next step)
  4. If the above step returned a -1 for any hour, the global variables will be searched for that trading hour and pair.
    (the variable's name looks like EURUSD Simone start_hourm)
  5. Whatever comes out of the above will now be written to the global variable, ready for use next time you invoke simone.


If at the end of the above you still end up with a -1 (i.e. in the corresponding Global Variable) then the auto-calc was unable to determine the hours *and* there was no global variable with a value in it.
It will only fail if it comes across a pair whose individual currencies it does not know.

Here is the code that does the GMT calculation

Inserted Code
/*
from: http://forex.timezoneconverter.com/index.cgi?timezone=GMT;
Forex Market CenterTime ZoneOpens GMTCloses GMT
=======================================================================================
Frankfurt, Germany Europe/Berlin06:00 AM, 11-June-201002:00 PM, 11-June-2010
London, Great BritainEurope/London07:00 AM, 11-June-201003:00 PM, 11-June-2010
New York, USAAmerica/New_York12:00 PM, 10-June-201008:00 PM, 10-June-2010
Sydney, Australia Australia/Sydney10:00 PM, 10-June-201006:00 AM, 11-June-2010
Tokyo, Japan Asia/Tokyo11:00 PM, 10-June-201007:00 AM, 11-June-2010
*/

void calcCurrencyTradingHours(string currency, int& hourStart, int& hourEnd) 
{
if (currency == "EUR" || currency == "CHF" || currency == "GBP")
{
hourStart = 06;
hourEnd = 14;
} else if (currency == "USD" || currency == "CAD")
{
hourStart = 12;
hourEnd = 20;
} else if (currency == "JPY")
{
hourStart = 23;
hourEnd = 31;// 7am next day
} else if (currency == "AUD" || currency == "NZD")
{
hourStart = 22;
hourEnd = 30;// 6am next day
}
}



Let me know what pair you were using.

*** Consider this to be a test version ***

If the feedback is positive, we can ask Steve to include it in the stable version (i.e. in msg#1).

If not, well.... it was a good try and you should be able to either revert to your backup copy or re-download it from msg #1.

Cheers,
Nick
Attached Image
Attached File(s)
File Type: mqh simone stuff.mqh   5 KB | 419 downloads
  • #267
  • Jun 20, 2010 12:18pm Jun 20, 2010 12:18pm
thanks very much, now my PC sudenly has compiled simone stuf ????
now is everything OK....
thanks for help and concern....
finaly have simone EA.....

cheers guys and happy trading
  • #268
  • Edited 10:49pm Jun 20, 2010 10:21pm | Edited 10:49pm
Hi grandehombre

thank you for this explanation, yet I do not totally understand it....lol

could you please expand on your information

"If you enter a number other than -1"

enter a -1 where ? in TRS_gmt_shift ?

"Your value is what will be used."

Your value meaning start_houre = 12; end_houre = 24;

"If at the end of the above you still end up with a -1 then the auto-calc was unable to determine the hours"

how will I know if the auto-calc was able or unable ?

what are the auto-calc hours for different pairs ? your settings are ?

I am interested in your auto-calc trading hours for each pair, it is a great idea, your patience and expanded explanation appreciated




Quoting grandehombre
this is an update of my msg #189

Before using this version, make sure you backup your current version of

expertsincludesimone stuff.mqh


You can tell you are using this version by looking at the parameters list.
The attached image shows you where it shows a version number.


The calculation sequence in this version is now as follows[list][*]MT4 prompts for params.[*][b]If you enter...
  • #269
  • Jun 20, 2010 10:56pm Jun 20, 2010 10:56pm
Quoting grandehombre
this is an update of my msg #189

Before using this version, make sure you backup your current version of
expertsincludesimone stuff.mqh


You can tell you are using this version by looking at the parameters list.
The attached image shows you where it shows a version number.


The calculation sequence in this version is now as follows[list][*]MT4 prompts for params.[*][b]If you enter a number other than -1, everything stops...

So this makes it stop trading certain currencies outside the their specific trading hours while still trading other currencies?

If I got that right then that is really cool.

Thanks Nick
  • #270
  • Jun 20, 2010 10:58pm Jun 20, 2010 10:58pm
Pic 1: An example of the Breech not updating/re-drawing

Pic 2: then I deleted the Global variables and reloaded the EA

Do all Globals need to be deleted and EA's reloaded at the start of a trading week ?
Attached Image(s) (click to enlarge)
Click to Enlarge Name: picy1.JPG Size: 48 KB
Click to Enlarge Name: picy2.JPG Size: 45 KB
  • #271
  • Jun 20, 2010 11:11pm Jun 20, 2010 11:11pm
please re-read the msg, as I have updated it to answer all those questions.

Quoting Burton
Hi grandehombre

thank you for this explanation, yet I do not totally understand it....lol

could you please expand on your information

"If you enter a number other than -1"

enter a -1 where ? in TRS_gmt_shift ?
...
...

  • #272
  • Jun 20, 2010 11:17pm Jun 20, 2010 11:17pm
The code in Simone itself has not been changed.

That is, it will still behave as before, which means that it will not trade a currency outside the specified hours.

The only change done above is that the calculation order has changed (in simone stuff.mqh).
The end result for Simone itself is the same.

With Simone, you open a chart (one pair of currencies) and drop Simone onto it. Simone, in that chart window, will only trade that pair within its trading hours.

If you use many chart windows, each copy of Simone within those windows will only trade that pair, within that pair's trading hours.

This is how Simone has always worked, as far as I can recall.

So, the answer to your question (as I understand it) is, yeap.

Cheers,
Nick

Quoting rfking2
So this makes it stop trading certain currencies outside the their specific trading hours while still trading other currencies?

If I got that right then that is really cool.

Thanks Nick
  • #273
  • Jun 20, 2010 11:30pm Jun 20, 2010 11:30pm
Quoting grandehombre
The code in Simone itself has not been changed.

That is, it will still behave as before, which means that it will not trade a currency outside the specified hours.

The only change done above is that the calculation order has changed (in simone stuff.mqh).
The end result for Simone itself is the same.

With Simone, you open a chart (one pair of currencies) and drop Simone onto it. Simone, in that chart window, will only trade that pair within its trading hours.

If you use many chart windows, each copy of Simone within those windows will only trade...


After looking at it I understand. I was thinking that you made it so the bot would automatically recognize the the pair and change trading times by itself based on your GMT. So you could have a single preset saved and it would change trading times accordingly.

Cheers
  • #274
  • Jun 21, 2010 12:16am Jun 21, 2010 12:16am
Great thank you Nick

I will change my simone stuff and try with auto-calc

Quoting grandehombre
please re-read the msg, as I have updated it to answer all those questions.
  • #275
  • Jun 21, 2010 12:28am Jun 21, 2010 12:28am
>> the bot would automatically recognize the the pair and change trading times by itself based on your GMT.

That is indeed the case.

When you start Simone, she looks at the pair in its chart window and automatically calculates the trading times unless you explicitly entered trading times in the parameters dialog.

Remember, the calculation sequence is
- whatever trading hours you enter in the parameter dialog
- if you entered any -1 in a(ny) trading hour there, the auto-calc will calculate those for you.
- if it failed to calc any (i.e. returned -1), the Global vars will be used to get the value.

No matter who calculated what in the above sequence, whatever trading hours have been established above, they will be written in the global vars.



Quoting rfking2
After looking at it I understand. I was thinking that you made it so the bot would automatically recognize the the pair and change trading times by itself based on your GMT. So you could have a single preset saved and it would change trading times accordingly.

Cheers
  • #276
  • Jun 21, 2010 12:56am Jun 21, 2010 12:56am
Ok have made the changes to simone suff (GMT)

as I am in NZ my GMT is 12+

so simone stuff settings are

extern int TRS_gmt_shift = 720 // NZ 12+ 12 * 60

My Simone EA settings are

extern string Trade_Hours_M= "Morning Hours 0-12";
extern int start_hourm = -1;
extern int end_hourm = -1;
extern string Trade_Hours_E= "Evening Hours 12-24";
extern int start_houre = -1;
extern int end_houre = -1;

here is a pic of what USDJPY shows

Q: why the gap between 30 & 33

thank you Nick
Attached Image
  • #277
  • Jun 21, 2010 3:16am Jun 21, 2010 3:16am
there is a 3 hr gap between end of US session (6am AUS) and start of Tokyo session (9am AUS)


Quoting Burton
Ok have made the changes to simone suff (GMT)

as I am in NZ my GMT is 12+

so simone stuff settings are

extern int TRS_gmt_shift = 720 // NZ 12+ 12 * 60

My Simone EA settings are

extern string Trade_Hours_M= "Morning Hours 0-12";
extern int start_hourm = -1;
extern int end_hourm = -1;
extern string Trade_Hours_E= "Evening Hours 12-24";
extern int start_houre = -1;
extern int end_houre = -1;

here is a pic of what USDJPY shows

Q: why the gap between 30 & 33

thank you Nick
Attached Image (click to enlarge)
Click to Enlarge Name: Image 1.png Size: 9 KB
  • #278
  • Jun 21, 2010 4:57pm Jun 21, 2010 4:57pm
Steve

I have been running some backtests on eu from Jan2010 to end of April2010. I am using these dates just to get around the missing alpari data which I can't seem to solve.

Anyway, at least over this period Simone looks better trading with the RSI filter off. One thing I have noticed doing this which if it could be changed would make it more profitable is that there are occasions when for instance Simone has taken a buy trade but before hitting either tp or sl she then enters a sell trade. NOrmally the buy eventually goes to sl and the second trade in this instance a sell hits tp. Would it be possible to close an open trade if entering an opposite position. It may not work out all of the time but in my tests so far it would be beneficial. I have detailed below one of these examples.

Thanks

Paul

40 2010.01.14 07:00 buy 17 0.02 1.45534 1.45079 1.45687
41 2010.01.14 09:30 sell 18 0.02 1.45237 1.45747 1.44847
42 2010.01.14 10:56 s/l 17 0.02 1.45079 1.45079 1.45687 -9.10 983.87
43 2010.01.14 13:11 t/p 18 0.02 1.44847 1.45747 1.44847 7.80 991.67
  • #279
  • Jun 21, 2010 5:20pm Jun 21, 2010 5:20pm
Quoting paulbt38
Steve

I have been running some backtests on eu from Jan2010 to end of April2010. I am using these dates just to get around the missing alpari data which I can't seem to solve.

Anyway, at least over this period Simone looks better trading with the RSI filter off. One thing I have noticed doing this which if it could be changed would make it more profitable is that there are occasions when for instance Simone has taken a buy trade but before hitting either tp or sl she then enters a sell trade. NOrmally the buy eventually goes to sl and the second...
Hehe. I have not the faintest idea what is going on here anymore.

I seem to recall posting a trading robot here at some distant stage in the past. Having said, "I seem to recall....." I am being a bit sarkey. I am still testing said robot on my live account.

What the latest posts are banging on about, I neither know nor care. Give me a poke if anything useful emerges from them. In the meantime, I am busy elsewhere.

  • #280
  • Jun 21, 2010 6:09pm Jun 21, 2010 6:09pm
Quoting SteveHopwood
Hehe. I have not the faintest idea what is going on here anymore.

I seem to recall posting a trading robot here at some distant stage in the past. Having said, "I seem to recall....." I am being a bit sarkey. I am still testing said robot on my live account.

What the latest posts are banging on about, I neither know nor care. Give me a poke if anything useful emerges from them. In the meantime, I am busy elsewhere.



0 traders viewing now