I would prefer the second option - we could choose then (true/false) the use of this brief Sunday candle - mostly I think we would excluse this candle ?
- #5,084
- Jun 18, 2010 2:37pm Jun 18, 2010 2:37pm
Hi Mandl,
I do not want to muddy the waters with too many versions of this EA and I am sure Piptician will see to this when he gets time, but if you would like to add this option to one of the open source versions, put the following code directly after the Start() open brace "{" :
if (UseSundayCandle == false)
{
if (DayOfWeek() == 0)
{
return;
}
}
and add the following extern to the externs at the top of the mq4 file:
extern bool UseSundayCandle = false;
Rick
I'll add this to my ToDo list
Regards,
Piptician
- #5,085
- Jun 18, 2010 2:54pm Jun 18, 2010 2:54pm
Is the problem always going to be Sunday for everyone ? Depending on where in the world you are i.e. GMT time difference, it's possible you may not want it to trade on Saturday rather than Sunday ...
I'll add this to my ToDo list
Regards,
Piptician
Hmmm. TimeOfDay() returns server time which is based on GMT, so Sunday GMT should always be Sunday GMT whereever you are, but I am writing this not having consumed nearly enough coffee, so I will give it a bit more thought. Thanks for making me think
Rick
- #5,086
- Jun 18, 2010 3:38pm Jun 18, 2010 3:38pm
Hi Piptician,
Hmmm. TimeOfDay() returns server time which is based on GMT, so Sunday GMT should always be Sunday GMT whereever you are, but I am writing this not having consumed nearly enough coffee, so I will give it a bit more thought. Thanks for making me think
Rick
Piptician
- #5,087
- Jun 18, 2010 3:45pm Jun 18, 2010 3:45pm
- Joined Apr 2009 | Status: Trader | 2,035 Posts
Sorry, I meant server time not the local time for the user. If server time is GMT minus anything then that makes it Saturday ???
Piptician
brokers that are known to have the Sunday bar!
There are more brokers that don't have this than do!
- #5,088
- Jun 18, 2010 3:55pm Jun 18, 2010 3:55pm
Sorry, I meant server time not the local time for the user. If server time is GMT minus anything then that makes it Saturday ???
Piptician
It does get confusing doesn't it
My assumption is that server time for brokers is always GMT based (both my live brokers are GMT based), but this is almost certainly not guaranteed the more I think about it since many brokers offset 00:00 GMT. That means that server time (and those time functions) are simply returning local time on the broker's server. So you are quite correct to call me on this. The easy way to ammend this would be to simply allow any day to be entered by ammending the code to:
if (UseDayExclusionFilter == true)
{
if (DayOfWeek() == DayToExclude)
{
return;
}
}
and
extern bool UseDayExclusionFilter = false;
extern int DayToExclude = 0;
Alternatively, we could use the Windows API to convert timedate to UTC, but that is way too geeky
Thanks for jogging my brain
Rick
- #5,089
- Jun 18, 2010 3:57pm Jun 18, 2010 3:57pm
If you are planning on adding this to the EA why not just disable it for the
brokers that are known to have the Sunday bar!
There are more brokers that don't have this than do!
if((GMToffset < 0 && DayOfWeek() == 6) || // 6 = Saturday
(GMToffset >= 0 && DayOfWeek() == 0)) // 0 = Sunday
return(0); // No trade today!
Piptician
- #5,090
- Jun 18, 2010 3:59pm Jun 18, 2010 3:59pm
- Joined Apr 2009 | Status: Trader | 2,035 Posts
I think something like this will do the trick without having to maintain a list of Sunday brokers:
if((GMToffset < 0 && DayOfWeek() == 6) || // 6 = Saturday
(GMToffset >= 0 && DayOfWeek() == 0)) // 0 = Sunday
return(0); // No trade today!
Piptician
- #5,091
- Jun 18, 2010 4:03pm Jun 18, 2010 4:03pm
I agree, so long as it is a user option!
Piptician
- #5,092
- Jun 18, 2010 4:06pm Jun 18, 2010 4:06pm
Sure, that can be wrapped in a check for a user option. Probably best that the user option defaults to true so by default Saturdays/Sundays are avoided.
Piptician
Rick
- #5,093
- Jun 18, 2010 4:14pm Jun 18, 2010 4:14pm
- Joined Apr 2009 | Status: Trader | 2,035 Posts
Good solution. I posted some code above which will exclude any day the user chooses. Could be useful on BOE interest decision days
Rick
- #5,096
- Jun 18, 2010 4:24pm Jun 18, 2010 4:24pm
- Joined Apr 2009 | Status: Trader | 2,035 Posts
Point well taken. Sorry for meddling.
I will leave it in the capable hands of Piptician.
Rick
as there would appear to be only 2 brokers that have this particular anomally
so it would seem to me that the default should favour the majority that do not!
Bear in mind the EA only trades twice per week on average, if we cut the week
down to 4 trading days this average is going to be reduced even more!
- #5,097
- Jun 18, 2010 4:26pm Jun 18, 2010 4:26pm
- Joined Apr 2009 | Status: Trader | 2,035 Posts
Getting not so simple anymore. I am sure that everyone knows how to disable the EA so it does not trade on Sunday. Next they will want this EA to wash their car.
Sorry guys but I don't think the default should be to disable the Sat/Sun candle
as there would appear to be only 2 brokers that have this particular anomally
so it would seem to me that the default should favour the majority that do not!
Bear in mind the EA only trades twice per week on average, if we cut the week
down to 4 trading days this average is going to be reduced even more!
Hi Geoffb,
3 brokers, GallantFX have the same problem
