Simple 3 order GBPUSD EA

Hi Freddy. Nice to see you here. I have been away fromn the boards for some time until recently. I agree with you on threads, but this one has no indicators to add. I'm sure some will try to refine the stops, or optimize the EA, or this and that. But, Geoff doesn't seem to mind helping people here that are new and have questions. I don't think he's even opposed to someone that might offer suggestions for improvement to what already appears to be a great EA.

22
22
30

TadawulFX Demo, trades took at 23:20 lasted about 36 minutes to all closed with profit.
Broker is set at GMT +2 at this time of year; their site says GMT+1 but someone here already pointed out due to daylight savings it's off. I used the P4L Clock indi and it showed broker time being gmt +2 as well.

Kerst

Anyone using a FXCM MT4 account?

Can you please confirm the offset is GMT +1

Thanks

Jogariga maybe FXCM is GMT -4? I saw this on Geoff's other thread, 1st post:

http://www.forexfactory.com/showthread.php?t=231650

Update: From FXCM's site FAQ: http://forexforums.dailyfx.com/faqs-...rader-4-a.html
What is the GMT offset for FXCM?
There are currently two different technology providers for MT4.
If the icon on your desktop says FXCM Trader 4, your GMT offset is -4
If the icon on your desktop says FXCM MT4 powered by BT, your GMT offset is +1

Kerst

i didnt get any trades on my gomarkets account at all... sorry im noob, is the gmt offset 2 for this broker?

According to their FAQ, yes it is GMT +2
http://www.gomarketsaus.com/faqs-go-...e-trading.html


Google is your friend ;-)



Kerst

Yup it is indeed +2

With Alpari Uk (demo) I had a short trade today. Are you using a demo or live account Mr Bosch?


And for those who still have "gmt issues", just go to http://www.forexmarkethours.com/. You can download a small app that converts timezones.

Hope it helps.

hmm i dunno why i didnt get any trades triggered then....weird.. :s everything is default....

3 shorts on Alpari this night. 1 TP, 2 SL, all positive. Great.

Ok...I said I would take a peak at the code tonight and here is what I've found without spending too much time looking at more details....

This is more on the technical side, not strategy side yet.

There have been a few posts from users saying that they get error #0. Most recent was from joet post 496. In the code after all the ordersend functions, GetLastError() is called checking to see if it is zero and if no, then display the error code. This is incorrect and extremely deceiving because it will give the user an error code of 0 (no error) every time there is an error in any part of this strategy. GetLastError() consumes the error trap. What you need to do is store the result of ordersend and if the result gives an error, then retrieve the error using GetLastError(), not consume it. Furthermore, it's also good practice to then call the error description built in function by mt4 to display to the user what the error code is. I fixed this in all the spots and if you don't consume the error message but actually show what it was, it's code 130, which is stoploss error.

The reason why most users (not all) are not having issues with this is because those users who are not having issues are using NON ECN brokers. ECN brokers do not deal against you, they don't manipulate the price, which is why I and others that use ECN brokers will see pip spreads from 0 - 1 pip. But ECN brokers do not allow EAs to submit stoplosses as one order. You have to split the orders out. I fixed it on my version, but don't want to post the new code...this is your thread and your strategy which is wonderful, but the logic will need to be corrected for it to work properly/correctly.

Also, for all the ordersends which is for any broker and everybody, I would recommend not using retries in the code using a counter if any error occurs. What if you get error code 137 broker is busy error and then after several loops, they get freed up and you potentially have several unattended orders in place while being asleep....I'm not saying this is likely, I'm just saying you typically handle these type of scenarios not with a counter but resending it only when the context is busy and when it's free then it will take the order. Then you are putting much less risk in potentially one day waking up and seeing filled orders you didn't want. You check for error code 146 context is busy only.

And one final comment, this EA could easily get a huge performance boost (not strategy just how fast it runs). All those times pre built server functions like OrderOpenprice(), Orderstotal(), ordertype(), etc make a call to the server take time and since it's being called a ton of times in the code all over and several different server functions, it can just be put in a local variable in the and reused. I also think RefreshRates() is a big waste and expensive performance boost especially when called so much, but there are others that will argue this is necessary, but in this case if the code is tweaked more, taking it out will make it run faster and hence handle more ticks and run through the algorithms more, but that's my opinion. I don't use it in any of my EAs, but as long as the EA is optimized. Oh and for the Poin variable, you can just use Point / 0.1, then you don't have to list specific currencies and make sure you handle all of them.

I'm going to start looking at the strategy itself tomorrow night hopefully as I'm curious in the finer details of it that are in the code...and to have another set of eyes look over it for any potential concerns.....as long as it's ok with geoff!

Let me know if you have any questions.

jd

Good morning Emanuele!

My live account traded 3 shorts on Alpari also!

No problem jd this was the purpose of the thread, to get more eyes!

I have seen what happens on other threads but I am hoping that this thread will encourage experienced members continue to help newbie members, as they have been doing so far.

I have seen newbies torn to shreds on other threads and I don't want that to happen here!

However, if it is apparent that new members have not even read post #1 before asking questions, I will be tempted to ignore them.

All suggestions for improvements will be taken on board and, some of them will be tested but my opinion is, "if it ain't broke why fix it" !

Regards
Geoff

No trades on my live account last night - None this week so far.

on FXpro demo
TP1 22
TP2 20
TP3 10
all perfect

Are you confident that you have everything set up correctly?

If you want some help just ask!

It traded last week and i have changed nothing. This is why I NEVER bother with demo - you can get super results in demo - then when you go live ??

So i trade micro live accounts at the testing stange now.

I know broker feeds are all different but the results people are getting are so extreme with this EA.

Lets just see what the rest of the week brings

My 2 demo and 1 live accounts have all returned error #0 these last few days. I use IamFx and BestDirect, both ECN brokers. Yet backtesting works perfectly. How is that???

It's a tad depressing when others get their pips and mine won't trade.

Sounds like you have hit the nail on the head. Hopefully Sir Geoff will be able to make the changes needed. I'll wait patiently.

Cheers