LOL I do prefer at least a heads up on my back test so I don't have to waste 6 months forward testing if it does a crap out on the backtest.
- #42
- Apr 15, 2010 12:53pm Apr 15, 2010 12:53pm
- Joined Apr 2009 | Status: Trader | 2,035 Posts
my 2 cents: backtest= loosing time, only trust forward test IMO
However, back testing does give some performance data.
Enough to decide whether the EA strategy is even worth pursuing!
- #43
- Apr 15, 2010 12:57pm Apr 15, 2010 12:57pm
- Joined Apr 2009 | Status: Trader | 2,035 Posts
LOL I do prefer at least a heads up on my back test so I don't have to waste 6 months forward testing if it does a crap out on the backtest.
With more work on the trend determination this EA could be very accurate.
Even with the 13 SMA method it does extremely well.
- #45
- Apr 15, 2010 3:02pm Apr 15, 2010 3:02pm
- Joined Apr 2009 | Status: Trader | 2,035 Posts
your time (based on 1st chart) is GMT -2 ... what's this country?
ur parameters for 5 digit have to be x by 10 i guess?
The 4 and 5 digit parameters are built in to the code but I have only used it on 5 digit, Alpari.
Hope this helps!
- #48
- Apr 15, 2010 3:16pm Apr 15, 2010 3:16pm
- Joined Apr 2009 | Status: Trader | 2,035 Posts
Thank you for that!
Can you suggest a way round it?
Can you suggest a way round it?
Hi,
Thanks for sharing your EA here. I've just been having a look through the code and I think I know why some people are not seeing any trades.
The problem is with this piece of code:
if (Hour() == Start_Time+GMToffset ....
If you have the input parameters of StartTime = 23, and GMTOffset = 1, then Start_Time+GMT_Offset = 24. However, the function Hour() only returns values between 0 and 23, so the EA won't place any trades.
Hope this helps, and thanks again for sharing.
PeeJay
- #49
- Apr 15, 2010 3:18pm Apr 15, 2010 3:18pm
- Joined Apr 2009 | Status: Trader | 2,035 Posts
modeling quality is to low for your test. Did you test with 90% quality? I use alpari too but no trades from your ea
Can you try it with zero in the GMT offset and 23 in the start_time!
- #50
- Apr 15, 2010 3:28pm Apr 15, 2010 3:28pm
- Joined Apr 2009 | Status: Trader | 2,035 Posts
Hi,
Thanks for sharing your EA here. I've just been having a look through the code and I think I know why some people are not seeing any trades.
The problem is with this piece of code:
if (Hour() == Start_Time+GMToffset ....
If you have the input parameters of StartTime = 23, and GMTOffset = 1, then Start_Time+GMT_Offset = 24. However, the function Hour() only returns values between 0 and 23, so the EA won't place any trades.
Hope this helps, and thanks again for sharing.
PeeJay
I am in the UK and NY closes at 10:00pm so I set my start_time to 11.
- #52
- Apr 15, 2010 4:12pm Apr 15, 2010 4:12pm
- Joined Apr 2009 | Status: Trader | 2,035 Posts
I have put a quick mod into the attached code (lines 303 & 304). I've done a quick test and it seems to work.
Many thanks.
I have changed the attachments in the first post to your version and changed it to v2.
- #53
- Apr 15, 2010 5:23pm Apr 15, 2010 5:23pm
FYI. original version worked for me. Opened trades right on schedule.
Your a STAR!
Many thanks.
I have changed the attachments in the first post to your version and changed it to v2.
Believe and Achieve!
- #56
- Apr 16, 2010 2:09am Apr 16, 2010 2:09am
- Joined Apr 2009 | Status: Trader | 2,035 Posts
Should the EA open trades at 5pm EST or 6pm EST?
Last night a manual trader using this method would have seen the price turning down an hour before the NY close and by one hour after the close was well established down and would have shorted.
Because of the simple 13 SMA direction indicator, the EA would have got it wrong! LOL!
- #58
- Apr 16, 2010 2:34am Apr 16, 2010 2:34am
- Joined Apr 2009 | Status: Trader | 2,035 Posts
FYI. original version worked for me. Opened trades right on schedule.
There was a problem with the start_time in the original and this has been solved in v2 thanks to peejaywk!
That's what I love about forex, you never stop learning from good people!
- #59
- Apr 16, 2010 3:40am Apr 16, 2010 3:40am
- Joined Apr 2009 | Status: Trader | 2,035 Posts
I've tested your EA this night. It opened two trades in GBPUSD H1: one short which was closed with TP and the other long which is still open but with a big loss. I'm leaving it doing his thing, let's see what happens.
Thanks for sharing, though.
It should either produce a buy or a sell after the NY close, not both!
Have you modified the EA?
I would be interested to see your chart for the past 24 hours, I only expected a buy order to be produced according to the strategy!
