Accessing More Than One Indicator in EA | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Accessing broker feed bypassing MT4 18 replies

Accessing MT4 at Work 16 replies

Accessing charts from a different PC 4 replies

Anyone else has difficulties accessing oanda platform right now? 7 replies

EA for accessing history data? 4 replies

Accessing More Than One Indicator in EA

  • #1
  • First Post: Mar 3, 2010 1:15pm Mar 3, 2010 1:15pm
Hi,

Am having a problem accessing two separate indicators in EA. Have recently figured out how to access them through iCustom(), and am not having a problem calling them up individually but, only when I try calling them up at the same time.

Is there some way that you go about doing this?

We began discussing the problem in this post here.
  • #2
  • Mar 3, 2010 2:23pm Mar 3, 2010 2:23pm
What do you mean at the same time?
  • #3
  • Mar 3, 2010 2:39pm Mar 3, 2010 2:39pm
This is how I am trying to access them. There are three options. Option 1 is Hekein Ashi by itself (IND=1), option 2 is Stochastic by itself (IND=2), and option 3 is where I'm reading both outputs simultaneously (IND=3). And here, both indicators are always "loaded," regardless of which option.

PHP Code
//---- Get Indicator Signals
   if(IND>0){
   if(iCustom(NULL,0,"Heiken_Ashi_Ma_DZ",10,1,10,1500,true,0.618,true,4,0)!=EMPTY_VALUE){ Alert1=1; }
   if(iCustom(NULL,0,"Heiken_Ashi_Ma_DZ",10,1,10,1500,true,0.618,true,5,0)!=EMPTY_VALUE){ Alert1=2; }
   if(iCustom(NULL,0,"Stochastic_Cross_DZ",5,3,3,0,0,80,20,false,true,false,"","",0,0)!=EMPTY_VALUE){ Alert2=1; }
   if(iCustom(NULL,0,"Stochastic_Cross_DZ",5,3,3,0,0,80,20,false,true,false,"","",1,0)!=EMPTY_VALUE){ Alert2=2; }
//---- Null Override
   if(ORN>0){ Alert1=1; Alert2=1; if(OPT==2){ Alert1=2; Alert2=2; } }
//---- Convert Indicator Signals
   if((IND==1&&Alert1==0)||(IND==2&&Alert2==0)||(IND==3&&Alert1==0)||(IND==3&&Alert2==0)||(IND==3&&Alert1!=Alert2)){ Opt2="NULL"; }
   if((IND==1&&Alert1==1)||(IND==2&&Alert2==1)||(IND==3&&Alert1==1&&Alert2==1)){ OPT=1; Opt2="BUY"; }    // Buy  Option I II and III
   if((IND==1&&Alert1==2)||(IND==2&&Alert2==2)||(IND==3&&Alert1==2&&Alert2==2)){ OPT=2; Opt2="SELL"; } } // Sell Option I II and III
  • #4
  • Mar 3, 2010 3:12pm Mar 3, 2010 3:12pm
Have you tried storing the iCustom values to variables and then call the variables?
  • #5
  • Mar 3, 2010 4:26pm Mar 3, 2010 4:26pm
Storing the variables? Am not sure what you mean? Are you saying not to query with the "if" statement first, but just assign the values to variables instead? I suppose that would be just as easy or, even simpler, although I am not sure what difference it would make?
  • #6
  • Mar 3, 2010 4:55pm Mar 3, 2010 4:55pm
Simpler to follow (for me anyway)

Judging by your code, there should be no reason why an iCustom all won't work unless there's something wrong with the indicator.
  • #7
  • Mar 3, 2010 7:06pm Mar 3, 2010 7:06pm
I think simpler is better too, and at least it's worth a try. Thanks.
  • #8
  • Mar 3, 2010 8:36pm Mar 3, 2010 8:36pm
i think you better use shift = 1 instead of 0, like iCustom(NULL,......,1). using shift = 0, you will get the value updated every tick, while shift = 1, the value will be changed only once for one bar

iCustom(NULL,......,shift)
  • #9
  • Mar 4, 2010 5:21am Mar 4, 2010 5:21am
Okay so, when do the indicator arrows display? ... at the beginning of the bar? If so, then what you are saying makes sense. But, when it says "1," does that mean it's not empty, or what? Or what exactly does "shift" mean?
  • #10
  • Mar 4, 2010 6:05am Mar 4, 2010 6:05am
shift is the number of bar back, start from current bar. by using shift = 0, you will get the current value, which will be updated every tick. while shift =1 will give you the value of the indicator on the last bar. if the indicator isn't a repainter, this value wouldn't change.

i suggest to get trigger information from that heiken ashi, you better check these two buffer,
PHP Code
   SetIndexBuffer(2,ExtMapBuffer3);
   SetIndexBuffer(3,ExtMapBuffer4);
and use the intrnal logic of HA in determining when arrow should appear.
PHP Code
if (ExtMapBuffer3[pos]<ExtMapBuffer4[pos] && ExtMapBuffer4[pos+1]<ExtMapBuffer3[pos+1])
the line above is the condition checking. because ExtMapBuffer3 has line index = 2, and ExtMapBuffer4 has line index = 3,
PHP Code
if(iCustom(....,2,1) > iCustom(...,3,1) && iCustom(...,3,2) < iCustom(...,2,2)) Alert = 1;
else
if(iCustom(....,2,1) < iCustom(...,3,1) && iCustom(...,3,2) > iCustom(...,2,2)) Alert = 2;
in this example, i use shift = 1 and 2, not shift = 0 and 1. it will prevent us from getting trigger that keep changing while the bar is forming.

hope this help
  • #11
  • Mar 4, 2010 4:23pm Mar 4, 2010 4:23pm
Well, I tried Ronald's suggestion, but the results are basically the same thing. So maybe there's a problem with the indicator? I just wish it were quick and cheap, because I have other things I need to do.

As for what you're saying Sangmane, it's a bit too far beyond me right now. As I said in the original post, this is the first time I've tried accessing an indicator(s) through iCustom(). Other than that, I've had little experience working with indicators. So, it's kind of hard to get it to sink in at the moment. But, I expect I should get there at some point, at least to where I can understand what you're saying.

Thanks.
  • #12
  • Mar 6, 2010 3:03pm Mar 6, 2010 3:03pm
Quoting sangmane
shift is the number of bar back, start from current bar. by using shift = 0, you will get the current value, which will be updated every tick. while shift =1 will give you the value of the indicator on the last bar. if the indicator isn't a repainter, this value wouldn't change.

i suggest to get trigger information from that heiken ashi, you better check these two buffer,
PHP Code
   SetIndexBuffer(2,ExtMapBuffer3);
   SetIndexBuffer(3,ExtMapBuffer4);
and use the intrnal logic of HA in determining when arrow should appear.
And in the code provided (below), this is what you're doing, right?

Quote
PHP Code
if (ExtMapBuffer3[pos]<ExtMapBuffer4[pos] && ExtMapBuffer4[pos+1]<ExtMapBuffer3[pos+1])
the line above is the condition checking. because ExtMapBuffer3 has line index = 2, and ExtMapBuffer4 has line index = 3,
Is this internal to the indicator or, is it a mod that I have to add ... and where? To the indicator or the EA?

Quote
PHP Code
if(iCustom(....,2,1) > iCustom(...,3,1) && iCustom(...,3,2) < iCustom(...,2,2)) Alert = 1;
else
if(iCustom(....,2,1) < iCustom(...,3,1) && iCustom(...,3,2) > iCustom(...,2,2)) Alert = 2;
in this example, i use shift = 1 and 2, not shift = 0 and 1. it will prevent us from getting trigger that keep changing while the bar is forming.

hope this help
Okay, I've added the code in the bottom section here (in a different EA by the way), is this all that's necessary? Or, do I need to add the code per the section above?

Oh, it seems to be working the way it is, although I really haven't had the chance to check. It also makes a lot more sense today than it did a couple of days ago ... or, at least I'm beginning to understand the way the logic (or math) works.

Thanks.
  • #13
  • Mar 6, 2010 3:15pm Mar 6, 2010 3:15pm
Oh, could somebody tell me what it means when an indicator "repaints?" I know it's a pretty basic question, and have read enough to know it's not the preferred method, but I still don't understand what it means?

Of course I could probably find it easily enough by doing a search but, if someone would like to explain, that's okay too.

Thanks.
  • #14
  • Edited 4:10pm Mar 6, 2010 4:08pm | Edited 4:10pm
I'm not sure that reading the other postings will provide you with the correct explanation of repainting. From what I have read I think about half the people posting know what repainting means and the other half don't or have a vague idea and use the term to try to impress others. Even amoung the people who understand the meaning, some seem to have this wrong impression that any indicator that repaints is "bad". That is a very unsophiscated opinion.

The most basic definition of repainting that I can come up with is that an indicator will change its appearance on the chart from one tick to another. Of course this is the proper thing to do if the calcuated value changes because of the new tick values. Changing the value of the indicator on the current bar should be expected and should never cause someone a problem. Some people don't understand this.

However there are some indicators that change the values of the indicator on previous bars when a new tick arrives. The most common of these type of indicators are the multi-time frame or MTF type of indicators. I recently worked on one of these and I will use it for my explanation. It calcuated support/resistance from a higher TF and displayed it on the lower TF. Of course if the new tick created a new high/low on the higher TF, the support / resistance level would change on the lower TF and the appearance would also change. But instead of just the last bar changing, it would change the appearance of one or more previous bars. For instance, on a 15M chart using the support/resistance from the 1H TF, the last 2 or 3 bars indicator values might change depending on how long ago the latest 1H bar formed. That is the nature of these kind of indicators and needs to be recognized. It is not a "bad" indicator as there is a valid reason to use the higher TF values on a lower TF.
  • #15
  • Mar 7, 2010 1:26pm Mar 7, 2010 1:26pm
A good example for a repainting indicator and the question "where does the arrow appear?" is the built in iFractals() indicator.

A fractal by this indicator is defined by a bar whose high is higher than the preceding two AND the following two bars. As soon as it detects this condition it will draw an arrow at this bar but naturally this condition can only appear if the bar in question is already 2 bars in the past. So when checking for the appearance of fractals you always have to use this indicator with a shift of 2, a fractal simply can never appear on bar 0. Furthermore if the current bar suddenly decides to exceed the high (or low) of the already drawn fractal that has formed at shift 2 the indicator will take the already drawn arrow away again because the condition (surrounded by two lower highs) is not fulfilled anymore. This is an example for a so called repainting indicator, and as Codemeister already explained this is a completely normal thing for such indicators.

Unfortunately I don't know much about the original indicators from your question, so i cannot be of much help here. However, the fact that you are using more than one indicator at the same time should not have any negative effect. The indicators should act completely independent of each other and you should be able to use as many indicators as you wish in the same EA. There must be some other nasty programming error hidden somewhere that simply doesn't want to be easily debugged.
  • #16
  • Mar 9, 2010 1:58am Mar 9, 2010 1:58am
Quoting CodeMeister
I'm not sure that reading the other postings will provide you with the correct explanation of repainting. From what I have read I think about half the people posting know what repainting means and the other half don't or have a vague idea and use the term to try to impress others. Even amoung the people who understand the meaning, some seem to have this wrong impression that any indicator that repaints is "bad". That is a very unsophiscated opinion.
Looks like it may have been worthwhile to ask after all. Which isn't to say I fully understand the rest of what you're saying, but that's fine. I know more about it than I did before.

Thanks.
  • #17
  • Last Post: Mar 9, 2010 1:58am Mar 9, 2010 1:58am
Quoting 7bit
There must be some other nasty programming error hidden somewhere that simply doesn't want to be easily debugged.
Yeah, that's what I'm afraid of. It's probably something on my end of it.
0 traders viewing now