Need Help with My EA ... | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Need help with 10M chart - got it already but need some help! 1 reply

I need help about afl to mql4!!! please help to me 0 replies

need help with a simple MA crossover EA. anyone can help? 7 replies

help, help, help (templates) 5 replies

Help me out? I need the help of you. 20 replies

Attachments: Need Help with My EA ...
Exit Attachments

Need Help with My EA ...

  • #1
  • First Post: Edited Feb 16, 2010 5:32pm Feb 15, 2010 3:52pm | Edited Feb 16, 2010 5:32pm
From this thread

Quoting D8d3
Having seen what you did majestically with "Ding Dong". I am humbled and I pray you to please take this my attached EA and add the necessary command lines to enable the EA do as follows:

When any Order is opened, open 7 Pending Orders at variable number of pips and lots as well.
Quote
i.e. If the EA opens a Buy Order, the EA should also open 7Nos of Pending Buy Orders at PB1, PB2, PB3, . . ., with LOT1, LOT2, LOT3, . . . respectively, at different provided number of pips lower than the instant executed open buy order. All shall have the same TP & SL points and all unactivated pending order should be cancelled immediately the TP is hit. Same for Sell Orders.
Okay so, which TP did you want it to hit? The TP on the original order or, TP on the order opened most recently? I currently have it set up for the original TP, which is probably what you don't want.

I haven't had a chance to test it yet (not even sure what it's supposed to do?), so I'll let you have a look.

Good luck!

ETA: Had to modify because wrong variable specified for "Same Lots" value. Should work either way though ...
Attached File(s)
File Type: mq4 SweetRSI_mod_1.0.mq4   14 KB | 275 downloads | Uploaded Feb 16, 2010 5:32pm
  • #2
  • Feb 15, 2010 4:20pm Feb 15, 2010 4:20pm
Oh, if you want all the lot sizes to be the same just enter "Same Lot" for either Buy or Sell, and there's no need to fill in the rest.

The same goes for the spread values. If you want the orders spread equally apart, you only need to enter "Same Spread" value.
  • #3
  • Edited 9:56am Feb 16, 2010 9:37am | Edited 9:56am
Quoting ecTrade
Oh, if you want all the lot sizes to be the same just enter "Same Lot" for either Buy or Sell, and there's no need to fill in the rest.

The same goes for the spread values. If you want the orders spread equally apart, you only need to enter "Same Spread" value.
Many thanks to you Angel ecTrade.
I am still running tests on it and its doing well. The only problem remains that the pending orders do not come onboard/get completely executed.

I found out that it truly attempts to open the limit pending orders but due to the "Ordersend error 4107" & "invalid stoploss/targetprofit for Ordersend function" per command line for opening the limit pending order, it could not.

Please ecTrade is it possible for you to find time to fix this one.

Thanks a lot.

D8D3.
  • #4
  • Feb 16, 2010 10:00am Feb 16, 2010 10:00am
Well, I was looking at the initial StopLoss in the EA and it's set awfully high at 24000. So, this might be what's causing that error. It almost looks like whoever wrote the EA didn't intend to use it. If that's the case, it would have been just as easy to set it to "0" or, none at all. If so, then I don't think there would be an error.

As for this other error, I don't know? I don't generally refer to the error log when working on EA's. I just tend to grind away at it. Maybe now's the time to start? If I get a chance, I'll take a look at it later.

Although I just modified it and set all the StopLosses to "0" so, you might want to take a look at that. Maybe this is what's causing the other problem as well?
  • #5
  • Feb 16, 2010 4:13pm Feb 16, 2010 4:13pm
Quoting ecTrade
Well, I was looking at the initial StopLoss in the EA and it's set awfully high at 24000. So, this might be what's causing that error. It almost looks like whoever wrote the EA didn't intend to use it. If that's the case, it would have been just as easy to set it to "0" or, none at all. If so, then I don't think there would be an error.

As for this other error, I don't know? I don't generally refer to the error log when working on EA's. I just tend to grind away at it. Maybe now's the time to start? If I get a chance, I'll take a look at it...

Thanks in millions angel ecTrade. I just finished running a very comprehensive test on the EA. Your generous actions so far on it is giving us a headway. From the results of the tests, I have found it very necessary to give the working scenarios of the EA as follow:

Should the condition for opening a trade be met in any currency pair, then a trade is opened eg. at 0.98765. So lets call the opened trade at 0.98765 = OPT1.

Lets say that OPT1 is a buy order that opened at 0.98765 with its targetprofit at 0.98800.

What this EA should do, is to apart from opening the OPT1, it should also open pending buylimit orders of PB1, PB2, PB3, . . ., PB7 (of which their interval/spacing as well as individual lot sizes should be entered by user - me for example).

If I have set the interval of PB1 to be 5 and its lot size as 0.03, interval of PB2 to be 10 and its lot size as 0.05, interval of PB3 to be 15 and its lot size to be 0.07 etc.

This EA should then open pending buylimit order:
PB1 at OPT1 - PB1 interval (5) = 0.98760 with lot size of 0.03.
PB2 at OPT1 - PB2 interval (10) = 0.98755 with lot size of 0.05.
PB3 at OPT1 - PB3 interval (15) = 0.98750 with lot size of 0.07 etc.

All the opened pending buylimit orders should have the same targetprofit (0.98800) of the initial opened trade OPT1.

Then immediately the targetprofit of OPT1 is hit, all its opened pending order whether activated or not should all close/delete as the case relates.

So for every other OPTn, whether buy or sell, there should be relevant corresponding pending buylimit/selllimit orders opened with their corresponding targetprofits accordingly.

I hope this clears the gray areas to enable you put this EA to rest.

Many humble greetings from me. Thanks angel ecTrade.

Please help me.

D8D3.
  • #6
  • Feb 16, 2010 5:38pm Feb 16, 2010 5:38pm
What, is this a Martingale?

Okay, I just modified it so that all orders will close at the same price. I also set the "Same Lots" variables to "0" as a default, as it looks like you wish to set each order individually.

The file has been updated in the original post.
  • #7
  • Feb 18, 2010 3:05pm Feb 18, 2010 3:05pm
Quoting ecTrade
What, is this a Martingale?

Okay, I just modified it so that all orders will close at the same price. I also set the "Same Lots" variables to "0" as a default, as it looks like you wish to set each order individually.

The file has been updated in the original post.

Dear ecTrade, good morning. I have been with a very difficult task while the EA was running as a test.

Well, its still almost ok. I am only worried that sometimes, when it opens the initial trade/order OPT1 that also opens up the pending orders PX1, PX2 etc., when OPT1 profit target is hit, I found out that many times, the pending orders PX1, PX2 etc. are still left undeleted/closed.

Please could you check again to eliminate this problem.

This EA actually intends to make use of the drawdown space to reap more profits, since market price would still eventually return to the initial order OPT1 target profit.

Please ecTrade, take a look at my EA again and see if you could spot the cause of the problem and eliminate it.

I am grateful.

Thank you.

D8D3.
  • #8
  • Feb 18, 2010 7:06pm Feb 18, 2010 7:06pm
Yes, there may be a conflict here. I forgot that, after adding the same Take Profit or closing value to the pending orders, I had set it up with a different way of deleting them ... which, I should have at least disabled at the time. I'm thinking there may be some sort of conflict involved, when two different mechanisms are trying to close the orders at the same time. Anyway, it's now disabled.

Hopefully you'll have better luck now.
Attached File(s)
File Type: mq4 SweetRSI_mod_1.0.mq4   14 KB | 227 downloads
  • #9
  • Feb 18, 2010 7:31pm Feb 18, 2010 7:31pm
Quoting D8d3
This EA actually intends to make use of the drawdown space to reap more profits, since market price would still eventually return to the initial order OPT1 target profit.
What, do you mean like six months later? I'm looking at the Euro right now and it's down almost 1,700 points over the USD since early last December. This is why I have suspended trading, for now, because I was employing a similar methodology, and was actually doing quite good, until this happened. Basically I lost all that I made over the previous two months and then some. So I figured I had better stop, and come up with a different approach.
  • #10
  • Feb 19, 2010 11:35pm Feb 19, 2010 11:35pm
Quoting ecTrade
What, do you mean like six months later? I'm looking at the Euro right now and it's down almost 1,700 points over the USD since early last December. This is why I have suspended trading, for now, because I was employing a similar methodology, and was actually doing quite good, until this happened. Basically I lost all that I made over the previous two months and then some. So I figured I had better stop, and come up with a different approach.

I shall get back to you with the test results.

Thank you so much.

D8D3.
  • #11
  • Feb 20, 2010 12:39am Feb 20, 2010 12:39am
Quoting D8d3
I shall get back to you with the test results.

Thank you so much.

D8D3.

Yes angel ecTrade, thanks for your efforts and time.

This EA really/truly has/needs to delete the pending orders PX1, PX2, etc. created because of the opened order XO1. Without this it would not be a success.

For instance, I noticed that Buy Order A1 (BOA1) opened at 18/02/2010 at 2:00a.m., of course it also opened its buylimit pending orders BPOa1, BPOa2 etc. But when BOA1 hit its target profit at 18/02/2010 at 2:03, its BPOa1, BPOa2 etc. were not deleted/closed, they all remained open. This should not be the case at all.

All pending orders whether sell-limit or buylimit must be deleted or closed immediately their initiating buy/sell order hit the intended target profit.

Please check again angel ecTrade. At the least, we are there but for this discomfort.

Many thanks.

D8D3.
  • #12
  • Edited Feb 21, 2010 2:05am Feb 20, 2010 5:14am | Edited Feb 21, 2010 2:05am
Okay, you're right, it didn't register (after the last fix) that you are trying to delete all pending and open orders at the same time. So, maybe it's just a matter of enabling what I disabled?

One thing about it though, depending on how many pending orders are open, is it doesn't always delete them at once. Sometimes it takes a second or, possibly a third or fourth tick in order to do this. The same thing applies to all open orders, when trying to do the same ... that is, without setting them all to the same Take Profit value (or target). I believe this is what I changed the last time.

So, I re-enabled it, the close all orders at once feature, to delete only the pending orders at the same time. Hopefully that should take care of it. Just be aware that it might take more than one or two ticks in order to do this. Okay?

Thanks.

ETA: Added mods per posts 14 and 15 below ...
Attached File(s)
File Type: mq4 SweetRSI_mod_1.0.mq4   15 KB | 250 downloads
  • #13
  • Feb 20, 2010 4:13pm Feb 20, 2010 4:13pm
Quoting ecTrade
Okay, you're right, it didn't register (after the last fix) that you are trying to delete all pending and open orders at the same time. So, maybe it's just a matter of enabling what I disabled?

One thing about it though, depending on how many pending orders are open, is it doesn't always delete them at once. Sometimes it takes a second or, possibly a third or fourth tick in order to do this. The same thing applies to all open orders, when trying to do the same ... that is, without setting them all to the same Take Profit value (or target). I believe...

Even the whole world cannot thank God enough. I am very grateful for this last adjustment. However, now it no longer waits for the initializing buy order to hit its target profit, it just opens the buylimit pending orders and delete them almost immediately (For Buy Orders Only), without waiting for the initializing buy order to hit the target profit first.

For the Sell Orders, it does not delete/close the Sell_Limit pendng Orders at all, they all just remain at the same spot, increasing trade uncertainty because they could be hit when they are not supposed to be part of the trade orders.

I pray for more grease to your elbows and milk to you mind, so that you could break this problematic situation.

Its only thank you ecTrade, but I say it with good senses of sincerity and respect for you.

Many thanks.

D8D3.
  • #14
  • Edited Feb 21, 2010 1:11am Feb 20, 2010 9:07pm | Edited Feb 21, 2010 1:11am
Hey that's weird, I didn't set "B_targ" or "S_targ." That might explain it. There's no target. Crap!

Oops, that's the part I just deleted! I thought I was deleting something else ...

Okay, I put it back. I also noticed the "reset to 0" was in the wrong place (resets to 0 after pending orders are deleted) and added an additional counter to make sure all pending orders are deleted first before it resets. I think this is why you were having problems before. Hopefully this should fix that.

I also made this specific to the chart symbol you are working on and added the magic number as well. This should help ensure you don't delete the wrong orders, if you are working on something else.

Oh well, it's too bad I don't know how to set it up (tried it once already but it didn't work), otherwise I could have tested it myself and had most of this fixed already. But I figured it would be better for you to test because you knew what you wanted.

I did plan on asking for the parameters after it was fixed but, maybe you could tell me now? (if possible). Or, maybe it's already setup? I tried opening it on the chart and forward tested it for 3 or 4 days, but nothing happened?

Well, hopefully it works better now. Let me know what happens, Okay?

I updated the file on previous post (#12).

Thanks.
  • #15
  • Feb 21, 2010 2:00am Feb 21, 2010 2:00am
Okay, I added a slight mod, for whoever downloaded a copy of the last revision.

I added a latch so, that once it hits the target it latches up and stays latched, until all pending orders are deleted. That way, if they're not deleted in the first tick, and the price dips below the target, the latch now serves as the signal and won't reset until this happens.

Good luck!
  • #16
  • Feb 21, 2010 9:19am Feb 21, 2010 9:19am
Okay, I just backtested it (thanks for the instructions) and it looks like the deletion problem only occurs during the Buy mode. The Sell mode, as far as I can tell, looks like it's operating correctly. Or, I made about $1,000 over the test period with lot sizes of .1, .3, .5, .7, etc. I'm also using a mini account, which is from standard account (I believe) by a factor of 10.

Nevermind, I went back checked the results and compared them with your results in post 13, and they're exactly the same, even after all the changes I made. Wow! That almost suggests something else is happening entirely which, of course doesn't make any sense. Will have another look though.

By the way, does Yahoo save the chats? I went back and looked after I sent the email but couldn't find it?

Thanks.
  • #17
  • Last Post: Feb 25, 2010 3:05am Feb 25, 2010 3:05am
Hi guys. I need help with my EA.
I want to open order (1 time) for buy condition and close& reverse if it will situation for sell condition.
Attached File(s)
File Type: mq4 SMAPA(1).mq4   7 KB | 310 downloads
Think like an investor, Act as a speculator. Ferid H.
0 traders viewing now