Help with GMT time offset

Hello all,

I need help with a custom indicator I have developed. I have 3 lines being drawn at the start of every day, one for daily open price, one for weekly open price, and one for monthly open price. My problem is that I am moving to a broker who doesn't give the new daily candle at 00:00 GMT. They give it at 22:00 GMT. So basically, my Daily Open price line needs to now be based on the broker's 02:00 hourly candle open price. Can you look at my script below and let me know how I can accomplish this? I've exhausted all that I know how to do. Thanks.



extern color DailyOpen_Color = Lime;
extern string DailyOpen_Style = "DOT";
extern int DailyOpen_Width = 1;
//
extern color WeeklyOpen_Color = Yellow;
extern string WeeklyOpen_Style = "DOT";
extern int WeeklyOpen_Width = 1;
//
extern color MonthlyOpen_Color = Red;
extern string MonthlyOpen_Style = "DOT";
extern int MonthlyOpen_Width = 1;

//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
// Only the style SOLID width can be greater than 1
if (DailyOpen_Style != "SOLID" && DailyOpen_Width > 1)
DailyOpen_Width = 1;

if (WeeklyOpen_Style != "SOLID" && WeeklyOpen_Width > 1)
WeeklyOpen_Width = 1;

if (MonthlyOpen_Style != "SOLID" && MonthlyOpen_Width > 1)
MonthlyOpen_Width = 1;

return(0);
}
//+------------------------------------------------------------------+
//| Custor indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
// Delete lines
ObjectDelete("Daily_Open_Line");
ObjectDelete("Weekly_Open_Line");
ObjectDelete("Monthly_Open_Line");
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{
// Current Daily bar open price
double do = iOpen(NULL, PERIOD_D1, 0);
double wo = iOpen(NULL, PERIOD_W1, 0);
double mo = iOpen(NULL, PERIOD_MN1, 0);

// Daily open line
ObjectCreate("Daily_Open_Line", OBJ_HLINE, 0, Time[0], do);
ObjectSet("Daily_Open_Line", OBJPROP_COLOR, DailyOpen_Color);
ObjectSet("Daily_Open_Line", OBJPROP_STYLE, GetLineStyle());
ObjectSet("Daily_Open_Line", OBJPROP_WIDTH, DailyOpen_Width);

// Weekly open line
ObjectCreate("Weekly_Open_Line", OBJ_HLINE, 0, Time[0], wo);
ObjectSet("Weekly_Open_Line", OBJPROP_COLOR, WeeklyOpen_Color);
ObjectSet("Weekly_Open_Line", OBJPROP_STYLE, GetLineStyle());
ObjectSet("Weekly_Open_Line", OBJPROP_WIDTH, WeeklyOpen_Width);

// Monthly open line
ObjectCreate("Monthly_Open_Line", OBJ_HLINE, 0, Time[0], mo);
ObjectSet("Monthly_Open_Line", OBJPROP_COLOR, MonthlyOpen_Color);
ObjectSet("Monthly_Open_Line", OBJPROP_STYLE, GetLineStyle());
ObjectSet("Monthly_Open_Line", OBJPROP_WIDTH, MonthlyOpen_Width);

return (0);
}
//+------------------------------------------------------------------+
//| GetLineStyle int |
//+------------------------------------------------------------------+
int GetLineStyle()
{
int ls = 0;
string stylearray[5] = {"SOLID", "DASH", "DOT", "DASHDOT", "DASHDOTDOT"};

if (DailyOpen_Style == stylearray[1]) ls = 1;
else if (DailyOpen_Style == stylearray[2]) ls = 2;
else if (DailyOpen_Style == stylearray[3]) ls = 3;
else if (DailyOpen_Style == stylearray[4]) ls = 4;

if (WeeklyOpen_Style == stylearray[1]) ls = 1;
else if (WeeklyOpen_Style == stylearray[2]) ls = 2;
else if (WeeklyOpen_Style == stylearray[3]) ls = 3;
else if (WeeklyOpen_Style == stylearray[4]) ls = 4;

if (MonthlyOpen_Style == stylearray[1]) ls = 1;
else if (MonthlyOpen_Style == stylearray[2]) ls = 2;
else if (MonthlyOpen_Style == stylearray[3]) ls = 3;
else if (MonthlyOpen_Style == stylearray[4]) ls = 4;

return(ls);
}
//+------------------------------------------------------------------+

You need to add a setting; lets call it GMTOffset. This is the number of hours difference between your broker's server and GMT. This number needs to multiplied by the number of seconds in an hour (60*60). Then you add this number to Time[0] in ObjectCreate and the line should appear on the chart in the proper location on the hourly and smaller time frames.

For your current broker GMTOffset = 0 and for your other broker = 2.

Codemeister, thanks for the response. I know where to add the GMT offset variable, but where do I need to make it do the math part? Is this done at the Time[0] in ObjectCreate, or is the math done before that and called as a variable to the Time[0]? Thanks again.

Either way will work. Whichever is more understandable to you. Personally I usually declare a variable and set it to the answer.

int GMToff = GMTOffset*60*60;

In the ObjectCreate call add GMToff to Time[0].

Hey codemeister, I'm unsure of how to add the variable to the ObjectCreate line. Anytime I change anything on that line, my indicator diappears. Here's the code with the variables added.


extern color DailyOpen_Color = Lime;
extern string DailyOpen_Style = "DOT";
extern int DailyOpen_Width = 1;
//
extern color WeeklyOpen_Color = Yellow;
extern string WeeklyOpen_Style = "DOT";
extern int WeeklyOpen_Width = 1;
//
extern color MonthlyOpen_Color = Red;
extern string MonthlyOpen_Style = "DOT";
extern int MonthlyOpen_Width = 1;

double GMTOffset = 2;

//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
// Only the style SOLID width can be greater than 1
if (DailyOpen_Style != "SOLID" && DailyOpen_Width > 1)
DailyOpen_Width = 1;

if (WeeklyOpen_Style != "SOLID" && WeeklyOpen_Width > 1)
WeeklyOpen_Width = 1;

if (MonthlyOpen_Style != "SOLID" && MonthlyOpen_Width > 1)
MonthlyOpen_Width = 1;

return(0);
}
//+------------------------------------------------------------------+
//| Custor indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
// Delete lines
ObjectDelete("Daily_Open_Line");
ObjectDelete("Weekly_Open_Line");
ObjectDelete("Monthly_Open_Line");
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{
int GMToff = GMTOffset*60*60;

// Current Daily bar open price

double do = iOpen(NULL, PERIOD_H1, 0);
double wo = iOpen(NULL, PERIOD_W1, 0);
double mo = iOpen(NULL, PERIOD_MN1, 0);



// Daily open line
ObjectCreate("Daily_Open_Line", OBJ_HLINE, 0, Time[0], do);
ObjectSet("Daily_Open_Line", OBJPROP_COLOR, DailyOpen_Color);
ObjectSet("Daily_Open_Line", OBJPROP_STYLE, GetLineStyle());
ObjectSet("Daily_Open_Line", OBJPROP_WIDTH, DailyOpen_Width);

// Weekly open line
ObjectCreate("Weekly_Open_Line", OBJ_HLINE, 0, Time[0], wo);
ObjectSet("Weekly_Open_Line", OBJPROP_COLOR, WeeklyOpen_Color);
ObjectSet("Weekly_Open_Line", OBJPROP_STYLE, GetLineStyle());
ObjectSet("Weekly_Open_Line", OBJPROP_WIDTH, WeeklyOpen_Width);

// Monthly open line
ObjectCreate("Monthly_Open_Line", OBJ_HLINE, 0, Time[0], mo);
ObjectSet("Monthly_Open_Line", OBJPROP_COLOR, MonthlyOpen_Color);
ObjectSet("Monthly_Open_Line", OBJPROP_STYLE, GetLineStyle());
ObjectSet("Monthly_Open_Line", OBJPROP_WIDTH, MonthlyOpen_Width);

return (0);
}
//+------------------------------------------------------------------+
//| GetLineStyle int |
//+------------------------------------------------------------------+
int GetLineStyle()
{
int ls = 0;
string stylearray[5] = {"SOLID", "DASH", "DOT", "DASHDOT", "DASHDOTDOT"};

if (DailyOpen_Style == stylearray[1]) ls = 1;
else if (DailyOpen_Style == stylearray[2]) ls = 2;
else if (DailyOpen_Style == stylearray[3]) ls = 3;
else if (DailyOpen_Style == stylearray[4]) ls = 4;

if (WeeklyOpen_Style == stylearray[1]) ls = 1;
else if (WeeklyOpen_Style == stylearray[2]) ls = 2;
else if (WeeklyOpen_Style == stylearray[3]) ls = 3;
else if (WeeklyOpen_Style == stylearray[4]) ls = 4;

if (MonthlyOpen_Style == stylearray[1]) ls = 1;
else if (MonthlyOpen_Style == stylearray[2]) ls = 2;
else if (MonthlyOpen_Style == stylearray[3]) ls = 3;
else if (MonthlyOpen_Style == stylearray[4]) ls = 4;

return(ls);
}
//+------------------------------------------------------------------+

I presume you must be talking about a non zero value for GMTOffset because adding 0 to Time[0] will not change a thing unless a mistake was made. If you haven't already done so, run the code with this setting.

Assuming there was no problem, run it with a value of 2. Be sure to check the journal for any run time errors. Assuming there are no errors, go to the 1 hour chart, right click anywhere and select Objects List. Look for the object name and select it and select Edit. Look at the parameters tab and make sure the numbers make sense. I am attaching a screen shot of what it should look like.

I'm not sure why you used a double for GMTOffset - an int is the proper type.

Hey Codemeister,

Thanks for all your help, but I'm just not getting it. I guess I'll let this one go. I can't seem to get the same results as you are getting.

You might benefit from using "P4L PeriodCon.mq4" which can generate a time-shifted chart for you. (However, some indicators do not work on such charts if they don't handle timeshifts and/or symbol name changes. I kind of doubt your specific indicator would work without modifications but you can try it).

It seems to me your question is about how to get the correct Open price at the desired time. Forget about accessing the price from Daily, Weekly or Monthly candles, rather, get only the time info from those. Then what you need is the HOURLY price data (OHLC) for the appropriate hour of the day (for Daily), and the hour+day-of-week (for Weekly) and ... for monthly.


Basically, the approach would be to get the *time* of whatever candle you want (Daily, Weekly, Monthly). Then shift that time by the number of seconds + or - (as appropriate). If +2hr, then +7200 seconds. Then get the hourly bar number for that time. Then get the hourly open price for that specific hourly bar.

Use "iTime" to get the time of a Daily bar.
Add/subtract the timeshift_in_seconds to get newtime.
Use "iBarShift(Symbol(),PERIOD_H1,newtime)" to find the hourBarNum
Use "iOpen(Symbol(),PERIOD_H1,hourBarNum)" to get the desired Open price.

Use that hourly Open price as the shifted-Daily-open-price. Use the Monday (or Sunday??) Daily-Open price for your Weekly calculations. For Monthly, it can be a bit tricky to get the right day-of-week, but the approach is the same.

Watch out for iBarShift problems! It doesn't always work as you would expect, especially when trying to retrieve bars over the weekend (which don't exist). You might get the wrong bar, or no bar, depending on whether you use "true" or "false" for one of it's arguments (the last one).

Good luck,
Kent (pips4life)