EA interfering with other charts

Hi,
please could someone tell me why the following code alters prices on other charts which the EA isn't attached to? it basically uses a moving average as a SL,
I thought the line "if (OrderSymbol() == Symbol())" made it chart specific?

thanks.

int totalorders = OpenOrders;

for(int i=OrdersTotal()-1;i>=0;i--)

{
OrderSelect(i, SELECT_BY_POS,MODE_TRADES);
if (OrderSymbol() == Symbol())

{
if ( OrderType() == OP_BUY )
{
sl=movavg;
OrderModify(OrderTicket(),OrderOpenPrice(),sl,OrderTakeProfit(),0,Green);
}
if ( OrderType() == OP_SELL)
{
sl=movavg+(Spread*10)*Point;
OrderModify(OrderTicket(),OrderOpenPrice(),sl,OrderTakeProfit(),0,Green);
}
}
}
//----
}

You need to use one more condition to specify a trade by magicnumber.

if(OrderMagicNumber() == MAGIC)

Some EAs don't add magicnumber to the ticket when they send open order.
(If they don't, magicnumber become 0 that is the same as manual trades.)

In this case, you can solve it by adding magic number.

// define Magic Number first like this
int MAGIC = 1234567;

// add Magic Number to order section like this
OrderSend(Symbol(), ............,MAGIC, ....);

thanks, but this EA manages trades only , it doesn't open them, so I can't really use magic no.s

Arnold49,

Ok, if so, OrderSymbol() == Symbol() does not manage trades only on the chart the EA is attached.

If you attach it on EURUSD chart and you are opening 5 other EURUSD charts, it will manage trades that is opened on all other 5 charts also.

I had it on GBP/JPY it adjusted the sell trade that was there and, at the same time time it adjusted a GBP/USD chart position, incidently it set them at the same value,

are you saying "if (OrderSymbol() == Symbol())" will not make it chart specific?

thanks,
Steve.

I can't say anything certain with only a piece of code above and without knowing what settings the management EA have, but,


Yes, It's not at least "chart specific" but only "symbol specific".

I don't think it will manage GBP/USD trades when you are attaching it to only GBP/JPY chart (if the code above is the only order modify section, of course).

Isn't there a possibility that other EA have modified it casually?

no, I just removed all other EA and tried again , still the same, I will post the whole EA, the idea is , you open a trade then this manages the close by trailing a moving average

ps, just found some redundant code so I've removed it & re-posted

Arnold49,

As I see, your EA will never manage trades on other symbol charts.

If it really happend without any other EAs,
the only possibility left is you used built-in trailing stop by MT4 terminal.

If negative, I have no idea about that, sorry.

ok, I don't understand it either, but thanks for looking.

this is weird, I've done some more testing

I have 3 charts open in demo, GBP/JPY, GBP/USD, EUR/USD

all have sell positions open

if I put the EA on GBP/JPY it adjusts all 3 charts

If I put it on GBP/USD it adjusts itself & EUR/USD

If I put it on EUR/USD It only adjusts itself

NO other EA or charts are open

Anybody?

At last got to the bottom of it,

MT4 was corrupted, I deleted and re-installed MT4 , now it all works as it should!