Relative Strength Basket Trading System | Page 155 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Trading system using relative strength 2,816 replies

BASKET TRADE Management: Using multiple trade management EA's on basket trades 11 replies

Basket Knights - A Basket Trading Round Table 1,313 replies

Trading System Using Relative Strength-Part 2 1,499 replies

My version of a relative strength basket 2 replies

Attachments: Relative Strength Basket Trading System
Exit Attachments

Relative Strength Basket Trading System

  • #3,081
  • Edited 7:17am Jan 28, 2009 6:09am | Edited 7:17am
Ye Gods. I am such a spoon at times.

I could not understand why others were getting the orders closing because of recrosses message but the trades were not closing. It was working fine on my machine here.

I had been testing the routine with just gbp and jpy as triggers, so I could watch the indi closely. That meant I was getting away with some incorrect coding, something that changed the moment I enabled a few more triggers.

Coders here can feel all smug and superior when I admit to coding:

Inserted Code
int ticket=OrderClose(OrderTicket(),OrderLots(), Bid,10,CLR_NONE);
instead of:
Inserted Code
int ticket=OrderClose(OrderTicket(),OrderLots(), MarketInfo(OrderSymbol(), MODE_BID),10,CLR_NONE);
And I had the error-trapping wrong, so I was chasing the wrong error for ages.

Hey ho. We all do it from time to time.

I see there is a demand for a global DC trade closure. I have added it to V4e, so please try it out and sing out if it does not work properly. Copied from the user guide:

DC global order closure: This offers the facility to close all open positions when the Daily Cross trading profit reaches your target.

  1. DcGlobalOrderClosureEnabled: set this to 'true' to enable this feature, 'false' to disable.
  2. ProfitInDollars: set this to 'true' if you want the ea to close all orders at a set USD profit, then set DollarProfit to the figure you want.
  3. ProfitAsPercentageOfBalance: set this to 'true' if you want the ea to close all orders when your trading profit reaches your chosen percentage of the account balance, then set PercentageProfit to the percentage you want.
  4. The default settings are:

    1. ProfitAsPercentageOfBalance = true
    2. PercentageProfit = 10;

Attached File(s)
File Type: zip KG Relative Strength EA V4e.zip   737 KB | 660 downloads
  • #3,082
  • Jan 28, 2009 7:28am Jan 28, 2009 7:28am
Quoting SteveHopwood
Ye Gods. I am such a spoon at times.

I could not understand why others were getting the orders closing because of recrosses message but the trades were not closing. It was working fine on my machine here.

I had been testing the routine with just gbp and jpy as triggers, so I could watch the indi closely. That meant I was getting away with some incorrect coding, something that changed the moment I enabled a few more triggers.

Coders here can feel all smug and superior when I admit to coding:

[code]int ticket=OrderClose(OrderTicket(),OrderLots(),...
Thanks again Steve... I don't know what i have to say, i'm lucky man could work with you in this project. It's an honor can work together with you here.. And I hope this project could reach the final setup soon.. because we will have another project to do... hehehehehehehe

Best regards,

KG
  • #3,083
  • Jan 28, 2009 7:33am Jan 28, 2009 7:33am
Quoting matrixebiz
Hey KG,
I would like to find out why the CCFp indicator bases its ma currency calculations only on USD?
The ma is calculated by comparing lets say CHF with USD or JPY with USD, etc. Not sure why only USD. Does yours calculate against the USD also?
Thanks
Aha you found it... that's why i decided to use my own formula. I'm not using only USD but i compare to all currency.

Hope it's help

KG
  • #3,084
  • Jan 28, 2009 7:42am Jan 28, 2009 7:42am
Quoting SteveHopwood
I see there is a demand for a global DC trade closure. I have added it to V4e, so please try it out and sing out if it does not work properly. Copied from the user guide:...
Steve... You are.....




AWESOME !!!


Regards,
- Mike -
  • #3,085
  • Jan 28, 2009 7:47am Jan 28, 2009 7:47am
Quoting Kang_Gun
Thanks again Steve... I don't know what i have to say, i'm lucky man could work with you in this project. It's an honor can work together with you here.. And I hope this project could reach the final setup soon.. because we will have another project to do... hehehehehehehe

Best regards,

KG
Thanks, KG. You and the rest of the group here are most welcome to the results of my efforts.

  • #3,086
  • Jan 28, 2009 7:51am Jan 28, 2009 7:51am
Steve u doin a gr8 job && KG & everyone here... Just a newbie suggestion for your managment EA...if there is a possibility of adding a multiple TP's option...
For example. =
TP=100 pipz
TP=200 Pipz
TP=300 Pipz

so if the price reaches 100 but not 200 then it will close at 100pipz..but if it corsses 200 but not 300 then close at 200...hope it makes sense...and sorry if i have asked something sillyy
  • #3,087
  • Jan 28, 2009 8:02am Jan 28, 2009 8:02am
Quoting Mike_Stax
Steve... You are.....




AWESOME !!!


Regards,
- Mike -
Awe, shucks.

I know the global closure by dollars works. I am not so sure about by percentage because I am unsure that I have the formula correct.

In fact, even as I was typing that last para I was thinking that the logic was wrong, so I had a quick look. The logic was wrong.

You do not need to be a coder to confirm the logic of this routine. DcProfit holds the upl of the total of DC trades. ProfitPercentage ends up holding the value of the required percentage of the balance of the account. Does this look correct?

Inserted Code
// Profit as percentage of account balance enabled
   if (DcProfitAsPercentageOfBalance)
   {
      ProfitPercentage=AccountBalance() * (DcPercentageProfit/100);
      if (DcProfit >= ProfitPercentage) CloseOrders=true;
   }

If you think it does, the re-download the updated V4e here.

I have noticed some strange-looking basket trade entries, so I am going to re-design and re-write the basket trade sending function. I shall re-write it as I would have originally written it, had I realised the EA was going to become such a monster. This will make it easier to track down the causes of these rogue trades. I might be quiet for a while.

Attached File(s)
File Type: ex4 KG Relative Strength trading EA V4e.ex4   253 KB | 504 downloads
File Type: ex4 KG Relative Strength trading EA Alpari V4e.ex4   253 KB | 417 downloads
  • #3,088
  • Jan 28, 2009 8:38am Jan 28, 2009 8:38am
Quoting SteveHopwood
Awe, shucks.

I know the global closure by dollars works. I am not so sure about by percentage because I am unsure that I have the formula correct.

In fact, even as I was typing that last para I was thinking that the logic was wrong, so I had a quick look. The logic was wrong.

You do not need to be a coder to confirm the logic of this routine. DcProfit holds the upl of the total of DC trades. ProfitPercentage ends up holding the value of the required percentage of the balance of the account. Does this look correct?

[code]// Profit...
alpari4e does not attach to chart
  • #3,089
  • Jan 28, 2009 8:46am Jan 28, 2009 8:46am
Quoting dracozny
alpari4e does not attach to chart
Sticks to mine like glue. Try re-starting the platform, re-downloading the EA, rebooting in that order.

  • #3,090
  • Jan 28, 2009 9:39am Jan 28, 2009 9:39am
The DC cross EA seems to be more profitable quickly when opened at the start of the week than if it is opened at the middle of the week. Even the dradown is less at this time.

Start the EA when the market opens at the start of the week. Take the targeted basket profit and then close the EA for the week. Start it again at the start of the next week.

Am I right in my observation!

Why the latest EA 4e does not take any trades when I started it now where as EA V4d started to take trades but not in profit and EA V4 took trades and is in profits now?
  • #3,091
  • Edited 10:18am Jan 28, 2009 10:03am | Edited 10:18am
Hi Steve

could you ..... or someone else ..... please leave a ranging set file that is working very well on the ranging method.... please post it? Very much appreciated if u would. Otherwise I will have to shelve it as weird things just keep happening for me with the method. Like getting message basket cancelled insufficient trades available, (and my MinTradePerBasket is set at 2) I also watched as I was only down 13.00 and accountCloseProfit ..... closed everything at a huge loss, and I saw the account with much greater DD without this happening. Just strange how my FXDD Demo 10k account is acting here!

Also do want to thank Steve and others for all the hard work u have done for us here. You are very kind! I know u all have busy schedules so sorry to bother u. IMO

Thank you all!
  • #3,092
  • Jan 28, 2009 3:10pm Jan 28, 2009 3:10pm
Quoting Kang_Gun
Aha you found it... that's why i decided to use my own formula. I'm not using only USD but i compare to all currency.

Hope it's help

KG
I think your still working on a way to eliminate some of the pairs in your indi so as to not need all 28 but will still be able to produce accurate results because of brokers that do not have all the pairs which causes your calculations to the less accurate, especially like on IBFX where we only have 24 out of the 28 pairs your indicator uses

Well, reading the article here http://articles.mql4.com/422 and in the Requirements for Cluster Indicators Operation section looks like only 24 pairs were only actually needed for the originally operation EURUSD, EURGBP, EURCHF, EURJPY, EURCAD, EURAUD, EURNZD, GBPUSD, GBPCHF, GBPJPY, GBPCAD, GBPAUD, GBPNZD, USDCHF, USDJPY, USDCAD, AUDUSD, AUDJPY, AUDCAD, AUDNZD, NZDUSD, NZDCHF, NZDCAD, NZDJPY which IBFX has 22 of them

Can you maybe read the article and see if those 24 are still accurate then modify your KG Indi for those 24 so maybe IBFX users and other brokers might be more accurate?

Let me know what you think
Thanks
24 hours in a day – 24 bottles of beer in a case – Coincidence? I think not
  • #3,093
  • Edited Jan 29, 2009 1:02am Jan 28, 2009 4:07pm | Edited Jan 29, 2009 1:02am
I need your help because I have not succeeded in making to effectively turn the EA of Steve till now; I have attentively read the file. pdf with the instructions and I have tried to use the EA on three different graphic activating on every of them only one of the three methods; unfortunately from the first attempt going back to 25 last to I have had only today a trade from 0.01 on EURUSD of the method Daily Cross that is concluded with a loss of 1.65 $; I have verified in the error messages and I have found this " 2009.01.28 22:38:34 KG RS GROUP V1.1 GBPJPY,H1: unknown subwindow number -1 for ObjectCreate function"; I have made different searches on the preceding posts and I have found the number 2923 where it is possible to read "You need to delete the "m" instead of blank it out. Otherwise the program is looking for "EURJPY " instead of "EUYJPY"; I have tried to do as suggested but the situation is not changed; it needs to hold that the account that I am using is an account demo Alpari UK so I have used the version of the EA codified for Alpari so I believe that the solution found in every case was not pertinent; I have tried to make another attempt loading, after having removed the encoded EA for Alpari, with that "universal" referring the operation related to her "m" but once more the error message "KG RS GROUP V1.1 GBPJPY,H1: unknown subwindow number -1 for ObjectCreate function" has continued to appear.
I have tried that is also the last version of the EA the version V4e but without best results.
I would like to ask therefore to the courtesy of someone that is using the EA without problems to post the template of everybody and three the methods and the respective sets

I thank since now and I offer kindest regards.

Frankalde

P.S.: It is better, perhaps, to post the profile of every method that works after having saved it from his own base MT4; in this way he is easily able and without errors to reconstruct the whole graph having loaded both the EA and the necessary indicators.
Thanks still.
Frankalde
  • #3,094
  • Jan 28, 2009 6:36pm Jan 28, 2009 6:36pm
Steve

V4e loaded (all was going well)..... something has changed and I cant see the setting for it.

When the pair lines cross back over the EA now closes off the trades (guessing they were reversing)... trouble is it is doing it all the time.

Result today is - 1400 pips! (account was 1300 up!)

What is going on?

Eddie
  • #3,095
  • Edited 9:57pm Jan 28, 2009 9:05pm | Edited 9:57pm
Quoting eddiemiller
Steve

V4e loaded (all was going well)..... something has changed and I cant see the setting for it.

When the pair lines cross back over the EA now closes off the trades (guessing they were reversing)... trouble is it is doing it all the time.

Result today is - 1400 pips! (account was 1300 up!)

What is going on?

Eddie

i have only had one trade close on a cross

in my thinking i would prefer that if the lower tf crosses it would close the trade and reopen when all are in agreement again. just a thought that would need some more watching but i think its a valid concept from what i have seen.
  • #3,096
  • Jan 28, 2009 9:22pm Jan 28, 2009 9:22pm
_Stevehopwood_

Take a look at the picture(attachment) that i posted---i think as great as this high flying EA is---it is completely flying in total darkness--there's no sense of direction--the first question a good pilot would ask after getting into this EA's cockpit is---WHERE IS THE RUNWAY--

i think we have to give this EA some sense of direction(a Channnel)--where it can takeoff and expect to land---for example---

BUY SIGNALS--ONly open trades 50 pips away from the top channel line
SELL SIGNALS---only open trades at least 50 pips away from the bottom channel line

The point is sometimes trades open so close to the bottom/top channel line is extremely bad--cause when the price hits the line--it will probably reverse--increasing your drawdowns--

this also has to apply to all time frames--cause distances vary depending on the timeframes..

Hope you understand what am getting at-
Attached Image (click to enlarge)
Click to Enlarge Name: TF 1216 AUDCAD GO LONG @M5 TIME=14-25.gif Size: 36 KB
  • #3,097
  • Jan 28, 2009 9:25pm Jan 28, 2009 9:25pm
the indicators are--

shi-channel indicator or COG channel--
any one of those would do--
  • #3,098
  • Jan 29, 2009 2:24am Jan 29, 2009 2:24am
I just noticed in V4E, Relative Strength..

Even though I have the asian session close times set, it is still showing that the asian session is open and not trading those triggers.

I believe the time is based on my pc's time..
  • #3,099
  • Jan 29, 2009 3:03am Jan 29, 2009 3:03am
Anyone had seen that the new engine opens a new basket? I had set the minimum of 2 trades for a basket, after some of the "insufficent" messages, but it seems, that it doesn't help. It looks like that theres a problem with the new engine...
Greetings to all!
  • #3,100
  • Jan 29, 2009 3:03am Jan 29, 2009 3:03am
Quoting FranKalde
... error messages ...
Activate the window you added the EA to (click on that chart), double click on "KG RS GROUP V1.1" in the Navigator window - that's it.
The messages will no longer appear.

gl,
Max
10 traders viewing now