TMA-CG-2024 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Extreme TMA System 16,212 replies

TMA Reality Tour 116 replies

Happs with TMA Trading Journal 25 replies

MTF TMA 287 replies

SnakeForce - simple TMA with alert? 3 replies

Attachments: TMA-CG-2024
Exit Attachments

TMA-CG-2024

  • #1
  • First Post: Edited Aug 31, 2024 8:28am Aug 25, 2024 3:36pm | Edited Aug 31, 2024 8:28am
Hey all,

I’ve edited the infamous TMA-CG-Mladen-NFP.

All credit goes to Mladen for his idea and humility in sharing the original TMA code.

In this version, I:
- Created a class to simplify use in Indicators, Expert Advisors, and more
- Replaced iCustom(s) with iBarShift
- Created an MT5 version
- Switched init() to OnInit()
- Switched start() to OnCalculate()
- Switched deinit() to OnDeInit()
- Removed alerts
- Converted externs into inputs
- Implemented the CIndicator class
- Changed the string input TimeFrame to ENUM_TIMEFRAMES input inpTimeframe
- Limited the drawing to a maximum of 5000 candles (user input)

I’ve attached the indicators and source code.

To keep up with the updated versions, head over to GitHub: https://github.com/jblanked/TMA-CG-2024

If you want to contribute, fork the repository and submit your changes.
Attached File(s)
File Type: ex4 TMA-CG-2024.ex4   34 KB | 1,008 downloads
File Type: ex5 TMA-CG-2024.ex5   25 KB | 753 downloads
File Type: mqh TMA-CG-2024.mqh   11 KB | 818 downloads
File Type: mq4 TMA-CG-2024.mq4   7 KB | 1,138 downloads
File Type: mq5 TMA-CG-2024.mq5   7 KB | 912 downloads
Software Developer and Music Producer
News Fundamentals All Time Return: 1,159.1%
  • #2
  • Aug 25, 2024 10:09pm Aug 25, 2024 10:09pm
Is it possible to color code like the RSIOMA in the pic?

Attached Image (click to enlarge)
Click to Enlarge Name: RSioma.png Size: 4 KB


Lime for slope up
Magenta for down slope
Yellow for no slope
  • #3
  • Aug 26, 2024 11:15am Aug 26, 2024 11:15am
Hi Jb
Got this error when i want to compile.Can cheak maybe i attach wrong file.
Attached Image (click to enlarge)
Click to Enlarge Name: 1.jpg Size: 169 KB
  • #4
  • Aug 26, 2024 12:50pm Aug 26, 2024 12:50pm
Quoting JohnL33
Hi Jb Got this error when i want to compile.Can cheak maybe i attach wrong file. {image}
Hey, what's up man. You need the JB-Indicator.mqh library file.

Although the JB-Indicator library is fully functional, it's not complete yet. You can grab it from GitHub as well.

All of the GitHub links and directions are in the source code.

I also released an update a few hours ago:

  1. added color inputs
  2. updated candle count to avoid "Array Out of Range" warnings

Software Developer and Music Producer
News Fundamentals All Time Return: 1,159.1%
  • #5
  • Edited Aug 27, 2024 12:36am Aug 26, 2024 11:51pm | Edited Aug 27, 2024 12:36am
Quoting jblanked
{quote} Hey, what's up man. You need the JB-Indicator.mqh library file. Although the JB-Indicator library is fully functional, it's not complete yet. You can grab it from GitHub as well. All of the GitHub links and directions are in the source code. I also released an update a few hours ago: added color inputs updated candle count to avoid "Array Out of Range" warnings

Hi JB,

Where do we place the JB-Indicator.mqh library file ?

And where to place the TMA-CG-2024.mqh file?

I am unable to load the compiled indi but I am testing the provided ex4 file with an EA. Looking great so far. WYSISYG is what I needed.

Can you kindly guide me on how to compile this without errors?

Thanks !!!
Attached Image (click to enlarge)
Click to Enlarge Name: TMA 2024 compilation errors.png Size: 35 KB
  • #6
  • Aug 27, 2024 4:06am Aug 27, 2024 4:06am
Quoting aarkay
{quote} Hi JB, Where do we place the JB-Indicator.mqh library file ? And where to place the TMA-CG-2024.mqh file? I am unable to load the compiled indi but I am testing the provided ex4 file with an EA. Looking great so far. WYSISYG is what I needed. Can you kindly guide me on how to compile this without errors? Thanks !!! {image}
Hey man,

All of the GitHub links and directions are in the source code. As far as your error messages, looks like you added some more code.

For members who don’t code, it’s best to use the .ex4 and .ex5 files.
Software Developer and Music Producer
News Fundamentals All Time Return: 1,159.1%
  • #7
  • Aug 27, 2024 10:22am Aug 27, 2024 10:22am
Quoting jblanked
{quote} Hey man, All of the GitHub links and directions are in the source code. As far as your error messages, looks like you added some more code. For members who don’t code, it’s best to use the .ex4 and .ex5 files.
Hi Bro,

Thanks for your response.

But I did no modification to the code.
  • #8
  • Aug 27, 2024 10:31am Aug 27, 2024 10:31am
Quoting aarkay
{quote} Hi Bro, Thanks for your response. But I did no modification to the code.
The original code has only 216 lines, but you have errors on lines 800+
Software Developer and Music Producer
News Fundamentals All Time Return: 1,159.1%
  • #9
  • Aug 28, 2024 4:13am Aug 28, 2024 4:13am
The indicator is labeled as non-repainting, but if you look closely, you'll notice that all the arrows do repaint.
  • #10
  • Aug 28, 2024 5:50am Aug 28, 2024 5:50am
Quoting Tdate
The indicator is labeled as non-repainting, but if you look closely, you'll notice that all the arrows do repaint.
Please provide a video brother.

The arrows don’t repaint, but they will remove themselves (on the current bar only) if the condition is no longer true. Once the candle has closed, if there was/is an arrow, it won’t repaint or remove the arrow.

Lastly, please note that I only updated this code (I didn't create it), so for specific technical details, you'll need to consult Mladen.

TLDR: Wait for the candle to close to confirm if it has an arrow.
Software Developer and Music Producer
News Fundamentals All Time Return: 1,159.1%
  • #11
  • Aug 29, 2024 5:10am Aug 29, 2024 5:10am
Jblanked,

may i ask you why did you remove the alarms? the indicator itself is nice.
also if i assume right , you get an red arrow once you hit a sell block outside the upper line. and a blue arrow if it is buy block outside the bottom line.

also what are your ideas for future updates?

i am also a fan in general of TMA so that is why i ask.
  • #12
  • Aug 29, 2024 9:08am Aug 29, 2024 9:08am
Quoting coinfactor
Jblanked, may i ask you why did you remove the alarms? the indicator itself is nice. also if i assume right , you get an red arrow once you hit a sell block outside the upper line. and a blue arrow if it is buy block outside the bottom line. also what are your ideas for future updates? i am also a fan in general of TMA so that is why i ask.
Honestly, I've never been a fan of alerts or alarms in forex. While they can be useful, there's no denying that. However, I believe traders who rely solely on them are missing out in a big way.

As for future updates, I don't have any specific plans for the indicator itself, but I'm pretty open-minded. I do have some expert advisors in mind, but there are already hundreds, if not thousands, of EAs built around the TMA. I think the TMA complements other strategies well, just like the Half-Trend and Guppy.
Software Developer and Music Producer
News Fundamentals All Time Return: 1,159.1%
  • #13
  • Aug 29, 2024 11:03am Aug 29, 2024 11:03am
Quoting jblanked
{quote} Please provide a video brother. The arrows don’t repaint, but they will remove themselves (on the current bar only) if the condition is no longer true. Once the candle has closed, if there was/is an arrow, it won’t repaint or remove the arrow. Lastly, please note that I only updated this code (I didn't create it), so for specific technical details, you'll need to consult Mladen. TLDR: Wait for the candle to close to confirm if it has an arrow.

Hi Bro,

How can we make an EA recognize EVERY arrow formed? Problem is many arrows get formed but no trades take place with some. I need a WYSISWG (What you see is what you get) indicator, as I am sure many others will need it too. This plays havoc with exit strategies. I tested for 2 days, thought it was working, but sad story all over again.

Can modifications be made?

Thanks in advance bro.
  • #14
  • Aug 29, 2024 11:34am Aug 29, 2024 11:34am
Quoting aarkay
{quote} Hi Bro, How can we make an EA recognize EVERY arrow formed? Problem is many arrows get formed but no trades take place with some. I need a WYSISWG (What you see is what you get) indicator, as I am sure many others will need it too. This plays havoc with exit strategies. I tested for 2 days, thought it was working, but sad story all over again. Can modifications be made? Thanks in advance bro.
Sounds like some inconsistencies with the EA you're using.

If you're using the TMA library file, use the run() method on every new candle then look for arrows on the previous candle.

The EA I made for the Simple Guppy Cap Reversal thread correctly trades from the arrows and uses the Top and Bottom bands for take profits.
Software Developer and Music Producer
News Fundamentals All Time Return: 1,159.1%
  • #15
  • Aug 29, 2024 11:55am Aug 29, 2024 11:55am
Quoting jblanked
{quote} Sounds like some inconsistencies with the EA you're using. If you're using the TMA library file, use the run() method on every new candle then look for arrows on the previous candle. The EA I made for the Simple Guppy Cap Reversal thread correctly trades from the arrows and uses the Top and Bottom bands for take profits.

Will check and get back bro...

I am using two EAs. Luke and Catarina that can use indicators with buffer codes. MT4.
  • #16
  • Edited 1:05pm Aug 29, 2024 12:22pm | Edited 1:05pm
Jblanked,

what i think would be a great idea. is using a TMA indicator like yours, but combine it with a different one.

as i show in this example in the picture. when the redline crosses the greenline do a sell.

and for a buy when the blueline crosses the greenline do a buy.

now this would only work if both indicators do not repaint / recalculate.

it is something i am thinking of for some time. however since i have 0 coding experience. and do not know
if the indicators actually repaint / recaclulate i have no idea if it would work.

but in theory it could. the indicator i added in the picture is tma_nrp__bands_2.mq4

if you have the time let me know what you would think.
Attached Image (click to enlarge)
Click to Enlarge Name: redline-crosses-greenline.png Size: 11 KB
  • #17
  • Edited 1:47pm Aug 29, 2024 12:38pm | Edited 1:47pm
Quoting coinfactor
Jblanked, what i think would be a great idea. is using a TMA indicator like yours, but combine it with a different one. as i show in this example in the picture. when the redline crosses the greenline do a sell. and for a buy when the blueline crosses the greenline do a buy. now this would only work if both indicators do not repaint / recalculate. it is something i am thinking of for some time. however since i have 0 coding experience. and do not know if the indicators actually repaint / recaclulate i have no idea if it would work. but in theory...
I think they could work together, but I prefer the TMA-CG over the TMA-Bands

As far as recalculating, here's Mladen's thoughts on recalculating -> https://www.mql5.com/en/forum/181241...omment_4458704

All moving averages "recalculate" as they are dynamic.

From ChatGPT, "For example, if you're looking at a 20-day moving average, the value for any specific day in the past was calculated using the prices from that day and the 19 preceding days. As you progress forward in time, the values of the moving average line are recalculated using the newest data, which can make historical points on the moving average line appear to change."

From Claude AI, "As time moves forward, the window shifts. The oldest candle drops out of the calculation, and the newest candle is added. When you look at a chart that includes historical data and brings it up to the present, the moving average line for past dates can appear different from what it would have looked like if you were viewing it in real-time back then. This is because the calculation now includes data that wasn't available at that historical point in time."

From Gemini, "As time progresses, new data points become available. With each new data point added, the entire average is recalculated. This means that the value of the moving average for a specific day in the past can change as new data becomes available."
Software Developer and Music Producer
News Fundamentals All Time Return: 1,159.1%
  • #18
  • Aug 29, 2024 2:11pm Aug 29, 2024 2:11pm
Quoting jblanked
Hey all, I’ve edited the infamous TMA-CG-Mladen-NFP, originally created by Mladen. All credit goes to Mladen for his idea and humility in sharing the code. In this version, I: - Created a class to simplify use in Indicators, Expert Advisors, and more - Replaced iCustom(s) with iBarShift - Created an MT5 version - Switched init() to OnInit() - Switched start() to OnCalculate() - Switched deinit() to OnDeInit() - Removed alerts - Converted externs into inputs - Implemented the CIndicator class - Changed the string input TimeFrame to ENUM_TIMEFRAMES...
Here's a very basic EA version.

It will sell on bearish arrows and buy on bullish arrows. It sets the take profit automatically at the Mid Line and will modify the take profit (to the Midline of the previous candle) on each new candle. It has a stop loss in pips and the volume is in lot sizes.
Attached File(s)
File Type: ex4 TMA-CG-2024-EA.ex4   53 KB | 545 downloads
File Type: ex5 TMA-CG-2024-EA.ex5   57 KB | 422 downloads
Software Developer and Music Producer
News Fundamentals All Time Return: 1,159.1%
  • #19
  • Aug 29, 2024 4:46pm Aug 29, 2024 4:46pm
Jblanked,

why do you prefer TMA-CG over TMA bands? and how do you deal with exit strategy with TMA-CG?
  • #20
  • Aug 29, 2024 5:18pm Aug 29, 2024 5:18pm
Quoting coinfactor
Jblanked, why do you prefer TMA-CG over TMA bands? and how do you deal with exit strategy with TMA-CG?
The CG version seems to provide more trading opportunities, and I like its smoothing over the bands.

The Mid Line is a well-known take profit area, but I think you'll have more success with trailing.
Software Developer and Music Producer
News Fundamentals All Time Return: 1,159.1%
0 traders viewing now