Help - EA run amok!

void CloseHalfTrade()
{
   double tp2 = MathAbs(OrderTakeProfit() - OrderOpenPrice());
   double tp1 = NormalizeDouble(tp2 * 0.5, Digits);
   double breakevenPips = PipsToAddToBreakeven / GetPipValue();
  
//----
   for(int b=OrdersTotal()-1; b>=0; b--)
      {
      if(OrderSelect(b, SELECT_BY_POS, MODE_TRADES))
         if(OrderSymbol()==ChartSymbol())
            if(OrderType()==OP_BUY)
               if(Bid-OrderOpenPrice()>=tp1)
                  if(OrderOpenPrice()>OrderStopLoss())
                     {
                      OrderClose(OrderTicket(), OrderLots()/2, Bid, 3, clrNONE);
                      OrderModify(OrderTicket(), OrderOpenPrice(), OrderOpenPrice() + breakevenPips, OrderTakeProfit(), 0,clrNONE);
                      Alert(OrderSymbol() + " TP1 Hit, closing half trade & moving stop to BE+ 2 pips");
                      SendNotification(OrderSymbol() + " TP1 Hit, closing half trade & moving stop to BE+ 2 pips");
                     }
      }

Quoting amando77

Disliked

nothing run amok, fix your code

Ignored

Quoting pepperb

Disliked

{quote} Yes, I think it's obvious that my code needs fixing, thank you. That is why I created the post in the first place. If I knew what the problem was, I wouldn't be asking for help.

Ignored

Quoting eess

Disliked

{quote} When half of the order was closed, the order is still open, so as long as the order is still open and the criteria is met (Bid-OrderOpenPrice()>=tp1), it will keep executing that code, that's why it keeps halving your lots on every tick until it reaches 0.01.

Ignored

Quoting pepperb

Disliked

{quote} Well that's what I thought at first, so I put in the line about checking if the OrderOpenPrice was greater than the OrderStopLoss. Because after it executes the OrderClose, it does an OrderModify to move the Stop Loss 2 pips above the Open Price. So on the next loop, the OrderOpenPrice is no longer greater than the OrderStopLoss, so that should stop the loop, right?

Ignored

Quoting pepperb

Disliked

I reviewed the data from my terminal, and it is running the OrderClose function 3 times before it is executing the OrderModify, all in about 1.5~2 seconds. So I've added a Sleep(5000) function at the end of the loop. Hope that will at least give the OrderClose time to work and serve as a stopgap measure while I figure this out. it is moving the Stop Loss as it is supposed to...just not fast enough.

Ignored

OrderModify(OrderTicket(), OrderOpenPrice(), OrderOpenPrice() + breakevenPips, OrderTakeProfit(), 0,clrNONE);
OrderClose(OrderTicket(), OrderLots()/2, Bid, 3, clrNONE);

Quoting pepperb

Disliked

I coded a portion of my EA to close half my position when I get to TP1 and move my stop to breakeven + a certain amount of pips. And it does...over and over again! It closes half my position, then on the next tick, it closes half, and half, until it gets down to 0.01 lot size. And I'm not sure why. As part of my if hierarchy, i have it stop if the Stop Loss has been moved. It should close half the position, move the stop loss (which it does), and then stop. Here's the code: void CloseHalfTrade() { double tp2 = MathAbs(OrderTakeProfit() - OrderOpenPrice());...

Ignored

if(StringFind(OrderComment(), "from") == -1)