London close trading system for currencies | Page 103 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

HYBRID: trading system within a trading system 31 replies

London Rush - Breakout Trading System 18 replies

Trading from NY close to London open 14 replies

London close trading system for currencies is not reproducible 0 replies

Price Levels - Weekly High/Low, NY-Close, London Close 6 replies

Attachments: London close trading system for currencies
Exit Attachments

London close trading system for currencies

  • #2,041
  • Jul 5, 2019 10:51am Jul 5, 2019 10:51am
Quoting NewtonForex
{quote} A) I agree with you bad idea. Maybe profit lock but not trail. C) I will try another way. A cumulative TP/SL so it calculates the closed and the open trades P/L, commission and swap included. So give the single trades the normal SL/TP fib levels and then close open trades and pending orders when the total goal for the day is reached. The idea is to bank the pips continuously and close the Ea when the daily goal is reached. You prevent possible loss but also possible wins. Hard to say if good idea when have not tested it. Therefore good to...
A) no its not a bad idea, it can be easily done. The thing is that I would need to warn the trader that if they decide to use a BASKET trailing stop that all of the individual SL/TPs would be removed. Thus if your machine is turned off... well no TP/SL of any kind will be active. That is the risk. Although on the ccfp EA we do that all the time and no one has yet to experience anything like that. So the track record is good so far but ya still gotta warn them.

For those that are wonder what I mean by a BASKET Trail Stop. The ccfp EA has a feature that allows the user to have the EA treat a Basket of Trades as one single pair. So in that mode the EA can treat the BASKET as if it were one single trade and apply a TRAIL STOP to it just as if it were one pair.

One neat feature that I am considering to add is the virtual basket. This is where the user tells the EA to open a virtual basket of trades (based on the approach) and to monitor it for when it reaches certain Triggers. Think of those triggers as STOP or LIMIT ORDERS. Once those "triggers" are hit then the EA opens a REAL BASKET and from then on it monitors it for REAL profit.

C) That is correct. The EA will add up all of the profit (running or closed and including swap,commission) for Today's session and use that total to compare against what you entered in the basket TP/SL inputs. Once the total profit is reached the EA will then close any open trades and/or pending order (if any are still open). So it pretty much already does what you stated.

This is what I thought you were aiming at:

1. EA opens trades per rules
2. No individual SL/TPs are set
3. EA records the individual SL/TP levels in memory
4. EA monitors both the total basket and the individual trades profit movement
5. So if EA first detects that one of the individual trades has hit TP/SL, it then re-applies all of the TP/SLs to each of the individual trades.
EA stops monitoring profit cause now all pairs have their own TP/SLs. EA resets memory and done for the day
6. But if the EA detects that the basket total profit/stoploss was hit.. close all trades, reset memory, done for the day.


Yup, anything can be done . But, LOL do I have the time?... Maybe... We'll see.
J
Our AWESOME IMAGINATION is the true holy grail!
  • #2,042
  • Edited 11:12am Jul 5, 2019 11:02am | Edited 11:12am
Hi Xmess7,

Ok, used your latest EA v21, one EUR/USD market order and another EUR/USD buy limit order...or was there suppose to be others?

And to add..I used your EA v19 on another account, and it opened market sell orders for GBPAUD & GBPNZD and 2 sell limit orders on the same 2 pairs....on this account EURUSD did not open..
  • #2,043
  • Jul 5, 2019 11:08am Jul 5, 2019 11:08am
Quoting samuel84
Hi Xmess7, Ok, used your latest EA v21, one EUR/USD market order and another EUR/USD buy limit order...or was there suppose to be others?

Did you set the debug=true?
If you see my video I explain how to use the debug to check if the EA is operating properly.
With the debug=true the EA will report all that it "sees" as it is analyzing the fibs and conditions.
By looking at the expert log you can immediately see if the EA "missed" anything or if it opened it "incorrectly"
For example, before I release the EA I was seeing BIG TIME ISSUES with the dates that I got back from METATRADER.
That affected on which candle the EA would start to look for FIBS, obviously if the candle was from yesterday then that was incorrect...
Look at the video, I explain how to scan the logs quickly ....


Jess
Our AWESOME IMAGINATION is the true holy grail!
  • #2,044
  • Jul 5, 2019 11:12am Jul 5, 2019 11:12am
LondonClose EA

Ok, the fix on version 21 is working. Got 6 open trades with 6 limit orders
Hec even the minimum % looks right....

if you guys add up the profit in the trade terminal and compare it to the EA display you will see that it is a little different. That is cause the commission is included, it is turned from $ to pips and subtracted from the pip total.
Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot1.png Size: 62 KB
Our AWESOME IMAGINATION is the true holy grail!
  • #2,045
  • Jul 5, 2019 11:14am Jul 5, 2019 11:14am
Quoting samuel84
Hi Xmess7, Ok, used your latest EA v21, one EUR/USD market order and another EUR/USD buy limit order...or was there suppose to be others? And to add..I used your EA v19 on another account, and it opened 2 additional orders for GBPAUD & GBPNZD...on this account EURUSD did not open..
sam:
I don't recommend you use v19, version 21 got rid of a couple of bugs that version had.
Also, did you re-download version 21? I fond some errors after I had released it and if you downloaded that first copy you could be experiencing those bugs.

Jess
Our AWESOME IMAGINATION is the true holy grail!
  • #2,046
  • Jul 5, 2019 11:25am Jul 5, 2019 11:25am
Quoting xmess7
{quote} sam: I don't recommend you use v19, version 21 got rid of a couple of bugs that version had. Also, did you re-download version 21? I fond some errors after I had released it and if you downloaded that first copy you could be experiencing those bugs. Jess
ok, I didn't know v21 had 2 versions. I downloaded v21 minutes after u updated here.
On the debug, yes, I did switch on. On the trades I missed, it states Failed ADR test.
  • #2,047
  • Jul 5, 2019 11:32am Jul 5, 2019 11:32am
Quoting ghostbiker
I mean xmess7 EA you can download quality data by "dukascopy" with 99% for all 28 pairs and make all backtests for the 28 pairs with the rules if is possible
Ghost:
This can be done in MT5, but I did come up with an idea of how to do it in MT4, just to lazy to implement it LOL.
Well maybe not anymore cause on one project I added to the EA an offline chart. No graphics or chart just the data (OHLC datetime) was generated in the EA.
So think about it. I can do the exact same thing for the LondonClose EA. That is take data from any time period and added to the EA, it can also be from multiple symbols too. NOW that I can run in the strategy tester and get "back test" results .

But to say the truth I do not give much value to back testing. The data that is collected does not represent the REAL activity . Yes even if they claim 100% quality, I can show you many segments where the data is "missing". Plus I have yet to see any service provide the SPREADS of each of the instruments for each ticks. As you guys know spreads change and that is not included in the "quality data". And of course, as you guys saw the EA has to request many times OHLC datetime data from the MetaTrader server cause they do not provide the correct data and they even admit it. So how do we know that the tick data of those services is correct? We don't.

The best TESTING is FORWARD TESTING. True it takes longer but MAN that covers the REAL trading environment.

PEACE
J
Our AWESOME IMAGINATION is the true holy grail!
  • #2,048
  • Jul 5, 2019 11:37am Jul 5, 2019 11:37am
Quoting samuel84
{quote} ok, I didn't know v21 had 2 versions. I downloaded v21 minutes after u updated here. On the debug, yes, I did switch on. On the trades I missed, it states Failed ADR test.
Good Job Sam!

So if you want you can slap on an ADR indicator and compare with the result that the EA calculated. I may be a little different cause I have found out that programmer do it different but the adr value should be close.

you also do a search in the experts log with
"zones"
"Failed"
"adr"
"8 pip"
"TRADE"

That should let you see all of the key things that the EA determined.
Just remember you need to activate the VIEWER so you can SEARCH the terms. ITs easier that way instead of SCROLLING down thru the Expert logs.

Thnx
J
Our AWESOME IMAGINATION is the true holy grail!
  • #2,049
  • Jul 5, 2019 11:46am Jul 5, 2019 11:46am
Quoting xmess7
{quote} Good Job Sam! So if you want you can slap on an ADR indicator and compare with the result that the EA calculated. I may be a little different cause I have found out that programmer do it different but the adr value should be close. you also do a search in the experts log with "zones" "Failed" "adr" "8 pip" "TRADE" That should let you see all of the key things that the EA determined. Just remember you need to activate the VIEWER so you can SEARCH the terms. ITs easier that way instead of SCROLLING down thru the Expert logs. Thnx J
Noted, thanks..will analyze them...
  • #2,050
  • Jul 5, 2019 11:51am Jul 5, 2019 11:51am
@xmess7: we make only backtest for function not for win or loss in the past

4 orders today with London close EA
  • #2,051
  • Jul 5, 2019 3:16pm Jul 5, 2019 3:16pm
I saw profit and clicked the Close button. It greyed out but didn't close the trades.

It happened on both Forex.com and Oanda. I didn't get the latest V21 installed before 16:00 but it's installed for Monday.

Attached Image (click to enlarge)
Click to Enlarge Name: Oanda Close.PNG Size: 86 KB


Attached Image (click to enlarge)
Click to Enlarge Name: Forexcom Close.PNG Size: 79 KB
  • #2,052
  • Jul 5, 2019 3:40pm Jul 5, 2019 3:40pm
Quoting ghostbiker
@xmess7: we make only backtest for function not for win or loss in the past 4 orders today with London close EA
Good to know.. but for function you so no need 99% quality data. Good ole regular data will do ...
Our AWESOME IMAGINATION is the true holy grail!
  • #2,053
  • Jul 5, 2019 3:45pm Jul 5, 2019 3:45pm
Quoting Lotsa_PIPS
I saw profit and clicked the Close button. It greyed out but didn't close the trades. It happened on both Forex.com and Oanda. I didn't get the latest V21 installed before 16:00 but it's installed for Monday. {image} {image}
Interesting ... Very interesting... I'll take a look at the code...
It should grey out but when all trades are closed it will go back to normal color.
I used it the other day to close out the test trades I showed in the video and didn't have any issues. I'll check the code. Thnx

BTW did the expert log report any errors?? If the EA saw an error and froze then yes the same thing u saw would happen.

Please checkth log and let me know if it reported any errors.
Our AWESOME IMAGINATION is the true holy grail!
  • #2,054
  • Jul 5, 2019 4:01pm Jul 5, 2019 4:01pm
Quoting xmess7
{quote} Interesting ... Very interesting... I'll take a look at the code... It should grey out but when all trades are closed it will go back to normal color. I used it the other day to close out the test trades I showed in the video and didn't have any issues. I'll check the code. Thnx BTW did the expert log report any errors?? If the EA saw an error and froze then yes the same thing u saw would happen. Please checkth log and let me know if it reported any errors.
Thanks xmess7 - I just checked both Forex.com and Oanda Expert logs. The last message from the EA in both was from the 16:00 processing.
  • #2,055
  • Jul 5, 2019 8:04pm Jul 5, 2019 8:04pm
Quoting Lotsa_PIPS
{quote} Thanks xmess7 - I just checked both Forex.com and Oanda Expert logs. The last message from the EA in both was from the 16:00 processing.
did you check the Journal log?

I just tried to test the close button on the broker FXChoice and it turns out that all of the symbols are deactivated. So like you the CloseButton Froze and stayed grey.
While in the Journal Log all you saw was
Closing trade at 000.00000
Trade Disabled.

In this case the EA cannot do anything cause the MT server is the kulprit.

Let me know if you see the same thing in your Journal.

Look at the image. All of the symbols are grayed out. Which means that they are not activated.
You or any EA cannot do anything until the broker re actives them.
Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot1.png Size: 79 KB
Our AWESOME IMAGINATION is the true holy grail!
  • #2,056
  • Jul 5, 2019 8:19pm Jul 5, 2019 8:19pm
Quoting xmess7
{quote} did you check the Journal log? I just tried to test the close button on the broker FXChoice and it turns out that all of the symbols are deactivated. So like you the CloseButton Froze and stayed grey. While in the Journal Log all you saw was Closing trade at 000.00000 Trade Disabled. In this case the EA cannot do anything cause the MT server is the kulprit. Let me know if you see the same thing in your Journal. Look at the image. All of the symbols are grayed out. Which means that they are not activated. You or any EA cannot do anything...
Hello Xmess7 another observation. I was testing basket SL set to 1%. It closed the trades and pending when it reached 1% but one pending order did not close and was still open. I have not checked for error message. I did not use the lastes update on 21.
  • #2,057
  • Jul 5, 2019 8:29pm Jul 5, 2019 8:29pm
Quoting xmess7
{quote} did you check the Journal log? I just tried to test the close button on the broker FXChoice and it turns out that all of the symbols are deactivated. So like you the CloseButton Froze and stayed grey. While in the Journal Log all you saw was Closing trade at 000.00000 Trade Disabled. In this case the EA cannot do anything cause the MT server is the kulprit. Let me know if you see the same thing in your Journal. Look at the image. All of the symbols are grayed out. Which means that they are not activated. You or any EA cannot do anything...
The last messages I saw in the Journal were for order placement.

Perhaps I wasn't patient enough (although it felt like an eternity lol).

When the market opens on Sunday I will run a test by changing the Open Trade Time to initiate some trades then I will use the Close button to close them.
  • #2,058
  • Edited 8:43pm Jul 5, 2019 8:29pm | Edited 8:43pm
Quoting NewtonForex
{quote} Hello Xmess7 another observation. I was testing basket SL set to 1%. It closed the trades and pending when it reached 1% but one pending order did not close and was still open. I have not checked for error message. I did not use the lastes update on 21.
Now I found the log. There were 5 limits order but EA only sent request for closing 4 - Limitorder NZDCAD is missing.

19:14:07.280 xm7_LondonClose_v21 EURUSD,M15: close #80081267 buy 0.10 EURUSD at 1.12154 sl: 1.11884 tp: 1.12264 at price 1.12201
2 19:14:07.952 xm7_LondonClose_v21 EURUSD,M15: close #80081313 buy 0.10 NZDCAD at 0.86731 sl: 0.86505 tp: 0.86841 at price 0.86686
2 19:14:08.233 xm7_LondonClose_v21 EURUSD,M15: close #80081306 sell 0.10 GBPNZD at 1.89016 sl: 1.89393 tp: 1.88829 at price 1.89120
2 19:14:09.093 xm7_LondonClose_v21 EURUSD,M15: close #80081290 sell 0.10 USDCHF at 0.99239 sl: 0.99527 tp: 0.99117 at price 0.99240
2 19:14:09.952 xm7_LondonClose_v21 EURUSD,M15: delete #80081324 sell limit 0.10 GBPAUD at 1.79571 sl: 1.79849 tp: 1.79324 ok
2 19:14:10.861 xm7_LondonClose_v21 EURUSD,M15: delete #80081275 buy limit 0.10 EURUSD at 1.12056 sl: 1.11819 tp: 1.12264 ok
2 19:14:11.626 xm7_LondonClose_v21 EURUSD,M15: delete #80081297 sell limit 0.10 USDCHF at 0.99339 sl: 0.99599 tp: 0.99117 ok
2 19:14:11.876 xm7_LondonClose_v21 EURUSD,M15: delete #80081308 sell limit 0.10 GBPNZD at 1.89117 sl: 1.89491 tp: 1.88829 ok
2 19:14:12.861 xm7_LondonClose_v21 EURUSD,M15: close #80081323 sell 0.10 GBPAUD at 1.79475 sl: 1.79772 tp: 1.79324 at price 1.79474


And settings
MagicNumber=2147483647 GMT_TradeTime=16:00 FibCandleCountsBack=72 _Pairs_To_Trade=-------------------------------------------- PairsToTrade=EURUSD,GBPUSD,USDCHF,USDJPY,AUDUSD,USDCAD,EURAUD,EURCHF,EURGBP,GBPNZD,EURJPY,GBPCHF,GBPJPY,AUDCAD,AUDCHF,AUDJPY,AUDNZD,CADCHF,CADJPY,CHFJPY,EURCAD,EURNZD,NZDCAD,NZDCHF,NZDJPY,NZDUSD,GBPAUD,GBPCAD _Fibo_Levels=---------------------------------------------- Fibo_Levels=-0.382,-0.318,-0.236,0.000,0.236,0.764,1.000,1.236,1.318,1.382 doNotSetAnyTPs_SLs=false moneyManagement= ==== Set Money Management =+== LotSizing=0 FixedLotSize=0.1 Lots_Per_Balance=0.01/1000 percentRisk=2.0 Slippage=3 manualSLTP= ==== Set Individual SL/TP Manually =+== StopLoss=0.0 TakeProfit=0.0 profitAsBasket= ==== Monitor Profit Basket =+== useProfitIn=0 basketStopLoss=1.0 basketTakeProfit=0.0 Filter= ==== Additional Filters =+== minPipRequired=8.0 maxSPREAD=6.0 ADR_Period=7 minADR=50.0 EAcontinueNoOpnTrades=true Debug= ==== EA Debugging === debug=true
  • #2,059
  • Edited 11:46pm Jul 5, 2019 8:51pm | Edited 11:46pm
EA UPDATE VERSION 22

Please update to this version before trying to find bugs

version 22 is released
https://github.com/xmess7/LondonCloseEA

and this is my experience of what iis happening with the close button:

Inserted Video


Thnx for the reports...

EDIT: I AM AN IDIOT!!! LOL..
The reason I could not close the trades is because the MARKET IS CLOSED!!!!!!!!!!!!!!!!!!
Geez I am so busy I don't know what DAY it is! LOL.
Attached File(s)
File Type: txt POST_WITH_LONDONCLOSE_EA_UPGRADE.txt   < 1 KB | 188 downloads
Our AWESOME IMAGINATION is the true holy grail!
  • #2,060
  • Jul 5, 2019 9:43pm Jul 5, 2019 9:43pm
Quoting xmess7
{quote} A) no its not a bad idea, it can be easily done. The thing is that I would need to warn the trader that if they decide to use a BASKET trailing stop that all of the individual SL/TPs would be removed. Thus if your machine is turned off... well no TP/SL of any kind will be active. That is the risk. Although on the ccfp EA we do that all the time and no one has yet to experience anything like that. So the track record is good so far but ya still gotta warn them. For those that are wonder what I mean by a BASKET Trail Stop. The ccfp EA has...
1. Basket trailing stop, I will not use because indivdual SL/TP would be removed. Maybe a breakeven or profitlock.

2. C) That is correct. The EA will add up all of the profit (running or closed and including swap,commission) for Today's session and use that total to compare against what you entered in the basket TP/SL inputs. - This is the way I hoped it would work so no changes because of me please!!!.

3. I thougt so, it is a huge challenge to backtest. I just hoped we could narrow the forward test arrea of interest.
0 traders viewing now