Need help on this indicator

input bool D_MACD = false;//DAILY MACD
input bool H4_MACD = false;//H4 MACD
input bool H1_MACD = false;//H1 MACD
input bool M30_MACD = false;//M30 MACD
input bool M15_MACD = false;//M15 MACD
input bool M5_MACD = false;//M5 MACD
input bool M1_MACD = false;//M1 MACD

      if(
         (D_MACD && iMACD(_Symbol,PERIOD_D1,macd_fast,macd_slow,macd_sma,macd_price,MODE_MAIN,iBarShift(_Symbol,PERIOD_D1,Time[i]))>0.0) &&
         (H4_MACD && iMACD(_Symbol,PERIOD_H4,macd_fast,macd_slow,macd_sma,macd_price,MODE_MAIN,iBarShift(_Symbol,PERIOD_H4,Time[i]))>0.0) &&
         (H1_MACD && iMACD(_Symbol,PERIOD_H1,macd_fast,macd_slow,macd_sma,macd_price,MODE_MAIN,iBarShift(_Symbol,PERIOD_H1,Time[i]))>0.0) &&
         (M30_MACD && iMACD(_Symbol,PERIOD_M30,macd_fast,macd_slow,macd_sma,macd_price,MODE_MAIN,iBarShift(_Symbol,PERIOD_M30,Time[i]))>0.0) &&
         (M15_MACD && iMACD(_Symbol,PERIOD_M15,macd_fast,macd_slow,macd_sma,macd_price,MODE_MAIN,iBarShift(_Symbol,PERIOD_M15,Time[i]))>0.0) &&
         (M5_MACD && iMACD(_Symbol,PERIOD_M5,macd_fast,macd_slow,macd_sma,macd_price,MODE_MAIN,iBarShift(_Symbol,PERIOD_M5,Time[i]))>0.0) &&
         (M1_MACD && iMACD(_Symbol,PERIOD_M1,macd_fast,macd_slow,macd_sma,macd_price,MODE_MAIN,iBarShift(_Symbol,PERIOD_M1,Time[i]))>0.0) &&
         )
        {ArrDnBuffer[i]=iLow(_Symbol,_Period,i)+10*pix_y();}

Quoting SLaKerZ

Disliked

Hi, I'm trying to create an indicator but having problem on this part Basically i have few rules input bool D_MACD = false;//DAILY MACD input bool H4_MACD = false;//H4 MACD input bool H1_MACD = false;//H1 MACD input bool M30_MACD = false;//M30 MACD input bool M15_MACD = false;//M15 MACD input bool M5_MACD = false;//M5 MACD input bool M1_MACD = false;//M1 MACD ------------------------------------------------------------------ if( (D_MACD && iMACD(_Symbol,PERIOD_D1,macd_fast,macd_slow,macd_sma,macd_price,MODE_MAIN,iBarShift(_Symbol,PERIOD_D1,Time))>0.0)...

Ignored

if(
(!D_MACD || iMACD(_Symbol,PERIOD_D1,macd_fast,macd_slow,macd_sma,macd_price,MODE_MAIN,iBarShift(_Symbol,PERIOD_D1,Time[i]))>0.0) &&
(!H4_MACD || iMACD(_Symbol,PERIOD_H4,macd_fast,macd_slow,macd_sma,macd_price,MODE_MAIN,iBarShift(_Symbol,PERIOD_H4,Time[i]))>0.0) &&
(!H1_MACD || iMACD(_Symbol,PERIOD_H1,macd_fast,macd_slow,macd_sma,macd_price,MODE_MAIN,iBarShift(_Symbol,PERIOD_H1,Time[i]))>0.0) &&
(!M30_MACD || iMACD(_Symbol,PERIOD_M30,macd_fast,macd_slow,macd_sma,macd_price,MODE_MAIN,iBarShift(_Symbol,PERIOD_M30,Time[i]))>0.0) &&
(!M15_MACD || iMACD(_Symbol,PERIOD_M15,macd_fast,macd_slow,macd_sma,macd_price,MODE_MAIN,iBarShift(_Symbol,PERIOD_M15,Time[i]))>0.0) &&
(!M5_MACD || iMACD(_Symbol,PERIOD_M5,macd_fast,macd_slow,macd_sma,macd_price,MODE_MAIN,iBarShift(_Symbol,PERIOD_M5,Time[i]))>0.0) &&
(!M1_MACD || iMACD(_Symbol,PERIOD_M1,macd_fast,macd_slow,macd_sma,macd_price,MODE_MAIN,iBarShift(_Symbol,PERIOD_M1,Time[i]))>0.0)  )
{ArrDnBuffer[i]=iLow(_Symbol,_Period,i)+10*pix_y();}

Quoting SLaKerZ

Disliked

Sir FerruFx Thank you so much for the 2nd guidance from you... Appreciate it sir.. Will test it out

Ignored

Quoting SLaKerZ

Disliked

Hi Sir FeruFX, What do i need to add in to the indicator so that it will be able to work on broker that is using prefix? Thank you Hi Sir Rockit, A good idea too... will try both to gain learning experience... thank you

Ignored

Quoting SLaKerZ

Disliked

Rockit, A good idea too... will try both to gain learning experience... thank you

Ignored

Quoting rockit

Disliked

{quote} And you should because I think FerruFX's code does not deliver. Here is why: The inner or operator reqires only one of its operands to result true (thus both will be checked) in order to render the condition true, making the switch* irrelevant in the case the indicator check results true. And likewise, making the indicator check irrelevant in the case the switch results true.. What is more, he inverts the switch, so that the condition renders true(!) when the switch is set to false.. Could not be more wrong. Here an example: Suppose you...

Ignored

Quoting FerruFx

Disliked

{quote} With all due respect, you are wrong ...

Ignored

#property strict
void OnStart()
{
    bool sw = false;
    double f = -1;
    if(!sw || f > 0)
        Print("rockit is right!");
    else
        Print("rockit is wrong indeed..");
}

Quoting rockit

Disliked

{quote} No problem. Can you state your reasoning, please? Here is a test script: #property strict void OnStart() { bool sw = false; double f = -1; if(!sw || f > 0) Print("rockit is right!"); else Print("rockit is wrong indeed.."); }

Ignored

extern string pairs="AUDUSD,AUDJPY,CADJPY,CADCHF,CHFJPY

   Background_Color=(color)ChartGetInteger(0,CHART_COLOR_BACKGROUND);
   pairs = StringTrimLeft(pairs);
   pairs = StringTrimRight(pairs);
   while(true && !IsStopped())
     {
      if(StringSubstr(pairs,StringLen(pairs)-1)==",")
         pairs=StringSubstr(pairs,0,StringLen(pairs)-1);
      else break;
     }
   int pos=0,p=1;
   while(true && !IsStopped())
     {
      pos=StringFind(pairs,",",0);
      ArrayResize(pair,p,100);
      pair[p-1]=StringTrimLeft(StringTrimRight(StringSubstr(pairs,0,pos)));
      pairs=StringSubstr(pairs,pos+1);
      if(pos<1)break;
      p++;
     }

Quoting FerruFx

Disliked

So my solution check only the selected MACDs and give the final result = true only if the selected MACDs validate the condition.

Ignored

Quoting rockit

Disliked

{quote} Yes, I see now. I agree. Please excuse my ignorance. However, there is one special case: if non are selected (will evaluate to true nevertheless), but I guess that this special case is not intended.

Ignored

Quoting One day!

Disliked

Thanks FerruFx and rockit for that discussion. I was struggling with the logic, until I came across precedence rules. It all makes sense now. A couple of links for anyone like me: http://www.cplusplus.com/doc/tutorial/operators/ & https://docs.mql4.com/basis/operations/rules

Ignored