EDSTO Expert Advisor - Proof of concept

Quoting jansb000

Disliked

This thread will discuss the development of a new Expert Advisor based on two indicators. A) Entry Detection (CO_NL_BB_SMA_ENTRY_DETECTION) B) Stochastics (the MT4 build-in version) This proof of concept is based on ideas that came up in the thread LRSF - TMS Expert Advisor. (https://www.forexfactory.com/showthread.php?t=723493). The used indicators (and the way we want to use them) are not compatible with the Trading Made Simple strategy so we decided to move this proof-of-concept (POC) to its own thread. This project will deliver an...

Ignored

Quoting jansb000

Disliked

This thread will discuss the development of a new Expert Advisor based on two indicators. A) Entry Detection (CO_NL_BB_SMA_ENTRY_DETECTION) B) Stochastics (the MT4 build-in version) This proof of concept is based on ideas that came up in the thread LRSF - TMS Expert Advisor. (https://www.forexfactory.com/showthread.php?t=723493). The used indicators (and the way we want to use them) are not compatible with the Trading Made Simple strategy so we decided to move this proof-of-concept (POC) to its own thread. This project will deliver an...

Ignored

Quoting MariaEduard

Disliked

{quote} Is this indicator work on all kind of trading pair? Or any limitation actually?

Ignored

Quoting wifiguy

Disliked

{quote} This indicator might be of interest to you. I believe it is what your indicator originated from. It has more settings options and it is MQ4. They both repaint but this one it seems a little less. {file}

Ignored

//+------------------------------------------------------------------+
//|                                                     edsto_ea.mq4 |
//|                        Copyright 2018, MetaQuotes Software Corp. |
//|                                             https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "Copyright 2018, edsto developer team."
#property link      "https://www.forexfactory.com/showthread.php?p=11316640#post11316640"
#property version   "1.00"
#property strict

#property description "An Expert Advisor (EA) that follows the rules from"
#property description "Trading Made Simple (TMS). This EA tries to catch"
#property description "Heiken Ashi sequences based on the crossing of the"
#property description "TDI Red and Green."

//+------------------------------------------------------------------+
//| Expert initialization function                                   |
//+------------------------------------------------------------------+
int OnInit()
  {
//--- create timer
   EventSetTimer(60);
      
//---
   return(INIT_SUCCEEDED);
  }
  
//+------------------------------------------------------------------+
//| Expert deinitialization function                                 |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
  {
//--- destroy timer
   EventKillTimer();
      
  }

//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick()
  {
//---
  
  }
  
//+------------------------------------------------------------------+
//| Timer function                                                   |
//+------------------------------------------------------------------+
void OnTimer()
  {
//---
  
  }
  
//+------------------------------------------------------------------+

Quoting jansb000

Disliked

In terms of software-projects, a proof-of-concept is a minimalistic piece of software that works, but has no other goal then to decide if certain assumptions work in practice or at least show so much promise that you can make a well founded decision on how to proceed to a next level. If we want to add to much functionality from the start there is a big risk that we spend loads of time to get the extra functionality working while we forget what it actually was that we wanted to prove. In that sense I propose to start as simple as possible and then...

Ignored

Quoting jansb000

Disliked

I wonder if this team function for MT4 is actually still supported. Although the helpfile from MT4 and MetaEditor mention it, and I can create a new project. I can not find any support for it on the community website. It's only MT5 that they seem to be supporting. Whatever link I click I always end up being redirected to MT5 content. Pffff.

Ignored

Quoting J1mm

Disliked

{quote} You are right, let's start small, but let's remove Entry Detection from our Scope HAHA

Ignored

//+------------------------------------------------------------------+
//|                                     cl_entry_detection_basis.mqh |
//|                                     Copyright 2018, BI-Magnet BV |
//|                                          http://www.bi-magnet.nl |
//+------------------------------------------------------------------+
/*--
 * The entry-detection indicator can effectively show when to enter
 * a new trade. The source-code is unknown, but the indicator is so
 * good that we take that for granted.
 *
 * +-----------------------------------------------------------------+
 * 25-03-2017 Version 1.00
 * Initial version
 * +--------------------------------------------------------------+ */
 
#property copyright "Copyright 2018, BI-Magnet BV"
#property link      "http://www.bi-magnet.nl"
#property version   "1.00"
#property strict
 
enum MODE_ED {
   ED_TRIGGER  = 0, // TRIGGER - Grey
   ED_SIGNAL   = 1, // SIGNAL  - Yellow
   ED_ZONE_HI  = 2, // BB HI   - Medium Blue
   ED_ZONE_LO  = 3  // BB LO   - Medium Blue  
};
 
// It's a custom indicator so we include the exact name
const string cED_IndicatorName = "bim\\tms\\CO_NL_BB_SMA_ENTRY_DETECTIONS";
      
// A structure for holding all values      
struct ED_VALUES {
   double trigger;
   double signal;  
   double zone_high;
   double zone_low;
};
      
class cl_ed_basis {
   private:      
      // Parameters for iCustom
      string            _symbol;
      ENUM_TIMEFRAMES   _tframe;
      int               _mode;
      //int               _shift;
      
      // Parameters for the Indicator
      int               _bb_period;      // BB up period (20)
      int               _bb_deviation;   // BB up deviation (2)
      int               _signal_period;  // Signal period (3)
      int               _signal_method;  // Signal method (SMA=0)
      bool              _alrt_use;       // Use alerts (false)  
      bool              _alrt_show;      // Arrows visible (false)
      string            _alrt_file;      // Alert sound (alert2.wav)    
      string            _alrt_id;        // Arrows id (CO_NL_BB_SMA_ENTRY_DETECTIONS)
              
   public:
      cl_ed_basis() { clear(); }
      cl_ed_basis(string &isym, ENUM_TIMEFRAMES itf);
      ~cl_ed_basis() {}
      
      void clear();
      void setup(const string isym, const ENUM_TIMEFRAMES itf,
                 const int i_bbper, const int i_bbdev,
                 const int i_sigper, const int i_sigmethod,
                 const bool i_alrt_use, const bool i_alrt_show,
                 const string &i_alrt_file, const string &i_alrt_id);
      
      // Setters
      void set_symbol(const string &symbol)     { _symbol = symbol; }
      void set_tframe(const ENUM_TIMEFRAMES tf) { _tframe = tf; }
      void set_mode(const int mode)             { _mode   = mode; }
        
      // Setters specific to this indicator
      void set_bb_period(const int p)           { _bb_period      = p;  }
      void set_bb_deviation(const int d)        { _bb_deviation   = d;  }
      void set_sig_period(const int p)          { _signal_period  = p;  }
      void set_sig_method(const int m)          { _signal_method  = m;  }      
      void set_alrt_use(const bool ua)          { _alrt_use       = ua; }      
      void set_alrt_show(const bool sa)         { _alrt_show      = sa; }
      void set_alrt_file(const string &fa)      { _alrt_file      = fa; }
      void set_alrt_id(const string &id)        { _alrt_id        = id; }
      
      // Getters
      string            get_symbol()           const { return _symbol; }
      ENUM_TIMEFRAMES   get_tframe()           const { return _tframe; }
      int               get_mode()             const { return _mode;   }
 
      // Getters specific to this indicator
      int               get_bb_period()        const { return _bb_period;     }
      int               get_bb_deviation()     const { return _bb_deviation;  }
      int               get_sig_period()       const { return _signal_period; }
      int               get_sig_method()       const { return _signal_method; }
      bool              get_alrt_use()         const { return _alrt_use;      }
      bool              get_alrt_show()        const { return _alrt_show;     }
      string            get_alrt_file()        const { return _alrt_file;     }
      string            get_alrt_id()          const { return _alrt_id;       }
        
      // Checkers
      bool check_indi();    
      
      // Basic functions      
      double value(const string sym, const ENUM_TIMEFRAMES tf, const MODE_ED mode, const int i_shift=0) const;
      double value(const ENUM_TIMEFRAMES tf, const MODE_ED mode, const int i_shift=0) const;
      double value(const MODE_ED i_mode, const int i_shift=0) const;
      
      void all_values(const string i_sym, const ENUM_TIMEFRAMES i_tf, const int i_shift, ED_VALUES &i_vals);
      void all_values(const ENUM_TIMEFRAMES i_tf, const int i_shift, ED_VALUES &i_vals);
      void all_values(const int i_shift, ED_VALUES &i_vals);
};
 
//---------------------------------------------------------------------  
void cl_ed_basis::setup(const string isym, const ENUM_TIMEFRAMES itf,
           const int i_bbper, const int i_bbdev,
           const int i_sigper, const int i_sigmethod,
           const bool i_alrt_use, const bool i_alrt_show,
           const string &i_alrt_file, const string &i_alrt_id) {
          
   // Parameters for the iCustom command
   _symbol = isym;
   _tframe = itf;
   _mode   = 0;
   //_shift  = 0;
  
   // Parameters for the Indicator
   _bb_period     = i_bbper;
   _bb_deviation  = i_bbdev;
   _signal_period = i_sigper;
   _signal_method = i_sigmethod;
   _alrt_use      = i_alrt_use;
   _alrt_show     = i_alrt_show;
   _alrt_file     = i_alrt_file;
   _alrt_id       = i_alrt_id;          
}          
                
// Fill the values with default values
void cl_ed_basis::clear() {
   string alrt_file = "alert2.wav";
   string alrt_id   = "CO_NL_BB_SMA_ENTRY_DETECTIONS";
   setup(_Symbol, PERIOD_CURRENT, 20, 2, 3, 0, false, false, alrt_file, alrt_id);
}
 
//---------------------------------------------------------------------
 
cl_ed_basis::cl_ed_basis(string &isym, ENUM_TIMEFRAMES itf) {
   clear();
  
   // Minimal set of parameters.
   // Usually most other parameters will remain default.
   _symbol = isym;
   _tframe = itf;
   //_shift  = ishft;
}
 
// Test if the custom indicator works.
// Call it AFTER setup.
// 4055 = ERR_CUSTOM_INDICATOR_ERROR
// 4071 = ERR_INDICATOR_CANNOT_INIT
// 4072 = ERR_INDICATOR_CANNOT_LOAD
// 4075 = ERR_NO_MEMORY_FOR_INDICATOR
bool cl_ed_basis::check_indi() {
   ResetLastError();
   double x = value(ED_SIGNAL, 0);
   int error = GetLastError();
   if (error == 4055 || error == 4071 || error == 4072 || error == 4075) return true;
   return false;
}
 
double cl_ed_basis::value(
   const string            i_sym,     // Symbol
   const ENUM_TIMEFRAMES   i_tf,      // Timeframe
   const MODE_ED           i_mode,    // Mode
   const int               i_shft=0  // Bar shift
) const {
   return iCustom(
      // Parameters for iCustom
      i_sym, i_tf, cED_IndicatorName,
      
      // Parameters for the Indicator
      _bb_period,       // BB up period (20)
      _bb_deviation,    // BB up deviation (2)
      _bb_period,       // BB dn period (20)
      _bb_deviation,    // BB dn deviation (2)
      _signal_period,   // Signal period (3)
      _signal_method,   // Signal method (SMA=0)
      _alrt_use,        // Use alerts (false)
      _alrt_file,       // Alert sound (alert2.wav)
      _alrt_show,       // Arrows visible (false)
      _alrt_id,         // Arrows id (CO_NL_BB_SMA_ENTRY_DETECTIONS)
      
      // Parameters for iCustom
      (int)i_mode, i_shft
   );      
}
 
// Medium version of the standard value
double cl_ed_basis::value(const ENUM_TIMEFRAMES i_tf, const MODE_ED i_mode, const int i_shift=0) const {
   return value(_symbol, i_tf, i_mode, i_shift);
}
 
// Short version of the standard value
double cl_ed_basis::value(const MODE_ED i_mode, const int i_shift=0) const {
   return value(_symbol, _tframe, i_mode, i_shift);
}
  
// Collect all TDI values in one go - long version
void cl_ed_basis::all_values(const string i_sym, const ENUM_TIMEFRAMES i_tf, const int i_shft, ED_VALUES &i_vals) {
   i_vals.zone_high  = value(i_sym, i_tf, ED_ZONE_HI, i_shft);
   i_vals.zone_low   = value(i_sym, i_tf, ED_ZONE_LO, i_shft);
   i_vals.signal     = value(i_sym, i_tf, ED_TRIGGER, i_shft);
   i_vals.trigger    = value(i_sym, i_tf, ED_SIGNAL,  i_shft);
}
 
// Collect all TDI values in one go - medium version
void cl_ed_basis::all_values(const ENUM_TIMEFRAMES i_tf, const int i_shft, ED_VALUES &i_vals) {
   all_values(_symbol, i_tf, i_shft, i_vals);
}
 
// Collect all TDI values in one go - short version  
void cl_ed_basis::all_values(const int i_shft, ED_VALUES &i_vals) {
   all_values(_symbol, _tframe, i_shft, i_vals);
}

Quoting J1mm

Disliked

{quote} You are right, let's start small, but let's remove Entry Detection from our Scope HAHA

Ignored

Quoting wifiguy

Disliked

{quote}...but combined with another indicator it can work very well...

Ignored

Quoting wifiguy

Disliked

{quote}...it repaints like crazy...

Ignored