Why this GMT Code doesn't work

#property indicator_chart_window
#property indicator_buffers 7
#property indicator_color1 Yellow
#property indicator_color2 Aqua
#property indicator_color3 Aqua
#property indicator_color4 Snow
#property indicator_color5 Snow
#property indicator_color6 Red
#property indicator_color7 Red

//---- buffers
double P1Buffer[];
double P2Buffer[];
double P3Buffer[];
double P4Buffer[];
double P5Buffer[];
double P6Buffer[];
double P7Buffer[];

extern int StartHour=0;
int myPeriod=PERIOD_D1;

double PP,R1,S1,R2,S2,R3,S3,Q,DQ;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
   SetIndexBuffer(0,P1Buffer);
   SetIndexBuffer(1,P2Buffer);
   SetIndexBuffer(2,P3Buffer);
   SetIndexBuffer(3,P4Buffer);
   SetIndexBuffer(4,P5Buffer);
   SetIndexBuffer(5,P6Buffer);
   SetIndexBuffer(6,P7Buffer);

   SetIndexStyle(0,DRAW_LINE,2,2,Yellow);
   SetIndexStyle(1,DRAW_LINE,2,2,Aqua);
   SetIndexStyle(2,DRAW_LINE,2,2,Aqua);
   SetIndexStyle(3,DRAW_LINE,2,1,Snow);
   SetIndexStyle(4,DRAW_LINE,2,1,Snow);
   SetIndexStyle(5,DRAW_LINE,2,2,Red);
   SetIndexStyle(6,DRAW_LINE,2,2,Red);
  
   
   return(0);
  }
//+------------------------------------------------------------------+
//| Custor indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
   ObjectDelete("DayP");
   ObjectDelete("DayR1");
   ObjectDelete("DayR2");
   ObjectDelete("DayR3");
   ObjectDelete("DayS1");
   ObjectDelete("DayS2");
   ObjectDelete("DayS3");
   ObjectDelete("txtDayP");
   ObjectDelete("txtDayR1");
   ObjectDelete("txtDayR2");
   ObjectDelete("txtDayR3");
   ObjectDelete("txtDayS1");
   ObjectDelete("txtDayS2");
   ObjectDelete("txtDayS3");
   Comment("");
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
   int i, dayi, counted_bars = IndicatorCounted();
//---- check for possible errors
   if(counted_bars < 0) 
       return(-1);
//---- last counted bar will be recounted
   if(counted_bars > 0) 
       counted_bars--;  
   int limit = Bars - counted_bars;
//----   
   for(i = limit - 1; i >= 0; i--)
     {
int day = TimeDayOfWeek( Time[i] );
int hour = TimeHour( Time[i] );
int minute = TimeMinute( Time[i] );
//if ( i < 20 ) Print( i, " day=", day, " hour=", hour, " min=",minute );
if (day != 0 && day != 6 && hour == StartHour && minute == 0)

       dayi = iBarShift(Symbol(), myPeriod, Time[i], false);
       Q = iHigh(Symbol(), myPeriod,dayi+1) - iLow(Symbol(), myPeriod,dayi+1);        
       PP=(iHigh(Symbol(), myPeriod,dayi+1) + 
           iLow(Symbol(), myPeriod,dayi+1) +
           iClose(Symbol(), myPeriod,dayi+1)+
           iClose(Symbol(), myPeriod,dayi+1)) / 4;
                     
           
       R1 = (2*PP)-iLow(Symbol(), myPeriod,dayi+1);
       S1 = (2*PP)-iHigh(Symbol(), myPeriod,dayi+1);
       R2 = PP+Q;
       S2 = PP-Q;
       R3 = (2*PP)+(iHigh(Symbol(), myPeriod,dayi+1)-(2*iLow(Symbol(), myPeriod,dayi+1)));
       S3 = (2*PP)-(2*iHigh(Symbol(), myPeriod,dayi+1)-iLow(Symbol(), myPeriod,dayi+1));

       P1Buffer[i]=PP;
       SetPrice("DayP",Time[i],PP,Yellow);
       SetText("txtDayP","P",Time[i],PP,Yellow);

       P2Buffer[i]=R1;
       SetPrice("DayR1",Time[i],R1,Aqua);
       SetText("txtDayR1","R1",Time[i],R1,Aqua);

       P3Buffer[i]=S1;
       SetPrice("DayS1",Time[i],S1,Aqua);
       SetText("txtDayS1","S1",Time[i],S1,Aqua);

       P4Buffer[i]=R2;
       SetPrice("DayR2",Time[i],R2,Snow);
       SetText("txtDayR2","R2",Time[i],R2,Snow);

       P5Buffer[i]=S2;
       SetPrice("DayS2",Time[i],S2,Snow);
       SetText("txtDayS2","S2",Time[i],S2,Snow);

       P6Buffer[i]=R3;
       SetPrice("DayR3",Time[i],R3,Red);
       SetText("txtDayR3","R3",Time[i],R3,Red);

       P7Buffer[i]=S3;
       SetPrice("DayS3",Time[i],S3,Red);
       SetText("txtDayS3","S3",Time[i],S3,Red);

    }
//----
   return(0);
  }

void SetPrice(string name,datetime Tm,double Prc,color clr)
  {
   if(ObjectFind(name) == -1)
     {
       ObjectCreate(name, OBJ_ARROW, 0, Tm, Prc);
       ObjectSet(name, OBJPROP_COLOR, clr);
       ObjectSet(name, OBJPROP_WIDTH, 1);
       ObjectSet(name, OBJPROP_ARROWCODE,SYMBOL_RIGHTPRICE);
     }
   else
     {
       ObjectSet(name, OBJPROP_TIME1, Tm);
       ObjectSet(name, OBJPROP_PRICE1, Prc);
       ObjectSet(name, OBJPROP_COLOR, clr);
       ObjectSet(name, OBJPROP_WIDTH, 1);
       ObjectSet(name, OBJPROP_ARROWCODE,SYMBOL_RIGHTPRICE);
     } 
  }

void SetText(string name,string txt,datetime Tm,double Prc,color clr)
  {
   if(ObjectFind(name) == -1)
     {
       ObjectCreate(name, OBJ_TEXT, 0, Tm, Prc);
       ObjectSetText(name,txt, 8, "Arial", clr);
       ObjectSet(name, OBJPROP_CORNER,2);
     }
   else
     {
       ObjectSet(name, OBJPROP_TIME1, Tm);
       ObjectSet(name, OBJPROP_PRICE1, Prc);
       ObjectSetText(name,txt, 8, "Arial", clr);
       ObjectSet(name, OBJPROP_CORNER,2);
     } 
  }

//+------------------------------------------------------------------+

Quoting Siro

Disliked

the problem is, that the indicator calculates the pivots based on the daily candles, so the high,low, close values and therefore the pivots will be always the same.

you need a loop, that searches every day for the selected period's high, low and close on an hourly chart.
for example if you use StartHour=1 the loop should start at the previous day's 01:00 candle, and go until today 01:00 on an hourly chart. in the loop you have to use a maximum and a minimum selection so you get the the high and low values for the selected period. the close is the last candle's close value, so today's 01:00 candle's close.
then use these values at the pivot points calculation.

but maybe there is an indicator somewhere that calculates the pivots this way and works properly.

Ignored

Quote

Disliked

but maybe there is an indicator somewhere that calculates the pivots this way and works properly