Custom Indicator - Draw Arrow and Close Price Line

int OnCalculate(...)
  {
//---
   int limit=rates_total-prev_calculated;
   if(rates_total<=maPeriod) return(0);
   if(prev_calculated>0) limit++;
   for(i=limit-1; i>=0; i--)
     {
      // Line - this is works perfect for me.
      maOne[i] = iMA( Symbol(), 0, 13, 0, MODE_SMA, PRICE_MEDIAN, 0 );
      maTwo[i] = iMA( Symbol(), 0, 26, 0, MODE_SMA, PRICE_MEDIAN, 0 );
      priceOne = maOne[i];
      priceTwo = maTwo[i];
 
      // Arrow - this fills tons of arrows but I need only one for first bar.
      if  ( priceOne > priceTwo )
      {
        drawArrow_one[i] = Low[i + 1] - 10 * Point;
      }
     }
     return(rates_total);
  }

Quoting FerruFx

Disliked

The arrow drawn only after a cross of your 2 MAs ... A cross is defined by 4 points ... You took only the 2 points after the cross (priceOne > priceTwo). If you add to this condition that the previous 2 MAs points weren't giving the same condition, then the cross is defined. Food for thought!

Ignored

// Arrow
if( priceOne > priceTwo && previous_priceOne <= previous_priceTwo )
{
 drawArrow_one[i] = Low[i + 1] - 10 * Point;
}

Quoting FerruFx

Disliked

The conditions you defined allow these 2 dots ... You will have to change your conditions according to your exact need.

Ignored

Quoting MaxEnrik

Disliked

I use below code, but I have not any ideas that I solve my issue, can you let me know that how can I do that, please? // Arrow if( priceOne > priceTwo && previous_priceOne <= previous_priceTwo ) { drawArrow_one[i] = Low[i + 1] - 10 * Point; } {quote}

Ignored

Quoting FerruFx

Disliked

{quote} Then the dots are plotted because you have a cross of the 2 MAs ... Assuming your MAs values are well calculated (you didn't copied them). Why don't you plot these MAs on your chart so to have the right visual of what is occuring ?

Ignored

Quoting MaxEnrik

Disliked

I hope I understand your comment correctly. Now I need to say I like clean chart, I do not like a bunch of things on my chart. ( tons of things distracting me ) Clean chart helps me staying right way ( Trend ). Now I really need to remove all of previous dots. ( also I will add few objects that single dots ) Help me, please. {quote}

Ignored

//+------------------------------------------------------------------+
#property       strict
#property       indicator_chart_window
#property       indicator_buffers 6
#property       indicator_width1  2
#property       indicator_width2  2
#property       indicator_width3  3
#property       indicator_color1  -1
#property       indicator_color2  -1
#property       indicator_color3  Blue
#property       indicator_color4  Red
int draw,i;
double maOne_price,maOne_Previous_price,
maTwo_price,maTwo_Previous_price,
drawArrow_one[],drawArrow_two[],
maOne[],maOne_Previous[],
maTwo[],maTwo_Previous[];
// OnInit
void OnInit(void)
  {
   IndicatorDigits(Digits);
// Line
   SetIndexStyle(0,DRAW_LINE);
   SetIndexBuffer(0,maOne);
   SetIndexLabel(0,"Fast");
   SetIndexStyle(4,DRAW_NONE);
   SetIndexBuffer(4,maOne_Previous);
   SetIndexLabel(4,"Fast Previous");
   SetIndexStyle(1,DRAW_LINE);
   SetIndexBuffer(1,maTwo);
   SetIndexLabel(1,"Slow");
   SetIndexStyle(5,DRAW_NONE);
   SetIndexBuffer(5,maTwo_Previous);
   SetIndexLabel(5,"Slow Previous");
// Arrow
   SetIndexStyle(2,DRAW_ARROW);
   SetIndexArrow(2,159); // 233
   SetIndexEmptyValue(2,0.0);
   SetIndexLabel(2,"Buy");
   SetIndexDrawBegin(2,draw);
   SetIndexBuffer(2,drawArrow_one);
   SetIndexStyle(3,DRAW_ARROW);
   SetIndexArrow(3,159); // 234
   SetIndexLabel(3,"Sell");
   SetIndexDrawBegin(3,draw);
   SetIndexBuffer(3,drawArrow_two);
  }
// OnCalculate
int OnCalculate(
                const int        rates_total,
                const int        prev_calculated,
                const datetime  &time[],
                const double    &open[],
                const double    &high[],
                const double    &low[],
                const double    &close[],
                const long      &tick_volume[],
                const long      &volume[],
                const int       &spread[]
                )
  {
//---
   int limit=rates_total-prev_calculated;
   if(prev_calculated>0) limit++;
   for(i=limit-1; i>=0; i--)
     {
      // Line
      maOne[i] = iMA( Symbol(), 0, 13, 0, MODE_EMA, PRICE_CLOSE, i );
      maTwo[i] = iMA( Symbol(), 0, 26, 0, MODE_EMA, PRICE_CLOSE, i );
      maOne_Previous[i] = iMA( Symbol(), 0, 13, 0, MODE_EMA, PRICE_CLOSE, i + 1 );
      maTwo_Previous[i] = iMA( Symbol(), 0, 26, 0, MODE_EMA, PRICE_CLOSE, i + 1 );
      
      maOne_price=maOne[i];
      maOne_Previous_price=maOne_Previous[i];
      maTwo_price=maTwo[i];
      maTwo_Previous_price=maTwo_Previous[i];
      // Arrow
      if(maOne_price>maTwo_price && maOne_Previous_price<=maTwo_Previous_price)
        {
         drawArrow_one[i]=Low[i]-6*Point;
        }
     }
//---
   return(rates_total);
  }
//+------------------------------------------------------------------+

Quoting FerruFx

Disliked

{quote} My point was just to show that the 2 dots you have on chart are there because of your coded rules (2 MAs cross). If you want to avoid some dot(s), you will have to filter or change your rules. Not easy to follow what you are doing as you only show piece of the whole thing.

Ignored

Quoting MaxEnrik

Disliked

Here is whole code of my CI codes ( I reduced some of irrelevant codes ) I hope now you clearly know what I am doing.

Ignored

Quoting FerruFx

Disliked

{quote} You are plotting an arrow when the fast MA is crossing above the slow MA. Nothing more, nothing less. BTW, you are doing this within the current candle ... so in real time, you will have some repainting.

Ignored

Quoting MaxEnrik

Disliked

I still have same question, what can I do for remove all of previous arrows, I have not any idea that I can remove them, can you let me know, please? {quote}

Ignored

Quoting FerruFx

Disliked

{quote} If you want only the latest arrow, then what is the purpose of running an historical loop ? Just do a real time check and plot the arrow (drawing object) when the cross occurs ... and at the next cross, the previous arrow will be moved to the new cross ... and so on ...

Ignored

Quoting MaxEnrik

Disliked

Thanks a lot for your very useful and more clearly answers. ( sometimes my English prevent to understand more clearly, sorry about that ) I have an another question, what could I do for prevent repaint, please? {quote}

Ignored

Quoting FerruFx

Disliked

{quote} Check the cross on the latest closed candle instead of the current one. So the values on candle 1 and 2 ... instead of candle 0 and 1.

Ignored

Quoting MaxEnrik

Disliked

Thanks a lot for your time. {quote}

Ignored

Quoting futurespec

Disliked

Don't want to interrupt Ferru's great help here but ..... You do not need buffers for 1 point (the arrows). Under init() set up the object eg. ObjectCreate("mL", OBJ_TEXT, 0, 0, 0, 0, 0); ObjectSet("mL", OBJPROP_TIME1 , Time[10]); ObjectSet("mL", OBJPROP_PRICE1 , Low[10] - 5 * Point()); ObjectSet("mL", OBJPROP_COLOR , clrRed); ObjectSet("mL", OBJPROP_BACK, true); ObjectSetText("mL", CharToStr(233), 10, "WingDings", clrRed); Then where you identify the cross of MA just move the object.... ObjectMove("mL", 0, Time[bar of MA cross], Low[of MA cross]...

Ignored

Quoting FerruFx

Disliked

{quote} Check the cross on the latest closed candle instead of the current one. So the values on candle 1 and 2 ... instead of candle 0 and 1.

Ignored

Quoting MaxEnrik

Disliked

( sorry ) I have an another question to you is it possible to move object when next bar open, please. ( because I want to see how to react Draw Line current condition / current time ) {quote}

Ignored