Little help with consecutive win/loss count | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Win in Trend and Win in Range 227 replies

38 consecutive wins, 0 losses = win? 30 replies

Why and how Win-Win in Forex is possible 56 replies

convert indicator that count bars to have it count ticks. is this possible? 0 replies

Win 2 trades out of 10 and win 180 pips 8 replies

Little help with consecutive win/loss count

  • #1
  • First Post: Edited Jul 30, 2021 9:34am Feb 1, 2016 8:01am | Edited Jul 30, 2021 9:34am
Hi guys, I'm seriously getting into programming but I have a lot more to learn.

I'm currently trying to implement into an EA a consecutive loss count / win count under the following condition:
Inserted Code
//-----------------------------------------------------
extern int = Max_Count; // User defines the maximum Loss/Win Count to start over from 0
//-----------------------------------------------------
here is where I got so far, counts properly the loss and wins, but I can't figure how to make it start over when Max_Count is reached:
Inserted Code
int LossCount = 0, WinCount = 0;
for (int i = 0; i < OrdersHistoryTotal(); i++)
{
if (!OrderSelect(i, SELECT_BY_POS, MODE_HISTORY))
continue;
if (OrderMagicNumber() == MagicNumber && OrderSymbol() == Symbol() && OrderProfit()<0)
{LossCount++; WinCount=0;}
if (OrderMagicNumber() == MagicNumber && OrderSymbol() == Symbol() && OrderProfit()>0)
{LossCount=0; WinCount++;}
}
//-----------------------------------------------------
Thanks !
You'll always miss 100% of the shots you don't take.
  • #2
  • Feb 1, 2016 8:31am Feb 1, 2016 8:31am
Each new order checked is resetting the opposite counter to 0 ... That's wrong to me ...
MT4/MT5 EAs/Indicators/Alerts coder
  • #3
  • Feb 1, 2016 8:59am Feb 1, 2016 8:59am
Hello Edorenta,

I'm not sure exactly what you're trying to achieve, but I also agree with FerruFx that the logic seems a little strange when you reset the opposite counter.

You can streamline your code a bit - there is no need to check OrderMagicNumber() and Symbol() for every 'if' statement.

I'm not sure what you want to do when you reach Max_Count - break the loop or just reset the counters?
Inserted Code
   int LossCount = 0, WinCount = 0;
   for(int i = 0; i < OrdersHistoryTotal(); i++)
     {
      if(!OrderSelect(i, SELECT_BY_POS, MODE_HISTORY))                   { continue; }
      if(OrderMagicNumber() != MagicNumber || OrderSymbol() != Symbol()) { continue; }
      if(OrderProfit() < 0)      { LossCount++; }
      else if(OrderProfit() > 0) { WinCount++;  }
 
      if(LossCount+WinCount > Max_Count) { LossCount=WinCount=0; } // resets the counters
 
      // or....
 
      if(LossCount+WinCount > Max_Count) { break; } // breaks the loop
 
     // or... something else entirely?
 
     }
  • #4
  • Feb 1, 2016 9:36am Feb 1, 2016 9:36am
Quoting honestknave
Hello Edorenta, I'm not sure exactly what you're trying to achieve, but I also agree with FerruFx that the logic seems a little strange when you reset the opposite counter. You can streamline your code a bit - there is no need to check OrderMagicNumber() and Symbol() for every 'if' statement. I'm not sure what you want to do when you reach Max_Count - break the loop or just reset the counters?
Thank you for those quick answers guys!
I should've been clearer:
I'm not counting the overall amount of loss and wins among the history but the Chainloss/wins, hence
Inserted Code
{LossCount++; WinCount=0;}
means that if a loss has occured, we add 1 to the loss count and reset the Chainwin count.
Your code
Inserted Code
 if(OrderProfit() < 0) { LossCount++; } else if(OrderProfit() > 0) { WinCount++; }
would just keep on counting till the max is reached which is not what I need

Problem I have just tried both your way to break with "if(LossCount+WinCount > Max_Count) { LossCount=WinCount=0; }"
and another way that both work to stop counting, BUT start over where the count stoped instead of starting back to count from 0:
Inserted Code
int LossCount, WinCount, History;

//I thought maybe we can set the number of orders to check to Max_Count that way:
 
if (History<OrdersHistoryTotal()) History=OrdersHistoryTotal(); else History=Max_Count;

//And then loop through the history till Max_Count:
 
for (int i = 0; i <= History; i++) {
if(!OrderSelect(i, SELECT_BY_POS, MODE_HISTORY)) { continue; }
if(OrderMagicNumber() != MagicNumber || OrderSymbol() != Symbol()) { continue; }
if(OrderProfit() < 0) { LossCount++; WinCount=0}
else if(OrderProfit() > 0) { WinCount++; LossCount=0 }

//Not working :p
Thanks again for being helpful, this world needs more people like you
You'll always miss 100% of the shots you don't take.
  • #5
  • Feb 1, 2016 10:00am Feb 1, 2016 10:00am
Quoting Edorenta
{quote} Thank you for those quick answers guys! I should've been clearer: I'm not counting the overall amount of loss and wins among the history but the Chainloss/wins, hence {LossCount++; WinCount=0;} means that if a loss has occured, we add 1 to the loss count and reset the Chainwin count. Your code if(OrderProfit() < 0) { LossCount++; } else if(OrderProfit() > 0) { WinCount++; } would just keep on counting till the max is reached which is not what I need Problem I have just tried both your way to break with "if(LossCount+WinCount > Max_Count)...
Hi Edorenta,

The chain of consecutive winners / losers makes more sense now I understand it.

But I'm still a little confused about what you want to happen when Max_Count is reached.
Let's say you get half way through the OrderHistory and you reach your Max_Count. What do you want to happen now?
If you want to start from the beginning again, you can simply set i=0 but that will get you into an endless loop (which is not good).

Or do you simply want to remember where you got to the last time when you next call the loop? If so, you can declare i as a static variable, or one with global scope.
  • #6
  • Feb 2, 2016 11:56am Feb 2, 2016 11:56am
Quoting honestknave
Let's say you get half way through the OrderHistory and you reach your Max_Count. What do you want to happen now?
Hi mate, once Max_Count is reached I'd like the Count to count only to the last Max_Count so that the chainloss/win restarts:

Example of what I wish could happen:

T[0] = Current trade
T[1] = last closed trade
T[2] = previous one
......
T[b] = last trade used to count, aka Count_Breaker
......
T[i] = last trade in history

Max_Count works as a count-breaker:

Case 1: No Max_Count is set, we don't preselect a T[b] because we want to count the whole chain:
If T[1], T[2], T[3],..., T[12] were losers, but T[13] winner, then LossCount==12; WinCount==0; No need to count till T[i] as the count-breaker T[b]==T[13].

Case 2: With Max_Count=6, we set T[b] already egals to the sixth consecutive loss or win, so whatever the profit was, the count is egals to maximum 6:
If T[1], T[2], T[3],..., T[12] were losers (same case), then
At T[12]:LossCount==1;
At T[11]:LossCount==2;
At T[10]:LossCount==3;
At T[9]:LossCount==4;
At T[8]:LossCount==5;
At T[7]:LossCount==6; <<<<==== Max_Count is reached there, start over from LossCount==0!!!! ===> T[7] was hence a count-breaker
At T[6]:LossCount==1;
At T[5]:LossCount==2;
At T[4]:LossCount==3;
At T[3]:LossCount==4;
At T[2]:LossCount==5;
At T[1]:LossCount==6;<<<<==== Max_Count is reached there, start over from LossCount==0!!!! ===>T[1] was hence a count-breaker
At T[0]:LossCount==1;

If T[0] closes as a loss again:

Case 1: At T[-1]LossCount==13; WinCount==0;
Case 2: At T[-1]LossCount==2; WinCount==0;

I hope I'm understandable
You'll always miss 100% of the shots you don't take.
  • #7
  • Last Post: Feb 6, 2016 1:54pm Feb 6, 2016 1:54pm
Anyone pleeeeeaaase?
You'll always miss 100% of the shots you don't take.
0 traders viewing now