Easiest way to count bars from X to Current Time? | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Small help with the code to count up-bars and down-bars 12 replies

easiest way to get realtime fx feed data? 7 replies

convert indicator that count bars to have it count ticks. is this possible? 0 replies

The Easiest way to convert EA from Standard to ECN trading account 1 reply

The Easiest way to convert EA from 4 to 5 decimals 7 replies

Easiest way to count bars from X to Current Time?

  • #1
  • First Post: Nov 2, 2015 2:04am Nov 2, 2015 2:04am
What is the easiest way to count bars from the start of the day 00:00:01 till the current bar?

I want to chart the live daily high low HHLL as it happens and have the data stay in a buffer so that I can see the historical intra day movement, PERIOD_D1 only allows the current day's price action, and using a 1mn chart and using 1440 includes yesterday's data.
  • #2
  • Nov 2, 2015 2:09am Nov 2, 2015 2:09am
iBarShift(...)
MT4/MT5 EAs/Indicators/Alerts coder
  • #3
  • Edited 4:23am Nov 2, 2015 4:11am | Edited 4:23am
Quoting FerruFx
iBarShift(...)
Thanks for that.

How is possible to specify datetime as 00:00:00 automatically so that iBarShift could count from the current bar to the first 1 minute bar of each day?

Without using iBarShift what I have is this but it's still counting bars into the previous trading session.

If I can count the exact number of bars back to 00:00:00 of each day's session, then the variable MinutesBack below could be the count of the shift exactly back to the beginning of 00:00:00 of each day only.

Inserted Code
int MinutesInHours = (Hour() - 0)*60;
int Minutes = Minute() - 0;
 
int MinutesBack = MinutesInHours+Minutes;
 
DH = High[iHighest(NULL,PERIOD_M1,MODE_HIGH,MinutesBack,i)];
DL = Low[iLowest(NULL,PERIOD_M1,MODE_LOW,MinutesBack,i)];
  • #4
  • Nov 2, 2015 4:48am Nov 2, 2015 4:48am
To find the shift of the first bar of the day
Inserted Code
int midnight_shift=iBarShift(Symbol(),0,TimeCurrent()-(TimeCurrent()%(PERIOD_D1*60)),true);
if(midnight_shift==-1)
 midnight_shift=iBarShift(Symbol(),0,TimeCurrent()-(TimeCurrent()%(PERIOD_D1*60)),false)-1;
Please Do Not PM Me With Coding Enquiries
  • #5
  • Nov 2, 2015 4:55am Nov 2, 2015 4:55am
Inserted Code
iBarShift(_Symbol,0,iTime(_Symbol,PERIOD_D1,0))

... is the only thing you need to find the number of candles since the day start.
MT4/MT5 EAs/Indicators/Alerts coder
  • #6
  • Nov 2, 2015 5:34am Nov 2, 2015 5:34am
Quoting FerruFx
iBarShift(_Symbol,0,iTime(_Symbol,PERIOD_D1,0)) ... is the only thing you need to find the number of candles since the day start.
That's perfect and efficient. Thank you.
  • #7
  • Nov 2, 2015 5:41am Nov 2, 2015 5:41am
Quoting Pipologist
{quote} That's perfect and efficient. Thank you.
Great!
MT4/MT5 EAs/Indicators/Alerts coder
  • #8
  • Nov 2, 2015 5:43am Nov 2, 2015 5:43am
Quoting Pipologist
{quote} That's perfect and efficient. Thank you.
Just a simple tip: don't forget that bars are numbered from 0.
So if iBarShift returns 12, there are actually 13 bars.
  • #9
  • Nov 2, 2015 7:31am Nov 2, 2015 7:31am
Quoting honestknave
{quote} Just a simple tip: don't forget that bars are numbered from 0. So if iBarShift returns 12, there are actually 13 bars.
example:

1st 1min bar of day is 00:00

now is 15:28

Shift = iBarShift(NULL,0,iTime(NULL,PERIOD_D1,0))

shift = 928 ferrufx
or my formula (15Hour*60 + 28min) = 928

DH = High[iHighest(NULL,PERIOD_M5,MODE_HIGH,Shift,i)] = High since 00:00 or High since 1st bar of the day


I THINK I have the right formula here otherwise from what you have said, we are calculating from 15:28 back to the 2nd bar of the day.
  • #10
  • Nov 2, 2015 8:45am Nov 2, 2015 8:45am
Try this out, see if the visuals help:
Inserted Code
#property strict
#property indicator_chart_window
#property indicator_buffers 2
 
double dayHigh[],
       dayLow[];
    
int OnInit()
  {
   SetIndexBuffer(0,dayHigh);
   SetIndexBuffer(1,dayLow);
   SetIndexStyle(0,DRAW_LINE);
   SetIndexStyle(1,DRAW_LINE);
   return(INIT_SUCCEEDED);
  }
 
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
   for(int i=rates_total-fmax(prev_calculated,1); i>=0; i--)
     {
      datetime midnight  = Time[i]-(Time[i]%86400);
      int      shift     = iBarShift(NULL,0,midnight),
               cnt       = shift-i+1,
               indexHigh = iHighest(NULL,0,MODE_HIGH,cnt,i),
               indexLow  = iLowest (NULL,0,MODE_LOW,cnt,i);
      dayHigh[i]=High[indexHigh];
      dayLow[i] =Low[indexLow];
     }
   return(rates_total);
  }
  • #11
  • Nov 2, 2015 10:35am Nov 2, 2015 10:35am
Quoting honestknave
Try this out, see if the visuals help
Thank you. That's actually closer to what I was trying to accomplish. For the DH and DL it's exactly what I was trying to do however, it made the rest of the lines more difficult. I added a few lines of code to what you did. You can see what I was trying to do by the code, I was trying to add concurrent lines at one third above the DL and one third below the DH, one third is arbitrary, it could be half or even a quarter or all. Concurrent and accurate is the key. I was able to get it to draw some lines at what I thought were at one third intervals but either my maths or logic is way off. I added the additional buffers and the code below. What could I be doing wrong here?

Inserted Code
   for(int i=rates_total-fmax(prev_calculated,1); i>=0; i--)
     {
      datetime midnight  = Time[i]-(Time[i]%86400);
      int      shift     = iBarShift(NULL,0,midnight),
               cnt       = shift-i+1,
               indexHigh = iHighest(NULL,0,MODE_HIGH,cnt,i),
               indexLow  = iLowest (NULL,0,MODE_LOW,cnt,i),
              
               indexU3   = indexHigh-((indexHigh-indexLow)/3),
               indexL3   = indexLow+((indexHigh-indexLow)/3);
              
              
      dayHigh[i]=High[indexHigh];
      dayLow[i] =Low[indexLow];
      
      dayU3[i] =Close[indexU3];
      dayL3[i] =Close[indexL3];
     }
  • #12
  • Nov 2, 2015 10:55am Nov 2, 2015 10:55am
Quoting Pipologist
{quote} Thank you. That's actually closer to what I was trying to accomplish. For the DH and DL it's exactly what I was trying to do however, it made the rest of the lines more difficult. I added a few lines of code to what you did. You can see what I was trying to do by the code, I was trying to add concurrent lines at one third above the DL and one third below the DH, one third is arbitrary, it could be half or even a quarter or all. Concurrent and accurate is the key. I was able to get it to draw some lines at what I thought were at one third...
You're trying to calculate the third using the indices of the high and low, not the value of the high and low.
Inserted Code
#property strict
#property indicator_chart_window
#property indicator_buffers 4
double dayHigh[],
       dayLow[],
       upper3[],
       lower3[];
    
int OnInit()
  {
   SetIndexBuffer(0,dayHigh);
   SetIndexBuffer(1,dayLow);
   SetIndexBuffer(2,upper3);
   SetIndexBuffer(3,lower3);
   SetIndexStyle(0,DRAW_LINE,STYLE_SOLID);
   SetIndexStyle(1,DRAW_LINE,STYLE_SOLID);
   SetIndexStyle(2,DRAW_LINE,STYLE_DASH);
   SetIndexStyle(3,DRAW_LINE,STYLE_DASH);
   return(INIT_SUCCEEDED);
  }
 
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
   for(int i=rates_total-fmax(prev_calculated,1); i>=0; i--)
     {
      datetime midnight  = Time[i]-(Time[i]%86400);
      int      shift     = iBarShift(NULL,0,midnight),
               cnt       = shift-i+1,
               indexHigh = iHighest(NULL,0,MODE_HIGH,cnt,i),
               indexLow  = iLowest (NULL,0,MODE_LOW,cnt,i);
      dayHigh[i]= High[indexHigh];
      dayLow[i] = Low[indexLow];
      double range = (dayHigh[i]-dayLow[i])/3;
      upper3[i] = dayHigh[i]-range;
      lower3[i] = dayLow[i] +range;
     }
   return(rates_total);
  }
  • #13
  • Nov 2, 2015 11:18am Nov 2, 2015 11:18am
Quoting honestknave
{quote} You're trying to calculate the third using the indices of the high and low, not the value of the high and low
Thanks for that. I had used the code below before you finished posting the new example. Got it to work with...

Inserted Code
     
dayU3[i] = dayHigh[i]-((dayHigh[i]-dayLow[i])/3);
dayL3[i] = dayLow[i]+((dayHigh[i]-dayLow[i])/3);
  • #14
  • Nov 2, 2015 11:40am Nov 2, 2015 11:40am
Quoting Pipologist
{quote} Thanks for that. I had used the code below before you finished posting the new example. Got it to work with... dayU3[i] = dayHigh[i]-((dayHigh[i]-dayLow[i])/3); dayL3[i] = dayLow[i]+((dayHigh[i]-dayLow[i])/3);
  • #15
  • Edited Nov 3, 2015 1:15am Nov 2, 2015 9:18pm | Edited Nov 3, 2015 1:15am
I've been trying to add 3 more lines to the visuals and only have had minor success.

#1. OK - I've added:

dayOpen[i] = Open[shift];

It works as intended with concurrent lines during each session showing the session's open.

#2. NOT OK - I'm also trying to add yesterday's close to this mix drawn today, and each previous day's close drawn the day after as well.

#3. If I can get #2 added, then I can also add ((yesterday's close+today's open) / 2) as the third additional line.


#2 and #3 are much more challenging than I would have thought. I can get yesterday's close line to appear today but I can't get it to shift appropriately, so the problem I assume is in the index set up.

dayPrevClose[i] = Close[shift+1]; does not work as intended and dayPrevClose[i] = Close[shift] draws the close of the 1st bar of the day.

How can I accomplish this so that the previous day's close is drawn across today's intraday data and shifted appropriately?
  • #16
  • Edited 2:40am Nov 3, 2015 1:30am | Edited 2:40am
Quoting Pipologist
I've been trying to add 3 more lines to the visuals and only have had minor success. #1. OK - I've added: dayOpen = Open[shift]; It works as intended with concurrent lines during each session showing the session's open. #2. NOT OK - I'm also trying to add yesterday's close to this mix drawn today, and each previous day's close drawn the day after as well. #3. If I can get #2 added, then I can also add ((yesterday's close+today's open) / 2) as the third additional line. #2 and #3 are much more challenging than I would have thought. I can get yesterday's...
I imagine you are getting an array out of range error message in your Experts log (if shift is already the oldest bar on the chart, you can't add 1 to it)
Inserted Code
#property strict
#property indicator_chart_window
#property indicator_buffers 7
double dayHigh[],
       dayLow[],
       upper3[],
       lower3[],
       dayOpen[],
       prevClose[],
       closeopen2[];
    
int OnInit()
  {
   SetIndexBuffer(0,dayHigh);
   SetIndexBuffer(1,dayLow);
   SetIndexBuffer(2,upper3);
   SetIndexBuffer(3,lower3);
   SetIndexBuffer(4,dayOpen);
   SetIndexBuffer(5,prevClose);
   SetIndexBuffer(6,closeopen2);
   SetIndexStyle(0,DRAW_LINE,STYLE_SOLID);
   SetIndexStyle(1,DRAW_LINE,STYLE_SOLID);
   SetIndexStyle(2,DRAW_LINE,STYLE_DASH);
   SetIndexStyle(3,DRAW_LINE,STYLE_DASH);
   SetIndexStyle(4,DRAW_LINE,STYLE_SOLID);
   SetIndexStyle(5,DRAW_LINE,STYLE_SOLID);
   SetIndexStyle(6,DRAW_LINE,STYLE_DOT);
   return(INIT_SUCCEEDED);
  }
 
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
   for(int i=rates_total-fmax(prev_calculated,1); i>=0; i--)
     {
      datetime midnight  = Time[i]-(Time[i]%86400);
      int      shift     = iBarShift(NULL,0,midnight),
               cnt       = shift-i+1,
               indexHigh = iHighest(NULL,0,MODE_HIGH,cnt,i),
               indexLow  = iLowest (NULL,0,MODE_LOW,cnt,i);
      dayHigh[i]= High[indexHigh];
      dayLow[i] = Low[indexLow];
      double range = (dayHigh[i]-dayLow[i])/3;
      upper3[i]    = dayHigh[i]-range;
      lower3[i]    = dayLow[i] +range;
      dayOpen[i]   = Open[shift];
      shift++;
      if(shift>=rates_total) { continue; }
      prevClose[i] = Close[shift];
      closeopen2[i]= (dayOpen[i]+prevClose[i])/2;
     }
   return(rates_total);
  }
  • #17
  • Nov 3, 2015 2:18am Nov 3, 2015 2:18am
Quoting honestknave
{quote} I imagine you are getting an array out of range error message in your Experts log (if shift is already the oldest bar on the chart, you can't add 1 to it) shift++; if(shift>=rates_total) { continue; } prevClose[i] = Open[shift]; closeopen2[i]= (dayOpen[i]+prevClose[i])/2; } return(rates_total); }
Would have never figured out the additional shift++. Thank you.
You are very very good at coding. I've seen lots of code, yours is tight and effective and very logical.

I did one small modification...

prevClose[i] = Open[shift]; changed to
prevClose[i] = Close[shift];

seems to work perfectly.
  • #18
  • Nov 3, 2015 2:37am Nov 3, 2015 2:37am
Quoting Pipologist
{quote} Would have never figured out the additional shift++. Thank you. You are very very good at coding. I've seen lots of code, yours is tight and effective and very logical. I did one small modification... prevClose[i] = Open[shift]; changed to prevClose[i] = Close[shift]; seems to work perfectly.
Good spot on the Open / Close ... it must have been too early in the morning to start coding

I'm glad you've got it working
  • #19
  • Dec 19, 2019 2:50am Dec 19, 2019 2:50am
Quoting FerruFx
iBarShift(_Symbol,0,iTime(_Symbol,PERIOD_D1,0)) ... is the only thing you need to find the number of candles since the day start.
iBarShift(_Symbol,0,iTime(_Symbol,PERIOD_D1,0)) works very nice. However I am using values of 1st 15M candle and for some calulations. But I can see the results in timeframe M15 to H4 but not in M5..

is there any way I can get the results to show in M5 timeframe as well.
  • #20
  • May 26, 2020 8:17am May 26, 2020 8:17am
is there any way to count bar forward, so the trailing stop loss only change after X number of candle ?
0 traders viewing now