Coders, Little Help with my EA Please :)

Quoting Edorenta

Disliked

Hi everyone, I've been out of this forum for quite a while now, but after having spent a year working a shit job for a private equity company I decided to get back to trading. I am currently actively learning MQL4 and Python side by side, and I am stuck with a little EA I developped this afternoon on a super stupid part: The extern variables definition. I've been messing around and looking it up on MQ4 docs but can't get it to work, I'm a noob. I hope my code is clean, please have a look at it and tell me what's wrong as I'd like to optimize...

Ignored

Quoting cyber1

Disliked

{quote} Edo- Not bad other than other than missing line terminators.

Ignored

Quoting Edorenta

Disliked

{quote} Hey Cyber1, thank you for your reply! By "Line terminators" you mean "}" right? Is that the reason why the inputs are not recognized?

Ignored

Quoting Edorenta

Disliked

Thanks I put the semicolons ";" after every variable it now doesn't pop up anymore, however I'm getting this error: The "missing" { is just the one from the beginning of the code that has to be fixed I guess? {image} {file}

Ignored

start(){
 
//for(cnt = 0; OrdersTotal(); cnt++){
// OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
//
// if(OrderMagicNumber() == MagicNumber){
// Total_Trades += 1;
//
// }
// }
 
//
return(0);
}

Quoting Edorenta

Disliked

I really appreciate your help but I did try to find missing ";" found some after a return value and some others but the error is still poping, I can'r figure it out one more hint?

Ignored

Quoting cyber1

Disliked

{quote} ST1 = iCustom(NULL, 0, "SuperTrend", 20, ST_Multiplier, 0, 0) needs a semi-colon if its a condition or function open would be a left curly brace if(OrderMagicNumber() == MagicNumber) { (BTW its less confusing to put the curly brace on the same line) and here there are missing commas double MA1 = iMA(NULL, 0, SMA_Length, 0 MODE_SMA, PRICE_CLOSE, 0);

Ignored

//+------------------------------------------------------------------+
//|                                               SuperTrendTest.mq4 |
//|                                                         BroStats |
//|                                             https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "BroStats";
#property link      "https://www.mql5.com";
#property version   "1.00";
#property strict
#define           LongTrade 1;
#define           ShortTrade 2;
// External Inputs
extern int        MagicNumber=21215;
extern int        Slippage=30;
extern double     PercentagePerTrade=1.0;
extern bool       UseStopLoss=True;
extern bool       UseTakeProfits=False;
extern bool       UseTrailingStop=True;
extern double     SL_ATRMultiplier = 1.0;
extern double     TP_ATRMultiplier = 3.0;
extern double     TS_ATRMultiplier = 2.0;
extern int        Close_EMA=45;
extern int        SMA_Length = 200;
extern int        Start_Time = 00;
extern int        Finish_Time= 24;
extern int        ST_Multiplier=1;
// Expert Initialization Function
int OnInit()
  {
//---
   return(INIT_SUCCEEDED);
  }
// Expert Deinitialization Function                                 |
void OnDeinit(const int reason)
  {
//---
  }
// Expert Tick Function    
int start()
  {
// Declaring Variables
   int cnt,ticket,Order,Current_Time;
// Check if at least 100 bars of data are available
   if(Bars<100)
     {
      Print("Bars are less than 100");
      return (0);
     }
// Lot calculation
   double K,K_Risked,SL_Amount,Lots_Traded;
   double Lots;                   //These 3 variable need to be assigned a value
   double TakeProfit;             //These 3 variable need to be assigned a value
   double TrailingStop;           //These 3 variable need to be assigned a value
   double ATR=iATR(NULL,0,20,1);
   double Point_Value=Point;
   K=AccountFreeMargin();
   K_Risked=K*(PercentagePerTrade/100);
   SL_Amount=(ATR*SL_ATRMultiplier/Point);
   Lots_Traded=K_Risked/SL_Amount;
// Calculation of Technical Indicators
   double ST1 = iCustom(NULL, 0, "SuperTrend", 20, ST_Multiplier, 0, 0); // Main trend filter
   double ST2 = iCustom(NULL, 0, "SuperTrend", 20, ST_Multiplier, 0, 1); // SuperTrend variation (shifted - non shifted)
   double MA1 = iMA(NULL, 0, SMA_Length, 0, MODE_SMA, PRICE_CLOSE, 0);    // Main MA filter
   double MA2 = iMA(NULL, 0, SMA_Length, 0, MODE_SMA, PRICE_CLOSE, 1);    // MA variation (shifted - non shifted)
   double EMA1 = iMA(NULL, 0, Close_EMA, 0, MODE_EMA, PRICE_CLOSE, 0);    // Fast EMA for triger
   double EMA2 = iMA(NULL, 0, Close_EMA, 0, MODE_EMA, PRICE_CLOSE, 1);    // Fast EMA variation (shifted - non shifted)

   int total=OrdersTotal();
// Check if trading is allowed by Time
   Current_Time=Hour();
   if(Current_Time>=Start_Time && Current_Time<=Finish_Time)
     {
      // Number of Trades Allowed
      int Total_Trades=0;
      for(cnt=0; cnt<total; cnt++)
        {
         if(OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES))
            if(OrderMagicNumber()==MagicNumber)
              {
               Total_Trades+=1;
              }
        }
      if(Total_Trades<1)
        {
         if(total<1)
           {
            // Open Trades Identifier
            if(AccountFreeMargin()<(1000*Lots))
              {
               Print("We have no money. Free Margin = ",AccountFreeMargin());
               return(0);
              }
            // Long entry Conditions and entry
            if(Close[0]>ST1 && Close[1]<ST2 && Close[0]>MA1)
              {
               ticket=OrderSend(Symbol(),OP_BUY,Lots,Ask,3,0,Ask+TakeProfit*Point,"Bitch",16384,0,Green);
               if(ticket>0)
                 {
                  if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES))
                     Print("BUY order opened : ",OrderOpenPrice());
                 }
              }
            else
              {
               if(Close[0]>MA1 && Close[1]<MA2 && Close[0]>ST1)
                 {
                  ticket=OrderSend(Symbol(),OP_BUY,Lots,Ask,3,0,Ask+TakeProfit*Point,"Bitch",16384,0,Green);
                  if(ticket>0)
                    {
                     if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES))
                        Print("BUY order opened : ",OrderOpenPrice());
                    }
                 }
               else
                  Print("Error opening BUY order : ",GetLastError());
               return(0);
              }
            // Short entry Conditions and entry
            if(Close[0]<ST1 && Close[1]>ST2 && Close[0]<MA1)
              {
               ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,3,0,Bid-TakeProfit*Point,"Bitch",16384,0,Green);
               if(ticket>0)
                 {
                  if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES))
                     Print("SELL order opened : ",OrderOpenPrice());
                 }
              }
            else
              {
               if(Close[0]<MA1 && Close[1]>MA2 && Close[0]<ST1)
                 {
                  ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,3,0,Bid-TakeProfit*Point,"Bitch",16384,0,Green);
                  if(ticket>0)
                    {
                     if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES))
                        Print("SELL order opened : ",OrderOpenPrice());
                    }
                 }
               else
                  Print("Error opening SELL order : ",GetLastError());
               return(0);
              }
           }
        }
     }
// Close conditions
   for(cnt=0;cnt<total;cnt++)
     {
      if(!OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES))
         continue;
      if(OrderType()<=OP_SELL &&   // check for opened position 
         OrderSymbol()==Symbol())  // check for symbol
        {
         // Check for BUY position opened
         if(OrderType()==OP_BUY)
           {
            //--- should it be closed?
            if(Close[0]<EMA1 && Close[1]>EMA2)
              {
               // Close BUY and Exit
               if(!OrderClose(OrderTicket(),OrderLots(),Bid,3,Violet))
                  Print("OrderClose error ",GetLastError());
               return(0);
              }
            // Trailing Stop conditions
            if(TrailingStop>0)
              {
               if(Bid-OrderOpenPrice()>Point*TrailingStop)
                 {
                  if(OrderStopLoss()<Bid-Point*TrailingStop)
                    {
                     // Modify order and Exit
                     if(!OrderModify(OrderTicket(),OrderOpenPrice(),Bid-Point*TrailingStop,OrderTakeProfit(),0,Green))
                        Print("OrderModify error ",GetLastError());
                     return(0);
                    }
                 }
              }
           }
         else // go to short position
           {
            // Check for SELL position opened
            if(Close[0]>EMA1 && Close[2]<EMA2)
              {
               // Close SELL and exit
               if(!OrderClose(OrderTicket(),OrderLots(),Ask,3,Violet))
                  Print("OrderClose error ",GetLastError());
               return(0);
              }
            // Trailing Stop conditions
            if(TrailingStop>0)
              {
               if((OrderOpenPrice()-Ask)>(Point*TrailingStop))
                 {
                  if((OrderStopLoss()>(Ask+Point*TrailingStop)) || (OrderStopLoss()==0))
                    {
                     // Modify Order and Exit
                     if(!OrderModify(OrderTicket(),OrderOpenPrice(),Ask+Point*TrailingStop,OrderTakeProfit(),0,Red))
                        Print("OrderModify error ",GetLastError());
                     return(0);
                    }
                 }
              }
           }
        }
     }
   return(0);
  }
// Good Night Algo