I've a questions about MQL4 programming.
How to draw horizontal line at the close or open of candle?
Any help how to do this?
How to draw horizontal line at the close or open of candle?
Any help how to do this?
astroganndotcom
I've coded but still get problems, I can't draw the horizontal line. Also there's some bars that's not draw/count the highest volume as can see the geen circle at the image.
How to draw the horizontal line based on High/Low or Open/Close? How to draw the blue line on Bull candle and the red line on Bear candle?
How to draw the horizontal line based on High/Low or Open/Close? How to draw the blue line on Bull candle and the red line on Bear candle?
Inserted Code
#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 Blue
#property indicator_color2 Red
#property indicator_width1 1
#property indicator_width2 1
#property indicator_style1 0
#property indicator_style2 0
extern int NumberOfBars = 500;
double HighLines[], LowLines[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
SetIndexBuffer(0,HighLines);
SetIndexStyle(0,DRAW_LINE,0,1,indicator_color1);
SetIndexLabel(0, "HighLines");
SetIndexEmptyValue(0, EMPTY_VALUE);
SetIndexBuffer(1,LowLines);
SetIndexStyle(1,DRAW_LINE,0,1,indicator_color2);
SetIndexLabel(1, "LowLines");
SetIndexEmptyValue(1, EMPTY_VALUE);
IndicatorShortName("SnRV");
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{
double HighestVolume;
int Limit;
int counted_bars=IndicatorCounted();
if(counted_bars>0) counted_bars--;
if ( NumberOfBars == 0 )
NumberOfBars = Bars-counted_bars;
Limit=NumberOfBars;
for(int i=0; i<Limit; i++)
{
HighLines[i] = Volume[i];
{
HighestVolume = Volume[iHighest(NULL,0,MODE_VOLUME,20,i)];
if (Volume[i] == HighestVolume)
{
HighLines[i]=0;
}
}
}
return(0);
} astroganndotcom
- #4
- Edited 1:37am Sep 15, 2015 12:30am | Edited 1:37am
Wow... many many thanks Cyber1! This's what I want... 
However I'm still have a questions about the MQL4 language.
- What's the right code to count the highest volume in n period?
- What's the right code to draw the horizontal line based on High or Low or High+Low and Open or Close or Open+Close?
- What's the right code to draw the LimeGreen line if the candle Bull and the Red line if the candle is Bear?
Can you send me the mql4's file please? Or maybe can you explain to me about your code please?
Because I want to learn the MQL4 programming since I'm newbie in the MQL4 and I want to know the logic behind that. So I can edit or create it by myself in the future.
However I'm still have a questions about the MQL4 language.
- What's the right code to count the highest volume in n period?
- What's the right code to draw the horizontal line based on High or Low or High+Low and Open or Close or Open+Close?
- What's the right code to draw the LimeGreen line if the candle Bull and the Red line if the candle is Bear?
Can you send me the mql4's file please? Or maybe can you explain to me about your code please?
Because I want to learn the MQL4 programming since I'm newbie in the MQL4 and I want to know the logic behind that. So I can edit or create it by myself in the future.
astroganndotcom
- #5
- Edited 2:52am Sep 15, 2015 1:42am | Edited 2:52am
- | Membership Revoked | Joined Aug 2015 | 1,243 Posts
- #6
- Sep 15, 2015 7:01am Sep 15, 2015 7:01am
- Joined Jan 2011 | Status: Trader | 1,299 Posts
Wow... many many thanks Cyber1! This's what I want...
Okay you want to learn, let's see how you do?
If you get stuck let me know.
First, this will only work on H1 timeframe.
We're not going to use any buffers, all the lines and numbers are objects
http://docs.mql4.com/objects
first define a two dimensional array
http://docs.mql4.com/array
double VolAr[500][2];
then inside your main loop test for Hour = 0
set up another "for loop" length = 24
now populate your array with volume and candle index
while still in the Hour = 0 condition
sort the array
ArraySort(VolAr,WHOLE_ARRAY,0,MODE_DESCEND);
now all the highest volume will be at the beginning of the array
define a function to draw a trend line and the numbers
set up a second "for loop" with the length equal to the number of highs you want to display on the chart with lines etc.
and call the draw trend line function using price and candle index as parameters to draw the trend line
- #11
- Edited 7:55pm Sep 17, 2015 7:40pm | Edited 7:55pm
- Joined Jan 2011 | Status: Trader | 1,299 Posts
- #13
- Edited 3:11am Sep 18, 2015 1:38am | Edited 3:11am
- | Membership Revoked | Joined Aug 2015 | 1,243 Posts
Cyber1 -
For a moment / 1st step, I want to draw the highest volume on separate window for each day (H1 timeframe only) for learning purpose. And then continue to 2nd step: to draw the horizontal line on the OHLC of candlesticks/bars based on 1st step.
Current condition, I can get the 3 highest volume histogram but it always display that histogram on 3 last histogram only (it's not right position on the right histograms, as we can see on the image that show: Bar index: 0, Volume: 12761).
How to draw all of highest volume bars for previous days on the right position?
Here's the latest code:
For a moment / 1st step, I want to draw the highest volume on separate window for each day (H1 timeframe only) for learning purpose. And then continue to 2nd step: to draw the horizontal line on the OHLC of candlesticks/bars based on 1st step.
Current condition, I can get the 3 highest volume histogram but it always display that histogram on 3 last histogram only (it's not right position on the right histograms, as we can see on the image that show: Bar index: 0, Volume: 12761).
How to draw all of highest volume bars for previous days on the right position?
Here's the latest code:
Inserted Code
//+------------------------------------------------------------------+
//| MVC-Highest.mq4 |
//| Copyright 2015, pije76. |
//| http://www.forexfactory.com/pije76 |
//+------------------------------------------------------------------+
#property copyright "Copyright 2015, pije76"
#property link "http://www.forexfactory.com/pije76"
#property indicator_separate_window
#property indicator_minimum 0
#property indicator_buffers 1
#property indicator_color1 Blue
#property indicator_width1 2
extern int NumberOfBars = 100;
extern int ControlOfBars = 25;
extern int NumberOfHighs = 3;
//1st step: Define a two dimensional array
double ArrayVolume[];
//double ArrayVolume[][2]; //[i][0] contains the volume index & [i][1] contains the candle index
double iVolume, jVolume, kVolume;
double HighestColor[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
SetIndexBuffer(0, HighestColor);
SetIndexStyle(0, DRAW_HISTOGRAM);
SetIndexLabel(0, NULL);
SetIndexEmptyValue(0, 0.0);
IndicatorShortName("MVC-Highest");
IndicatorDigits(0);
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{
double iVolume, jVolume, kVolume;
// int bulan = 0;
// int hari = 0;
// int tahun = 0;
// string tanggal = "";
// datetime thisbartime = 0;
datetime thisbartime[];
// int shift = 0;
// int time_frame = 1440;
// int min = 0;
// int jam = 0;
// int thour=0, tmin=0;
int Limit;
int counted_bars=IndicatorCounted();
//---- last counted bar will be recounted
if(counted_bars>0) counted_bars--; //always count the previous bar
if ( NumberOfBars == 0 )
NumberOfBars = Bars-counted_bars;
Limit=NumberOfBars;
// bulan=TimeMonth(Time[NumberOfBars]);
// hari=TimeDay(Time[NumberOfBars]);
// tahun=TimeYear(Time[NumberOfBars]);
// min = TimeMinute(Time[NumberOfBars]);
// jam = TimeHour(Time[NumberOfBars]);
// tanggal = tahun + "." + bulan + "." + hari + " " + jam + ":" + min;
// thisbartime = StrToTime(tanggal);
// shift = iBarShift(NULL,time_frame,thisbartime); //returns the correct shift of the current daily bar
// thour = TimeHour(iTime(NULL,60,iBarShift(NULL,60,thisbartime)));
// tmin = TimeMinute(iTime(NULL,Period(),NumberOfBars));
ArrayCopySeries(thisbartime,MODE_TIME,Symbol(),1440);
for(int i=0, t=0; i<Limit; i++)
// for(int i=0; i<Limit; i++)
{
//2nd step: Inside main loop, add condition here to check for Hour == 0
if (Time[i]<thisbartime[t]) t++;
//if(thour == 0 && tmin == 0)
{
ArrayResize(ArrayVolume, Limit, 0);
//3rd step: Set up another "for loop" length = 24 as there are 24 candles in a day for H1
for(int j=0; j<ControlOfBars; j++)
{
// 4th step: Populate the Array with volume index
ArrayVolume[j] = Volume[j];
//ArrayVolume[j] = Volume[j];
//j++;
} // end of "j for" loop
} // end of "if" condition for hour == 0
//5th step: Sort the Array
ArraySort(ArrayVolume, WHOLE_ARRAY, 0, MODE_DESCEND);
//jVolume = ArrayVolume[j];
}// end of "i for" loop
//6th step: Define a function to draw a trend line
//7th step: Set up a second "for loop" with the length equal to the number of highs to display on the chart with lines
for (int k=0; k<NumberOfHighs; k++)
{
//if (ArrayResize(ArrayVolume) > 0) ArraySort(ArrayVolume, WHOLE_ARRAY, 0, MODE_DESCEND);
//{
kVolume = ArrayVolume[k];
//8th step: call the draw trend line function using price and candle index as parameters to draw the trend line
Print("BarIndex: ", k, ", Value: ", kVolume);
HighestColor[k]=kVolume;
//} //end of "if" condition
}//end of "k for" loop
return(0);
} astroganndotcom