How to find if any EA order has been closed by TP | Page 2 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Any EA that shows when market has closed 20 days above/below ema 0 replies

How to check if an order has been closed by SL/TP? 5 replies

Order Comment blank after order closed 4 replies

How to determine if a trade has been closed. 2 replies

Attachments: How to find if any EA order has been closed by TP
Exit Attachments

How to find if any EA order has been closed by TP

  • #21
  • Edited 6:22am Dec 7, 2014 3:20am | Edited 6:22am
I have made some changes to the orig. code so that it can start all over after close out. Doing whatever it does.

Attached File(s)
File Type: mq4 EAmartin.mq4   10 KB | 374 downloads


Quoting alex8585
So i decided to describe an example to make it easier to understand for what i am looking for.
I do not see how this strategy makes sense.

Attached File(s)
File Type: mq4 hedge.ea.mq4   2 KB | 380 downloads
Return To Disorder
  • #22
  • Dec 7, 2014 6:25am Dec 7, 2014 6:25am
Quoting rockit
I have made some changes to the orig. code so that it can start all over after close out. Doing whatever it does. {file}
I have only two issues that after it opens first order and it closes with tp . the next order that it opens it does not modify order with tp.

also what most worries me is that it does not open opposite position even if the condition is met.
Read carefully the code but can't find what is going wrong . I don't if it helps but in journal i get Order error send 130.
Any ideas?
  • #23
  • Dec 7, 2014 6:43am Dec 7, 2014 6:43am
Quoting rockit
I have made some changes to the orig. code so that it can start all over after close out. Doing whatever it does. {file} {quote} I do not see how this strategy makes sense. {file}
the second EA hedge does open the opposite order but still does not close all the rest opened orders after one of them reaches tp.
  • #24
  • Dec 7, 2014 6:46am Dec 7, 2014 6:46am
Quoting alex8585
the second EA hedge does open the opposite order but still does not close all the rest opened orders after one of them reaches tp.
Can you please check the comment section of the closed by tp order(s) in account history pane (possibly you have to enable it first)? What does the comment say?
Return To Disorder
  • #25
  • Dec 7, 2014 6:59am Dec 7, 2014 6:59am
in the tester i have such columns
Attached Image (click to enlarge)
Click to Enlarge Name: Untitled.png Size: 133 KB
  • #26
  • Dec 7, 2014 7:16am Dec 7, 2014 7:16am
Seems like in the tester TP is not indicated (retrievable) or indicated somehow else than by comment.
Possibly try printing all attributes (i.e. OrderType, Order bla bla) of those historic orders (in check_tp_hit()) to see if there is something that can be exploited to distinguish TP hit..
Return To Disorder
  • #27
  • Dec 7, 2014 7:34am Dec 7, 2014 7:34am
Quoting rockit
Seems like in the tester TP is not indicated (retrievable) or indicated somehow else than by comment. Possibly try printing all attributes (i.e. OrderType, Order bla bla) of those historic orders (in check_tp_hit()) to see if there is something that can be exploited to distinguish TP hit..
No luck tried OrderType , OrderTakeprofit .
I changeg the condition to OrderClosePrice >= OrderTakeprofit.

Can you help me now to include in my original ea the hedge ea and get rid of the warnings about global declaration .
  • #28
  • Dec 7, 2014 7:36am Dec 7, 2014 7:36am
OK I think I got it.
You will have to modify in check_tp_hit function where it says OrderComment() == "[tp]" into: OrderComment() == "0[tp]" .
For some reason.. And this is only(!) for the tester.

Now because of you I had to learn to do the test(er) lol.
Return To Disorder
  • #29
  • Dec 7, 2014 8:00am Dec 7, 2014 8:00am
Quoting rockit
OK I think I got it. You will have to modify in check_tp_hit function where it says OrderComment() == "[tp]" into: OrderComment() == "0[tp]" . For some reason.. And this is only(!) for the tester. Now because of you I had to learn to do the test(er) lol.
Yes it worked . but and the above condition OrderClosePrice >= OrderTakeprofit did the work. that is the good news.

Now i need to insert it in my original EA or you believe it is better to continue on this one and insert some adjustments.
Because now i need to insert that if new opposite order opens but didn't hit TP and reverses to open another buy. i will explain with example which will make life easier i hope.

First order Buy 1.3000. 0.5 Lot TP 1.30300
Second order Sell 1.29700. Lot TP 1.29700

Now if the price triggers sell order and don't hits TP and reverses back again and reaches 1.3000 to open another buy order 0.05 lot with TP 1.30300 as the first's buy order.
How you think can this been coded ?
  • #30
  • Dec 7, 2014 8:19am Dec 7, 2014 8:19am
Yes, the >= check does the trick - but only when there is no slippage to the other side, like in real life.

Now to the other part: Then you have three trades - how far do you intend to do this ping-pong?

It reads simple though:
each time the last order reaches a stealth SL, do the opposite trade, which becomes the last order, and so on.

I thought that so far only the check for TP and kill all had to be fixed, which is now done (for the tester)? So, the last version of your EA (post #21) has to be updated to the fix for the check_tp_hit.. Or does your code per se not work in the sense of your last example?
Return To Disorder
  • #31
  • Dec 7, 2014 8:37am Dec 7, 2014 8:37am
Quoting rockit
Yes, the >= check does the trick - but only when there is no slippage to the other side, like in real life. Now to the other part: Then you have three trades - how far do you intend to do this ping-pong? It reads simple though: each time the last order reaches a stealth SL, do the opposite trade, which becomes the last order, and so on. I thought that so far only the check for TP and kill all had to be fixed, which is now done (for the tester)? So, the last version of your EA (post #21) has to be updated to the fix for the check_tp_hit.. Or does...
Correct i want this ping pong until from one side or another TP is hit.

Until now It opens only one buy and one sell and if in the meantime price reaches original entry prices it does not open any further trade. Explanation with example.

First order buy 1.3000 TP 1.3030
Second order sell 1.2970 TP 1.2940

So far so good. Now until TP won't be hit from one side or another. As many times in the meanwhile price reaches 1.30000 open buy and how many times reaches 1.2970 open sell. After TP is hit no matter side close all orders.
  • #32
  • Edited 9:49am Dec 7, 2014 8:40am | Edited 9:49am
Try this:

Attached File(s)
File Type: mq4 hedge2.ea.mq4   2 KB | 414 downloads
Return To Disorder
  • #33
  • Dec 7, 2014 8:48am Dec 7, 2014 8:48am
Quoting rockit
Try this: {file}
it returns error that initialization failed (1)
  • #34
  • Dec 7, 2014 8:55am Dec 7, 2014 8:55am
Oh well.. that MT4. Buggy or what?
Please remove "#property strict" from source..
Return To Disorder
  • #35
  • Dec 7, 2014 9:04am Dec 7, 2014 9:04am
Quoting rockit
Oh well.. that MT4. Buggy or what? Please remove "#property strict" from source..
You won't believe it but guess it does open second buy and TP is hit but the other sell order was not closed . Simply now it does not close all open orders when TP is hit.
  • #36
  • Edited 9:40am Dec 7, 2014 9:14am | Edited 9:40am
Hm.. for some reason it's "[tp]" again and not "0[tp]"!?
Return To Disorder
  • #37
  • Dec 7, 2014 9:20am Dec 7, 2014 9:20am
try this one:
StringFind( OrderComment(), "[tp]" ) >= 0
  • #38
  • Edited 9:41am Dec 7, 2014 9:31am | Edited 9:41am
Quoting iwjw
try this one: StringFind( OrderComment(), "[tp]" ) >= 0
Yeah man, I too just wanted to propose just that (had some other work to do though), in order to stop this random token BS from this MT4 thing.. Seems like you do not like "!="? *g*
Return To Disorder
  • #39
  • Dec 7, 2014 9:48am Dec 7, 2014 9:48am
Quoting rockit
{quote} Yeah man, I too just wanted to propose just that (had some other work to do though), in order to stop this random token BS from this MT4 thing.. Seems like you do not like "!="? *g*
Guys i know it will sound ridiculous but i can't add it properly.
Please assist.
  • #40
  • Edited 10:07am Dec 7, 2014 9:50am | Edited 10:07am
There was still a bug in the code.
I have re-uploaded the last version (see post #32).
Return To Disorder
0 traders viewing now