"divide by zero" question | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Need help to solve "zero divide error" 7 replies

"zero divide error" on the EA 6 replies

Divide by zero error? 2 replies

Zero Divide Error 5 replies

Zero Divide problem with XpMa EA 1 reply

Attachments: "divide by zero" question
Exit Attachments

"divide by zero" question

  • #1
  • First Post: Edited 9:26pm Oct 2, 2014 9:00pm | Edited 9:26pm
I have a script that finds the percent change of the current candle in relation to the closing price of the previous candle. The main thing I use it for is Daily comparison to see how far each currency pair has moved during the day. I'd like to use it on smaller timeframes, but I'm running into an issue with dividing by zero. I can only assume it is because either the price has not changed or because the change is so small, the double integers ("gj" in the example below) do not have enough decimal places.

Example:
Inserted Code
gj = (((MarketInfo("GBPJPY",MODE_BID))-(iClose("GBPJPY",PERIOD_M15,1)))/(iOpen("GBPJPY",PERIOD_M15,0))*100);

The smallest I intend to use it on is M15 and I intend to run it during the last 30 seconds of each 15-minute candle. So... it *should* always have a different closing price from the previous candle unless it's just a coincidence that the script runs while at the closing price of the previous candle. I can also run it on M30 but I'd like to have it on M15. Right now, H4 seems to work and H1 seems to work. But I really would love to have it working consistently on M30 or 15.

When I test it, I get a "divide by zero" error consistently on M30 and M15. I don't know if it's because one of the pairs (this compares all pairs my broker offers at the same time in the same script to get a whole market snapshot) is at the same price as the closing price of the last candle. Or if it's because the percent change in the price is so small that the double value is not specific enough and I need to use a floating value...? Or it could be a combination of the two :\

Can anyone tell me how to make this work reliably?

Thank you...
  • #2
  • Oct 2, 2014 9:22pm Oct 2, 2014 9:22pm
Hi,
Simple answer, fix the zero divide.

If a line of code like this gives a zero divide
condition = MathRound((ma - close) / divisor);
then change it to this
if (divisor!=0)
condition = MathRound((ma - close) / divisor);
else condition = 0;
Trade what you see not what you hope
  • #3
  • Oct 3, 2014 6:54pm Oct 3, 2014 6:54pm
Quoting cja
Hi, Simple answer, fix the zero divide. If a line of code like this gives a zero divide condition = MathRound((ma - close) / divisor); then change it to this if (divisor!=0) condition = MathRound((ma - close) / divisor); else condition = 0;

cja, I looked at your website and you wrote about all the problems of the new builds of the MT4 since January of this year. In your last update you wrote:

"14/08/2014 : Build 509 is no longer supported however no new 600 series updates have been released yet, lets hope MetaQuotes get it right and fix all the bugs on the next update."

Have you noticed any improvements from Metaquotes with the MT4 in their latest updates? Is the MT4 still a total "mess" as you have said previously?
"Success is not a fantasy, it's a formula." - MTI
  • #4
  • Oct 3, 2014 7:06pm Oct 3, 2014 7:06pm
Quoting Topgun_1
{quote} cja, I looked at your website and you wrote about all the problems of the new builds of the MT4 since January of this year. In your last update you wrote: "14/08/2014 : Build 509 is no longer supported however no new 600 series updates have been released yet, lets hope MetaQuotes get it right and fix all the bugs on the next update." Have you noticed any improvements from Metaquotes with the MT4 in their latest updates? Is the MT4 still a total "mess" as you have said previously?
Actually the latest builds ( 14/08/2014 I wrote that when 670 was the latest build ) 697 to 711 etc are the worst yet and I did not think that would be possible, platform crashes, platform freezes, the editor just shutting down with no save options and excessive memory usage to name but a few of the new bugs they have added without fixing any of the existing issues.
Trade what you see not what you hope
  • #5
  • Oct 3, 2014 8:58pm Oct 3, 2014 8:58pm
Quoting cja
{quote} Actually the latest builds ( 14/08/2014 I wrote that when 670 was the latest build ) 697 to 711 etc are the worst yet and I did not think that would be possible, platform crashes, platform freezes, the editor just shutting down with no save options and excessive memory usage to name but a few of the new bugs they have added without fixing any of the existing issues.
hai cja...

please fix this renko script , when i execute it , it is getting zero divide error.
Attached File(s)
File Type: mq4 RK-RenkoLiveChart_v6-script-adj-nf.mq4   11 KB | 392 downloads


and please change the following ea into renko bar ea, actually it is range bar ea by malden for new mt4 build, it works perfectly but i could not understand the basic behind the range and renko ea, please change the following into a renko ea.
Attached File(s)
File Type: mq4 Range bars EA new format 1.mq4   16 KB | 340 downloads
  • #6
  • Oct 3, 2014 11:00pm Oct 3, 2014 11:00pm
Quoting cja
{quote} Actually the latest builds ( 14/08/2014 I wrote that when 670 was the latest build ) 697 to 711 etc are the worst yet and I did not think that would be possible, platform crashes, platform freezes, the editor just shutting down with no save options and excessive memory usage to name but a few of the new bugs they have added without fixing any of the existing issues.

Do you think it is a case of it being too difficult for anyone to accomplish whatever it is that they are trying to accomplish? Or is it a case of pure incompetence on their part? In other words, just how hard is it to get the job done in regards to the various new builds? Is it something that requires the very best minds in the country? I am not being sarcastic - I am being serious in wondering about the level of difficulty of these new builds and to fix any of the bugs.
"Success is not a fantasy, it's a formula." - MTI
  • #7
  • Oct 4, 2014 10:28am Oct 4, 2014 10:28am
Quoting scalper.exp
{quote} hai cja... please fix this renko script , when i execute it , it is getting zero divide error. {file} and please change the following ea into renko bar ea, actually it is range bar ea by malden for new mt4 build, it works perfectly but i could not understand the basic behind the range and renko ea, please change the following into a renko ea. {file}
hai cja,

i got it right, now only i see your code clearly and corrected mine thanks
  • #8
  • Last Post: Oct 5, 2014 12:29pm Oct 5, 2014 12:29pm
Quoting cja
Hi, Simple answer, fix the zero divide. If a line of code like this gives a zero divide condition = MathRound((ma - close) / divisor); then change it to this if (divisor!=0) condition = MathRound((ma - close) / divisor); else condition = 0;
Thanks, man!
0 traders viewing now