"zero divide error" on the EA

Hi All,

Got this Close All position EA at this forum: https://www.forexfactory.com/showthread.php?t=235952

Problems when running it, the ea will stop at certain time due to "zero divide error".
Can any expert here helps to point out the error & how to resolve it??

Thanks in advance.

Try this ... Fixed but not tested.

Hi FerruFx,

Thanks for the help, will try it out when market open.

Hi FerruFx,

The EA is running ok without any "zero divide error".

But I notice that the EA will "freeze" or should I said that it stop working after the objective is met.
Example, if I select the "close all orders now", the ea will close all the orders when the tick comes in. After that, another tick comes it, the ea is "freeze" & stop working, you can notice this by the timer shows on the chart, the timer is not running when the tick comes after it execute the condition.

I have tested on other condition & the result is the same when the EA executed once & it will stop, I have to remove the EA & reattach it to the chart in order for the EA to work.

Anyway to resolve this??

what do you mean by "stop working"?
EA job is to close all order.
When there is no order to close, EA has no purpose on chart. i.e It should not execute.
This is suppose to be semi-auto EA.
I suggest you convert this to script. (one time execution).

Hairi,

Maybe I didn't clearly stated on the problems, below is the test scenario:

On the demo account, just open a few trades, e.g. 3 trade sell & 2 trade long.
Select the "closes all orders now" = True
EA will close all trade (3 trade sell & 2 trade long) when the tick come in
There is a time shows on the Chart call "Current Time is", it will show the time whenever new tick comes in.
IF we place another trades, e.g. 1 sell order after that
EA is not reacting & the "Current Time is" freeze there.

Below is another test sample :
Instead of select the "closes all orders now" = True
We select "closes only profitable trades" = True
Put any amount that you want on "Only trades above this amount close out"
Open some trades & Wait for the target amount to be hit
Once target hit, continue to place more trades but you can see EA is not reacting & the "Current Time is" freeze there.

The closing order parts in the EA is working well but I want this EA to continue to monitor the trades after new trade is open or waiting for new trades as I can't always monitor the trades that why I want it fully automated.

Do you have any solution??
I would like to know how to resolve this problem so that this EA can run correctly.