please help with simple iCustom call

#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 White
#property indicator_color2 White
string market;
double result1,result2;

void OnInit() {
   SetIndexBuffer(0, result1);
   SetIndexBuffer(1, result2);
   market = Symbol();
}
 
void OnTick(){
   result1 = iCustom(Symbol(),0,"indi1.mq4",0,1); //line0, shift=1
   result2 = iCustom(Symbol(),0,"indi2.mq4",1,1); //line1, shift=1
   
}

Quoting djarum11

Disliked

could someone please help fix... i am not a coder, just a poser (but i am trying) i just want to call the previous bar of the 2 indicators and store them as output buffers. errors i am getting relate to OnCalculate() and SetIndexBuffer. i think i am missing some code thanks #property indicator_chart_window #property indicator_buffers 2 #property indicator_color1 White #property indicator_color2 White string market; double result1,result2; void OnInit() { SetIndexBuffer(0, result1); SetIndexBuffer(1, result2); market = Symbol(); } void OnTick(){...

Ignored

#property indicator_chart_window
 
#property indicator_buffers 2
#property indicator_color1 White
#property indicator_color2 White
 
 
string market;
double PRMBearishPrev[],PRMBullishPrev[],buffers[];
 
 
int init()
{
SetIndexBuffer(0, PRMBearishPrev);
SetIndexBuffer(1, PRMBullishPrev);
 
market = Symbol();
 
return(0);
}
 
 
int start()
{
int counted_bars=IndicatorCounted();
int limit,r,i;
 
if(counted_bars<0) return(-1);
if(counted_bars>0) counted_bars--;
limit=Bars-counted_bars;
if (ArrayRange(buffers,0) != Bars) ArrayResize(buffers,Bars);
 
for(i=limit, r=Bars-limit-1; i>=0; i--,r++)
 
 
PRMBearishPrev[r] = iCustom(Symbol(),0,"PatternRecogMstrv7_bearish",0,1); //line0=bearish reading, shift=1
PRMBullishPrev[r] = iCustom(Symbol(),0,"PatternRecogMstrv7_bullish",1,1); //line1=bullish reading, shift=1
 
 
 
 
return(0);
}

Quoting djarum11

Disliked

thanks, i think this is closer

Ignored

for(i=limit, i>=0; i--) {
    PRMBearishPrev[i] = iCustom(Symbol(),0,"PatternRecogMstrv7_bearish",0,i);
    PRMBullishPrev[i] = iCustom(Symbol(),0,"PatternRecogMstrv7_bullish",1,i);
}

Quoting djarum11

Disliked

but loops are way beyond me (haven't used one since Commodore64 1984...)

Ignored

Quote

Disliked

curiously, when i use the code i posted above, the first buffer returns the correct value but the 2nd buffer returns NULL value (ie. 2nd buffer is not grabbing a value from the original indicator)

Quote

Disliked

'What is the function of the buffers array?' is a complete mystery to me. what is the purpose of it ?

Quote

Disliked

I can handle the iCustom part and the input/output buffers but not loops and the more complex programming concepts, i have no framework in my mind for these, but i want to learn the basics (do not want to become a serious MT4 programmer). thanks for the help

Quoting djarum11

Disliked

in fact, my only purpose of trying to write an iCustom is to grab the bar[1] value of otherwise perfectly fine indictators. but i could not see a way to modify the original indicator to return this value instead of the current bar value. perhaps i don't need an iCustom, perhaps there is a way to read the first closed bar value (the one i need).

Ignored

#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 White
#property indicator_color2 White
 
string market;
double PRMBearishPrev[],PRMBullishPrev[];
 
int init()
  {
   SetIndexBuffer(0, PRMBearishPrev);
   SetIndexBuffer(1, PRMBullishPrev);
   market = Symbol();
  
   return(0);
   }
  
int start()
 
 {
    PRMBearishPrev[1] = iCustom(Symbol(),0,"PatternRecogMstrv7_bearish",0,1); //shift=1  
    PRMBullishPrev[1] = iCustom(Symbol(),0,"PatternRecogMstrv7_bullish",0,1); //shift=1  
 }

Quoting djarum11

Disliked

you are an angel, thank you i hope those links will be helpful as i have had trouble getting my head around the loop stuff whenever i have looked it up in the past. this is what i have now, it is very simple. see below. i suspect i do not need "#property indicator_chart_window" since this is not an indi for a chart window question: if [] denotes an array variable then why do i need [] if i am just grabbing the bar[1] value? when i omit [] MT4 spits a funny error 'no one of the overloads can be applied to a function call' #property indicator_chart_window...

Ignored

#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 White
#property indicator_color2 White
 
string market;
double PRMBearishPrev,PRMBullishPrev;
 
int init()
  {
 
   market = Symbol();
  
   return(0);
   }
  
 
int start()
 {
    PRMBearishPrev = iCustom(Symbol(),0,"PatternRecogMstrv7_bearish",0,1); //shift=1  
    PRMBullishPrev = iCustom(Symbol(),0,"PatternRecogMstrv7_bullish",0,1); //shift=1  
 }

Quoting djarum11

Disliked

ok thanks Ferru. i have eliminated buffers and []'s but now it is completely broken, neither buffer returns a value. #property indicator_chart_window #property indicator_buffers 2 #property indicator_color1 White #property indicator_color2 White string market; double PRMBearishPrev,PRMBullishPrev; int init() { market = Symbol(); return(0); } int start() { PRMBearishPrev = iCustom(Symbol(),0,"PatternRecogMstrv7_bearish",0,1); //shift=1 PRMBullishPrev = iCustom(Symbol(),0,"PatternRecogMstrv7_bullish",0,1); //shift=1 }

Ignored

Quoting djarum11

Disliked

ok thanks Ferru. i have eliminated buffers and []'s but now it is completely broken, neither buffer returns a value.

Ignored

int start()
  { PRMBearishPrev = iCustom(Symbol(),0,"PatternRecogMstrv7_bearish",0,1);
     PRMBullishPrev = iCustom(Symbol(),0,"PatternRecogMstrv7_bullish",0,1);
     Print("Bullish=",PRMBullishPrev,"  Bearish=", PRMBearishPrev); // Check Experts tab in terminal for print data
  }

#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 White
#property indicator_color2 White
double PRMBearishPrev,PRMBullishPrev;
int init()
  {
   SetIndexBuffer(0, PRMBearishPrev);
   SetIndexBuffer(1, PRMBullishPrev);
   return(0);
   }
int start()
  { PRMBearishPrev = iCustom(Symbol(),0,"PatternRecogMstrv7_bearish",0,1);
     PRMBullishPrev = iCustom(Symbol(),0,"PatternRecogMstrv7_bullish",0,1);
     Print("Bullish=",PRMBullishPrev,"  Bearish=", PRMBearishPrev); // Check Experts tab in terminal for print data
  }

Quoting djarum11

Disliked

yes, thank you, your Print works, i see the correct values now i still need to assign the 2 variables in the code below to the output buffers #0 and #1 so Mexcel will pick them up. but SetIndexBuffers still produce an error.

Ignored