Can anyone help to fix this Pip-count indicator?

Dear All,

This up/down PIPs count indicator counts at first the direct bid rate. It has to count 0 for both up & down pips at starting of count and then it has to count normally. Starting first counting bar is the problem can some one fix this issue? The indicator is below & also attached.

Regards,

Vinay

#property indicator_separate_window
#property indicator_buffers 2
#property indicator_color1 Green
#property indicator_color2 Red
//---- buffers
//extern int MaxDrawBars=20;
double ExtMapBuffer1[];
double ExtMapBuffer2[];
double CurrentTick;
double PreviousTick;
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicators
SetIndexStyle(0,DRAW_HISTOGRAM);
SetIndexBuffer(0, ExtMapBuffer1);
SetIndexEmptyValue(0,0.0);

SetIndexStyle(1,DRAW_HISTOGRAM);
SetIndexBuffer(1, ExtMapBuffer2);
SetIndexEmptyValue(1,0.0);

SetIndexDrawBegin(0,1);
SetIndexDrawBegin(1,1);


//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----

//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{
int i, limit=1;

PreviousTick = CurrentTick;
CurrentTick = Bid;

//----
for(i = 0; i < limit; i++)
{
if(CurrentTick > PreviousTick) ExtMapBuffer1 += CurrentTick - PreviousTick;
if(CurrentTick < PreviousTick) ExtMapBuffer2 += PreviousTick - CurrentTick;
}

return(0);
}
//+------------------------------------------------------------------+

ExtMapBuffer1 and ExtMapBuffer2 are arrays, so if you assign a value to them, you need to use [], in this case maybe ExtMapBuffer1

Now I see that the text has changed to italics, please see this post
http://www.forexfactory.com/showthre...35#post7012435

Dear all,

ExtMapBuffer1 & ExtMapBuffer are arrays only, still during attaching the indicator ExtMapBuffer1 is only showing the bid value instead I need to assign zero for both ExtMapBuffer1 & ExtMapBuffer2 before starting calculation.

Starting Bid value should be avoided. Kindly fix the bug in this indicator

If possible someone can fix this indicator?

you have multiple problems with this code...

firstly, if you want to COUNT the ticks then it is no good adding/subtracting the price value of the bid. You need to simply do Tick++ or Tick-- depending of the bid is greater or less than last.

it will not work on historic bars as MT4 does not store ticks.

etc etc.

if you do a search of the web this indicator has been written many times before.