Script to close orders once and only when new bar detected

// no error checking
void start()
{
  int old_bars = Bars;
  while (true)
  {
    if (old_bars != Bars)
    {
      for (int i = OrdersTotal()-1; i >= 0; i--)
      {
        OrderSelect(i, SELECT_BY_POS);
        OrderClose(OrderTicket(), OrderLots(), Ask, 3);
      }
      old_bars = Bars;//or return;
    }
    Sleep(1);
  }
}

Quote

Disliked

datetime old_bar = 0;

int start()
{

while(true)
{


if (Time[0] != old_bar)
{
for (int i = OrdersTotal() - 1; i >= 0; i--)
{
if(OrderSelect(i,SELECT_BY_POS)==true)
{
int ticket=OrderTicket();
double lots=OrderLots();
OrderClose(ticket,lots,Ask,3);
}
}
} old_bar = Time[0];
}

}

Quoting pipdigging

Disliked

Hi nubcake,

Thanks for your input. I have then tried with Time[0]. But without success. it does close the opened orders (not pending) when I attach the script to my minute chart. But when I place new orders before (not pending) the end of the bar and when the current bar closes it would not close the newly opened orders. Any thoughts ?

Ignored

datetime old_bar = 0;
 
int start() {
  while(true)  { 
    if (Time[0] != old_bar)  {  
      for (int i = OrdersTotal() - 1; i >= 0; i--) {
        if(OrderSelect(i,SELECT_BY_POS) == true) {
          int ticket=OrderTicket();
          double lots=OrderLots();
          OrderClose(ticket,lots,Ask,3);
        }
      }
      old_bar = Time[0];  // <-- this is where you should have put it.  it only updates after a new bar starts
    }
    //old_bar = Time[0];  // <--- this is where you had it.  this is in the wrong spot.  it runs every tick, not on new bars
  }
}

Quoting pipdigging

Disliked

Thanks for updating the code. However, for some reason it does close all existing orders when script is initially attached, but if I open new orders after the next bar opens it would not close anymore anything when a new bar is formed !
Would an EA version be better ?

Ignored