Help Coding vertical lines with EA

Hi,

I took some code from someone's indicator for drawing vertical lines. I've used the code in an EA and want to run the EA purely to draw the lines over a six month period so that I can look at the chart afterwards for manual backtesting purposes.

The problem is that when a new line is drawn (at a market open) the previous line is deleted, which is no good for backtesting. I tried commenting out the first line:

ObjectDelete("MMl"+DoubleToStr(i,0));

But that wasn't successful. I'd appreciate any help please. I'll paste the function below, as well as where I call it from the start() function. Thanks.

int VerticalLine(string s,int i,int st,int Col)
{
ObjectDelete("MMl"+DoubleToStr(i,0));
val1=Low[Lowest(NULL,0,MODE_LOW,BarsPerWindow(),0)];
val2=High[Highest(NULL,0,MODE_HIGH,BarsPerWindow(),0)];
ObjectCreate("MMl"+DoubleToStr(i,0),OBJ_TREND,0,Time[i],0,Time[i],900);
ObjectSet("MMl"+DoubleToStr(i,0),OBJPROP_COLOR,Col);
ObjectSet("MMl"+DoubleToStr(i,0),OBJPROP_WIDTH,2);
ObjectSet("MMl"+DoubleToStr(i,0),OBJPROP_STYLE,st);
ObjectSet("MMl"+DoubleToStr(i,0),OBJPROP_RAY,0);
ObjectDelete("MMt"+DoubleToStr(i,0));
ObjectCreate("MMt"+DoubleToStr(i,0),OBJ_TEXT,0,Time[i],val2+Point*3);
ObjectSetText("MMt"+DoubleToStr(i,0),s,10,"Arial",Col);
ObjectSet("MMt"+DoubleToStr(i,0), OBJPROP_ANGLE, 90); //Rotates text 90 degrees
ObjectsRedraw();
return(0);
}
//======================================
int start()
{
h=TimeHour(Time[0]);
m=TimeMinute(Time[0]);

if ((h==7) && (m==0)) {VerticalLine("LO",0,STYLE_SOLID,Aqua);}
if ((h==13) && (m==30)) {VerticalLine("NYO",0,STYLE_SOLID,Orange);}

return(0);
}
//=================

Thanks people

The code that deletes the line is most likely not in anything you posted.

Look for something like:

if (ObjectFind("Line") > -1) {
ObjectDelete("Line");
}

But it's hard to say from the smidgen of code you showed us.

no, if you look again you'll see that the line is just being moved forward all the time when a new timezone wakes up. it's only tracking 2 timezones and shifting them forward every 24 hours, object delete or not (in fact the delete is redundant).

edit : i think the 2 if tests could just be wrapped into a while loop that just seeks bars into the past until hitting some max 'found' amount or the end of the history, plotting newly found times that match. too busy to care enough to do it and test it, but small easy job for someone bored enough.

Yup, you're spot on.

I didn't look that close LOL

But I did see the redundancy in the delete, which prompted my premature post.

Thanks for pointing that out!

Thanks guys, I appreciate it. I'll just attach the whole thing and you'll see there's not much more to it than the code I pasted. I suspect that it's not even using two lines, but only one for both opens, since it loses the previous line as soon as the new one appears.

I'll give it a go and hopefully manage to fix it.

Thanks again.

dude, just do some time in the search box as i'm sure you'd come across something more than suitable quicker than any of us would take to re-work the code. i'd be surprised if you don't find something far better that works perfectly.

and yes, you are correct about it not even doing the two lines. each time it just plots line '0' over and over. whoever did this is obviously taking their first steps in coding and is trying to find their way a bit.

Hey Nubcake,

Thanks. Found something, and found someone else had posted snippets of code to make it the way I want it... working great now. Thanks for your trouble.

Good trading to you