jiva34's BB Stop auto-trader by SteveHopwood

Quoting pah

Disliked

Do you know which particular routines are responsible/afflicted Steve? I can have a look for it later today.

Regards, Paul.

Ignored

Quoting skoda2008

Disliked

I've looked at the code and can't find anything wrong with it either.

I'm not sure if this helps, but I did notice the buy signal would have been correct if the EA was running on a 5min chart.

Ignored

Quoting SteveHopwood

Disliked

Not quite there with the code yet.

The bot took this trade earlier. This would have been correct had there been a HalfLot trade already in place but there wasn't, so this was a premature trade.

Ignored

//Close opposite direction trades on a SlowTrend change
      if (SlowTrend == up && SellOpen && !HedgingInProgress)
      {
         CloseAllTrades();
         if (ForceTradeClosure) 
         {
            CloseAllTrades();
            OldBars = 0;
            return;
         }//if (ForceTradeClosure) 
      }//if (SlowTrend == up && BuyOpen)
      
      
      if (SlowTrend == down && BuyOpen && !HedgingInProgress)
      {
         CloseAllTrades();
         if (ForceTradeClosure) 
         {
            CloseAllTrades();
            OldBars = 0;
            return;
         }//if (ForceTradeClosure) 
      }//if (SlowTrend == up && BuyOpen)

//Close opposite direction trades on a SlowTrend change
      if (SlowTrend == up && SellOpen && !HedgingInProgress)
      {
         CloseAllTrades();
         OldBars = 0;
         if (ForceTradeClosure) 
         {
            CloseAllTrades();
            OldBars = 0;
            return;
         }//if (ForceTradeClosure) 
      }//if (SlowTrend == up && BuyOpen)
      
      
      if (SlowTrend == down && BuyOpen && !HedgingInProgress)
      {
         CloseAllTrades();
         OldBars = 0;
         if (ForceTradeClosure) 
         {
            CloseAllTrades();
            OldBars = 0;
            return;
         }//if (ForceTradeClosure) 
      }//if (SlowTrend == up && BuyOpen)

Quoting SteveHopwood

Disliked

void ReadIndicatorValues() sets up the variables that void LookForTradingOpportunities() works with.

SlowTrend and FastTrend are seti to up or down - constants that the program works with i.e. up = "Up" etc, but I imagine you know this already,

CountOpenTrades() increments the value of OpenTrades from zero whenit finds open trades.

Therefore, in LookForTradingOpportunities() the EU buy should not have triggered because

double SendLots = HalfLot;//Initialise with a default value

initialises SendLots with the initial lot size

then...

Ignored

Quoting hiredwhip

Disliked

After doing a bunch of reading it look's really interesting Steve....I've used a system of jiva's once before and it also was a lot of fun....Have it loaded up and will give it a go.....
BTW, I also read the post by forexpippy on hedging....have never seen that before.....I didn't see anything that would tell me that he copy and pasted that from somewhere else so I will assume that he wrote that himself.....If he did he ought to get a vouch for that, without a doubt the two best paragraph's on hedging I've ever read...
I hope he reads this and confirms...

Ignored

Quoting pah

Disliked

I wonder if the gap would cause the CBI code to open a trade. Maybe CBI code shouldn't run first thing on Mondays.

Regards, Paul.

Ignored

Quoting skoda2008

Disliked

I have been watching this trade today (on the 1 min chart just to see what happens). It seems to enter as expected, except for one thing; If a trade is closed when the BB Stop changes direction, a trade in the opposite direction is not opened until the NEXT change in direction of the BB Stop indicator. What this means is that only every second trading opportunity is opened, and in effect every trade will be in the same direction as the very first trade when the EA was started.

I suggest changing:

Ignored

Quoting wfh2006

Disliked

Steve,

I'm not sure if this is the issue, but shouldn't CloseAllTrades() reset BuyOpen and SellOpen back to false and OpenTrades to 0? I'm not sure if this would actually happen, but as written, the Start() proc could call routines in this order:

CountOpenTrades() -- will set BuyOpen/SellOpen and OpenTrades
CloseAllTrades() -- when there is a slow trend change
LookForTradingOpportunities() -- calls this without counting existing trades again

George

Ignored

Quoting SteveHopwood

Disliked

We also need NoSundayTrading and MondayTradingStartTime filters to avoid trading the very start of the week. There is no rush for this, so I shall add this sometime this week.

Ignored

   //Find open trades.
   CountOpenTrades();
[color=Red]   if (OpenTrades > 0)
   {
      if (OrderProfit() > 0) TradeManagementModule();
      LookForTradeClosure();
   }//if (OpenTrades > 0)
[/color]

Quoting forexpippy

Disliked

Many thanks for the kind words whip Certainly brightened up an otherwise dreary monday morning.

I can confirm that it's my parable.

Ignored