Learning to Code Question (sangmane)

extern int CumProfitStart = 00;

if(AllowTrade == True) TradeTaken = "No ("+DoubleToStr(cummulativeProfit(CumProfitStart),2)+")";

[color=black]double[/color] cummulativeProfit(int startHour)
{
int totalHistory = OrdersHistoryTotal(); //get number of history orders in orders' pool
double profit = 0; //set initial profit = 0
datetime thistime = TimeCurrent(); //now use TimeCurrent() instead of Time[0], to avoid logic flaw when run on 24 Hr cycle
datetime startTime = StrToTime(TimeToStr(thistime,TIME_DATE)+" "+startHour+":00"); //construct startTime based on startHour and current day, month, year
if(thistime<startTime) startTime = startTime-24*60*60; //check if current time is behind startTime, subtract startTime by 24 hours
for(int i = totalHistory-1; i>=0; i--)
{
  OrderSelect(i, SELECT_BY_POS, MODE_HISTORY); //check if order's close time behind starttime, exit loop
  if(OrderCloseTime() < startTime) break;
     profit += OrderProfit();    
}
return(NormalizeDouble(profit,2)); //accumulate profit
}

extern int CountTradesStart = 00;

Comment......
# Trades Today = ", cummulativeTradeCount(CountTradesStart), "\n",

[color=red]int[/color] cummulativeTradeCount(int startHour)
{
int totalHistory = OrdersHistoryTotal(); //get number of history orders in orders' pool
int TradeCount = 0; //set initial count = 0
datetime thistime = TimeCurrent(); //now use TimeCurrent() instead of Time[0], to avoid logic flaw when run on 24 Hr cycle
datetime startTime = StrToTime(TimeToStr(thistime,TIME_DATE)+" "+startHour+":00"); //construct startTime based on startHour and current day, month, year
if(thistime<startTime) startTime = startTime-24*60*60; //check if current time is behind startTime, subtract startTime by 24 hours
[color=red]for(int k = totalHistory-1; k>=0; k--) [/color]
{
  OrderSelect(k, SELECT_BY_POS, MODE_HISTORY); //check if order's close time behind starttime, exit loop
  if(OrderCloseTime() < startTime) break;
     if(OrderSymbol()==Symbol() && OrderMagicNumber() == MagicNumber) TradeCount++;    
}
return(TradeCount); //
}

Quoting EKnockers

Disliked

The following code was provided courtesy of sangmane. It accummulates profit for a user defined 24 hr period:

Ignored

for(int i = totalHistory-1; i>=0; i--) 

for(int i = 0; i<totalHistory; i++)