Make EA get custom magic number...will this work? | Page 2 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Need Script/EA can only generate Magic number 5 replies

GBPUSD Magic Number 45 replies

Comment vs. Magic Number 2 replies

can we manually assign a magic number 4 replies

Ever seen this magic number bug? 4 replies

Attachments: Make EA get custom magic number...will this work?
Exit Attachments

Make EA get custom magic number...will this work?

  • #21
  • Edited 7:21pm Sep 3, 2011 7:00pm | Edited 7:21pm
Raptor

to more understand what the first post is doing here is a few screen shots they do not show the complet code blocks however;


the First shot shows the creation of a signature file, this code only gets visited IF no signature file is found or if it is corrupted. this code will write a new signature but it will fill it with default settings, the two marks in front of the word HOLD: are meaningful. These settings after the file is created contains the last setting of the system, and when you fire up the system the old settings are reinstalled.

the second shot shows the creation of the devices which get visited only once.

the third shot shows the code block to set a device. there are 6 different types of devices. a device is basicly a switch nothing more.

There are other controls (not shown) this is the code lines that creates them;

1 $_CreateDisPatch( $_ControlID, Name );
this is an order control to tell the Executor to place an order of a type;

2 $_CreatePort( $_ControlID, Name );
A port is a two way control. a program must request data and the program that responds with the data requested. no out put is done till a request is made.

3 $_CreateFeed( $_ControlID, Name );
a feed is a control that sends out data in a continual stream that can be any type data. any program that read it must know what it contains. This is a one way communication a program can not request any data

4 $_CreateStream( $_ControlID, "Error Handler", Empty, Clear );
a stream is a communications port that doesnot dispatch information all the time it only send information on an event. Any program can stream out data to this control, there must be a program that stands by and reads this control and reponds to it. Other events can include communication, news evens, time events, market events etc...

I use screen shots a lot as my english is not good and it takes me a long time to try to explain anything in writing,

Keit


Quoting RaptorUK
OK, maybe I misunderstood what you were describing, I understand the use of a GlobalVariable for a mutex . . . I guess the other is just to prevent two EAs using the same root number for it's Object names, etc ?
Attached Image(s) (click to enlarge)
Click to Enlarge Name: defaults.jpg Size: 150 KB
Click to Enlarge Name: Create Devices.jpg Size: 124 KB
Click to Enlarge Name: sets a device.jpg Size: 84 KB
Trader Keit ... Methods Of A Dirt Road Mad Man....
  • #22
  • Sep 4, 2011 12:03am Sep 4, 2011 12:03am
FWIW, I use the following function:

Inserted Code
//+------------------------------------------------------------------+
int GetHash(string str)   {
//+------------------------------------------------------------------+
  int sum = 0;
  for (int i=0; i<StringLen(str); i++)
    sum = sum + (i+1)*MathPow(StringGetChar(str,i),2);
  return(sum);
}

Passing it a currency string, e.g. GetHash("EURUSD") or GetHash(Symbol()) happens to return a unique value for each of these pairs:

AUDCAD99372
AUDCHF105823
AUDJPY133977
AUDNZD125127
AUDUSD123636
CADJPY128241
CHFJPY130987
EURAUD120152
EURCAD106208
EURCHF112659
EURGBP119727
EURJPY140813
EURNZD131963
EURUSD130472
GBPAUD113722
GBPCAD99778
GBPCHF106229
GBPJPY134383
GBPNZD125533
GBPUSD124042
NZDJPY137586
NZDUSD127245
USDCAD101700
USDCHF108151
USDJPY136305
  • #23
  • Edited 6:25am Sep 4, 2011 6:02am | Edited 6:25am
Well since im a "newbie" to coding i think this is easiest for my problem. I just added the period to the symbol so each TF would have its own magic number for that symbol & TF. This is what i have but of course for each pair i wanted to trade i would have to do it for. Thanks to who have replied but most are WAY to complex for me to add .
Inserted Code
//+----------------------------------------------------------------------------+
//|  Get Magic Number For Pair & Time Frame                                    |
//+----------------------------------------------------------------------------+
int GetMagicNumber() {
 // EURUSD
 if (Symbol()=="EURUSD" && PERIOD_M1)  return(101);
 if (Symbol()=="EURUSD" && PERIOD_M5)  return(105); 
 if (Symbol()=="EURUSD" && PERIOD_M15) return(115);
 if (Symbol()=="EURUSD" && PERIOD_M30) return(130);
 if (Symbol()=="EURUSD" && PERIOD_H1)  return(160);
 if (Symbol()=="EURUSD" && PERIOD_H4)  return(1240);
 if (Symbol()=="EURUSD" && PERIOD_D1)  return(11440);
 // GBPUSD 
 if (Symbol()=="GBPUSD" && PERIOD_M1)  return(201);
 if (Symbol()=="GBPUSD" && PERIOD_M5)  return(205); 
 if (Symbol()=="GBPUSD" && PERIOD_M15) return(215);
 if (Symbol()=="GBPUSD" && PERIOD_M30) return(230);
 if (Symbol()=="GBPUSD" && PERIOD_H1)  return(260);
 if (Symbol()=="GBPUSD" && PERIOD_H4)  return(2240);
 if (Symbol()=="GBPUSD" && PERIOD_D1)  return(21440);
// AUDUSD 
 if (Symbol()=="AUDUSD" && PERIOD_M1)  return(301);
 if (Symbol()=="AUDUSD" && PERIOD_M5)  return(305); 
 if (Symbol()=="AUDUSD" && PERIOD_M15) return(315);
 if (Symbol()=="AUDUSD" && PERIOD_M30) return(330);
 if (Symbol()=="AUDUSD" && PERIOD_H1)  return(360);
 if (Symbol()=="AUDUSD" && PERIOD_H4)  return(3240);
 if (Symbol()=="AUDUSD" && PERIOD_D1)  return(31440);
// NZDUSD
 if (Symbol()=="NZDUSD" && PERIOD_M1)  return(401);
 if (Symbol()=="NZDUSD" && PERIOD_M5)  return(405); 
 if (Symbol()=="NZDUSD" && PERIOD_M15) return(415);
 if (Symbol()=="NZDUSD" && PERIOD_M30) return(430);
 if (Symbol()=="NZDUSD" && PERIOD_H1)  return(460);
 if (Symbol()=="NZDUSD" && PERIOD_H4)  return(4240);
 if (Symbol()=="NZDUSD" && PERIOD_D1)  return(41440);
// USDCHF
 if (Symbol()=="USDCHF" && PERIOD_M1)  return(501);
 if (Symbol()=="USDCHF" && PERIOD_M5)  return(505); 
 if (Symbol()=="USDCHF" && PERIOD_M15) return(515);
 if (Symbol()=="USDCHF" && PERIOD_M30) return(530);
 if (Symbol()=="USDCHF" && PERIOD_H1)  return(560);
 if (Symbol()=="USDCHF" && PERIOD_H4)  return(5240);
 if (Symbol()=="USDCHF" && PERIOD_D1)  return(51440);
// USDJPY
 if (Symbol()=="USDJPY" && PERIOD_M1)  return(601);
 if (Symbol()=="USDJPY" && PERIOD_M5)  return(605); 
 if (Symbol()=="USDJPY" && PERIOD_M15) return(615);
 if (Symbol()=="USDJPY" && PERIOD_M30) return(630);
 if (Symbol()=="USDJPY" && PERIOD_H1)  return(660);
 if (Symbol()=="USDJPY" && PERIOD_H4)  return(6240);
 if (Symbol()=="USDJPY" && PERIOD_D1)  return(61440); 
// USDCAD
 if (Symbol()=="USDCAD" && PERIOD_M1)  return(701);
 if (Symbol()=="USDCAD" && PERIOD_M5)  return(705); 
 if (Symbol()=="USDCAD" && PERIOD_M15) return(715);
 if (Symbol()=="USDCAD" && PERIOD_M30) return(730);
 if (Symbol()=="USDCAD" && PERIOD_H1)  return(760);
 if (Symbol()=="USDCAD" && PERIOD_H4)  return(7240);
 if (Symbol()=="USDCAD" && PERIOD_D1)  return(71440); 
// XAUUSD(GOLD)
 if (Symbol()=="XAUUSD" && PERIOD_M1)  return(801);
 if (Symbol()=="XAUUSD" && PERIOD_M5)  return(805); 
 if (Symbol()=="XAUUSD" && PERIOD_M15) return(815);
 if (Symbol()=="XAUUSD" && PERIOD_M30) return(830);
 if (Symbol()=="XAUUSD" && PERIOD_H1)  return(860);
 if (Symbol()=="XAUUSD" && PERIOD_H4)  return(8240);
 if (Symbol()=="XAUUSD" && PERIOD_D1)  return(81440); 
// XAGUSD (SIVER)
 if (Symbol()=="XAGUSD" && PERIOD_M1)  return(901);
 if (Symbol()=="XAGUSD" && PERIOD_M5)  return(905); 
 if (Symbol()=="XAGUSD" && PERIOD_M15) return(915);
 if (Symbol()=="XAGUSD" && PERIOD_M30) return(930);
 if (Symbol()=="XAGUSD" && PERIOD_H1)  return(960);
 if (Symbol()=="XAGUSD" && PERIOD_H4)  return(9240);
 if (Symbol()=="XAGUSD" && PERIOD_D1)  return(91440);    
return;
}// end int GetMagicNumber()
  • #24
  • Sep 4, 2011 6:28am Sep 4, 2011 6:28am
MQL.com is back up now so here is the code i was talking about but it says it will not work for more then 1 trade per pair. But it would make what i added a heck of alot shorter so working on adding it right now but getting a few errors.

Inserted Code
 
string GetSymbol=Symbol();
int MNSymbol,MNSymbolCalc,MagicNumber;
for(int a=0;a<6;a++)//turn the Symbol() into an ASCII string and add each character into MNSymbol
{
MNSymbolCalc=StringGetChar(GetSymbol, a);
MNSymbolCalc=((MNSymbolCalc-64)*(MathPow(10,(a))));//subtract 64 b/c ASCII characters start at 65, multiply result by the a-th power for neatness (unnecessary though)
MNSymbol = MNSymbol+MNSymbolCalc;
} 
int MNPeriod=Period();
int MNEACode=100000;//Make this number different for each EA to prevent two different types of EA's choosing the same Magic Number
MagicNumber=MNSymbol+MNPeriod+MNEACode;
  • #25
  • Sep 4, 2011 6:31am Sep 4, 2011 6:31am
Quoting Dredding82
Well since im a "newbie" to coding i think this is easiest for my problem. I just added the period to the symbol so each TF would have its own magic number for that symbol & TF. This is what i have but of course for each pair i wanted to trade i would have to do it for. Thanks to who have replied but most are WAY to complex for me to add .
Why don't you just use the TF for your MagicNumber ? you don't need to put anything to do with the Symbol into the MagicNumber because you can get the Symbol from the Order info . . .

OrderSelect(. . . );
OrderSymbol();
20 pips a day isn't too much to ask . . .
  • #26
  • Sep 4, 2011 6:34am Sep 4, 2011 6:34am
Quoting RaptorUK
Why don't you just use the TF for your MagicNumber ? you don't need to put anything to do with the Symbol into the MagicNumber because you can get the Symbol from the Order info . . .

OrderSelect(. . . );
OrderSymbol();
I have no clue man........i am just going by what i read and understand. The last post i made has the code i want to use which would do what you say i think.
  • #27
  • Edited 1:30pm Sep 4, 2011 12:42pm | Edited 1:30pm
Ok since i have the magic number stuff added and i am going to be giving the EA out once i am done with it for testing i need to know if this stuff looks good since its the weekend and the markets are not open yet so i have no tick data coming in. I am only adding this for the testing period so if the EA does work and people like it they WILL message me after the trail ends with there feed back on any changes or bugs that need to be fixed instead of just running off with there code or trying to sell it on some website. I also know someone could decompile the ex4 so i should use a .dll file or some other kind of protection but like i have said i am a newbie to coding so the easy stuff will work for me. Plus adding this basic stuff as i see it helps me work on my coding SKILLZ...lol

Inserted Code
//+----------------------------------------------------------------------------+
//|  Start (called after each tick)                                            |
//+----------------------------------------------------------------------------+
 int start()
 {
 
   // Check For Password-----------------------------------
     if (Password != "Freebie Newbie") //change to the password  
     SignalBUY = false;
     SignalSELL = false;     
     {
         Alert ("Wrong Password!");
         return (0);  
     }
 
 
   // Check Expire Date-----------------------------------
  datetime expiry=D'2011.12.25 00:00';
   if(TimeCurrent()>expiry)
   SignalBUY = false;
   SignalSELL = false;
   {
   Alert("This Expert Advisor Has Expired.."); 
   return(0); 
   }
 
 
 
   // Check account number-----------------------------------   
   int hard_accnt = 0; //<-- type the user account here 
   int accnt = AccountNumber();
   if (accnt != hard_accnt)
   SignalBUY = false;
   SignalSELL = false;
    {
       Alert ("You Can Not Use Account #(" + DoubleToStr(accnt,0) + ") With This Program!");  
      return(0);
    }
 
 
   // Allow Use Only On Demo-----------------------------------     
   bool demo_account = IsDemo();
 
   if (!demo_account)
   SignalBUY = false;
   SignalSELL = false;   
    {
       Alert ("You Can Not Use This Program With A Real Account!"); 
      return(0);
    }
  • #28
  • Sep 4, 2011 1:03pm Sep 4, 2011 1:03pm
Quoting Dredding82
Ok since i have the magic number stuff added and i am going to be giving the EA out once i am done with it for testing i need to know if this stuff looks good since its the weekend and the markets are not open yet so i have no tick data coming in.
Why don't you test it with the Strategy Tester ?
20 pips a day isn't too much to ask . . .
  • #29
  • Sep 4, 2011 1:05pm Sep 4, 2011 1:05pm
Quoting RaptorUK
Why don't you test it with the Strategy Tester ?
Didnt know you could test that stuff with the tester..will check it out, Thanks!
  • #30
  • Sep 4, 2011 1:09pm Sep 4, 2011 1:09pm
Quoting RaptorUK
Why don't you test it with the Strategy Tester ?
Ok just did the tester but the popup alert doesnt seem to work. It did tell the EA that all buys/sells are false and did not take any trades. Is there something wrong with the code for the alert or how i have it coded? or is it just because its the tester and its not tick data but stored data?
  • #31
  • Sep 4, 2011 1:47pm Sep 4, 2011 1:47pm
Quoting Dredding82
Ok just did the tester but the popup alert doesnt seem to work. It did tell the EA that all buys/sells are false and did not take any trades. Is there something wrong with the code for the alert or how i have it coded? or is it just because its the tester and its not tick data but stored data?
Some things don't fully work in the Strategy Tester . . . e.g. Alerts

http://articles.mql4.com/72
20 pips a day isn't too much to ask . . .
  • #32
  • Sep 4, 2011 1:52pm Sep 4, 2011 1:52pm
Quoting RaptorUK
Some things don't fully work in the Strategy Tester . . . e.g. Alerts

http://articles.mql4.com/72
Ok thanks man...was just checking lol
  • #33
  • Edited 2:01am Sep 5, 2011 1:45am | Edited 2:01am
Quoting zznbrm
Instead of having a unique Magic Number for each trade, why not simply use the Ticket Number?
so just put this.........


GetTicketNumber = OrderTicket(); ?


THATS FU*KING K.I.S.S if i ever seen it! lol

It compiles in my EA and looks like it will do what i need it to do for checking for open orders and tracking them with my money management i have in the EA.

Thanks
Dredding82
  • #34
  • Sep 5, 2011 2:02am Sep 5, 2011 2:02am
no.... NOT USING MAGIC NUMBERS AT ALL.... is k.i.s.s.

if all you care about is doing some mathemagic based on floating risk on a particular currency pair due to already open orders then all you need to do is iterate through all open orders and only pay attention to the ones on the particular symbol() the ea is currently running.

e.g. if you have the EA running on ABC/DEF and QRS/TUV, but you don't want to confuse orders between the two different pairs.... you just check that the symbol the EA is running on is also the same as the open orders you are iterating through

Inserted Code
int c;

for (c = 0; c < OrdersTotal(); c++) {
  OrderSelect(c, SELECT_BY_POS, MODE_TRADES);
  if (OrderSymbol() == Symbol() {
////// DO STUFF HERE!!!
  }
}

if you are coding something, and it just seems WAY TOO HARD, then you are doing it wrong. period.
Congratulations ScalaFX for coming out of the closet!
  • #35
  • Sep 5, 2011 2:17am Sep 5, 2011 2:17am
Quoting nubcake
no.... NOT USING MAGIC NUMBERS AT ALL.... is k.i.s.s.

if all you care about is doing some mathemagic based on floating risk on a particular currency pair due to already open orders then all you need to do is iterate through all open orders and only pay attention to the ones on the particular symbol() the ea is currently running.

e.g. if you have the EA running on ABC/DEF and QRS/TUV, but you don't want to confuse orders between the two different pairs.... you just check that the symbol the EA is running on is also the same as the open orders...
Yea i got that part but with the money management its a bit complex so i want to make sure it checks the symbol and some speacial number for the order to not confuse one order on that pair with another that could be open on the same pair with the same time frame or same pair and a different time frame...This is part of the code below;

Inserted Code
   int cnt, total = OrdersTotal();
   if(OrdersTotal() == 0)
      PartialClose = false;
   for (cnt = 0; cnt < total; cnt++)
   {
      OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
      if (UsePartialClose) 
         Lots2Close = NormalizeDouble(OrderLots() * LotClosePercent/100, precision);
      if (OrderType() <= OP_SELL && OrderSymbol() == Symbol() && OrderTicket() == GetTicketNumber)
  • #36
  • Sep 5, 2011 2:28am Sep 5, 2011 2:28am
Quoting Dredding82
Yea i got that part but with the money management its a bit complex so i want to make sure it checks the symbol and some speacial number for the order to not confuse one order on that pair with another that could be open on the same pair with the same time frame or same pair and a different time frame...This is part of the code below;

[code]
int cnt, total = OrdersTotal();
if(OrdersTotal() == 0)
PartialClose = false;
for (cnt = 0; cnt < total; cnt++)
{
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if (UsePartialClose)...
none of that code has anything at all to do with timeframes....

if you are trying to isolate different timeframe strategies, then just set your magic number to the timeframe the ea is currently running on! it won't matter a damn if you have EURUSD orders and GBPUSD orders and JPYGBP orders etc etc that all happen to have the same magic number because they happen to be running the same timeframe chart, because you are still checking if the EA is looking at an order that is on it's own currency pair via testing Symbol() against OrderSymbol().

if symbol() == ordersymbol() and period() == ordermagic() then the EA has found an order that is on the currency pair the EA is running on and also the magic number happens to match the period the EA is running on.... so if when you open orders you specify the magic number to be the period the chart is currently showing then your EA will find the orders you specifically want.

the timeframes are matched, and the currency pair is matched. does this not isolate the orders you seem to be wanting to be able to specifically find?
Congratulations ScalaFX for coming out of the closet!
  • #37
  • Sep 5, 2011 2:33am Sep 5, 2011 2:33am
Quoting nubcake
none of that code has anything at all to do with timeframes....

if you are trying to isolate different timeframe strategies, then just set your magic number to the timeframe the ea is currently running on! it won't matter a damn if you have EURUSD orders and GBPUSD orders and JPYGBP orders etc etc that all happen to have the same magic number because they happen to be running the same timeframe chart, because you are still checking if the EA is looking at an order that is on it's own currency pair via testing Symbol() against OrderSymbol().

if...
Your not getting what i am saying......the EA can open more then one(1) order on the same time frame for the same pair. If the EA is only looking at the sybmol and time frame then it might get the SL,TP,BE,TSL,Partial close.....etc wrong for the trade. It might mix up the first open order for the second or the first for the third since its ONLY looking at the sybmol and time frame.
If i just wanted one order per time frame per pair them im set....thats easy.........the code above doesnt have to do anything with time frames because it does not need to since it is checking the ticket number for the trade that needs to have its SL,TP,TSL....etc adjusted. which each ticket number is different so you do not need to include a time frame unless you wish to for your own reasons.
  • #38
  • Sep 5, 2011 2:52am Sep 5, 2011 2:52am
Quoting RaptorUK
Why don't you just use the TF for your MagicNumber ? you don't need to put anything to do with the Symbol into the MagicNumber because you can get the Symbol from the Order info . . .

OrderSelect(. . . );
OrderSymbol();
I didnt know know all this till i was reading the code and mql.com seeing what everything does. The EA i made is a copy and paste EA that i took parts from this one, that one...alil from here and alil from there......lol it has taken me months to get done though...

Thanks
  • #39
  • Sep 5, 2011 3:12am Sep 5, 2011 3:12am
Quoting Dredding82
I didnt know know all this till i was reading the code and mql.com seeing what everything does. The EA i made is a copy and paste EA that i took parts from this one, that one...alil from here and alil from there......lol it has taken me months to get done though...

Thanks
You are welcome . . . learning all this stuff takes time, seems like you are learning keep going and you will get there.
20 pips a day isn't too much to ask . . .
  • #40
  • Sep 5, 2011 3:27am Sep 5, 2011 3:27am
Quoting Dredding82
Your not getting what i am saying......the EA can open more then one(1) order on the same time frame for the same pair. If the EA is only looking at the sybmol and time frame then it might get the SL,TP,BE,TSL,Partial close.....etc wrong for the trade. It might mix up the first open order for the second or the first for the third since its ONLY looking at the sybmol and time frame.
If i just wanted one order per time frame per pair them im set....thats easy.........the code above doesnt have to do anything with time frames because it does not need...
come on man!

... so then you just check OrderOpenTime()!!!!! pump the relevant ticket data that meets the specific chart criteria (currency, timeframe), then just bubble-sort the array data per the OrderOpenTime()!

now you have orders that match the following required criteria...

the currency pair
the timeframe
and you have these listed in your array in the order that they are opened.

none of this requires you having these hand-made tables of different magic numbers for different pairs and timeframes and whatever other nonsensical thing you can add!

i guarantee you that you are making things hard for yourself.

from what i have read of what you are trying to do i don't see why you would think that doing things like making the magic number = the order ticket number would help in any way.... the ticket number is the ticket number, so matching a magic number to that is redundant and pointless.

anyway... my interest in this has waned and i'm probably not understanding what you are trying to do. good luck.
Congratulations ScalaFX for coming out of the closet!
0 traders viewing now