BigBob: Nanningbob V10 auto-trading robot by SteveHopwood | Page 17 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Nanningbob 4h trading system ver. 5.0 4,432 replies

Nanningbob 60x90 EA 3,920 replies

Require help amending Nanningbob v10 EA 0 replies

Help regarding NanningBob EA 27 replies

Nanningbob 4H trading system 2,017 replies

Attachments: BigBob: Nanningbob V10 auto-trading robot by SteveHopwood
Exit Attachments

BigBob: Nanningbob V10 auto-trading robot by SteveHopwood

  • #321
  • Sep 1, 2011 7:29am Sep 1, 2011 7:29am
Quoting batemap
Y, sorry you are correct.

Paul
...only from time to time, hehe.
I don't say
  • #322
  • Sep 1, 2011 8:13am Sep 1, 2011 8:13am
Sorry, guys
Have done the suggested additions into code, tested it with Hedge enabled and without it, but I have to report:

Luc is still there!
I don't say
  • #323
  • Sep 1, 2011 12:04pm Sep 1, 2011 12:04pm
Quoting dragosd1
Sorry, guys
Have done the suggested additions into code, tested it with Hedge enabled and without it, but I have to report:

Luc is still there!
Maybe you could provide your exact settings (just save the settings file in the backtester), symbol and time when the error occurred - so I can backtest it .

Cheers
Martin
  • #324
  • Sep 1, 2011 12:10pm Sep 1, 2011 12:10pm
I have been trying to post a *.set file so someone could review the settings and help clear something up for me, but when I try to attach the file I get an error saying it is an invalid file?
  • #325
  • Sep 1, 2011 12:22pm Sep 1, 2011 12:22pm
Quoting panamamike
I have been trying to post a *.set file so someone could review the settings and help clear something up for me, but when I try to attach the file I get an error saying it is an invalid file?
You have to change the file extension to one that is allowed by FF and tell people to change it back, or zip it.

Ridiculous restriction in a Forex forum, but we can't have everything.

  • #326
  • Sep 1, 2011 12:27pm Sep 1, 2011 12:27pm
There you go...
Set is pretty much default, except values for Carolco lots, no SL for Carolco.
Set file in archive.
Attached Image (click to enlarge)
Click to Enlarge Name: bb01.09.2011.gif Size: 28 KB
Attached File(s)
File Type: rar newbbd1.rar   2 KB | 478 downloads
I don't say
  • #327
  • Edited 1:03pm Sep 1, 2011 12:50pm | Edited 1:03pm
I am using MPTM to manage NB 1hr CT trades that I am trading in addition to BigBob. When it places a hedge trade, the hedge part closes shortly after going +ve, and basically leaving me where I was before the hedge was entered. I have it set to close the hedged pair at BE.
Attached File(s)
File Type: zip 40js+30bephedgex2-100.zip   2 KB | 419 downloads
  • #328
  • Sep 1, 2011 5:07pm Sep 1, 2011 5:07pm
I have a bit of light relief for you guys - another EU scalper. http://www.forexfactory.com/showthread.php?t=312723 for details.

  • #329
  • Sep 2, 2011 2:13am Sep 2, 2011 2:13am
Hello,
BB has just opened multiple hedge trade. Is that what suppose to be done?
Attached Image (click to enlarge)
Click to Enlarge Name: hedge.jpg Size: 75 KB
  • #330
  • Sep 2, 2011 2:28am Sep 2, 2011 2:28am
Quoting peje
Hello,
BB has just opened multiple hedge trade. Is that what suppose to be done?
Nope. This is the second such bug report (Monty in the newbies thread). Definitely a bug, the bug's children and their extended family taking residence.

Leave it with me.

  • #331
  • Sep 2, 2011 3:19am Sep 2, 2011 3:19am
Quoting SteveHopwood
Nope. This is the second such bug report (Monty in the newbies thread). Definitely a bug, the bug's children and their extended family taking residence.

Leave it with me.

Please try to take care of Luc too, if you got the time
I don't say
  • #332
  • Sep 2, 2011 3:51am Sep 2, 2011 3:51am
Quoting dragosd1
Please try to take care of Luc too, if you got the time
If I could, I would. Not a clue why the stuff doesn't work. For now, you will have to intervene manually.

That is the trouble with bolting stuff onto a system that was not designed to cope with it; it causes trouble.

  • #333
  • Sep 2, 2011 4:17am Sep 2, 2011 4:17am
Quoting SteveHopwood
If I could, I would. Not a clue why the stuff doesn't work. For now, you will have to intervene manually.

That is the trouble with bolting stuff onto a system that was not designed to cope with it; it causes trouble.

Yeah, I do that. BB is by far the most complex EA I have seen, so it's understandable Luc is making trouble between variables, sometimes...
I don't say
  • #334
  • Sep 2, 2011 4:44am Sep 2, 2011 4:44am
I have nailed down the source of a couple of the problems. I had two carolco GC buys and the associated grid open. GC is back into freefall and is now comfortably on the sell side of the moving averages.

Prob no 1: having a carolco grid of pendings stops hedging kicking in.

I removed the bot and deleted the pendings. As soon as I reloaded it, BB sent 7 hedge trades:

Prob no 2: enabling carolco causes multiple hedges to be sent.

Those of you who can, make the highlighted edits to this code snippet from void LookForTradeClosure() and see if it cures prob no 2:
Inserted Code
      //Hedging instead of closure   
      if (CloseTrade && UseHedging && !HedgingInProgress && OrderProfit() < 0)
      {
         double SendLots = OrderLots() * HedgeLotMultiplier;
         RefreshRates();
         if (OrderType() == OP_BUY)
         {
            result = SendSingleTrade(OP_SELL, HedgeTradeComment, SendLots, NormalizeDouble(Bid, Digits), 0, 0);
[color=Red]            if (result) 
            {
               //Delete outstanding pendings
               if (UseCarolco && (NoOfPendingBuys > 0 || NoOfPendingSells > 0 ) )
               {
                  DeletePendings();
                  CountOpenTrades();//Forces startcarolco() to do a rerun if any deletions fail. cot resets all the xxxOpen variables.
                  return;//Attempt to stop multiple hedge trades being taken
               }//if (UseCarolco)
            }//if (result) 
[/color]            
         }//if (OrderType() == OP_BUY)
      
         if (OrderType() == OP_SELL)
         {
            result = SendSingleTrade(OP_BUY, HedgeTradeComment, SendLots, NormalizeDouble(Ask, Digits), 0, 0);
[color=Red]            if (result) 
            {
               //Delete outstanding pendings
               if (UseCarolco && (NoOfPendingBuys > 0 || NoOfPendingSells > 0 ) )
               {
                  DeletePendings();
                  CountOpenTrades();//Forces startcarolco() to do a rerun if any deletions fail. cot resets all the xxxOpen variables.
                  return;//Attempt to stop multiple hedge trades being taken
               }//if (UseCarolco)
            }//if (result) 
[/color]         }//if (OrderType() == OP_SELL)
  • #335
  • Sep 2, 2011 4:58am Sep 2, 2011 4:58am
When I came to add the code to BB on my always-on trading machine, I realised the 'return' commands need to be placed lower down, so use this slightly different version.

Inserted Code
      //Hedging instead of closure   
      if (CloseTrade && UseHedging && !HedgingInProgress && OrderProfit() < 0)
      {
         double SendLots = OrderLots() * HedgeLotMultiplier;
         RefreshRates();
         if (OrderType() == OP_BUY)
         {
            result = SendSingleTrade(OP_SELL, HedgeTradeComment, SendLots, NormalizeDouble(Bid, Digits), 0, 0);
            [color=Red]if (result) 
            {
               //Delete outstanding pendings
               if (UseCarolco && (NoOfPendingBuys > 0 || NoOfPendingSells > 0 ) )
               {
                  DeletePendings();
                  CountOpenTrades();//Forces startcarolco() to do a rerun if any deletions fail. cot resets all the xxxOpen variables.                  
               }//if (UseCarolco)
            return;//Attempt to stop multiple hedge trades being taken
            }//if (result)             
         }/[/color]/if (OrderType() == OP_BUY)
      
         if (OrderType() == OP_SELL)
         {
            result = SendSingleTrade(OP_BUY, HedgeTradeComment, SendLots, NormalizeDouble(Ask, Digits), 0, 0);
[color=Red]            if (result) 
            {
               //Delete outstanding pendings
               if (UseCarolco && (NoOfPendingBuys > 0 || NoOfPendingSells > 0 ) )
               {
                  DeletePendings();
                  CountOpenTrades();//Forces startcarolco() to do a rerun if any deletions fail. cot resets all the xxxOpen variables.                  
               }//if (UseCarolco)
            return;//Attempt to stop multiple hedge trades being taken
            }//if (result)         
[/color]         }//if (OrderType() == OP_SELL)
      
         
      }//if (CloseTrade && UseHedging && !HedgingInProgress)

  • #336
  • Sep 2, 2011 5:29am Sep 2, 2011 5:29am
Or, I think I have. Time will tell.

Those of you who can (and any of you reading this who cannot yet go and shoot yourselves; you are a disgrace) go to the very top of void LookForTradeClosure() and remove these two lines of code:

Inserted Code
if (!OrderSelect(TicketNo, SELECT_BY_TICKET) ) return;
   if (OrderSelect(TicketNo, SELECT_BY_TICKET) && OrderCloseTime() > 0) return;

They hark back to a time when BB was designed for single trades only, and abort the function if there is any problem with the trade referenced by TicketNo.

For the peasants, there is an update with all the latest in post 1.

  • #337
  • Edited 6:58am Sep 2, 2011 5:49am | Edited 6:58am
As coded, when hedging is enabled

 

  1. BB spots that there is a trend trade open and the trend has moved in the opposite direction; it will hedge the trade.
  2. Having hedged the trade, BB will not hedge further.
  3. This means that the second of the carolco market trades is left unhedged.
  4. The solution is to double your 'normal' HedgeLotMultiplier. I am finding in demo manual trading that initial lot size * 4 is working very well, so my HedgeLotMultiplier is 8 when the carolco grid is enabled.

All well and good until a range trade turns into a trend trade and the hedging process is repeated as I describe above, and I am left with a * 8 lots hedge. Mind, it will not take many pips to bring the pair to breakeven.

How likely it is that this will happen is anybody's guess. I suppose it is worthwhile remembering my oft-repeated mantra: if it can happen and it is bad for you, it will happen.

Something to make a mental note of in the future.

  • #338
  • Sep 2, 2011 7:29am Sep 2, 2011 7:29am
Quoting SteveHopwood
if it can happen and it is bad for you, it will happen.


if by any chance you fear it happens faster.
  • #339
  • Sep 2, 2011 8:51am Sep 2, 2011 8:51am
Steve,

Was that hedging code copied from MPTM? I just had MPTM fire off 6 hedge trades for 1 EURUSD position 6 minutes ago on a NB10 1hr demo.
  • #340
  • Sep 2, 2011 12:00pm Sep 2, 2011 12:00pm
Quoting panamamike
Steve,

Was that hedging code copied from MPTM? I just had MPTM fire off 6 hedge trades for 1 EURUSD position 6 minutes ago on a NB10 1hr demo.
No. mptm's hedging pre-dates my better understanding of the mt4 pitfalls and Matt's functions to ensure trades have been registered in the history before proceeding. Multiple trades must be a risk with mptm.

0 traders viewing now