Menu
Sister Sites

Options

Bookmark Thread

First Page First Unread Last Page Last Post

Print Thread

Similar Threads

Need Script/EA can only generate Magic number 5 replies

GBPUSD Magic Number 45 replies

Comment vs. Magic Number 2 replies

can we manually assign a magic number 4 replies

Ever seen this magic number bug? 4 replies

Attachments: Make EA get custom magic number...will this work?
Exit Attachments

Make EA get custom magic number...will this work?

  • Post #1
  • Quote
  • First Post: Edited 3:33pm Sep 1, 2011 3:22pm | Edited 3:33pm
Im still trying to get everything done to an EA right now i am trying to make each pair have its own magic number. I know this will only work if there is only 1 order open for that pair but i dont code and this is what i think would work for now. Can someone please tell me if it would work.

//+----------------------------------------------------------------------------+
//| Get Magic Number For Pair |
//+----------------------------------------------------------------------------+
int GetMagicNumber() {
// What number to use for what pair
if (Symbol()=="EURUSD") return(001);
if (Symbol()=="GBPUSD") return(002);
if (Symbol()=="AUDUSD") return(003);
if (Symbol()=="NZDUSD") return(004);
if (Symbol()=="USDCHF") return(005);
if (Symbol()=="USDJPY") return(006);
if (Symbol()=="USDCAD") return(007);
if (Symbol()=="XAUUSD") return(008);
if (Symbol()=="XAGUSD") return(009);
return;
}

I added it to the code and it compiled with no errors, so i know its wrote right i guess but i dont know how to check to see besides letting the EA make a trade then checking the comments when it closes. But i dont even think then it shows the magic number.

Thanks
Dredding82
Dredding,

You're already 95% of the way there with your routine. All that's left for you to master is how to test your own code...

Create a new script and call it whatever

Copy your function to it

Modify the start() as follows:
Inserted Code
int start()
{
    int MagicNo = GetMagicNumber();
    Print("Magic Number for ", Symbol(), " is ", MagicNo);
}


You can now open this script in various charts and see what the magic number returned is.

It's a good idea to use scripts to polish your code routines one or two at a time. If you try to do everything in your EA, all at once, you often lose site of the trees for the forest. (or is it the other way round...)

Anyway, once you've done that you'll see that your routine works fine...
Quoting coda
Dredding,

You're already 95% of the way there with your routine. All that's left for you to master is how to test your own code...

Create a new script and call it whatever

Copy your function to it

Modify the start() as follows:
Inserted Code
int start()
{
    int MagicNo = GetMagicNumber();
    Print("Magic Number for ", Symbol(), " is ", MagicNo);
}


You can now open this script in various charts and see what the magic number returned is.

It's a good idea to use scripts to polish your code routines one or two at a time. If you...
Thanks man! i just added what you said to the EA quickly and it printed the magic number right. I saw some code on mql.com for making a magic number for each pair off of the symbol code ASC something but the site is down so the code above is all i could think to do for now. The other code on mql.com would pick a new magic number for each pair and each trade so no trades would ever have the same magic number so i could have the EA open more then one trade per pair and the EA could keep track of each trade. Guess i will have to wait till the site is back up to get the code lol.

But thanks man !
Quoting coda
Dredding,

You're already 95% of the way there with your routine. All that's left for you to master is how to test your own code...

Create a new script and call it whatever

Copy your function to it

Modify the start() as follows:
Inserted Code
int start()
{
    int MagicNo = GetMagicNumber();
    Print("Magic Number for ", Symbol(), " is ", MagicNo);
}


You can now open this script in various charts and see what the magic number returned is.

It's a good idea to use scripts to polish your code routines one or two at a time. If you...
Oh yea...almost nothing i do is my "own" code lol. I can read and understand what is going on in the code or what it was made to do, but can not start one to save my life. So i find indicators or EAs that have what i need or want in it ...then i copy and paste. LMAO!
Its been working for me so far, only have questions every now and then.
Quoting Dredding82
The other code on mql.com would pick a new magic number for each pair and each trade so no trades would ever have the same magic number so i could have the EA open more then one trade per pair and the EA could keep track of each trade.
Instead of having a unique Magic Number for each trade, why not simply use the Ticket Number?
Quoting Dredding82
The other code on mql.com would pick a new magic number for each pair and each trade so no trades would ever have the same magic number so i could have the EA open more then one trade per pair and the EA could keep track of each trade.
Plenty of ways to do this.

If you don't care what the magic number is, but just want to track the trade, then you can use a simple counter like so:

Inserted Code
int GetMagicNumber()
{ 

   int Counter = GlobalVariableGet("MagicNumberCounter");
   Counter = Counter + 1;
   GlobalVariableSet("MagicNumberCounter", Counter);
 
   return (Counter);
}
Quoting zznbrm
Instead of having a unique Magic Number for each trade, why not simply use the Ticket Number?

This is a valid point. I've had problems using magic numbers with the strategy tester.
Quoting Dredding82
Im still trying to get everything done to an EA right now i am trying to make each pair have its own magic number. I know this will only work if there is only 1 order open for that pair but i dont code and this is what i think would work for now. Can someone please tell me if it would work.
You don't need each pair to have it's own Magic number, you can isolate which pair a trade is from by Doing an OrderSelect() and then checking OrderSymbol().

If you want a simple scheme to generate a Mgic Number per symbol you can use this . . . it's what I currently use but will soon be moving away from . . .

Inserted Code
MagicNo = (StringGetChar(Symbol(),1)*1    // calculate a unique Magic number based on the pair name
          +StringGetChar(Symbol(),2)*100
          +StringGetChar(Symbol(),3)*10000
          +StringGetChar(Symbol(),4)*1000000
          );
20 pips a day isn't too much to ask . . .
Quoting zznbrm
Instead of having a unique Magic Number for each trade, why not simply use the Ticket Number?
How do you determine which orders were placed by which EA ? imagine I have an EA on GBPUSD H4 and another on GBPUSD H1 and a third on USDJPY H1 . . how do I tell which open orders were placed by which EA ?
20 pips a day isn't too much to ask . . .
Quoting RaptorUK
How do you determine which orders were placed by which EA ? imagine I have an EA on GBPUSD H4 and another on GBPUSD H1 and a third on USDJPY H1 . . how do I tell which open orders were placed by which EA ?
In that situation where you have multiple EAs trading the same symbol on the same account, you would use some other mechanism (i.e. Magic Number) within each EA to determine the submitter of the order.
  • Post #11
  • Quote
  • Edited 8:16pm Sep 1, 2011 7:54pm | Edited 8:16pm
This peice of code will not only keep track of your orders but every thing else.... like labaling graphic object, Globals, screenshots, all logs, etc... The numbers are increased by one each time one is pulled. the global variable that holds the next number is not deleted and is let run.

Lets just say that the pullnumber given your EA was 312, if you use that for lets say labaling graphics objects that you can have a simple code to delete all objects 312.... it will delete all objects starting with 312.

track your orders say 312 again was your pullnumber multiply that by one hundred will give your 31200 order number 31201 can linked to this ea and logs can becreated to track your daily proformance. This number is used to lock the order book when an ea places an order to prevent other eas from walking on each other.

I take it one step further with useing a controlID and an pullnumber adding the date and time the ea was started along with the currency pair. this is called the RunTimeSerial and it keeps all logs, screen shots, and any other things that happen. You can keep you perform logs and each trade documented, even with screenshots when the trade was open and closed. the first screen shot shows the RunTimeSerial on the main chart and it shows up on the account records.

The next screen shot shows some examples of the use of the different numbers, the devices calld Sharded are all the Pullnumbers of all the programs that are currently running. theres a lot there you'll have to study the screen shot.

the last is something else that I've developed they are device switches which control the programs execution. the list on the left are there names and the current setting of the switches are on the right.

Theres 8 different programs currently running and all are tied to this system, none of the programs are called between each other but all exposes its data to all the other programs through a device called a Custom Feed: that any other program can read directly with the need to call the program use the iCustom(). You'll see some Custom Feed: devices on the third screen shot down.

actually this is getting of the original topic. I haven't done a good job to explain this very tired pass my bed time. good nite.

Keit









Quoting RaptorUK
How do you determine which orders were placed by which EA ? imagine I have an EA on GBPUSD H4 and another on GBPUSD H1 and a third on USDJPY H1 . . how do I tell which open orders were placed by which EA ?
Attached Image(s) (click to enlarge)
Click to Enlarge Name: PullNumber.jpg Size: 63 KB
Click to Enlarge Name: RunTimeSerial.jpg Size: 70 KB
Click to Enlarge Name: Object list.jpg Size: 116 KB
Attached Image
Trader Keit ... Methods Of A Dirt Road Mad Man....
Quoting CockeyedCowboy
actually this is getting of the original topic. I haven't done a good job to explain this very tired pass my bed time. good nite.

Keit
I think I see what you are doing . . . a question. Imagine your PC's HDD died how would you get your account up and running on a new PC and be able to manage any orders currently open ?
20 pips a day isn't too much to ask . . .
Quoting coda
Plenty of ways to do this.

If you don't care what the magic number is, but just want to track the trade, then you can use a simple counter like so:

Inserted Code
int GetMagicNumber()
{ 
 
   int Counter = GlobalVariableGet("MagicNumberCounter");
   Counter = Counter + 1;
   GlobalVariableSet("MagicNumberCounter", Counter);
 
   return (Counter);
}

I dont know what i need. Some other guy that codes said for the EA to work right doing multiple trades i need to have magic numbers because of my TSL and the R:R settings i have which moves when such is hit. With what you wrote above will that act like a magic number so the EA can keep trade of each order per pair?
Quoting CockeyedCowboy
This peice of code will not only keep track of your orders but every thing else.... like labaling graphic object, Globals, screenshots, all logs, etc... The numbers are increased by one each time one is pulled. the global variable that holds the next number is not deleted and is let run.

Lets just say that the pullnumber given your EA was 312, if you use that for lets say labaling graphics objects that you can have a simple code to delete all objects 312.... it will delete all objects starting with 312.

track your orders say 312 again was your...

Thanks man but i can only copy and paste code then modify it to a point...what you are talking about looks like rocket science to me lol
Quoting zznbrm
Instead of having a unique Magic Number for each trade, why not simply use the Ticket Number?
I have no ideal what the differece is............well i mean i dont know how to get the ticketnumber....but since it is different for each trade that would work since im just trying to track the trade i guess so the EA can modify orders and not mix up a EurUsd trade with a GbpUsd trade and so on.
Quoting Dredding82
Thanks man but i can only copy and paste code then modify it to a point...what you are talking about looks like rocket science to me lol
My code works . . . just add it in the init() section and declare the MagicNo variable globally . .
20 pips a day isn't too much to ask . . .
  • Post #17
  • Quote
  • Edited 12:37pm Sep 3, 2011 12:24pm | Edited 12:37pm
Raptor

First I run 3 PCs in a network, one (server) is used just for analying the general market, it then passes trade information (which pairs to trade) to the other 2 computors (client) that do the actual trading. These two machines can trade up to 2 pairs at a time, which means I can trade 4 pairs at any one time (this is as much I can handle). The system is set up to alow up to 5 computors to operate at any one time. Meaning upto 8 pairs. All trade information is passed to the server unit (in real time) and inturn to a seperate external hard drive. Each client also kepts current information on its drive and flash drive. I have 8 laptops some are new (2 years old) and never turned on yet. I only use 4 at a time. One for research and development.

The system was designed to be able to pass the baton to another trader over the internet so trades can be picked up by another trader half way accross the planet. This feather has not been tryed nor tested as I have no one to pass on to. And I donot trust anyone on the net with my finacial information to test it. (if you look I dont even post the broker name even on a demo, I see so meny people post screen shots with there accounts and balance information..... dumb).

I have 2 generators and a large UPS that can run ONE computer for up to 40 hours. the system 3 computers can run for 8-10 hours between charges. When that goes down the laptops are self suppportive for arround an hour on there battary given me time to crank up a generater which I can do without getting out of my chair. If the tempature is hot outside I have a generator running any ways, for AC. I do not use land power (in most cases) as I am totally moble. The internet runs off a second UPS powered off the trucks charging system.

O, I have 3 solar panels on the roof too. I am typing this in the parking lot of a Home Depot store, need some supplies.

The week link is the internet. if it or the broker goes down I'm F... I do have my phone and the number to the broker handy but thats not reliable if their down. I use what I call eStops to get me out of a trade when I am in a trade I have no control of. In the screen shot you see the little arrows in the Prompt Zone they are the stop markers. the ledger (shows up when you mouse over the stop tab) shows the stop locations. These stops are continually updated to the brokers server when you have an open position. If the connection goes down then and alarm goes off with a marker that shows up 'OFF LINE' were it currently says 'DEMO' and it says FUNDED on a live account. This all works even if your not on line or if no trading is allowed. This is the week end by the way and my platform still runs as though the broker was open.

There I go again, Hope somewere in this post I answered your question. theres more to trading then little green arrows, that is if your really want to do it for a living.


Keit

edit: If you look at the little clock that says 15:54 GMT that is in real time and works even when theres no connection or the broker is closed. Look at the other numbers all read 99.x that tells me the broker data feed is off as all bars are at there maxmum percentage change, when the data feed starts up the will start working again.





Quoting RaptorUK
I think I see what you are doing . . . a question. Imagine your PC's HDD died how would you get your account up and running on a new PC and be able to manage any orders currently open ?
Attached Image (click to enlarge)
Click to Enlarge Name: eStops.jpg Size: 43 KB
Trader Keit ... Methods Of A Dirt Road Mad Man....
Quoting CockeyedCowboy
There I go again, Hope somewere in this post I answered your question. theres more to trading then little green arrows, that is if your really want to do it for a living.
No you didn't really . . my question was really about all the info you have in GlobalVariables . . . that info is stored by the MT4 terminal, if you HDD goes down it's lost . . unless you are keeping it somewhere else ?
20 pips a day isn't too much to ask . . .
  • Post #19
  • Quote
  • Edited 6:29pm Sep 3, 2011 6:14pm | Edited 6:29pm
Raptor

I didnot understand what you were asking.

I only have two things in GlobalVariables one that generates the Program ID and the other is when an order is being placed theres a lock on the order book to prevent orders form two programs walking on each other. Neither are critical for recovery of the system. Every thing else are in files I call a signature files and kept in 4 locations. The memery stick that is pluged into each trade computer is all I need to change one computer to another. These files can be sent over the net to a trading partner and he (with a copy of my platform) can use the files and take over trading the system and recover any open orders too. Theres only one critical program in the system that is the Controller. This is the program that makes sure that all other programs play well together and watches for user imputs.


what you think are global variables in the lists of my first post above are not globals at all. You need to take a second look, as I said theres a lot of information there. All these settings are kept in files and can be recovered quickly.

Keit



Quoting RaptorUK
No you didn't really . . my question was really about all the info you have in GlobalVariables . . . that info is stored by the MT4 terminal, if you HDD goes down it's lost . . unless you are keeping it somewhere else ?
Trader Keit ... Methods Of A Dirt Road Mad Man....
Quoting CockeyedCowboy
Raptor

I didnot understand what you were asking.

I only have two things in GlobalVariables one that generates the Program ID and the other is when an order is being placed theres a lock on the order book to prevent orders form two programs walking on each other.
OK, maybe I misunderstood what you were describing, I understand the use of a GlobalVariable for a mutex . . . I guess the other is just to prevent two EAs using the same root number for it's Object names, etc ?
20 pips a day isn't too much to ask . . .
0 traders viewing now