My EA does not respect my strategy, Please help!

I wrote an EA for opening a trade when Stochastic of D1 and H4 and H1 are in agreement, however as soon as I drop the EA on the chart it's open a trade without respecting the strategy,
here are the code's line for the strategy,

double StoH4ValueS0, StoH4SignalS0, StoH4ValueS1, StoH4SignalS1;
double StoH1Value, StoH1Signal, StoD1Value, StoD1Signal ;

StoH4ValueS0 = iStochastic(Symbol(),sto1,K1,3,3,MODE_SMA,1,MODE_MAIN,0);
StoH4SignalS0 = iStochastic(Symbol(),sto1,K1,3,3,MODE_SMA,1,MODE_SIGNAL,0);
StoH4ValueS1 = iStochastic(Symbol(),sto1,K1,3,3,MODE_SMA,1,MODE_MAIN,Shiftt);
StoH4SignalS1 = iStochastic(Symbol(),sto1,K1,3,3,MODE_SMA,1,MODE_SIGNAL,Shiftt);

StoH1Value = iStochastic(Symbol(),sto2,K2,3,3,MODE_SMA,1,MODE_MAIN,0);
StoH1Signal = iStochastic(Symbol(),sto2,K2,3,3,MODE_SMA,1,MODE_SIGNAL,0);
StoD1Value = iStochastic(Symbol(),sto3,K3,3,3,MODE_SMA,1,MODE_MAIN,0);
StoD1Signal = iStochastic(Symbol(),sto3,K3,3,3,MODE_SMA,1,MODE_SIGNAL,0);


if(StoH4ValueS0>StoH4SignalS0 && StoH4ValueS1<StoH4SignalS1 && StoH1Value>StoH1Signal && StoD1Value>StoD1Signal && StoD1Value>LowLevel)
{ EnterLong (Sym, Lots, ""); }
else
if(StoH4ValueS0<StoH4SignalS0 && StoH4ValueS1>StoH4SignalS1 && StoH1Value<StoH1Signal && StoD1Value<StoD1Signal && StoD1Value<HighLevel)
{ EnterShrt (Sym, Lots, ""); }

}

return (0);

}

For those who want to see the entire code, here it is

//Ben Stochastic.mq4


#include <stderror.mqh>

//-----------------------------------------------Block 01----------------------------------------------------

datetime CurrTime = 0;
datetime PrevTime = 0;
string Sym = "";
int TimeFrame = 0;
int Shift = 1;
int SymDigits = 5;
double SymPoints = 0.0001;

//-----------------------------------------------Block 02----------------------------------------------------

extern bool UseCompletedBars = true;

extern int Shiftt=3;
extern int sto1=240;
extern int sto2=60;
extern int sto3=1440;
extern int K1=5;
extern int K2=5;
extern int K3=5;
extern int KE=5;
extern int LowLevel = 20;
extern int HighLevel = 80;

extern double Lots = 1.0;
extern int MagicNumber = 1235;
extern int ProfitTarget = 100;
extern int StopLoss = 0;
extern int Slippage = 3;

//-----------------------------------------------Block 03----------------------------------------------------

int init ()

{

Sym = Symbol();
TimeFrame = Period();
SymPoints = MarketInfo( Sym, MODE_POINT );
SymDigits = MarketInfo( Sym, MODE_DIGITS );

if ( SymPoints == 0.001 ) { SymPoints = 0.01; SymDigits = 3; }
else
if ( SymPoints == 0.00001) { SymPoints = 0.0001; SymDigits = 5; }

return (0);

}

//-----------------------------------------------Block 04----------------------------------------------------

int deinit () { return(0); }

//-----------------------------------------------Block 05----------------------------------------------------

int start ()

{

int RealTime = 0;
if (UseCompletedBars)

{

CurrTime = iTime ( Sym, TimeFrame, 1);
if ( CurrTime == PrevTime )
{
return(0);
}
PrevTime = CurrTime;
RealTime = 1;

}

if ( CountAll ( Sym, MagicNumber) == 0 )

{

double StoH4ValueS0, StoH4SignalS0, StoH4ValueS1, StoH4SignalS1;
double StoH1Value, StoH1Signal, StoD1Value, StoD1Signal ;

StoH4ValueS0 = iStochastic(Symbol(),sto1,K1,3,3,MODE_SMA,1,MODE_MAIN,0);
StoH4SignalS0 = iStochastic(Symbol(),sto1,K1,3,3,MODE_SMA,1,MODE_SIGNAL,0);
StoH4ValueS1 = iStochastic(Symbol(),sto1,K1,3,3,MODE_SMA,1,MODE_MAIN,Shiftt);
StoH4SignalS1 = iStochastic(Symbol(),sto1,K1,3,3,MODE_SMA,1,MODE_SIGNAL,Shiftt);

StoH1Value = iStochastic(Symbol(),sto2,K2,3,3,MODE_SMA,1,MODE_MAIN,0);
StoH1Signal = iStochastic(Symbol(),sto2,K2,3,3,MODE_SMA,1,MODE_SIGNAL,0);
StoD1Value = iStochastic(Symbol(),sto3,K3,3,3,MODE_SMA,1,MODE_MAIN,0);
StoD1Signal = iStochastic(Symbol(),sto3,K3,3,3,MODE_SMA,1,MODE_SIGNAL,0);


if(StoH4ValueS0>StoH4SignalS0 && StoH4ValueS1<StoH4SignalS1 && StoH1Value>StoH1Signal && StoD1Value>StoD1Signal && StoD1Value>LowLevel)
{ EnterLong (Sym, Lots, ""); }
else
if(StoH4ValueS0<StoH4SignalS0 && StoH4ValueS1>StoH4SignalS1 && StoH1Value<StoH1Signal && StoD1Value<StoD1Signal && StoD1Value<HighLevel)
{ EnterShrt (Sym, Lots, ""); }

}

return (0);

}

//-----------------------------------------------Block 06----------------------------------------------------

int CountAll (string Symbole, int Magic)

{

int count = 0;
for (int i = OrdersTotal() - 1; i >=0; i --)

{

OrderSelect (i, SELECT_BY_POS,MODE_TRADES);
if ( OrderMagicNumber () != Magic) continue;
if ( OrderSymbol() != Symbole ) continue;
if ( OrderType () == OP_BUY) { count ++; }
else
if ( OrderType () == OP_SELL) { count ++; }

}

return (count);

}

//-----------------------------------------------Block 07----------------------------------------------------

double StopLong(double price,double stop,double point,double SymDgts)

{
if(stop==0) {return(0);}
else
{return(NormalizeDouble(price-(stop*point),SymDgts));}
}


double StopShrt(double price,double stop,double point,double SymDgts)

{

if(stop==0) {return(0);}
else
{return(NormalizeDouble(price+(stop*point),SymDgts));}

}


double TakeLong(double price, double take,double point, double SymDgts)

{

if(take==0) { return(0); }
else
{return(NormalizeDouble(price +(take*point),SymDgts));}

}


double TakeShrt(double price,double take,double point, double SymDgts)

{

if(take==0){return(0);}
else
{return(NormalizeDouble(price-(take*point),SymDgts));}

}

//-----------------------------------------------Block 08----------------------------------------------------

int EnterLong(string FinalSymbol,double FinalLots,string EA_Comment)

{

int Ticket = -1; int err = 0; bool OrderLoop = False; int TryCount = 0;
while( !OrderLoop)

{
while (IsTradeContextBusy()) { Sleep (10); }
RefreshRates();
double SymAsk = NormalizeDouble(MarketInfo(FinalSymbol,MODE_ASK), SymDigits);
double SymBid = NormalizeDouble(MarketInfo(FinalSymbol,MODE_BID), SymDigits);
Ticket = OrderSend(FinalSymbol,OP_BUY,FinalLots,SymAsk,0,0.0,0.0,EA_Comment,MagicNumber,0,CLR_NONE);
int Err = GetLastError();
switch(Err)

{
case ERR_NO_ERROR: OrderLoop = true;
if(OrderSelect(Ticket,SELECT_BY_TICKET))
{OrderModify(Ticket,OrderOpenPrice(),StopLong(SymBid, StopLoss, SymPoints, SymDigits), TakeLong(SymAsk, ProfitTarget, SymPoints, SymDigits), 0, CLR_NONE);}
break;
case ERR_SERVER_BUSY:
case ERR_NO_CONNECTION:
case ERR_INVALID_PRICE:
case ERR_OFF_QUOTES:
case ERR_BROKER_BUSY:
case ERR_TRADE_CONTEXT_BUSY: TryCount++; break;
case ERR_PRICE_CHANGED:
case ERR_REQUOTE: continue;
case ERR_INVALID_STOPS: OrderLoop = true; Print("Invalid Stops" );break;
case ERR_INVALID_TRADE_VOLUME: OrderLoop = true; Print("Invalid Lots" );break;
case ERR_MARKET_CLOSED: OrderLoop = true; Print("Market Close" );break;
case ERR_TRADE_DISABLED: OrderLoop = true; Print("Trades Disabled" );break;
case ERR_NOT_ENOUGH_MONEY: OrderLoop = true; Print("Not Enough Money");break;
case ERR_TRADE_TOO_MANY_ORDERS: OrderLoop = true; Print("Too Many Orders" );break;
case ERR_NO_RESULT:
default: OrderLoop = true; Print("Unknown Error -"+Err);break;
}

if(TryCount>10) {OrderLoop=true;}
}

return(Ticket);

}

//-----------------------------------------------Block 09----------------------------------------------------

int EnterShrt(string FinalSymbol, double FinalLots, string EA_Comment)

{

int Ticket = -1; int err = 0; bool OrderLoop = False; int TryCount = 0;
while (!OrderLoop)

{

while(IsTradeContextBusy()) { Sleep(10); }
RefreshRates();
double SymAsk = NormalizeDouble(MarketInfo(FinalSymbol, MODE_ASK ), SymDigits);
double SymBid = NormalizeDouble(MarketInfo(FinalSymbol, MODE_BID ), SymDigits);
Ticket = OrderSend(FinalSymbol,OP_SELL,FinalLots,SymBid,0,0.0,0.0,EA_Comment,MagicNumber,0,CLR_NONE);
int Err=GetLastError();
switch(Err)

{

case ERR_NO_ERROR: OrderLoop = true;
if(OrderSelect(Ticket, SELECT_BY_TICKET))
{OrderModify(Ticket,OrderOpenPrice(),StopShrt(SymAsk, StopLoss, SymPoints, SymDigits), TakeShrt(SymBid, ProfitTarget, SymPoints, SymDigits),0,CLR_NONE);}
break;
case ERR_SERVER_BUSY:
case ERR_NO_CONNECTION:
case ERR_INVALID_PRICE:
case ERR_OFF_QUOTES:
case ERR_BROKER_BUSY:
case ERR_TRADE_CONTEXT_BUSY: TryCount++; break;
case ERR_PRICE_CHANGED:
case ERR_REQUOTE: continue;
case ERR_INVALID_STOPS: OrderLoop = true; Print("Invalid Stops" );break;
case ERR_INVALID_TRADE_VOLUME: OrderLoop = true; Print("Invalid Lots" );break;
case ERR_MARKET_CLOSED: OrderLoop = true; Print("Market Close" );break;
case ERR_TRADE_DISABLED: OrderLoop = true; Print("Trades Disabled" );break;
case ERR_NOT_ENOUGH_MONEY: OrderLoop = true; Print("Not Enough Money");break;
case ERR_TRADE_TOO_MANY_ORDERS: OrderLoop = true; Print("Too Many Orders" );break;
case ERR_NO_RESULT:
default: OrderLoop = true; Print("Unknown Error -"+Err);break;
}

if(TryCount>10) {OrderLoop=true;}
}

return(Ticket);

}

I would much appreciate any inside on this matter.
thank you

So?...

Put some Print or Comment statements in your code and verify that the values you THINK should be there ARE really there.

If they are not what you think they should be, put in more Print or Comment statements until you find the problem.

I would start with the iStochastic calls - display the values and verify that they match the chart.

P.S. When posting code you should either place it inside a code block ( ) or attach the source - it's very hard to read the way you've done it.

How about using a whip? Your EA may change mind and may give respect to you




P.S. Sorry buy i cracked into laughter reading the subject !

P.S.2 Hey LouG... been long.. hope you are doing good

That is what you feel after putting hours and hours just to find out a problem which I don't have a clue what is the solution

Sometimes the comments are useless when u are using very very simple EA template
because it is simply predefined template for very simple strategy.

I was referring to the MQL Comment statement, not //comments one might add to make the code more clear.

If the EA is not functioning correctly the Comment or Print statements may help you see the problem - but if you prefer some other approach, have it as you like it...

I think I see your problem:

The H4 value and signal for the previous period in the iStochastic statement are (correctly) using a 240 timeframe but are using an offset of 3 (in Shiftt) instead of 1.

Not to belabor the point but displaying the data returned by iStochastic using a Comment() statement and comparing the values to the chart would have pinpointed this...

Well ! this is an approach I am going to try it in the coming London/NY Session. Then I let you know the results.

Would you mind to share the knowledge how I would be using the Comment() after iStochastic to then compare the values with the chart as you mention ?

Anyway your help is much appreciated.

With MT4 programming you don't have any debuggers to help you so you need to remember one simple rule.

Rule 1 - Keep things as simple as possible.

When you have a problem, isolate the problem. Get rid of any code that is not involved. Everything else is of no use, and just gets in the way.

Step 1. Have the simplest possible code that reproduces the problem. In your present case it could be something like this...



You also need to implement the methods above. Maybe like so...


Note - the code above is simple prototyping. It needs some work on your part to complete the missing bits and pieces. I assume you will know how to do that.


Step 2. Use the simplified code in a script, instead of an EA. If you don't have charts that generate the data that you need for all conditions, you could hardwire some of the data in your Setup() to test different values.

Once you can see what your calculations are actually evaluating to and why, it is usually easy to figure out what the problem is.


Step 3 Once you have the logic working correctly you can fix your EA and move on to the next problem.


There are lots of other ways to locate and fix your problem. You could simply sprinkle Print statements throughout your code wherever you are not 100% sure what your logic is really doing. You can probably spot the problem that way, but in an EA, you may end up with a huge amount of data to sift through.


Good luck!

the above code will do the job. Replace "yourdata" with the data elements of your choice. The comment will appear in the upper left corner of the chart.

In some cases you may wish to convert the data to strings to improve readability - if so, replace "yourdata" with (for example) DoubleToStr(yourdata), TimeToStr(yourdata), etc.

I routinely do this in new EAs and indicators until I'm sure they are functioning properly - saves debugging time later...

You just provided me some very valuable information, for sure it is going to help me in the long run. Thanks

I will try to put comment () on the way you just described and I will post here as soon I get any results.
Thank you

You can also use Print() to see the value of variables within your code as Coda suggests.

I generally lean toward Comment() only because it's necessary to search the log files to find the output of Print() but the output of Comment() is right there on the chart. Both methods are equally good ways to debug your code.

Because of the mean of learning one of my favorite way is to look up for people with similiar strategy and look the way they write their EA and compare each approach and style. This way is also great boost for learning MQL4 language, so I am little bit shy but I will ask from you or anybody else who read this post, do you have any Stochastic EA please post them here, and I will try to post some helpful analysis.