Adding Manual Confirm to Expert Advisor

I have been trying to code my system "Freebie Newbie System" into an EA and i have gotten it going pretty good but right now i am trying to add something so you can use it with manual confirm. I cant seem to get it to only alert with a popup order box only once per new order. With this it should beable to be unchecked and the EA will enter without having to do anything, if checked then you would have to confirm the order before it is placed.

I am not attaching the EA for a few reason

1) It is not finished
2) I have been lied to ALOT! by people that say they will help only to "steal" the code and never reply to me again.
3) You dont need an EA code to tell me how to add a few lines of code that will make it only alert once per signal.


This is what i have in the code right now since it works on the indicators but doesnt seem to work on the EA. Any help would be great.

Thanks
Dredding82

if(OrdersTotal()<MaxOrders)
{
if(SignalBUY=="true")
{
if(RiskMangement) {
Lots=GetLots(BSL,StopLoss,margin);// risk calculation
}
if(UseRiskRewardTakeProfit) {
TakeProfit = NormalizeDouble(RiskRewardTakeProfit_Ratio * StopLoss,0);
}
if (margin > 75) return; // if not enough margin do nothing
if(HideSL==false&&StopLoss>0){SL=Ask-StopLoss*pointz;/*OPP=Bid-StopLoss*pointz;SLP=Bid;*/}else {SL=0;/*SLP=0;*/}
if(HideTP==false&&TakeProfit>0){TP=Ask+TakeProfit*pointz;/*TPP=Bid-(TakeProfit*2)*pointz;*/}else {TP=0;/*TPP=0;*/}
if(HideSL==false&&HedgeSL>0)SLH=Bid+HedgeSL*pointz;else SLH=0;
if(HideTP==false&&HedgeTP>0)TPH=Bid-HedgeTP*pointz;else TPH=0;
while(Ticket<=0 && number<tries){
if(ECN) {
if (TimeOpen < Time[0]) // I can trade this bar
TimeOpen = Time[0];
Ticket=OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,0,0,EAName,Magic,0,Blue);
if(Ticket>0) ecnmodify(OP_BUY, Ticket, Bid, SL,TP);
} else {
if (TimeOpen < Time[0]) // I can trade this bar
TimeOpen = Time[0];
Ticket=OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,SL,TP,EAName,Magic,0,Blue);
//if(Hedge)TicketH=OrderSend(Symbol(),OP_SELL,Lots,Bid,Slippage,SLH,TPH,EAName,Magic,0,Red);
//if(ReverseAtStop&&StopLoss>0)TicketP=OrderSend(Symbol(),OP_SELLSTOP,Lots,OPP,Slippage,SLP,TPP,EAName,Magic,Expire,Red);*/
}
if(Ticket<=0) number++;
}
}
}

if(SignalSELL=="true")
{
if(RiskMangement) {
Lots=GetLots(SSL,StopLoss,margin);// risk calculation
}
if (UseRiskRewardTakeProfit) {
TakeProfit = NormalizeDouble(RiskRewardTakeProfit_Ratio * StopLoss,0);
}
if (margin > 75) return; // if not enough margin do nothing
if(HideSL==false&&StopLoss>0){SL=Bid+(StopLoss*pointz);/*OPP=Ask+StopLoss*pointz;SLP=Ask;*/}else {SL=0;/*SLP=0;*/}
if(HideTP==false&&TakeProfit>0){TP=Bid-TakeProfit*pointz;/*TPP=Ask+(TakeProfit*2)*pointz;*/}else {TP=0;/*TPP=0;*/}
if(HideSL==false&&HedgeSL>0)SLH=Ask-HedgeSL*pointz;else SLH=0;
if(HideTP==false&&HedgeTP>0)TPH=Ask+HedgeTP*pointz;else TPH=0;
while(Ticket<=0 && number<tries){
if(ECN) {
if (TimeOpen < Time[0]) // I can trade this bar
TimeOpen = Time[0];
Ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,Slippage,0,0,EAName,Magic,0,Red);
if(Ticket>0) ecnmodify(OP_SELL, Ticket, Bid, SL,TP);
} else {
if (TimeOpen < Time[0]) // I can trade this bar
TimeOpen = Time[0];
Ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,Slippage,SL,TP,EAName,Magic,0,Red);
//if(Hedge)TicketH=OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,SLH,TPH,EAName,Magic,0,Blue);
//if(ReverseAtStop&&StopLoss>0)TicketP=OrderSend(Symbol(),OP_BUYSTOP,Lots,OPP,Slippage,SLP,TPP,EAName,Magic,Expire,Red);
}
if(Ticket<=0) number++;
}
}
if(Ticket<0) Print("Error opening order! ",errordescription(GetLastError()));
}
}
return(0);

Hi Dredding

got a little bit confused by your post - but I understood it as

you wish to have an EA that will open trades, however you want the user to have the ability to manually confirm that the trade should be placed if need be.

If that is correct then there is no coding required, MT4 can handle that automatically.

When you load the EA on the chart (or press F7 with with the EA on the chart), select the Common tab and check the manual confirmation box

The EA will then ask you to confirm for each new trade.

Yes i know there is no coding for the manual confirm because the platform has that in it. The problem is that with the EA when i get a signal it pops up the order box...so i can can "confirm" to enter a position. But if just exit the order box without placing an order the EA will send another signal and another order box will pop up. It will keep doing so untill i either enter the position or i turn the EA off. Im trying to find a way to fix this.

P.S. Sorry if i confused anyone lol

OK - think I understood

in that case you need to move your time check to something like

if (Signal == "SELL")
{
if (TimeOpen == Time[0]) return; // Already tried on this bar
TimeOpen = Time[0];
int li_ans = MessageBox("Do you wish to open this sell order at xxx",
"Sell Confirm",MB_YESNO|ICON_QUESTION);
if (li_ans != 1) return; // OK/Yes not pressed
...
... rest of code

then it will only try to open the order on the first time
if the user does not press OK to open the order, the next tick will not allow the routine to run because TimeOpen would be equal to the current bar

of course you need to remember that TimeOpen has to be either defined globally or as static

Limit the EA to send a buy/sell signal once per bar.

So your saying i cant use the manual confirm the MT4 has...right?

Thats what i am trying to do but i have no coding back ground lol...so i have no clue how to do it, I thought the TimeOpen[0] would work since i use something like that on the OHLC indicator when i added an alert to it. The indicators i mess with are just easy copy and paste coding...which works pretty good if i do say so myself lol.

not if the EA can try to open orders mid-bar

but the code I have given you will do as you require

I had this in the EA but it did not seem to make it work right either

datetime PreviousBarTime1;
datetime PreviousBarTime2; // Both under Internal parameters at the top of the code.

//+------------------------------------------------------------------+
//| Allow one action per bar |
//+------------------------------------------------------------------+
bool NewBarBuy()
{
if(PreviousBarTime1<Time[0])
{
PreviousBarTime1=Time[0];
return(true);
}
return(false);
}
bool NewBarSell()
{
if(PreviousBarTime2<Time[0])
{
PreviousBarTime2=Time[0];
return(true);
}
return(false);
}

and i added if(SignalBUY=="true"&&NewBarBuy()) or if(SignalSELL=="true"&&NewBarSell())

The EA only looks for orders at the close of a bar. So i know thats not the problem because when i run it it only places orders once the signal has happened and that bar has closed.

static datetime LastBuySignal;

if(iBarShift(NULL, 0, LastBuySignal, False) > 0)
{
//Send new buy signal
LastBuySignal = TimeCurrent();
}

Do i put it like this? i tried the way you had it but it compiled with an error. The way i have it there are no errors.

if(SignalBUY=="true")
if(iBarShift(NULL,0, LastBuySignal,False)>0) //Send new buy signal
LastBuySignal= TimeCurrent();
{
if(RiskMangement) {
Lots=GetLots(BSL,StopLoss,margin);// risk calculation
}
if(UseRiskRewardTakeProfit) {
TakeProfit = NormalizeDouble(RiskRewardTakeProfit_Ratio * StopLoss,0);
}
if (margin > 75) return; // if not enough margin do nothing
if(HideSL==false&&StopLoss>0){SL=Ask-StopLoss*pointz;/*OPP=Bid-StopLoss*pointz;SLP=Bid;*/}else {SL=0;/*SLP=0;*/}
if(HideTP==false&&TakeProfit>0){TP=Ask+TakeProfit*pointz;/*TPP=Bid-(TakeProfit*2)*pointz;*/}else {TP=0;/*TPP=0;*/}
if(HideSL==false&&HedgeSL>0)SLH=Bid+HedgeSL*pointz;else SLH=0;
if(HideTP==false&&HedgeTP>0)TPH=Bid-HedgeTP*pointz;else TPH=0;
while(Ticket<=0 && number<tries){
if(ECN) {
Ticket=OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,0,0,EAName,Magic,0,Blue);
if(Ticket>0) ecnmodify(OP_BUY, Ticket, Bid, SL,TP);
} else {
Ticket=OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,SL,TP,EAName,Magic,0,Blue);
//if(Hedge)TicketH=OrderSend(Symbol(),OP_SELL,Lots,Bid,Slippage,SLH,TPH,EAName,Magic,0,Red);
//if(ReverseAtStop&&StopLoss>0)TicketP=OrderSend(Symbol(),OP_SELLSTOP,Lots,OPP,Slippage,SLP,TPP,EAName,Magic,Expire,Red);*/
}
if(Ticket<=0) number++;
}
}
}

if(SignalSELL=="true")
if(iBarShift(NULL,0, LastSellSignal,False)>0) //Send new buy signal
LastSellSignal= TimeCurrent();