How to configure global variable according to currency pair? | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

please guide me how to configure this EA 1 reply

Multi-pair trading or Few-Pair Trading. [poll] 15 replies

Easylanguage GLobal Variable with Excel 2 replies

Global Variable question: 7 replies

lock pattern for global variable in MT4 2 replies

Attachments: How to configure global variable according to currency pair?
Exit Attachments

How to configure global variable according to currency pair?

  • #1
  • First Post: Jun 8, 2011 9:04pm Jun 8, 2011 9:04pm
How can I configure global variable according to currency pair?

GlobalVariableSet(TakeOverXXXXXX,0);


How can I have the XXXXXX automatically be filled with the currency symbol?
  • #2
  • Jun 8, 2011 9:44pm Jun 8, 2011 9:44pm
Quoting mindreality
How can I configure global variable according to currency pair?

GlobalVariableSet(TakeOverXXXXXX,0);


How can I have the XXXXXX automatically be filled with the currency symbol?
GlobalVariableSet("TakeOver"+Symbol(),0);
  • #3
  • Jun 8, 2011 10:39pm Jun 8, 2011 10:39pm
How do I declare the variable in the same way?

string TakeOverXXXXXX = "TakeOverXXXXX"


How can I have the XXXXXX automatically be filled with the currency symbol? Does it work the same way for variable declaration or is there a matrix I should use for it?
  • #4
  • Jun 8, 2011 10:58pm Jun 8, 2011 10:58pm
wait what? you want the variable NAMES to contain the symbol names?

what exactly are you trying to do because it sounds like you might be confusing different issues and making a mess of things?

edit : i have a suspicion that you are simply trying to overcome a similar issue to something i answered earlier today here http://www.forexfactory.com/showthread.php?t=297820
Congratulations ScalaFX for coming out of the closet!
  • #5
  • Jun 8, 2011 11:07pm Jun 8, 2011 11:07pm
I have these variables declared:

string TakeOverEURUSD = "TakeOverEURUSD", TakeOverGBPUSD = "TakeOverGBPUSD", TakeOverAUDUSD = "TakeOverAUDUSD", TakeOverNZDUSD = "TakeOverNZDUSD", TakeOverUSDCAD = "TakeOverUSDCAD", TakeOverUSDCHF = "TakeOverUSDCHF", TakeOverUSDJPY = "TakeOverUSDJPY", TakeOverGBPJPY = "TakeOverGBPJPY", TakeOverEURAUD = "TakeOverEURAUD";

string StopOtherEURUSD = "StopOtherGBPUSD", StopOtherGBPUSD = "StopOtherGBPUSD", StopOtherAUDUSD = "StopOtherAUDUSD", StopOtherNZDUSD = "StopOtherNZDUSD", StopOtherUSDCAD = "StopOtherUSDCAD", StopOtherUSDCHF = "StopOtherUSDCHF", StopOtherUSDJPY = "StopOtherUSDJPY", StopOtherGBPJPY = "StopOtherGBPJPY", StopOtherEURAUD = "StopOtherEURAUD";

string CTtriggeredEURUSD = "CTtriggeredEURUSD", CTtriggeredGBPUSD = "CTtriggeredGBPUSD", CTtriggeredAUDUSD = "CTtriggeredAUDUSD", CTtriggeredNZDUSD = "CTtriggeredNZDUSD", CTtriggeredUSDCAD = "CTtriggeredUSDCAD", CTtriggeredUSDCHF = "CTtriggeredUSDCHF", CTtriggeredUSDJPY = "CTtriggeredUSDJPY", CTtriggeredGBPJPY = "CTtriggeredGBPJPY", CTtriggeredEURAUD = "CTtriggeredEURAUD";


I wonder how can I simplify them.

I uses those string variables in my Global Variables, and Global variables can only use boolean variables as the output.
  • #6
  • Jun 8, 2011 11:24pm Jun 8, 2011 11:24pm
i can sort of see what you are trying to accomplish...

why do you need to specify each and every symbol you expect to encounter? why can't you simply refer to Symbol() to see if it is relevant to the chart the indicator or ea or script or whatever is ACTUALLY on?

for example, if you are dealing with a EURUSD chart then do you really need to deal with the other chart symbols? maybe you do, it depends on what your overall goal is... i don't know. you are going to face dealing with non-standard symbol names if you are trying to do this correctly and make it universally compatible, and i can see ways to get around this but judging by your level of coding skill this will be far beyond your capabilities and therefore not relevant.

what is the ultimate aim of what you are trying to achieve? what does your ea / indi / script do? you are probably trying to accomplish something relatively simple but going about it the most difficult way.
Congratulations ScalaFX for coming out of the closet!
  • #7
  • Jun 9, 2011 12:05am Jun 9, 2011 12:05am
I am using Global variables.

GlobalVariableSet(TakeOverEURUSD,0);

string TakeOverEURUSD = "TakeOverEURUSD";



When another EA checks for the Global Variable, it needs to find the one with the same symbol as the chart it is on. That is why I add symbol names to all my Global variables.
  • #8
  • Jun 9, 2011 12:21am Jun 9, 2011 12:21am
Quoting mindreality
I am using Global variables.

GlobalVariableSet(TakeOverEURUSD,0);

string TakeOverEURUSD = "TakeOverEURUSD";



When another EA checks for the Global Variable, it needs to find the one with the same symbol as the chart it is on. That is why I add symbol names to all my Global variables.
yeah, so in this case it's like hanover suggested.

if you are only interested in the chart it is attached to then you don't care about any other symbol. all you need to do is something like

Inserted Code
string nameTakeOver = "MyEA_TakeOver";
string nameStopOther = "MyEA_StopOther";
string nameTriggered = "MyEA_Triggered";

bool TakeOver, StopOther, Triggered;
but, when you set and when you read the global variables you simply append the symbol name to the string to make it unique to the symbol you are dealing with and / or wanting to check against;

Inserted Code
TakeOver = false;
if (GlobalVariableCheck(nameTakeOver + Symbol())) TakeOver = True;
StopOther = false;
if (GlobalVariableCheck(nameStopOther + Symbol())) StopOther = True;
Triggered = false;
if (GlobalVariableCheck(nameTriggered + Symbol())) Triggered = True;

if you are looking at a EURUSD chart then the global variable it will check for will be "MyEA_TakeOverEURUSD" and so on. but if you are on a GBPUSD chart then it will instead check for "MyEA_TakeOverGBPUSD". see how that works?

trying to hardcode symbol names into variable names and then trying to deal with the correct symbol is nightmarish and would require using heaps of 'switch' statements and entirely defeats the purpose of variables.
Congratulations ScalaFX for coming out of the closet!
  • #9
  • Jun 9, 2011 12:47am Jun 9, 2011 12:47am
Quoting mindreality
I have these variables declared:

string TakeOverEURUSD = "TakeOverEURUSD", TakeOverGBPUSD = "TakeOverGBPUSD",...

I wonder how can I simplify them.

I uses those string variables in my Global Variables, and Global variables can only use boolean variables as the output.
Values of GVs are not boolean but double (you can store any numeric variable into a GV /int, double, datetime/. You can even store a bool variable since after all, it's a number too. But you can't store a string. Trying to do that results in error 4064).

nubcake's solution is absolutely perfect unless you're dealing with some multipair EAs. If you really need a state snapshot of 3 boolean values (TakeOver, StopOther, Triggered) on listed 10 pairs, you could store all of it in a single global variable (bitwise).. a 4-byte integer provides just enough room for all the information
MarginTrader All Time Return: na
  • #10
  • Jun 9, 2011 12:48am Jun 9, 2011 12:48am
actually you could take that one small step further and just combine the symbol name into the declaration of the strings and be done with it.

string nameTakeOver = "MyEA_TakeOver" + Symbol();

and then later when accessing globals just refer to nameTakeOver etc which is already correctly named.

globalvariablecheck(nameTakeOver) etc.
Congratulations ScalaFX for coming out of the closet!
  • #11
  • Edited 1:04am Jun 9, 2011 12:59am | Edited 1:04am
Quoting MaryJane
Values of GVs are not boolean but double (you can store any numeric variable into a GV /int, double, datetime/. You can even store a bool variable since after all, it's a number too. But you can't store a string. Trying to do that results in error 4064).

nubcake's solution is absolutely perfect unless you're dealing with some multipair EAs. If you really need a state snapshot of 3 boolean values (TakeOver, StopOther, Triggered) on listed 10 pairs, you could store all of it in a single global variable (bitwise).. a 4-byte integer...
correct... but if you want to take it a step further, and the direction i was thinking, if you want to be able to deal with virtually unlimited number of chart symbols as well as allowing for exotic non-standard symbol names then i would lean to doing something like :

have a file that stores known symbols.

on initializing read from the file and search for the current symbol. if found then the line position in the file is the index used to refer to this symbol.

if you wanted to deal with multiple symbols within one ea then you would just load each symbol listed in the file into an array, and again the index still simply relates to it's position within the file and now the array.

if the current symbol is not in the file you now consider it to be the next index that would have been read from file, and you now write this symbol name to file so that it is forevermore regarded as known and indexed as such.

from this you forget about referring to symbols by their name and simply refer to them by an index number that relates to the file (/ and array if using one).

globals from then onwards would simply append the symbol index to the names used... e.g. "MyEA_TakeOver1" "MyEA_TakeOver2".

each time you run the ea it will always read and find the correct index number to use in relating to it's current symbol and if you dump the list of symbol names from file into an array you can always find in the array whatever symbol is currently known if you need to then check a global variable relating to a different symbol than the current chart symbol... if it's not in the array then it's not known and therefore has no data to check anyway.

a bit more involved, but not particularly complex. it allows for symbols to be called anything. the names are only going to be a problem if they are exotic and have odd text appended to the symbol name, but in this case you can still simply do a string search of each name to see if the standard symbol name is within the longer exotic name.

e.g. "EURUSDstupidappendagetext" still contains "EURUSD" so is findable irregardless of the odd naming convention.

/ramble
Congratulations ScalaFX for coming out of the closet!
  • #12
  • Jun 9, 2011 1:18am Jun 9, 2011 1:18am
Quoting nubcake
/ramble
yep, i'm even doing something like

string nameTakeOver = "MyEA_TakeOver" + ..... + AccountNumber();

for my GVs to survive frequent account switching, lol
MarginTrader All Time Return: na
  • #13
  • Jun 9, 2011 1:20am Jun 9, 2011 1:20am
Here is all the parts of my code that deals with the String, Global Variable and the Symbol:

Inserted Code
extern bool TradeTakeOver = false;
extern bool AllowTakeOver = false;
extern bool StopOtherTrades = false;
extern bool CannotReversalWithCT = false;
extern bool CTcheck = false;
 
bool TradeTakenOver = false, StoppedByOther = false, ReversalNoTrade = false;
 
string TakeOverEURUSD = "TakeOverEURUSD", TakeOverGBPUSD = "TakeOverGBPUSD", TakeOverAUDUSD = "TakeOverAUDUSD", TakeOverNZDUSD = "TakeOverNZDUSD", TakeOverUSDCAD = "TakeOverUSDCAD", TakeOverUSDCHF = "TakeOverUSDCHF", TakeOverUSDJPY = "TakeOverUSDJPY", TakeOverGBPJPY = "TakeOverGBPJPY", TakeOverEURAUD = "TakeOverEURAUD";
string StopOtherEURUSD = "StopOtherGBPUSD", StopOtherGBPUSD = "StopOtherGBPUSD", StopOtherAUDUSD = "StopOtherAUDUSD", StopOtherNZDUSD = "StopOtherNZDUSD", StopOtherUSDCAD = "StopOtherUSDCAD", StopOtherUSDCHF = "StopOtherUSDCHF", StopOtherUSDJPY = "StopOtherUSDJPY", StopOtherGBPJPY = "StopOtherGBPJPY", StopOtherEURAUD = "StopOtherEURAUD";
string CTtriggeredEURUSD = "CTtriggeredEURUSD", CTtriggeredGBPUSD = "CTtriggeredGBPUSD", CTtriggeredAUDUSD = "CTtriggeredAUDUSD", CTtriggeredNZDUSD = "CTtriggeredNZDUSD", CTtriggeredUSDCAD = "CTtriggeredUSDCAD", CTtriggeredUSDCHF = "CTtriggeredUSDCHF", CTtriggeredUSDJPY = "CTtriggeredUSDJPY", CTtriggeredGBPJPY = "CTtriggeredGBPJPY", CTtriggeredEURAUD = "CTtriggeredEURAUD";
 
 
if (TradeTakeOver == true && BothPointsNotZigZagAllowed == true && extensionbreakouttime1 == false && retrace50time1 == true && SecondPointIsSemafor == true && invalidnotfullzz == false)
{
if ((extensiontime1 == true && fibotime1 == true) || (extensiontime2 == true && fibotime2 == true && extensiontime1invalidtrade == false))
{
if(StringFind(Symbol(), "EURUSD", 0) != -1)
{
GlobalVariableSet(TakeOverEURUSD,1);
}
if(StringFind(Symbol(), "GBPUSD", 0) != -1)
{
GlobalVariableSet(TakeOverGBPUSD,1);
}
if(StringFind(Symbol(), "AUDUSD", 0) != -1)
{
GlobalVariableSet(TakeOverAUDUSD,1);
}
if(StringFind(Symbol(), "NZDUSD", 0) != -1)
{
GlobalVariableSet(TakeOverNZDUSD,1);
}
if(StringFind(Symbol(), "USDCAD", 0) != -1)
{
GlobalVariableSet(TakeOverUSDCAD,1);
}
if(StringFind(Symbol(), "USDCHF", 0) != -1)
{
GlobalVariableSet(TakeOverUSDCHF,1);
}
if(StringFind(Symbol(), "USDJPY", 0) != -1)
{
GlobalVariableSet(TakeOverUSDJPY,1);
}
if(StringFind(Symbol(), "GBPJPY", 0) != -1)
{
GlobalVariableSet(TakeOverGBPJPY,1);
}
if(StringFind(Symbol(), "EURAUD", 0) != -1)
{
GlobalVariableSet(TakeOverEURAUD,1);
}
}
}
 
if (AllowTakeOver == True)
{
if(GlobalVariableGet(TakeOverEURUSD) == 1 && StringFind(Symbol(), "EURUSD", 0) != -1)
{
TradeTakenOver = true;
}
if (GlobalVariableGet(TakeOverGBPUSD) == 1 && StringFind(Symbol(), "GBPUSD", 0) != -1)
{
TradeTakenOver = true;
}
if (GlobalVariableGet(TakeOverAUDUSD) == 1 && StringFind(Symbol(), "AUDUSD", 0) != -1)
{
TradeTakenOver = true;
}
if (GlobalVariableGet(TakeOverNZDUSD) == 1 && StringFind(Symbol(), "NZDUSD", 0) != -1)
{
TradeTakenOver = true;
}
if (GlobalVariableGet(TakeOverUSDCAD) == 1 && StringFind(Symbol(), "USDCAD", 0) != -1)
{
TradeTakenOver = true;
}
if (GlobalVariableGet(TakeOverUSDCHF) == 1 && StringFind(Symbol(), "USDCHF", 0) != -1)
{
TradeTakenOver = true;
}
if (GlobalVariableGet(TakeOverUSDJPY) == 1 && StringFind(Symbol(), "USDJPY", 0) != -1)
{
TradeTakenOver = true;
}
if (GlobalVariableGet(TakeOverGBPJPY) == 1 && StringFind(Symbol(), "GBPJPY", 0) != -1)
{
TradeTakenOver = true;
}
if (GlobalVariableGet(TakeOverEURAUD) == 1 && StringFind(Symbol(), "EURAUD", 0) != -1)
{
TradeTakenOver = true;
}
}
 
if ((StopOtherTrades == true && retrace76aftertrade == true && CounterTrend == false) || (StopOtherTrades == true && alreadytp == true && CounterTrend == true))
{
if(StringFind(Symbol(), "EURUSD", 0) != -1)
{
GlobalVariableSet(StopOtherEURUSD,1);
}
if(StringFind(Symbol(), "GBPUSD", 0) != -1)
{
GlobalVariableSet(StopOtherGBPUSD,1);
}
if(StringFind(Symbol(), "AUDUSD", 0) != -1)
{
GlobalVariableSet(StopOtherAUDUSD,1);
}
if(StringFind(Symbol(), "NZDUSD", 0) != -1)
{
GlobalVariableSet(StopOtherNZDUSD,1);
}
if(StringFind(Symbol(), "USDCAD", 0) != -1)
{
GlobalVariableSet(StopOtherUSDCAD,1);
}
if(StringFind(Symbol(), "USDCHF", 0) != -1)
{
GlobalVariableSet(StopOtherUSDCHF,1);
}
if(StringFind(Symbol(), "USDJPY", 0) != -1)
{
GlobalVariableSet(StopOtherUSDJPY,1);
}
if(StringFind(Symbol(), "GBPJPY", 0) != -1)
{
GlobalVariableSet(StopOtherGBPJPY,1);
}
if(StringFind(Symbol(), "EURAUD", 0) != -1)
{
GlobalVariableSet(StopOtherEURAUD,1);
}
}
 
if (AllowStoppedByOther == true)
{
if(GlobalVariableGet(StopOtherEURUSD) == 1 && StringFind(Symbol(), "EURUSD", 0) != -1)
{
StoppedByOther = true;
}
if (GlobalVariableGet(StopOtherGBPUSD) == 1 && StringFind(Symbol(), "GBPUSD", 0) != -1)
{
StoppedByOther = true;
}
if (GlobalVariableGet(StopOtherAUDUSD) == 1 && StringFind(Symbol(), "AUDUSD", 0) != -1)
{
StoppedByOther = true;
}
if (GlobalVariableGet(StopOtherNZDUSD) == 1 && StringFind(Symbol(), "NZDUSD", 0) != -1)
{
StoppedByOther = true;
}
if (GlobalVariableGet(StopOtherUSDCAD) == 1 && StringFind(Symbol(), "USDCAD", 0) != -1)
{
StoppedByOther = true;
}
if (GlobalVariableGet(StopOtherUSDCHF) == 1 && StringFind(Symbol(), "USDCHF", 0) != -1)
{
StoppedByOther = true;
}
if (GlobalVariableGet(StopOtherUSDJPY) == 1 && StringFind(Symbol(), "USDJPY", 0) != -1)
{
StoppedByOther = true;
}
if (GlobalVariableGet(StopOtherGBPJPY) == 1 && StringFind(Symbol(), "GBPJPY", 0) != -1)
{
StoppedByOther = true;
}
if (GlobalVariableGet(StopOtherEURAUD) == 1 && StringFind(Symbol(), "EURAUD", 0) != -1)
{
StoppedByOther = true;
}
}
 
if (CTcheck == true && (extensionbreakouttime2 == true || extensionaftertime2 == true))
{
if (BothPointsNotZigZag == false && extensionbreakouttime1 == false && retrace50time1 == true && SecondPointIsSemafor == true)
{
if(StringFind(Symbol(), "EURUSD", 0) != -1)
{
GlobalVariableSet(CTtriggeredEURUSD,1);
}
if(StringFind(Symbol(), "GBPUSD", 0) != -1)
{
GlobalVariableSet(CTtriggeredGBPUSD,1);
}
if(StringFind(Symbol(), "AUDUSD", 0) != -1)
{
GlobalVariableSet(CTtriggeredAUDUSD,1);
}
if(StringFind(Symbol(), "NZDUSD", 0) != -1)
{
GlobalVariableSet(CTtriggeredNZDUSD,1);
}
if(StringFind(Symbol(), "USDCAD", 0) != -1)
{
GlobalVariableSet(CTtriggeredUSDCAD,1);
}
if(StringFind(Symbol(), "USDCHF", 0) != -1)
{
GlobalVariableSet(CTtriggeredUSDCHF,1);
}
if(StringFind(Symbol(), "USDJPY", 0) != -1)
{
GlobalVariableSet(CTtriggeredUSDJPY,1);
}
if(StringFind(Symbol(), "GBPJPY", 0) != -1)
{
GlobalVariableSet(CTtriggeredGBPJPY,1);
}
if(StringFind(Symbol(), "EURAUD", 0) != -1)
{
GlobalVariableSet(CTtriggeredEURAUD,1);
}
}
}
 
if (CannotReversalWithCT == true)
{
if (reversal == true)
{
if(GlobalVariableGet(CTtriggeredEURUSD) == 1 && StringFind(Symbol(), "EURUSD", 0) != -1)
{
ReversalNoTrade = true;
}
if (GlobalVariableGet(CTtriggeredGBPUSD) == 1 && StringFind(Symbol(), "GBPUSD", 0) != -1)
{
ReversalNoTrade = true;
}
if (GlobalVariableGet(CTtriggeredAUDUSD) == 1 && StringFind(Symbol(), "AUDUSD", 0) != -1)
{
ReversalNoTrade = true;
}
if (GlobalVariableGet(CTtriggeredNZDUSD) == 1 && StringFind(Symbol(), "NZDUSD", 0) != -1)
{
ReversalNoTrade = true;
}
if (GlobalVariableGet(CTtriggeredUSDCAD) == 1 && StringFind(Symbol(), "USDCAD", 0) != -1)
{
ReversalNoTrade = true;
}
if (GlobalVariableGet(CTtriggeredUSDCHF) == 1 && StringFind(Symbol(), "USDCHF", 0) != -1)
{
ReversalNoTrade = true;
}
if (GlobalVariableGet(CTtriggeredUSDJPY) == 1 && StringFind(Symbol(), "USDJPY", 0) != -1)
{
ReversalNoTrade = true;
}
if (GlobalVariableGet(CTtriggeredGBPJPY) == 1 && StringFind(Symbol(), "GBPJPY", 0) != -1)
{
ReversalNoTrade = true;
}
if (GlobalVariableGet(CTtriggeredEURAUD) == 1 && StringFind(Symbol(), "EURAUD", 0) != -1)
{
ReversalNoTrade = true;
}
}
}

Considering all the above functions, how would the simplified code look like?
  • #14
  • Jun 9, 2011 1:30am Jun 9, 2011 1:30am
Quoting MaryJane
yep, i'm even doing something like

string nameTakeOver = "MyEA_TakeOver" + ..... + AccountNumber();

for my GVs to survive frequent account switching, lol
crap on a cracker... even more intense than i was talking about. very nice mj!
Congratulations ScalaFX for coming out of the closet!
  • #15
  • Edited 3:18am Jun 9, 2011 2:46am | Edited 3:18am
Quoting mindreality
Here is all the parts of my code that deals with the String, Global Variable and the Symbol:
...
Considering all the above functions, how would the simplified code look like?
String array.
Inserted Code
[font=Courier New]extern bool TradeTakeOver = false;[/font]
[font=Courier New]extern bool AllowTakeOver = false;[/font]
[font=Courier New]extern bool StopOtherTrades = false;[/font]
[font=Courier New]extern bool CannotReversalWithCT = false;[/font]
[font=Courier New]extern bool CTcheck = false;[/font]
 
[font=Courier New]bool BothPointsNotZigZagAllowed, extensionbreakouttime1, retrace50time1, SecondPointIsSemafor, invalidnotfullzz;[/font]
[font=Courier New]bool extensiontime1, extensiontime2, fibotime1, fibotime2, extensiontime1invalidtrade, BothPointsNotZigZag, reversal;[/font]
[font=Courier New]bool retrace76aftertrade, CounterTrend, alreadytp, AllowStoppedByOther, extensionbreakouttime2, extensionaftertime2;[/font]
 
[font=Courier New]bool TradeTakenOver = false, StoppedByOther = false, ReversalNoTrade = false;[/font]
 
[font=Courier New]string Sym[9];[/font]
 
[font=Courier New]void init()[/font]
[font=Courier New] {[/font]
[font=Courier New] Sym[0] = "EURUSD";[/font]
[font=Courier New] Sym[1] = "GBPUSD";[/font]
[font=Courier New] Sym[2] = "AUDUSD";[/font]
[font=Courier New] Sym[3] = "NZDUSD";[/font]
[font=Courier New] Sym[4] = "USDCAD";[/font]
[font=Courier New] Sym[5] = "USDCHF";[/font]
[font=Courier New] Sym[6] = "USDJPY";[/font]
[font=Courier New] Sym[7] = "GBPJPY";[/font]
[font=Courier New] Sym[8] = "EURAUD";[/font]
[font=Courier New] } [/font]
 
[font=Courier New]void start()[/font]
[font=Courier New] {[/font]
[font=Courier New] if (TradeTakeOver && BothPointsNotZigZagAllowed && !extensionbreakouttime1 && retrace50time1 && SecondPointIsSemafor && !invalidnotfullzz)[/font]
[font=Courier New]    {[/font]
[font=Courier New]    if ((extensiontime1 && fibotime1) || (extensiontime2 && fibotime2 && !extensiontime1invalidtrade))[/font]
[font=Courier New]       {[/font]
[font=Courier New]       for (int x = 0; x < 9; x++) {if (StringFind(Symbol(), Sym[x], 0) != -1) GlobalVariableSet("TakeOver" + Sym[x], 1);}[/font]
[font=Courier New]       }[/font]
[font=Courier New]    }[/font]
 
[font=Courier New] if (AllowTakeOver)[/font]
[font=Courier New]    {[/font]
[font=Courier New]    TradeTakenOver = false;[/font]
[font=Courier New]    for (x = 0; x < 9; x++) {if (GlobalVariableGet("TakeOver" + Sym[x]) == 1 && StringFind(Symbol(), Sym[x], 0) != -1) TradeTakenOver = true;}[/font]
[font=Courier New]    }[/font]
 
[font=Courier New] if ((StopOtherTrades && retrace76aftertrade && !CounterTrend) || (StopOtherTrades && alreadytp && CounterTrend))[/font]
[font=Courier New]    {[/font]
[font=Courier New]    for (x = 0; x < 9; x++) {if (StringFind(Symbol(), Sym[x], 0) != -1) GlobalVariableSet("StopOther" + Sym[x], 1);}[/font]
[font=Courier New]    }[/font]
 
[font=Courier New] if (AllowStoppedByOther)[/font]
[font=Courier New]    {[/font]
[font=Courier New]    StoppedByOther = false;[/font]
[font=Courier New]    for (x = 0; x < 9; x++) {if (GlobalVariableGet("StopOther" + Sym[x]) == 1 && StringFind(Symbol(), Sym[x], 0) != -1) StoppedByOther = true;}[/font]
[font=Courier New]    }[/font]
 
[font=Courier New] if (CTcheck && (extensionbreakouttime2 || extensionaftertime2))[/font]
[font=Courier New]    {[/font]
[font=Courier New]    if (BothPointsNotZigZag == false && extensionbreakouttime1 == false && retrace50time1 == true && SecondPointIsSemafor == true)[/font]
[font=Courier New]       {[/font]
[font=Courier New]       for (x = 0; x < 9; x++) {if (StringFind(Symbol(), Sym[x], 0) != -1) GlobalVariableSet("CTtriggered" + Sym[x], 1);}[/font]
[font=Courier New]       }[/font]
[font=Courier New]    }   [/font]
 
[font=Courier New] if (CannotReversalWithCT == true)[/font]
[font=Courier New]    {[/font]
[font=Courier New]    if (reversal)[/font]
[font=Courier New]       {[/font]
[font=Courier New]       ReversalNoTrade = false;[/font]
[font=Courier New]       for (x = 0; x < 9; x++) {if (GlobalVariableGet("CTtriggered" + Sym[x]) == 1 && StringFind(Symbol(), Sym[x], 0) != -1) ReversalNoTrade = true;}[/font]
[font=Courier New]       }[/font]
[font=Courier New]    }[/font]
[font=Courier New] }  [/font]

i have added init() and start() and declared the switches you're using just for sake of a compile check.. it's still horribly unefficient.. oops, too many loops. if i would do something like that for myself i would do it some other way.. but hope it helps.

edit: it seems you're really processing only one symbol at a time.. i forgot to add a break out of the for loops.. the first match will always be the last one.
Attached File(s)
File Type: mq4 mindreality.mq4   3 KB | 418 downloads
MarginTrader All Time Return: na
  • #16
  • Jun 9, 2011 5:38am Jun 9, 2011 5:38am
the above posted is equivalent to your original routines (as you requested). But it could make some sense only if the ea does some kind of multi-pair trade management.. looking at the conditions as suggested by variable names (zigzags, semafors, fibotime) ..unless you're not handling some synthetic (cointegrated) stuff there, which i highly doubt..

then all you needed was to apply hanover's advice, confirmed by nubcake:

Inserted Code
[font=Courier New]if (TradeTakeOver && BothPointsNotZigZagAllowed && !extensionbreakouttime1 && retrace50time1 && SecondPointIsSemafor && !invalidnotfullzz)[/font]
[font=Courier New]  {[/font]
[font=Courier New]  if ((extensiontime1 && fibotime1) || (extensiontime2 && fibotime2 && !extensiontime1invalidtrade)) GlobalVariableSet("TakeOver" + Symbol(), 1);[/font]
[font=Courier New]  }[/font]
 
[font=Courier New]if (AllowTakeOver)[/font]
[font=Courier New]  {[/font]
[font=Courier New]  TradeTakenOver = false;[/font]
[font=Courier New]  if (GlobalVariableGet("TakeOver" + Symbol()) == 1) TradeTakenOver = true;[/font]
[font=Courier New]  }[/font]
 
[font=Courier New]if ((StopOtherTrades && retrace76aftertrade && !CounterTrend) || (StopOtherTrades && alreadytp && CounterTrend))[/font]
[font=Courier New]  {[/font]
[font=Courier New]  GlobalVariableSet("StopOther" + Symbol(), 1);[/font]
[font=Courier New]  }[/font]
 
[font=Courier New]if (AllowStoppedByOther)[/font]
[font=Courier New]  {[/font]
[font=Courier New]  StoppedByOther = false;[/font]
[font=Courier New]  if (GlobalVariableGet("StopOther" + Symbol()) == 1) StoppedByOther = true;[/font]
[font=Courier New]  }[/font]
 
[font=Courier New]if (CTcheck && (extensionbreakouttime2 || extensionaftertime2))[/font]
[font=Courier New]  {[/font]
[font=Courier New]  if (BothPointsNotZigZag == false && extensionbreakouttime1 == false && retrace50time1 == true && SecondPointIsSemafor == true)[/font]
[font=Courier New]     {[/font]
[font=Courier New]     GlobalVariableSet("CTtriggered" + Symbol(), 1);[/font]
[font=Courier New]     }[/font]
[font=Courier New]  }   [/font]
 
[font=Courier New]if (CannotReversalWithCT == true)[/font]
[font=Courier New]  {[/font]
[font=Courier New]  if (reversal)[/font]
[font=Courier New]     {[/font]
[font=Courier New]     ReversalNoTrade = false;[/font]
[font=Courier New]     if (GlobalVariableGet("CTtriggered" + Symbol()) == 1) ReversalNoTrade = true;[/font]
[font=Courier New]     }[/font]
[font=Courier New]  }[/font]
i bet those 38 lines will do the same as the 321 lines of your original code did ..but it was fun.

bye.
MarginTrader All Time Return: na
  • #17
  • Jun 13, 2011 4:35am Jun 13, 2011 4:35am
I get errors when I put in this code:

Inserted Code
if (AllowTakeOver)
[font=Courier New] {[/font]
[font=Courier New] if (GlobalVariableGet("TakeOver" + Symbol()) == 1) TradeTakenOver = true;[/font]
[font=Courier New] }[/font]

Do I still need to declare all those variables when I use your code?

Inserted Code
string TakeOverEURUSD = "TakeOverEURUSD", TakeOverGBPUSD = "TakeOverGBPUSD", TakeOverAUDUSD = "TakeOverAUDUSD", TakeOverNZDUSD = "TakeOverNZDUSD", TakeOverUSDCAD = "TakeOverUSDCAD", TakeOverUSDCHF = "TakeOverUSDCHF", TakeOverUSDJPY = "TakeOverUSDJPY", TakeOverGBPJPY = "TakeOverGBPJPY", TakeOverEURAUD = "TakeOverEURAUD";
string StopOtherEURUSD = "StopOtherGBPUSD", StopOtherGBPUSD = "StopOtherGBPUSD", StopOtherAUDUSD = "StopOtherAUDUSD", StopOtherNZDUSD = "StopOtherNZDUSD", StopOtherUSDCAD = "StopOtherUSDCAD", StopOtherUSDCHF = "StopOtherUSDCHF", StopOtherUSDJPY = "StopOtherUSDJPY", StopOtherGBPJPY = "StopOtherGBPJPY", StopOtherEURAUD = "StopOtherEURAUD";
string CTtriggeredEURUSD = "CTtriggeredEURUSD", CTtriggeredGBPUSD = "CTtriggeredGBPUSD", CTtriggeredAUDUSD = "CTtriggeredAUDUSD", CTtriggeredNZDUSD = "CTtriggeredNZDUSD", CTtriggeredUSDCAD = "CTtriggeredUSDCAD", CTtriggeredUSDCHF = "CTtriggeredUSDCHF", CTtriggeredUSDJPY = "CTtriggeredUSDJPY", CTtriggeredGBPJPY = "CTtriggeredGBPJPY", CTtriggeredEURAUD = "CTtriggeredEURAUD";
  • #18
  • Jun 13, 2011 4:49am Jun 13, 2011 4:49am
Quoting mindreality
I get errors when I put in this code:
what errors? you need to help us help you.

Quote
Do I still need to declare all those variables when I use your code?

no, that's the point. you did it the ultimate worst way, and MJ cleaned it up and made it how it should be.
Congratulations ScalaFX for coming out of the closet!
  • #19
  • Jun 13, 2011 5:28am Jun 13, 2011 5:28am
I found out that I added an extra } to the code. I have removed it and fixed the error.

Thanks for both you and MJ's help! Now my code looks 100x CLEANER!
  • #20
  • Jun 13, 2011 5:30am Jun 13, 2011 5:30am
Thanks, Nubcake, MaryJane and Hanover!
0 traders viewing now